Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130068/?format=api
{ "id": 130068, "url": "http://patchwork.dpdk.org/api/patches/130068/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/463ed192eecb0f45116b4487741039d16f5e3aea.1691658879.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<463ed192eecb0f45116b4487741039d16f5e3aea.1691658879.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/463ed192eecb0f45116b4487741039d16f5e3aea.1691658879.git.gmuthukrishn@marvell.com", "date": "2023-08-10T09:35:26", "name": "[v1,4/6] cryptodev: use generic EC xform params for SM2", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fc13031be8bf80d1105887c5e3ce0b4a65db1178", "submitter": { "id": 2301, "url": "http://patchwork.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/463ed192eecb0f45116b4487741039d16f5e3aea.1691658879.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 29149, "url": "http://patchwork.dpdk.org/api/series/29149/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29149", "date": "2023-08-10T09:35:22", "name": "cryptodev: support digest message in SM2", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29149/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130068/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130068/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 52CBB4301B;\n\tThu, 10 Aug 2023 11:36:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 32AD743260;\n\tThu, 10 Aug 2023 11:35:50 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 0E06343261\n for <dev@dpdk.org>; Thu, 10 Aug 2023 11:35:48 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37A57QG9014710; Thu, 10 Aug 2023 02:35:48 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sc57snqrr-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 10 Aug 2023 02:35:48 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 10 Aug 2023 02:35:46 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 10 Aug 2023 02:35:46 -0700", "from BG-LT91401.marvell.com (BG-LT91401.marvell.com [10.28.168.34])\n by maili.marvell.com (Postfix) with ESMTP id 30AD73F705B;\n Thu, 10 Aug 2023 02:35:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=n/gEhMzpNUU0BbdPG/XWwgPW8abwl5ysOtGfrz0Su2k=;\n b=Y8txYtlbB/MmTigB3za0qbB+N2s7YULCHUoINf3JvVj1rOcrzgO3ZYThZ/MjZsCSzg6a\n Sfr/z5i+ANiAIxRYwSrNJG5A/8OVUXU/eFKSTdzkCIGU1ElZmouVreUEJTsJbdOTZTKo\n 79WHLPBH3lHU/AXv5DbljAWATp9p0iemE4bunuelS43g1j6mZwyJK25TEyPAqrL9yQ+E\n ssVdOomcNGURTdqpMZ4pq0LY4+TuVqdXIBdlZo802EnKV8qc+se6QopPmTlRX8BHw+2/\n aMgv0PVASC+b3Uumy+YSnjH909bxx0RJbBQi8i9+2q+BzXuCL7QfqefrtW0qaRVxgQ21 tQ==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<anoobj@marvell.com>, Akhil Goyal <gakhil@marvell.com>, Fan Zhang\n <fanzhang.oss@gmail.com>, Kai Ji <kai.ji@intel.com>, \"Gowrishankar\n Muthukrishnan\" <gmuthukrishn@marvell.com>", "Subject": "[v1 4/6] cryptodev: use generic EC xform params for SM2", "Date": "Thu, 10 Aug 2023 15:05:26 +0530", "Message-ID": "\n <463ed192eecb0f45116b4487741039d16f5e3aea.1691658879.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<cover.1691658879.git.gmuthukrishn@marvell.com>", "References": "<cover.1691658879.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "K_I_0RudpivI6Lq3zfFbbFZa7L_VJ-nD", "X-Proofpoint-ORIG-GUID": "K_I_0RudpivI6Lq3zfFbbFZa7L_VJ-nD", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_09,2023-08-09_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Now, generic EC xform parameters include hash algorithm field.\nHence, SM2 curve can use this generic struct for setting hash\nalgorithm, which would also require SM2 curve ID enumerated\nalong with other curves, as listed in:\nhttps://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\n app/test/test_cryptodev_asym.c | 12 ++++++++----\n app/test/test_cryptodev_sm2_test_vectors.h | 4 +++-\n doc/guides/rel_notes/release_23_11.rst | 2 ++\n drivers/crypto/openssl/rte_openssl_pmd_ops.c | 2 +-\n lib/cryptodev/rte_crypto_asym.h | 16 ++--------------\n 5 files changed, 16 insertions(+), 20 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 0ef2642fdd..b08772a9bf 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -1838,7 +1838,8 @@ _test_sm2_sign(bool rnd_secret)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\txform.ec.curve_id = input_params.curve;\n+\txform.ec.hash = RTE_CRYPTO_AUTH_SM3;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\n@@ -2019,7 +2020,8 @@ test_sm2_verify(void)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\txform.ec.curve_id = input_params.curve;\n+\txform.ec.hash = RTE_CRYPTO_AUTH_SM3;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\n@@ -2120,7 +2122,8 @@ _test_sm2_enc(bool rnd_secret)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\txform.ec.curve_id = input_params.curve;\n+\txform.ec.hash = RTE_CRYPTO_AUTH_SM3;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\n@@ -2299,7 +2302,8 @@ test_sm2_dec(void)\n \t/* Setup asym xform */\n \txform.next = NULL;\n \txform.xform_type = RTE_CRYPTO_ASYM_XFORM_SM2;\n-\txform.sm2.hash = RTE_CRYPTO_AUTH_SM3;\n+\txform.ec.curve_id = input_params.curve;\n+\txform.ec.hash = RTE_CRYPTO_AUTH_SM3;\n \n \tret = rte_cryptodev_asym_session_create(dev_id, &xform, sess_mpool, &sess);\n \tif (ret < 0) {\ndiff --git a/app/test/test_cryptodev_sm2_test_vectors.h b/app/test/test_cryptodev_sm2_test_vectors.h\nindex 7a4ce70c10..3d2dba1359 100644\n--- a/app/test/test_cryptodev_sm2_test_vectors.h\n+++ b/app/test/test_cryptodev_sm2_test_vectors.h\n@@ -17,6 +17,7 @@ struct crypto_testsuite_sm2_params {\n \trte_crypto_param id;\n \trte_crypto_param cipher;\n \trte_crypto_param message;\n+\tint curve;\n };\n \n static uint8_t fp256_pkey[] = {\n@@ -123,7 +124,8 @@ struct crypto_testsuite_sm2_params sm2_param_fp256 = {\n \t.cipher = {\n \t\t.data = fp256_cipher,\n \t\t.length = sizeof(fp256_cipher),\n-\t}\n+\t},\n+\t.curve = RTE_CRYPTO_EC_GROUP_SM2\n };\n \n #endif /* __TEST_CRYPTODEV_SM2_TEST_VECTORS_H__ */\ndiff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex 4411bb32c1..23c89e8ea9 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -91,6 +91,8 @@ Removed Items\n \n * kni: Removed the Kernel Network Interface (KNI) library and driver.\n \n+* crypto: Removed SM2 xform parameter in asymmetric xform.\n+\n \n API Changes\n -----------\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\nindex 0b3601db40..e521c0c830 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n@@ -1307,7 +1307,7 @@ static int openssl_set_asym_session_parameters(\n \t\tOSSL_PARAM *params = NULL;\n \t\tint ret = -1;\n \n-\t\tif (xform->sm2.hash != RTE_CRYPTO_AUTH_SM3)\n+\t\tif (xform->ec.hash != RTE_CRYPTO_AUTH_SM3)\n \t\t\treturn -1;\n \n \t\tparam_bld = OSSL_PARAM_BLD_new();\ndiff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex 51f5476c6e..9b68c3f5e2 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -69,7 +69,8 @@ enum rte_crypto_curve_id {\n \tRTE_CRYPTO_EC_GROUP_SECP224R1 = 21,\n \tRTE_CRYPTO_EC_GROUP_SECP256R1 = 23,\n \tRTE_CRYPTO_EC_GROUP_SECP384R1 = 24,\n-\tRTE_CRYPTO_EC_GROUP_SECP521R1 = 25\n+\tRTE_CRYPTO_EC_GROUP_SECP521R1 = 25,\n+\tRTE_CRYPTO_EC_GROUP_SM2 = 41,\n };\n \n /**\n@@ -382,16 +383,6 @@ struct rte_crypto_ec_xform {\n \t/**< Hash algorithm used in EC op. */\n };\n \n-/**\n- * Asymmetric SM2 transform data.\n- *\n- * Structure describing SM2 xform params.\n- */\n-struct rte_crypto_sm2_xform {\n-\tenum rte_crypto_auth_algorithm hash;\n-\t/**< Hash algorithm used in SM2 op. */\n-};\n-\n /**\n * Operations params for modular operations:\n * exponentiation and multiplicative inverse\n@@ -649,9 +640,6 @@ struct rte_crypto_asym_xform {\n \t\t/**< EC xform parameters, used by elliptic curve based\n \t\t * operations.\n \t\t */\n-\n-\t\tstruct rte_crypto_sm2_xform sm2;\n-\t\t/**< SM2 xform parameters */\n \t};\n };\n \n", "prefixes": [ "v1", "4/6" ] }