Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130141/?format=api
{ "id": 130141, "url": "http://patchwork.dpdk.org/api/patches/130141/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230811085805.441256-25-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230811085805.441256-25-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230811085805.441256-25-ndabilpuram@marvell.com", "date": "2023-08-11T08:57:59", "name": "[25/31] net/cnxk: update different size bit operations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "eb9a501510b07c84cad37a52df6a4c97c5a533f2", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230811085805.441256-25-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 29177, "url": "http://patchwork.dpdk.org/api/series/29177/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29177", "date": "2023-08-11T08:57:35", "name": "[01/31] common/cnxk: add aura ref count mechanism", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29177/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130141/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130141/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 595A043032;\n\tFri, 11 Aug 2023 11:00:54 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0289432A7;\n\tFri, 11 Aug 2023 10:59:41 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 75AF143247\n for <dev@dpdk.org>; Fri, 11 Aug 2023 10:59:38 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37AN2WVA011282 for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:38 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8ya1gcd-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:37 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 11 Aug 2023 01:59:24 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 11 Aug 2023 01:59:24 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 725A63F706C;\n Fri, 11 Aug 2023 01:59:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=xy3uN3Gw5QwVoaqPLaPDHGcz8tqaLcg6Aovw1l2r4lQ=;\n b=Elf525X5s0MjvX5m+6wHlfZ6mBh3fR8o3R73DynoECxIvUDASRd8pDxIGnH7Q1P5EK0r\n kBe8BanBTCqGWb6WjRzES9WRgQbp3C9UzVxdbpbh9N1TweRpnMrxI9/WJHVoSJQ6L00k\n isDz+0OfKG3iExZYU5xOEZS0uml6pKNJfUDyhUjznudYuZt0lPpYbyXL2Qb0XqWisfjC\n VLyt3kZm2919PkKBwJmO016PwZSivXNKnBGVwSOI9B/u7df2Zd3APBaa+2iC7C8jsBnL\n V39Hlv5zT7yg1JYahNub0v3FMWyNgn4jCkIKioqF5hKF/3i/8bw9ne1GFWwFZ+7hEW4M Dw==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>", "Subject": "[PATCH 25/31] net/cnxk: update different size bit operations", "Date": "Fri, 11 Aug 2023 14:27:59 +0530", "Message-ID": "<20230811085805.441256-25-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "References": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "uJkP8Je-5TaROG4ZtQnLmSIiNpxm9_9-", "X-Proofpoint-GUID": "uJkP8Je-5TaROG4ZtQnLmSIiNpxm9_9-", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Akhil Goyal <gakhil@marvell.com>\n\nCertain bitwise operations are done with different\nsized operands which causes warnings in static code\nanalysis. The necessary operands are typecast to remove\nthe warning.\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n drivers/net/cnxk/cn10k_ethdev.c | 2 +-\n drivers/net/cnxk/cn10k_rx.h | 10 +++++-----\n drivers/net/cnxk/cn10k_tx.h | 12 ++++++------\n 3 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c\nindex 4c4acc7cf0..40437d2d73 100644\n--- a/drivers/net/cnxk/cn10k_ethdev.c\n+++ b/drivers/net/cnxk/cn10k_ethdev.c\n@@ -262,7 +262,7 @@ cn10k_nix_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid,\n \n \t\ttxq->cpt_desc = inl_lf->nb_desc * 0.7;\n \t\ttxq->sa_base = (uint64_t)dev->outb.sa_base;\n-\t\ttxq->sa_base |= eth_dev->data->port_id;\n+\t\ttxq->sa_base |= (uint64_t)eth_dev->data->port_id;\n \t\tPLT_STATIC_ASSERT(ROC_NIX_INL_SA_BASE_ALIGN == BIT_ULL(16));\n \t}\n \ndiff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h\nindex 0dc0b0595c..a696427091 100644\n--- a/drivers/net/cnxk/cn10k_rx.h\n+++ b/drivers/net/cnxk/cn10k_rx.h\n@@ -795,7 +795,7 @@ cn10k_nix_cqe_to_mbuf(const struct nix_cqe_hdr_s *cq, const uint32_t tag,\n \t/* Skip rx ol flags extraction for Security packets */\n \tif ((!(flag & NIX_RX_SEC_REASSEMBLY_F) || !(w1 & BIT(11))) &&\n \t\t\tflag & NIX_RX_OFFLOAD_CHECKSUM_F)\n-\t\tol_flags |= nix_rx_olflags_get(lookup_mem, w1);\n+\t\tol_flags |= (uint64_t)nix_rx_olflags_get(lookup_mem, w1);\n \n \tif (flag & NIX_RX_OFFLOAD_VLAN_STRIP_F) {\n \t\tif (rx->vtag0_gone) {\n@@ -1334,10 +1334,10 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts,\n \t\t}\n \n \t\tif (flags & NIX_RX_OFFLOAD_CHECKSUM_F) {\n-\t\t\tol_flags0 |= nix_rx_olflags_get(lookup_mem, cq0_w1);\n-\t\t\tol_flags1 |= nix_rx_olflags_get(lookup_mem, cq1_w1);\n-\t\t\tol_flags2 |= nix_rx_olflags_get(lookup_mem, cq2_w1);\n-\t\t\tol_flags3 |= nix_rx_olflags_get(lookup_mem, cq3_w1);\n+\t\t\tol_flags0 |= (uint64_t)nix_rx_olflags_get(lookup_mem, cq0_w1);\n+\t\t\tol_flags1 |= (uint64_t)nix_rx_olflags_get(lookup_mem, cq1_w1);\n+\t\t\tol_flags2 |= (uint64_t)nix_rx_olflags_get(lookup_mem, cq2_w1);\n+\t\t\tol_flags3 |= (uint64_t)nix_rx_olflags_get(lookup_mem, cq3_w1);\n \t\t}\n \n \t\t/* Translate meta to mbuf */\ndiff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h\nindex 298d243aac..04d02317b1 100644\n--- a/drivers/net/cnxk/cn10k_tx.h\n+++ b/drivers/net/cnxk/cn10k_tx.h\n@@ -484,7 +484,7 @@ cn10k_nix_sec_steorl(uintptr_t io_addr, uint32_t lmt_id, uint8_t lnum,\n \tdata &= ~(0x7ULL << 16);\n \t/* Update lines - 1 that contain valid data */\n \tdata |= ((uint64_t)(lnum + loff - 1)) << 12;\n-\tdata |= lmt_id;\n+\tdata |= (uint64_t)lmt_id;\n \n \t/* STEOR */\n \troc_lmt_submit_steorl(data, pa);\n@@ -577,7 +577,7 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t *cmd0, uint64x2_t *cmd1,\n \t\tnixtx = (nixtx - 1) & ~(BIT_ULL(7) - 1);\n \t\tnixtx += 16;\n \n-\t\tw0 |= cn10k_nix_tx_ext_subs(flags) + 1;\n+\t\tw0 |= cn10k_nix_tx_ext_subs(flags) + 1ULL;\n \t\tdptr += l2_len;\n \t\tucode_cmd[1] = dptr;\n \t\t*cmd1 = vsetq_lane_u16(pkt_len + dlen_adj, *cmd1, 0);\n@@ -718,7 +718,7 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, uintptr_t *nixtx_addr,\n \t\tnixtx = (nixtx - 1) & ~(BIT_ULL(7) - 1);\n \t\tnixtx += 16;\n \n-\t\tw0 |= cn10k_nix_tx_ext_subs(flags) + 1;\n+\t\tw0 |= cn10k_nix_tx_ext_subs(flags) + 1ULL;\n \t\tdptr += l2_len;\n \t\tucode_cmd[1] = dptr;\n \t\tsg->seg1_size = pkt_len + dlen_adj;\n@@ -1421,7 +1421,7 @@ cn10k_nix_xmit_pkts(void *tx_queue, uint64_t *ws, struct rte_mbuf **tx_pkts,\n \t\tpa = io_addr | (data & 0x7) << 4;\n \t\tdata &= ~0x7ULL;\n \t\tdata |= ((uint64_t)(burst - 1)) << 12;\n-\t\tdata |= lmt_id;\n+\t\tdata |= (uint64_t)lmt_id;\n \n \t\tif (flags & NIX_TX_VWQE_F)\n \t\t\tcn10k_nix_vwqe_wait_fc(txq, burst);\n@@ -1583,7 +1583,7 @@ cn10k_nix_xmit_pkts_mseg(void *tx_queue, uint64_t *ws,\n \t\tdata0 &= ~0x7ULL;\n \t\t/* Move lmtst1..15 sz to bits 63:19 */\n \t\tdata0 <<= 16;\n-\t\tdata0 |= ((burst - 1) << 12);\n+\t\tdata0 |= ((burst - 1ULL) << 12);\n \t\tdata0 |= (uint64_t)lmt_id;\n \n \t\tif (flags & NIX_TX_VWQE_F)\n@@ -3193,7 +3193,7 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws,\n \t\t\twd.data[0] <<= 16;\n \n \t\twd.data[0] |= ((uint64_t)(lnum - 1)) << 12;\n-\t\twd.data[0] |= lmt_id;\n+\t\twd.data[0] |= (uint64_t)lmt_id;\n \n \t\tif (flags & NIX_TX_VWQE_F)\n \t\t\tcn10k_nix_vwqe_wait_fc(txq, burst);\n", "prefixes": [ "25/31" ] }