Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130181/?format=api
{ "id": 130181, "url": "http://patchwork.dpdk.org/api/patches/130181/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1691775136-6460-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1691775136-6460-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1691775136-6460-2-git-send-email-roretzla@linux.microsoft.com", "date": "2023-08-11T17:32:11", "name": "[v2,1/6] eal: provide rte stdatomics optional atomics API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4943f0dd167503f14970f16832371577dd7956b3", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1691775136-6460-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29194, "url": "http://patchwork.dpdk.org/api/series/29194/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29194", "date": "2023-08-11T17:32:10", "name": "RFC optional rte optional stdatomics API", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29194/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130181/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/130181/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4105243036;\n\tFri, 11 Aug 2023 19:32:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D64E64325D;\n\tFri, 11 Aug 2023 19:32:21 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id AFA1E40E03;\n Fri, 11 Aug 2023 19:32:19 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id F346520FCF71; Fri, 11 Aug 2023 10:32:18 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com F346520FCF71", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1691775139;\n bh=zQJAvQqBWUhcK0L1hR1G4IKW0ThcFKGFk4uynaR0a0A=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=a1UyKsgNwBeM5P1c03EJFTfw3JnEvf4LKO+rb7/cwcVH2dKKfGod4m3sPCVX/IR03\n iTMYYqVDyayc7JmwJsRvgUIF7k6l5EpoMFshKM7iaqpRp8UBDTut9kGwhrc/D4J5xN\n +Hss5paUfsI5ax0FfgAp3LRIf7SYdAQZD4xnaMI0=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "techboard@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Jerin Jacob <jerinj@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Joyce Kong <joyce.kong@arm.com>, David Christensen <drc@linux.vnet.ibm.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n David Hunt <david.hunt@intel.com>, Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 1/6] eal: provide rte stdatomics optional atomics API", "Date": "Fri, 11 Aug 2023 10:32:11 -0700", "Message-Id": "<1691775136-6460-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1691775136-6460-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com>\n <1691775136-6460-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Provide API for atomic operations in the rte namespace that may\noptionally be configured to use C11 atomics with meson\noption enable_stdatomics=true\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n config/meson.build | 1 +\n lib/eal/include/generic/rte_atomic.h | 1 +\n lib/eal/include/generic/rte_pause.h | 1 +\n lib/eal/include/generic/rte_rwlock.h | 1 +\n lib/eal/include/generic/rte_spinlock.h | 1 +\n lib/eal/include/meson.build | 1 +\n lib/eal/include/rte_mcslock.h | 1 +\n lib/eal/include/rte_pflock.h | 1 +\n lib/eal/include/rte_seqcount.h | 1 +\n lib/eal/include/rte_stdatomic.h | 182 +++++++++++++++++++++++++++++++++\n lib/eal/include/rte_ticketlock.h | 1 +\n lib/eal/include/rte_trace_point.h | 1 +\n meson_options.txt | 2 +\n 13 files changed, 195 insertions(+)\n create mode 100644 lib/eal/include/rte_stdatomic.h", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex d822371..ec49964 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -303,6 +303,7 @@ endforeach\n # set other values pulled from the build options\n dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports'))\n dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet'))\n+dpdk_conf.set('RTE_ENABLE_STDATOMIC', get_option('enable_stdatomic'))\n dpdk_conf.set('RTE_ENABLE_TRACE_FP', get_option('enable_trace_fp'))\n # values which have defaults which may be overridden\n dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64)\ndiff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h\nindex aef44e2..efd29eb 100644\n--- a/lib/eal/include/generic/rte_atomic.h\n+++ b/lib/eal/include/generic/rte_atomic.h\n@@ -15,6 +15,7 @@\n #include <stdint.h>\n #include <rte_compat.h>\n #include <rte_common.h>\n+#include <rte_stdatomic.h>\n \n #ifdef __DOXYGEN__\n \ndiff --git a/lib/eal/include/generic/rte_pause.h b/lib/eal/include/generic/rte_pause.h\nindex ec1f418..bebfa95 100644\n--- a/lib/eal/include/generic/rte_pause.h\n+++ b/lib/eal/include/generic/rte_pause.h\n@@ -16,6 +16,7 @@\n #include <assert.h>\n #include <rte_common.h>\n #include <rte_atomic.h>\n+#include <rte_stdatomic.h>\n \n /**\n * Pause CPU execution for a short while\ndiff --git a/lib/eal/include/generic/rte_rwlock.h b/lib/eal/include/generic/rte_rwlock.h\nindex 9e083bb..24ebec6 100644\n--- a/lib/eal/include/generic/rte_rwlock.h\n+++ b/lib/eal/include/generic/rte_rwlock.h\n@@ -32,6 +32,7 @@\n #include <rte_common.h>\n #include <rte_lock_annotations.h>\n #include <rte_pause.h>\n+#include <rte_stdatomic.h>\n \n /**\n * The rte_rwlock_t type.\ndiff --git a/lib/eal/include/generic/rte_spinlock.h b/lib/eal/include/generic/rte_spinlock.h\nindex c50ebaa..e18f0cd 100644\n--- a/lib/eal/include/generic/rte_spinlock.h\n+++ b/lib/eal/include/generic/rte_spinlock.h\n@@ -23,6 +23,7 @@\n #endif\n #include <rte_lock_annotations.h>\n #include <rte_pause.h>\n+#include <rte_stdatomic.h>\n \n /**\n * The rte_spinlock_t type.\ndiff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build\nindex a0463ef..e94b056 100644\n--- a/lib/eal/include/meson.build\n+++ b/lib/eal/include/meson.build\n@@ -42,6 +42,7 @@ headers += files(\n 'rte_seqlock.h',\n 'rte_service.h',\n 'rte_service_component.h',\n+ 'rte_stdatomic.h',\n 'rte_string_fns.h',\n 'rte_tailq.h',\n 'rte_thread.h',\ndiff --git a/lib/eal/include/rte_mcslock.h b/lib/eal/include/rte_mcslock.h\nindex a805cb2..18e63eb 100644\n--- a/lib/eal/include/rte_mcslock.h\n+++ b/lib/eal/include/rte_mcslock.h\n@@ -27,6 +27,7 @@\n #include <rte_common.h>\n #include <rte_pause.h>\n #include <rte_branch_prediction.h>\n+#include <rte_stdatomic.h>\n \n /**\n * The rte_mcslock_t type.\ndiff --git a/lib/eal/include/rte_pflock.h b/lib/eal/include/rte_pflock.h\nindex a3f7291..790be71 100644\n--- a/lib/eal/include/rte_pflock.h\n+++ b/lib/eal/include/rte_pflock.h\n@@ -34,6 +34,7 @@\n #include <rte_compat.h>\n #include <rte_common.h>\n #include <rte_pause.h>\n+#include <rte_stdatomic.h>\n \n /**\n * The rte_pflock_t type.\ndiff --git a/lib/eal/include/rte_seqcount.h b/lib/eal/include/rte_seqcount.h\nindex ff62708..098af26 100644\n--- a/lib/eal/include/rte_seqcount.h\n+++ b/lib/eal/include/rte_seqcount.h\n@@ -26,6 +26,7 @@\n #include <rte_atomic.h>\n #include <rte_branch_prediction.h>\n #include <rte_compat.h>\n+#include <rte_stdatomic.h>\n \n /**\n * The RTE seqcount type.\ndiff --git a/lib/eal/include/rte_stdatomic.h b/lib/eal/include/rte_stdatomic.h\nnew file mode 100644\nindex 0000000..f03be9b\n--- /dev/null\n+++ b/lib/eal/include/rte_stdatomic.h\n@@ -0,0 +1,182 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2023 Microsoft Corporation\n+ */\n+\n+#ifndef _RTE_STDATOMIC_H_\n+#define _RTE_STDATOMIC_H_\n+\n+#include <assert.h>\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#ifdef RTE_ENABLE_STDATOMIC\n+#ifdef __STDC_NO_ATOMICS__\n+#error enable_stdatomics=true but atomics not supported by toolchain\n+#endif\n+\n+#include <stdatomic.h>\n+\n+#define __rte_atomic _Atomic\n+\n+/* The memory order is an enumerated type in C11. */\n+typedef memory_order rte_memory_order;\n+\n+#define rte_memory_order_relaxed memory_order_relaxed\n+#ifdef __ATOMIC_RELAXED\n+static_assert(rte_memory_order_relaxed == __ATOMIC_RELAXED,\n+\t\"rte_memory_order_relaxed == __ATOMIC_RELAXED\");\n+#endif\n+\n+#define rte_memory_order_consume memory_order_consume\n+#ifdef __ATOMIC_CONSUME\n+static_assert(rte_memory_order_consume == __ATOMIC_CONSUME,\n+\t\"rte_memory_order_consume == __ATOMIC_CONSUME\");\n+#endif\n+\n+#define rte_memory_order_acquire memory_order_acquire\n+#ifdef __ATOMIC_ACQUIRE\n+static_assert(rte_memory_order_acquire == __ATOMIC_ACQUIRE,\n+\t\"rte_memory_order_acquire == __ATOMIC_ACQUIRE\");\n+#endif\n+\n+#define rte_memory_order_release memory_order_release\n+#ifdef __ATOMIC_RELEASE\n+static_assert(rte_memory_order_release == __ATOMIC_RELEASE,\n+\t\"rte_memory_order_release == __ATOMIC_RELEASE\");\n+#endif\n+\n+#define rte_memory_order_acq_rel memory_order_acq_rel\n+#ifdef __ATOMIC_ACQ_REL\n+static_assert(rte_memory_order_acq_rel == __ATOMIC_ACQ_REL,\n+\t\"rte_memory_order_acq_rel == __ATOMIC_ACQ_REL\");\n+#endif\n+\n+#define rte_memory_order_seq_cst memory_order_seq_cst\n+#ifdef __ATOMIC_SEQ_CST\n+static_assert(rte_memory_order_seq_cst == __ATOMIC_SEQ_CST,\n+\t\"rte_memory_order_seq_cst == __ATOMIC_SEQ_CST\");\n+#endif\n+\n+#define rte_atomic_load_explicit(ptr, memorder) \\\n+\tatomic_load_explicit(ptr, memorder)\n+\n+#define rte_atomic_store_explicit(ptr, val, memorder) \\\n+\tatomic_store_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_exchange_explicit(ptr, val, memorder) \\\n+\tatomic_exchange_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_compare_exchange_strong_explicit( \\\n+\t ptr, expected, desired, succ_memorder, fail_memorder) \\\n+\tatomic_compare_exchange_strong_explicit( \\\n+\t ptr, expected, desired, succ_memorder, fail_memorder)\n+\n+#define rte_atomic_compare_exchange_weak_explicit( \\\n+\t ptr, expected, desired, succ_memorder, fail_memorder) \\\n+\tatomic_compare_exchange_strong_explicit( \\\n+\t ptr, expected, desired, succ_memorder, fail_memorder)\n+\n+#define rte_atomic_fetch_add_explicit(ptr, val, memorder) \\\n+\tatomic_fetch_add_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_sub_explicit(ptr, val, memorder) \\\n+\tatomic_fetch_sub_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_and_explicit(ptr, val, memorder) \\\n+\tatomic_fetch_and_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_xor_explicit(ptr, val, memorder) \\\n+\tatomic_fetch_xor_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_or_explicit(ptr, val, memorder) \\\n+\tatomic_fetch_or_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_nand_explicit(ptr, val, memorder) \\\n+\tatomic_fetch_nand_explicit(ptr, val, memorder)\n+\n+#define rte_atomic_flag_test_and_set_explicit(ptr, memorder) \\\n+\tatomic_flag_test_and_set_explicit(ptr, memorder)\n+\n+#define rte_atomic_flag_clear_explicit(ptr, memorder) \\\n+\tatomic_flag_clear(ptr, memorder)\n+\n+/* We provide internal macro here to allow conditional expansion\n+ * in the body of the per-arch rte_atomic_thread_fence inline functions.\n+ */\n+#define __rte_atomic_thread_fence(memorder) \\\n+\tatomic_thread_fence(memorder)\n+\n+#else\n+\n+#define __rte_atomic\n+\n+/* The memory order is an integer type in GCC built-ins,\n+ * not an enumerated type like in C11.\n+ */\n+typedef int rte_memory_order;\n+\n+#define rte_memory_order_relaxed __ATOMIC_RELAXED\n+#define rte_memory_order_consume __ATOMIC_CONSUME\n+#define rte_memory_order_acquire __ATOMIC_ACQUIRE\n+#define rte_memory_order_release __ATOMIC_RELEASE\n+#define rte_memory_order_acq_rel __ATOMIC_ACQ_REL\n+#define rte_memory_order_seq_cst __ATOMIC_SEQ_CST\n+\n+#define rte_atomic_load_explicit(ptr, memorder) \\\n+\t__atomic_load_n(ptr, memorder)\n+\n+#define rte_atomic_store_explicit(ptr, val, memorder) \\\n+\t__atomic_store_n(ptr, val, memorder)\n+\n+#define rte_atomic_exchange_explicit(ptr, val, memorder) \\\n+\t__atomic_exchange_n(ptr, val, memorder)\n+\n+#define rte_atomic_compare_exchange_strong_explicit( \\\n+\t ptr, expected, desired, succ_memorder, fail_memorder) \\\n+\t__atomic_compare_exchange_n( \\\n+\t ptr, expected, desired, 0, succ_memorder, fail_memorder)\n+\n+#define rte_atomic_compare_exchange_weak_explicit( \\\n+\t ptr, expected, desired, succ_memorder, fail_memorder) \\\n+\t__atomic_compare_exchange_n( \\\n+\t ptr, expected, desired, 1, succ_memorder, fail_memorder)\n+\n+#define rte_atomic_fetch_add_explicit(ptr, val, memorder) \\\n+\t__atomic_fetch_add(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_sub_explicit(ptr, val, memorder) \\\n+\t__atomic_fetch_sub(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_and_explicit(ptr, val, memorder) \\\n+\t__atomic_fetch_and(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_xor_explicit(ptr, val, memorder) \\\n+\t__atomic_fetch_xor(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_or_explicit(ptr, val, memorder) \\\n+\t__atomic_fetch_or(ptr, val, memorder)\n+\n+#define rte_atomic_fetch_nand_explicit(ptr, val, memorder) \\\n+\t__atomic_fetch_nand(ptr, val, memorder)\n+\n+#define rte_atomic_flag_test_and_set_explicit(ptr, memorder) \\\n+\t__atomic_test_and_set(ptr, memorder)\n+\n+#define rte_atomic_flag_clear_explicit(ptr, memorder) \\\n+\t__atomic_clear(ptr, memorder)\n+\n+/* We provide internal macro here to allow conditional expansion\n+ * in the body of the per-arch rte_atomic_thread_fence inline functions.\n+ */\n+#define __rte_atomic_thread_fence(memorder) \\\n+\t__atomic_thread_fence(memorder)\n+\n+#endif\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_STDATOMIC_H_ */\ndiff --git a/lib/eal/include/rte_ticketlock.h b/lib/eal/include/rte_ticketlock.h\nindex 5db0d8a..e22d119 100644\n--- a/lib/eal/include/rte_ticketlock.h\n+++ b/lib/eal/include/rte_ticketlock.h\n@@ -24,6 +24,7 @@\n #include <rte_common.h>\n #include <rte_lcore.h>\n #include <rte_pause.h>\n+#include <rte_stdatomic.h>\n \n /**\n * The rte_ticketlock_t type.\ndiff --git a/lib/eal/include/rte_trace_point.h b/lib/eal/include/rte_trace_point.h\nindex c6b6fcc..d587591 100644\n--- a/lib/eal/include/rte_trace_point.h\n+++ b/lib/eal/include/rte_trace_point.h\n@@ -30,6 +30,7 @@\n #include <rte_per_lcore.h>\n #include <rte_string_fns.h>\n #include <rte_uuid.h>\n+#include <rte_stdatomic.h>\n \n /** The tracepoint object. */\n typedef uint64_t rte_trace_point_t;\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 621e1ca..bb22bba 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -46,6 +46,8 @@ option('mbuf_refcnt_atomic', type: 'boolean', value: true, description:\n 'Atomically access the mbuf refcnt.')\n option('platform', type: 'string', value: 'native', description:\n 'Platform to build, either \"native\", \"generic\" or a SoC. Please refer to the Linux build guide for more information.')\n+option('enable_stdatomic', type: 'boolean', value: false, description:\n+ 'enable use of C11 stdatomic')\n option('enable_trace_fp', type: 'boolean', value: false, description:\n 'enable fast path trace points.')\n option('tests', type: 'boolean', value: true, description:\n", "prefixes": [ "v2", "1/6" ] }