Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130190/?format=api
{ "id": 130190, "url": "http://patchwork.dpdk.org/api/patches/130190/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1691778287-15746-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1691778287-15746-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1691778287-15746-3-git-send-email-roretzla@linux.microsoft.com", "date": "2023-08-11T18:24:45", "name": "[v4,2/4] build: determine execution environment at config time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f05ddd4f501413f7fd3e953a4d768c1b325973d9", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1691778287-15746-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29197, "url": "http://patchwork.dpdk.org/api/series/29197/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29197", "date": "2023-08-11T18:24:46", "name": "enable use of the MSVC compiler", "version": 4, "mbox": "http://patchwork.dpdk.org/series/29197/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130190/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130190/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1294743037;\n\tFri, 11 Aug 2023 20:25:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CF0D84325F;\n\tFri, 11 Aug 2023 20:24:52 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 822C040F17\n for <dev@dpdk.org>; Fri, 11 Aug 2023 20:24:49 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id BD38F20FCF7F; Fri, 11 Aug 2023 11:24:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com BD38F20FCF7F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1691778288;\n bh=tFtPwRO1U6JpXiQuWkrmOwTG9wSAqtJWzlOWfFJiZSw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=CAKbPsaW2ptw6z1dEWma+uIKSpNxq7/uwJagvUz8IrEcWmNlWrlssIXJkSeqzIL5g\n vVrJ8gkJLOe77va+FYM+eX4ob/jE9hT9oNZwDk9NlvwKXpg0C0o5esmlWDOd9WArau\n syq/mPVNFQ9XD8dtCsRqINejy5LNpvQ7QN4uFIZQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n david.marchand@redhat.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 2/4] build: determine execution environment at config time", "Date": "Fri, 11 Aug 2023 11:24:45 -0700", "Message-Id": "<1691778287-15746-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com>\n <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Move execution environment determination and definitions to config. The\nRTE_EXEC_ENV macros are actually used by libraries built before EAL.\n\nCurrently it does not matter that this is determined in lib/eal since\nthe definitions are consumed before anything is built including libs\nbuilt before lib/eal. By moving this logic to config it allows kvargs\nand telemetry to be built without EAL.\n\nNo functional change intended.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/meson.build | 8 ++++++++\n lib/eal/meson.build | 8 --------\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex b6c7d48..821a1c3 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -14,6 +14,14 @@ foreach env:supported_exec_envs\n set_variable('is_' + env, exec_env == env)\n endforeach\n \n+exec_envs = {'freebsd': 0, 'linux': 1, 'windows': 2}\n+foreach env, id:exec_envs\n+ dpdk_conf.set('RTE_ENV_' + env.to_upper(), id)\n+ dpdk_conf.set10('RTE_EXEC_ENV_IS_' + env.to_upper(), (exec_env == env))\n+endforeach\n+dpdk_conf.set('RTE_EXEC_ENV', exec_envs[exec_env])\n+dpdk_conf.set('RTE_EXEC_ENV_' + exec_env.to_upper(), 1)\n+\n # MS linker requires special treatment.\n # TODO: use cc.get_linker_id() with Meson >= 0.54\n is_ms_compiler = is_windows and (cc.get_id() == 'msvc')\ndiff --git a/lib/eal/meson.build b/lib/eal/meson.build\nindex 0fb974c..9942104 100644\n--- a/lib/eal/meson.build\n+++ b/lib/eal/meson.build\n@@ -10,14 +10,6 @@ if not is_windows\n subdir('unix')\n endif\n \n-exec_envs = {'freebsd': 0, 'linux': 1, 'windows': 2}\n-foreach env, id:exec_envs\n- dpdk_conf.set('RTE_ENV_' + env.to_upper(), id)\n- dpdk_conf.set10('RTE_EXEC_ENV_IS_' + env.to_upper(), (exec_env == env))\n-endforeach\n-dpdk_conf.set('RTE_EXEC_ENV', exec_envs[exec_env])\n-\n-dpdk_conf.set('RTE_EXEC_ENV_' + exec_env.to_upper(), 1)\n subdir(exec_env)\n \n subdir(arch_subdir)\n", "prefixes": [ "v4", "2/4" ] }