Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130200/?format=api
{ "id": 130200, "url": "http://patchwork.dpdk.org/api/patches/130200/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1691781658-32520-8-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1691781658-32520-8-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1691781658-32520-8-git-send-email-roretzla@linux.microsoft.com", "date": "2023-08-11T19:20:49", "name": "[v11,07/16] eal: use byte swap intrinsics", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3da1c4d642e4d6b0b65200a0f6003d4209984d04", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1691781658-32520-8-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29198, "url": "http://patchwork.dpdk.org/api/series/29198/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29198", "date": "2023-08-11T19:20:44", "name": "msvc integration changes", "version": 11, "mbox": "http://patchwork.dpdk.org/series/29198/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130200/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE65243037;\n\tFri, 11 Aug 2023 21:21:50 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A9244327B;\n\tFri, 11 Aug 2023 21:21:12 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id A87F240F17\n for <dev@dpdk.org>; Fri, 11 Aug 2023 21:21:01 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 78CDD20FD0E4; Fri, 11 Aug 2023 12:21:00 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 78CDD20FD0E4", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1691781660;\n bh=w+QVq1B9vMO46jggBj+ImzeYs3RHkEKQSzKvJNzoXs8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=axylZvzwm8Mm5CCyFMcEucjx1BcVyhVhVF6v3oJuTkYBxOUbmd+cYljqes0XtbtHh\n YUG4EGt5uVmwI92WI0kGgd1zImrrIFaxC/8bczaIw9TquGvLXCGCM+DrpzG3+/dXNd\n 98fD836wWBc36mWE+YcXCeV/ZI2n70D5TQHWjt48=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Ciara Power <ciara.power@intel.com>, thomas@monjalon.net,\n david.marchand@redhat.com, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v11 07/16] eal: use byte swap intrinsics", "Date": "Fri, 11 Aug 2023 12:20:49 -0700", "Message-Id": "<1691781658-32520-8-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1691781658-32520-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>\n <1691781658-32520-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Inline assembly is not supported for MSVC x64 instead expand\nuse _byteswap_u{ushort,ulong,uint64} intrinsics instead.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/include/generic/rte_byteorder.h | 11 +++++++++++\n lib/eal/x86/include/rte_byteorder.h | 4 ++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/lib/eal/include/generic/rte_byteorder.h b/lib/eal/include/generic/rte_byteorder.h\nindex a67e1d7..1e32a1b 100644\n--- a/lib/eal/include/generic/rte_byteorder.h\n+++ b/lib/eal/include/generic/rte_byteorder.h\n@@ -234,6 +234,7 @@\n #endif /* __DOXYGEN__ */\n \n #ifdef RTE_FORCE_INTRINSICS\n+#ifndef RTE_TOOLCHAIN_MSVC\n #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8)\n #define rte_bswap16(x) __builtin_bswap16(x)\n #endif\n@@ -241,6 +242,16 @@\n #define rte_bswap32(x) __builtin_bswap32(x)\n \n #define rte_bswap64(x) __builtin_bswap64(x)\n+#else\n+/*\n+ * note: we may want to #pragma intrsinsic(_byteswap_u{short,long,uint64})\n+ */\n+#define rte_bswap16(x) _byteswap_ushort(x)\n+\n+#define rte_bswap32(x) _byteswap_ulong(x)\n+\n+#define rte_bswap64(x) _byteswap_uint64(x)\n+#endif\n \n #endif\n \ndiff --git a/lib/eal/x86/include/rte_byteorder.h b/lib/eal/x86/include/rte_byteorder.h\nindex a2dfecc..3d6e58e 100644\n--- a/lib/eal/x86/include/rte_byteorder.h\n+++ b/lib/eal/x86/include/rte_byteorder.h\n@@ -18,6 +18,7 @@\n #define RTE_BYTE_ORDER RTE_LITTLE_ENDIAN\n #endif\n \n+#ifndef RTE_TOOLCHAIN_MSVC\n /*\n * An architecture-optimized byte swap for a 16-bit value.\n *\n@@ -69,6 +70,7 @@ static inline uint32_t rte_arch_bswap32(uint32_t _x)\n \t\t\t\t rte_arch_bswap16(x)))\n #endif\n #endif\n+#endif\n \n #define rte_cpu_to_le_16(x) (x)\n #define rte_cpu_to_le_32(x) (x)\n@@ -86,11 +88,13 @@ static inline uint32_t rte_arch_bswap32(uint32_t _x)\n #define rte_be_to_cpu_32(x) rte_bswap32(x)\n #define rte_be_to_cpu_64(x) rte_bswap64(x)\n \n+#ifndef RTE_TOOLCHAIN_MSVC\n #ifdef RTE_ARCH_I686\n #include \"rte_byteorder_32.h\"\n #else\n #include \"rte_byteorder_64.h\"\n #endif\n+#endif\n \n #ifdef __cplusplus\n }\n", "prefixes": [ "v11", "07/16" ] }