Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130266/?format=api
{ "id": 130266, "url": "http://patchwork.dpdk.org/api/patches/130266/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230810153951.3889409-1-jhascoet@kalray.eu/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230810153951.3889409-1-jhascoet@kalray.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/20230810153951.3889409-1-jhascoet@kalray.eu", "date": "2023-08-10T15:39:51", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "06e293f8e3eca5e0ca0702675b1f62b0b598cb6f", "submitter": { "id": 3147, "url": "http://patchwork.dpdk.org/api/people/3147/?format=api", "name": "jhascoet", "email": "ju.hascoet@gmail.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230810153951.3889409-1-jhascoet@kalray.eu/mbox/", "series": [ { "id": 29215, "url": "http://patchwork.dpdk.org/api/series/29215/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29215", "date": "2023-08-10T15:39:51", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29215/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130266/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130266/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B85DA43063;\n\tMon, 14 Aug 2023 16:07:37 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5AF9640A7F;\n\tMon, 14 Aug 2023 16:07:37 +0200 (CEST)", "from mail-ej1-f43.google.com (mail-ej1-f43.google.com\n [209.85.218.43]) by mails.dpdk.org (Postfix) with ESMTP id C086940691\n for <dev@dpdk.org>; Thu, 10 Aug 2023 17:39:54 +0200 (CEST)", "by mail-ej1-f43.google.com with SMTP id\n a640c23a62f3a-9923833737eso148410466b.3\n for <dev@dpdk.org>; Thu, 10 Aug 2023 08:39:54 -0700 (PDT)", "from coolup54.lin.mbt.kalray.eu ([217.181.231.53])\n by smtp.gmail.com with ESMTPSA id\n kd7-20020a17090798c700b0099ba3438554sm1084778ejc.191.2023.08.10.08.39.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 10 Aug 2023 08:39:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1691681994; x=1692286794;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=;\n b=CMT09z2wSJbaUQlgv8PxsInmKvZsflUZV3P4B/lNrmQKFjq4XvkUk5RLPzfaN3SJRd\n 68DnLNwaw0efc4SkQxQduh08HO/uNCHoY/AwUDd5JagI7WWLkocHv8VpHL5pLviGfamP\n SIPVJ9N25fMIjYIpSzmyJQHcYFlUYnCZRkDjErA7yeSl9v3/JnmojbXNUTPk2wJDEVZ3\n GoO7wslZXuRTBVTUXUizNLh+zmuA10Cxs95rKsilIbFXb6fVedGxjn4e9s+txg7AmJfi\n wm0MHzuTcqijrrl/mRuy+S1WJxXsa+70obq20iOmCyazhSfrIsUQa/KuBVj3X2nJVxpq\n 4/rw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691681994; x=1692286794;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=;\n b=ZShICU4KVa6j8VnJYIu/dT/TpSOYgDzmuukFWD+Ice4A7PuCc+DKZROuRApDiqlEcy\n OcwNruTu369V9xA3Dk0NZTpk10a1BEPAdNuP9c7zSON0+fF8OI1n5GRr8pOil5YNV8L1\n 9voLYwrucxVY9XF4ER9Uypza9qiDR9HSgrimg5qzQ5bas96VO4DK1C9ze2XOp/r6p4lN\n 5fQ1IdryqVLOGAsehNBYWbU2DnwwB839NVJK5GzVET+jdjwyl0UYMTrqHBYMxrd9PEwb\n Xdn+pAPPLfsjftD+lrYmhThLg10et1DY7cWhxKJ7KqiR/NjgjnIH5XMrQgWMfLlwOOmf\n krvg==", "X-Gm-Message-State": "AOJu0Yym4rtNkFnKlKvVAlhoPwKHZzpe1mTuBi4s0FUsSvDZmndqrVSl\n bewNo8SThpMZOuNrg+hPr0c=", "X-Google-Smtp-Source": "\n AGHT+IGEnKhJe4wjJitnjzvNwfwOY53ozsTSuwU+75jV30Cu0KdLSsThuvi74WdYkvNt0EQ6VJRbqg==", "X-Received": "by 2002:a17:907:760d:b0:992:13c7:563 with SMTP id\n jx13-20020a170907760d00b0099213c70563mr2306355ejc.75.1691681994063;\n Thu, 10 Aug 2023 08:39:54 -0700 (PDT)", "From": "jhascoet <ju.hascoet@gmail.com>", "X-Google-Original-From": "jhascoet <jhascoet@kalray.eu>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org,\n\tJulien Hascoet <ju.hascoet@gmail.com>", "Subject": "[PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "Date": "Thu, 10 Aug 2023 17:39:51 +0200", "Message-Id": "<20230810153951.3889409-1-jhascoet@kalray.eu>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 14 Aug 2023 16:07:37 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Julien Hascoet <ju.hascoet@gmail.com>\n\nIn case of ring full state, we retry the enqueue\noperation in order to avoid mbuf loss.\n\nFixes: af75078fece (\"first public release\")\n\nSigned-off-by: Julien Hascoet <ju.hascoet@gmail.com>\n---\n app/test/test_mbuf.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex efac01806b..be114e3302 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,\n \t\ttref += ref;\n \t\tif ((ref & 1) != 0) {\n \t\t\trte_pktmbuf_refcnt_update(m, ref);\n-\t\t\twhile (ref-- != 0)\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\twhile (ref-- != 0) {\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+\t\t\t\t\t;\n+\t\t\t}\n \t\t} else {\n \t\t\twhile (ref-- != 0) {\n \t\t\t\trte_pktmbuf_refcnt_update(m, 1);\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)\n+\t\t\t\t\t;\n \t\t\t}\n \t\t}\n \t\trte_pktmbuf_free(m);\n", "prefixes": [] }