Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130267/?format=api
{ "id": 130267, "url": "http://patchwork.dpdk.org/api/patches/130267/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230810160941.3895855-1-jhascoet@kalray.eu/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230810160941.3895855-1-jhascoet@kalray.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/20230810160941.3895855-1-jhascoet@kalray.eu", "date": "2023-08-10T16:09:41", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cb8cef8b84f75c75daf85c8bc8440cd8923f62d1", "submitter": { "id": 3147, "url": "http://patchwork.dpdk.org/api/people/3147/?format=api", "name": "jhascoet", "email": "ju.hascoet@gmail.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230810160941.3895855-1-jhascoet@kalray.eu/mbox/", "series": [ { "id": 29216, "url": "http://patchwork.dpdk.org/api/series/29216/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29216", "date": "2023-08-10T16:09:41", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29216/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130267/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130267/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA81B43063;\n\tMon, 14 Aug 2023 16:07:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C5D7E43293;\n\tMon, 14 Aug 2023 16:07:38 +0200 (CEST)", "from mail-lj1-f178.google.com (mail-lj1-f178.google.com\n [209.85.208.178])\n by mails.dpdk.org (Postfix) with ESMTP id 3963940691\n for <dev@dpdk.org>; Thu, 10 Aug 2023 18:09:44 +0200 (CEST)", "by mail-lj1-f178.google.com with SMTP id\n 38308e7fff4ca-2b9bee2d320so16816111fa.1\n for <dev@dpdk.org>; Thu, 10 Aug 2023 09:09:44 -0700 (PDT)", "from coolup54.lin.mbt.kalray.eu ([217.181.231.53])\n by smtp.gmail.com with ESMTPSA id\n o20-20020a17090611d400b0099bd6026f45sm1112994eja.198.2023.08.10.09.09.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 10 Aug 2023 09:09:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1691683783; x=1692288583;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vNUJtctEe9Fb/DWhLDmJ4i4ahTOndz0EhBeq9LlgZk0=;\n b=qg/FskRbJt+hK2vTMmN1KWyBzNtjfapYKK0Og8E1/6DXoQsOe9lsOtzj90NCvVLan3\n 80mWa7S3OiRdtrWsRNNAdkxTjlbC/K2Vuya1xZhxaWWFw2UpgaHBS2QcWBCqhfjiENe1\n 4EMV/WGm3rpeHIJ/jlmk/1nJMNdABO/nCiTjAaexDYE2Ls28ULmhN6LWwtbh9XnRRmBJ\n pmHqdZsiT17UQggq4+RJpOnUGx0GdVkRFIpZbf3yuR1raxnDnrTIz1pCZ3xygpTzF4IZ\n HIPlIHaKmUDNlHKob3bI1gvTNQNXL9GnHKubT097czWovhtZEEjoQf7/Z8dgKN2S/ikZ\n 1CAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691683783; x=1692288583;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=vNUJtctEe9Fb/DWhLDmJ4i4ahTOndz0EhBeq9LlgZk0=;\n b=T6tXRK2/01aNNuekyG+VXgepvhFc2Ockk9XQ/HOSc4lF4Vtw0L5oLDqr6x/x8bO7Tc\n zinWC4ooquvp3xvJwnLsmqlkw9eHD+0TXt0twpMUZHCReXOosqJUoyBeJRb+XeKTtAv1\n 94uj1vPsiph6KHy5ChVmWzJDeElw/hgGNkKd2204W76K4j2GP26dJ6E584HsProm/s/K\n XqCuw3cDYoN+vHc6Qwv49tbUbR8ltQ/aVscQkoUWfxxmIU358SdB5/P2bsIZoT3A2bdy\n EcTEIGjKPXXF54pA+lc473AoUSFxn35Z5UZhkJzWIjMrU5PeW19vkMeiM8WW9yh7KfTo\n 8ATQ==", "X-Gm-Message-State": "AOJu0Yy2kAtklJ7bPRNvZ9dP2epOTHmDxG2E/DIrgmZv4ohF5/zYJL7g\n X3YIylQOfakWgcqm+KSQVeE=", "X-Google-Smtp-Source": "\n AGHT+IFlEtpoPxxqvCqzrkXlaopfNtBp2/vv08Lsr0tbDWjKgG7TCINR0LiTNTD8ZlqfllMRLcYv8Q==", "X-Received": "by 2002:a2e:320d:0:b0:2b9:4418:b46e with SMTP id\n y13-20020a2e320d000000b002b94418b46emr2582341ljy.21.1691683783298;\n Thu, 10 Aug 2023 09:09:43 -0700 (PDT)", "From": "jhascoet <ju.hascoet@gmail.com>", "X-Google-Original-From": "jhascoet <jhascoet@kalray.eu>", "To": "david.marchand@redhat.com", "Cc": "dev@dpdk.org,\n\tJulien Hascoet <ju.hascoet@gmail.com>", "Subject": "[PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "Date": "Thu, 10 Aug 2023 18:09:41 +0200", "Message-Id": "<20230810160941.3895855-1-jhascoet@kalray.eu>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230810060030.3759835-1-jhascoet@kalray.eu>", "References": "<20230810060030.3759835-1-jhascoet@kalray.eu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 14 Aug 2023 16:07:37 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Julien Hascoet <ju.hascoet@gmail.com>\n\nIn case of ring full state, we retry the enqueue\noperation in order to avoid mbuf loss.\n\nFixes: af75078fece (\"first public release\")\n\nSigned-off-by: Julien Hascoet <ju.hascoet@gmail.com>\n---\n app/test/test_mbuf.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex efac01806b..ad18bf6378 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -1033,12 +1033,21 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,\n \t\ttref += ref;\n \t\tif ((ref & 1) != 0) {\n \t\t\trte_pktmbuf_refcnt_update(m, ref);\n-\t\t\twhile (ref-- != 0)\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\twhile (ref-- != 0) {\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) {\n+\t\t\t\t\t/* let others consume */\n+\t\t\t\t\trte_pause();\n+\t\t\t\t}\n+\t\t\t}\n \t\t} else {\n \t\t\twhile (ref-- != 0) {\n \t\t\t\trte_pktmbuf_refcnt_update(m, 1);\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) {\n+\t\t\t\t\t/* let others consume */\n+\t\t\t\t\trte_pause();\n+\t\t\t\t}\n \t\t\t}\n \t\t}\n \t\trte_pktmbuf_free(m);\n", "prefixes": [] }