Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130285/?format=api
{ "id": 130285, "url": "http://patchwork.dpdk.org/api/patches/130285/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230814163125.63033-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230814163125.63033-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230814163125.63033-2-stephen@networkplumber.org", "date": "2023-08-14T16:31:20", "name": "[v8,1/6] ip_frag: use a dynamic logtype", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "99feb8468347dad8f1745204d44f3bc9735985f0", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230814163125.63033-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 29220, "url": "http://patchwork.dpdk.org/api/series/29220/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29220", "date": "2023-08-14T16:31:19", "name": "Convert use of RTE_LOGTYPE_USER1 in libraries", "version": 8, "mbox": "http://patchwork.dpdk.org/series/29220/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130285/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130285/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C91143066;\n\tMon, 14 Aug 2023 18:31:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED292432A9;\n\tMon, 14 Aug 2023 18:31:39 +0200 (CEST)", "from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by mails.dpdk.org (Postfix) with ESMTP id F04A840A7F\n for <dev@dpdk.org>; Mon, 14 Aug 2023 18:31:37 +0200 (CEST)", "by mail-pl1-f178.google.com with SMTP id\n d9443c01a7336-1bddac1b7bfso8626835ad.0\n for <dev@dpdk.org>; Mon, 14 Aug 2023 09:31:37 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n t10-20020a170902bc4a00b001bdd51748f8sm3892743plz.271.2023.08.14.09.31.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 14 Aug 2023 09:31:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692030697;\n x=1692635497;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=39oi0XMZ/bSiInQ/m2Fwrvucyi+D0Ge2Q9c8CWxrhRc=;\n b=sUxWaezaz5phh1U5tbdcdx4xFG+pSdOaFbGo/LkXNQio1EjnevgPCITvA5w9NzAzza\n 07mT1IJlK7hLZtwS8LH+aIbJuOaRPHZ9VZOQL5zhm0uKgbqTengwjqy00k7R6IgQYhlr\n y07ZzjX/CJOC4X4E2UR6WcV6ZG8hyVWDn63hZ8tlUusM6n/2jjdC6LYSu86bZl4/1xta\n AeC5MRqmwcpBdwM6gCekQgae8d32edDhWqIFs6FYErCMzSSoVc/eZYHlCwXR4RQuZ1VW\n jMWagOnNqODb7S9ijnFAZGq4OLMkUEt6m2mqLJ/BYwyd/yl+7992+G30hu2D1UxbdL9c\n 8oyQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1692030697; x=1692635497;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=39oi0XMZ/bSiInQ/m2Fwrvucyi+D0Ge2Q9c8CWxrhRc=;\n b=N5R4c/7FwdLsp+VDHLlOwPqZRoEcSmFbSj5ul7S+otaGrXIfrWAovjpR2NOhuA1Tf7\n tYyKiofzhuWwxCf91CnYcYteAq60FnQ52mUDxsDq+KHbcVuV61x1XwMgTzAySF5NK0So\n bNeM1FTZZCK9lcUj4zfpLCIPVYmnOETA/Qao+KJxUT752NLfEnkhjBpxTLl46oFJP3cO\n POOfQBkRwpxzHQh/KrnWx9kOaAdHAfcNP3z6MMxZ32UPoAbPPsi0jnz8F+wAGgxGKoyj\n N/vKvGbrvKy6UOZnXEiWlA+LitsyRVuTSSIJUvJzCPYnUmjcJYiuOlE/UScTzkVrdkRq\n 24BA==", "X-Gm-Message-State": "AOJu0YyyF74hAaYCRbBuqQvpEl7hHfkRbLYChfNFwjqxI3CMg09JAZf1\n 96AaR8qdS6m+QaFJBG0xf3hf9y9QKOJuogm+bm6ttTwPyw0=", "X-Google-Smtp-Source": "\n AGHT+IFofbekXXZ7g8DtpiuSqvKl+hi6Pv0Pjzw/Ld45OP/fU28b8cME2Z0mEJ8BQaBTjbJcFzqjVQ==", "X-Received": "by 2002:a17:902:d50c:b0:1bb:55be:e198 with SMTP id\n b12-20020a170902d50c00b001bb55bee198mr10856976plg.0.1692030696850;\n Mon, 14 Aug 2023 09:31:36 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>", "Subject": "[PATCH v8 1/6] ip_frag: use a dynamic logtype", "Date": "Mon, 14 Aug 2023 09:31:20 -0700", "Message-Id": "<20230814163125.63033-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230814163125.63033-1-stephen@networkplumber.org>", "References": "<20230208044825.1682620-1-stephen@networkplumber.org>\n <20230814163125.63033-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in\nlieu of doing proper logtype registration.\n\nAcked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>\nFixes: 416707812c03 (\"ip_frag: refactor reassembly code into a proper library\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/ip_frag/ip_frag_common.h | 5 ++++-\n lib/ip_frag/rte_ip_frag_common.c | 8 +++++---\n 2 files changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/ip_frag/ip_frag_common.h b/lib/ip_frag/ip_frag_common.h\nindex 7d6c1aa98d98..537bce7c3b62 100644\n--- a/lib/ip_frag/ip_frag_common.h\n+++ b/lib/ip_frag/ip_frag_common.h\n@@ -18,9 +18,12 @@\n #include \"rte_ip_frag.h\"\n #include \"ip_reassembly.h\"\n \n+extern int ipfrag_logtype;\n+#define RTE_LOGTYPE_IPFRAG\tipfrag_logtype\n+\n /* logging macros. */\n #ifdef RTE_LIBRTE_IP_FRAG_DEBUG\n-#define\tIP_FRAG_LOG(lvl, fmt, args...)\tRTE_LOG(lvl, USER1, fmt, ##args)\n+#define\tIP_FRAG_LOG(lvl, fmt, args...)\tRTE_LOG(lvl, IPFRAG, fmt, ##args)\n #else\n #define\tIP_FRAG_LOG(lvl, fmt, args...)\tdo {} while(0)\n #endif /* IP_FRAG_DEBUG */\ndiff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_frag_common.c\nindex c1de2e81b6d0..eed399da6bc5 100644\n--- a/lib/ip_frag/rte_ip_frag_common.c\n+++ b/lib/ip_frag/rte_ip_frag_common.c\n@@ -7,6 +7,8 @@\n \n #include <rte_log.h>\n \n+RTE_LOG_REGISTER_DEFAULT(ipfrag_logtype, INFO);\n+\n #include \"ip_frag_common.h\"\n \n #define\tIP_FRAG_HASH_FNUM\t2\n@@ -52,20 +54,20 @@ rte_ip_frag_table_create(uint32_t bucket_num, uint32_t bucket_entries,\n \tif (rte_is_power_of_2(bucket_entries) == 0 ||\n \t\t\tnb_entries > UINT32_MAX || nb_entries == 0 ||\n \t\t\tnb_entries < max_entries) {\n-\t\tRTE_LOG(ERR, USER1, \"%s: invalid input parameter\\n\", __func__);\n+\t\tRTE_LOG(ERR, IPFRAG, \"%s: invalid input parameter\\n\", __func__);\n \t\treturn NULL;\n \t}\n \n \tsz = sizeof (*tbl) + nb_entries * sizeof (tbl->pkt[0]);\n \tif ((tbl = rte_zmalloc_socket(__func__, sz, RTE_CACHE_LINE_SIZE,\n \t\t\tsocket_id)) == NULL) {\n-\t\tRTE_LOG(ERR, USER1,\n+\t\tRTE_LOG(ERR, IPFRAG,\n \t\t\t\"%s: allocation of %zu bytes at socket %d failed do\\n\",\n \t\t\t__func__, sz, socket_id);\n \t\treturn NULL;\n \t}\n \n-\tRTE_LOG(INFO, USER1, \"%s: allocated of %zu bytes at socket %d\\n\",\n+\tRTE_LOG(INFO, IPFRAG, \"%s: allocated of %zu bytes at socket %d\\n\",\n \t\t__func__, sz, socket_id);\n \n \ttbl->max_cycles = max_cycles;\n", "prefixes": [ "v8", "1/6" ] }