Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130465/?format=api
{ "id": 130465, "url": "http://patchwork.dpdk.org/api/patches/130465/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230817114557.25574-2-rnagadheeraj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230817114557.25574-2-rnagadheeraj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230817114557.25574-2-rnagadheeraj@marvell.com", "date": "2023-08-17T11:45:56", "name": "[1/2] crypto/nitrox: fix panic with higher mbuf segments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5382a4c86e698f19111eb9a3d116b915062eaa5e", "submitter": { "id": 1365, "url": "http://patchwork.dpdk.org/api/people/1365/?format=api", "name": "Nagadheeraj Rottela", "email": "rnagadheeraj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230817114557.25574-2-rnagadheeraj@marvell.com/mbox/", "series": [ { "id": 29264, "url": "http://patchwork.dpdk.org/api/series/29264/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29264", "date": "2023-08-17T11:45:55", "name": "Add AES-CCM support and fix application panic", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29264/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130465/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130465/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C47F4308D;\n\tThu, 17 Aug 2023 13:46:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 66D8E40EE2;\n\tThu, 17 Aug 2023 13:46:15 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 383B142D12;\n Thu, 17 Aug 2023 13:46:13 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37H3ZFva017346; Thu, 17 Aug 2023 04:46:12 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sgptkwp48-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 17 Aug 2023 04:46:12 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 17 Aug 2023 04:46:10 -0700", "from hyd1399.caveonetworks.com.com (10.69.176.80) by\n DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id\n 15.0.1497.48 via Frontend Transport; Thu, 17 Aug 2023 04:46:08 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=Q6Ygg/Su5Re4Jk30l83aWtEuYrW6Eix+SffxM2740Ic=;\n b=gTV5lQoqlCLG6tdYxkdBs2Lm291bV2M4zCKCCMsWQgQydFDiCKw7tICwLz/CwE3KwDb1\n o/FxAutsKlJ2Ja/NCd246ay51EyvbYpw6GMI371KAjucHz8fjnONNE9cH0QcIr0KouHX\n p/EUIzUy20k+sXJ9zsl3P2EE1QN65HwjineSbi+Lf/2svlCPH+eZnYf++wql7s7oR656\n 7okumWaPI0OfvjmJEdxiGP/UViHcgxQRwpR7Stlw/mBZylkSY417ZecA8DAM67kOPhIc\n AEuEk238Sy4wa73vV5uKf/7kdjPIOI3BbUBIRoaGZfutvac82aUynk3yZaI9/S1L6Nm0 dw==", "From": "Nagadheeraj Rottela <rnagadheeraj@marvell.com>", "To": "<gakhil@marvell.com>", "CC": "<dev@dpdk.org>, Nagadheeraj Rottela <rnagadheeraj@marvell.com>,\n <stable@dpdk.org>", "Subject": "[PATCH 1/2] crypto/nitrox: fix panic with higher mbuf segments", "Date": "Thu, 17 Aug 2023 17:15:56 +0530", "Message-ID": "<20230817114557.25574-2-rnagadheeraj@marvell.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20230817114557.25574-1-rnagadheeraj@marvell.com>", "References": "<20230817114557.25574-1-rnagadheeraj@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "VpLBF14vYj7BJiFl05AXSMlTWnsrjkCN", "X-Proofpoint-GUID": "VpLBF14vYj7BJiFl05AXSMlTWnsrjkCN", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26\n definitions=2023-08-17_04,2023-08-17_02,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the number of segments in source or destination mbuf is higher than\nmax supported then the application was panicked during the creation of\nsglist when RTE_VERIFY was called. Validate the number of mbuf segments\nand return an error instead of panicking.\n\nFixes: 678f3eca1dfd (\"crypto/nitrox: support cipher-only operations\")\nFixes: 9282bdee5cdf (\"crypto/nitrox: add cipher auth chain processing\")\nCc: stable@dpdk.org\n\nSigned-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>\n---\n drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 21 ++++++++++++++++-----\n 1 file changed, 16 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/crypto/nitrox/nitrox_sym_reqmgr.c b/drivers/crypto/nitrox/nitrox_sym_reqmgr.c\nindex 9edb0cc00f..d7e8ff7db4 100644\n--- a/drivers/crypto/nitrox/nitrox_sym_reqmgr.c\n+++ b/drivers/crypto/nitrox/nitrox_sym_reqmgr.c\n@@ -10,8 +10,11 @@\n #include \"nitrox_sym_reqmgr.h\"\n #include \"nitrox_logs.h\"\n \n-#define MAX_SGBUF_CNT 16\n-#define MAX_SGCOMP_CNT 5\n+#define MAX_SUPPORTED_MBUF_SEGS 16\n+/* IV + AAD + ORH + CC + DIGEST */\n+#define ADDITIONAL_SGBUF_CNT 5\n+#define MAX_SGBUF_CNT (MAX_SUPPORTED_MBUF_SEGS + ADDITIONAL_SGBUF_CNT)\n+#define MAX_SGCOMP_CNT (RTE_ALIGN_MUL_CEIL(MAX_SGBUF_CNT, 4) / 4)\n /* SLC_STORE_INFO */\n #define MIN_UDD_LEN 16\n /* PKT_IN_HDR + SLC_STORE_INFO */\n@@ -303,7 +306,7 @@ create_sglist_from_mbuf(struct nitrox_sgtable *sgtbl, struct rte_mbuf *mbuf,\n \t\tdatalen -= mlen;\n \t}\n \n-\tRTE_VERIFY(cnt <= MAX_SGBUF_CNT);\n+\tRTE_ASSERT(cnt <= MAX_SGBUF_CNT);\n \tsgtbl->map_bufs_cnt = cnt;\n \treturn 0;\n }\n@@ -375,7 +378,7 @@ create_cipher_outbuf(struct nitrox_softreq *sr)\n \tsr->out.sglist[cnt].virt = &sr->resp.completion;\n \tcnt++;\n \n-\tRTE_VERIFY(cnt <= MAX_SGBUF_CNT);\n+\tRTE_ASSERT(cnt <= MAX_SGBUF_CNT);\n \tsr->out.map_bufs_cnt = cnt;\n \n \tcreate_sgcomp(&sr->out);\n@@ -600,7 +603,7 @@ create_aead_outbuf(struct nitrox_softreq *sr, struct nitrox_sglist *digest)\n \t\t\t\t\t\t resp.completion);\n \tsr->out.sglist[cnt].virt = &sr->resp.completion;\n \tcnt++;\n-\tRTE_VERIFY(cnt <= MAX_SGBUF_CNT);\n+\tRTE_ASSERT(cnt <= MAX_SGBUF_CNT);\n \tsr->out.map_bufs_cnt = cnt;\n \n \tcreate_sgcomp(&sr->out);\n@@ -774,6 +777,14 @@ nitrox_process_se_req(uint16_t qno, struct rte_crypto_op *op,\n {\n \tint err;\n \n+\tif (unlikely(op->sym->m_src->nb_segs > MAX_SUPPORTED_MBUF_SEGS ||\n+\t\t (op->sym->m_dst &&\n+\t\t op->sym->m_dst->nb_segs > MAX_SUPPORTED_MBUF_SEGS))) {\n+\t\tNITROX_LOG(ERR, \"Mbuf segments not supported. \"\n+\t\t\t \"Max supported %d\\n\", MAX_SUPPORTED_MBUF_SEGS);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n \tsoftreq_init(sr, sr->iova);\n \tsr->ctx = ctx;\n \tsr->op = op;\n", "prefixes": [ "1/2" ] }