Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130481/?format=api
http://patchwork.dpdk.org/api/patches/130481/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1692308537-2646-7-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1692308537-2646-7-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1692308537-2646-7-git-send-email-roretzla@linux.microsoft.com", "date": "2023-08-17T21:42:17", "name": "[v5,6/6] devtools: forbid new direct use of GCC atomic builtins", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1916f0057609f60eed3abb89afb8f12eef456b1f", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1692308537-2646-7-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29268, "url": "http://patchwork.dpdk.org/api/series/29268/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29268", "date": "2023-08-17T21:42:11", "name": "optional rte optional stdatomics API", "version": 5, "mbox": "http://patchwork.dpdk.org/series/29268/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130481/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/130481/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B910A4308E;\n\tThu, 17 Aug 2023 23:43:09 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D550743273;\n\tThu, 17 Aug 2023 23:42:41 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 1E798406A2;\n Thu, 17 Aug 2023 23:42:33 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id C6759211F7C8; Thu, 17 Aug 2023 14:42:31 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com C6759211F7C8", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1692308551;\n bh=CtPx/12FnxZe22wfYHPDbEsgnICJPfc3jYTQ8YoePRU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=bDlk/eCzUVSBBZhdhln7r2+0Zn40xlJine6FzhiD/Yiu0CptPwBiWGdct3FEZ+UXA\n +Tegt7fQq5yxusrid3uyXo4wXodouihYYCRmNdAFQuCUmWw3zHSjioVXj2zUjDQ9f5\n BcfC0/Jju6Noy0Dl0/oDsZgsokIJZxO9l+ivwWAE=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "techboard@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Jerin Jacob <jerinj@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Joyce Kong <joyce.kong@arm.com>, David Christensen <drc@linux.vnet.ibm.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n David Hunt <david.hunt@intel.com>, Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 6/6] devtools: forbid new direct use of GCC atomic builtins", "Date": "Thu, 17 Aug 2023 14:42:17 -0700", "Message-Id": "<1692308537-2646-7-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1692308537-2646-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com>\n <1692308537-2646-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Refrain from using compiler __atomic_xxx builtins DPDK now requires\nthe use of rte_atomic_<op>_explicit macros when operating on DPDK\natomic variables.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nSuggested-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n devtools/checkpatches.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh\nindex 43f5e36..84c096d 100755\n--- a/devtools/checkpatches.sh\n+++ b/devtools/checkpatches.sh\n@@ -107,15 +107,15 @@ check_forbidden_additions() { # <patch>\n \tawk -v FOLDERS=\"lib drivers app examples\" \\\n \t\t-v EXPRESSIONS=\"__atomic_thread_fence\\\\\\(\" \\\n \t\t-v RET_ON_FAIL=1 \\\n-\t\t-v MESSAGE='Using __atomic_thread_fence' \\\n+\t\t-v MESSAGE='Using __atomic_thread_fence built-in, prefer rte_atomic_thread_fence' \\\n \t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n \t\t\"$1\" || res=1\n \n-\t# refrain from using compiler __atomic_{add,and,nand,or,sub,xor}_fetch()\n+\t# refrain from using compiler __atomic_xxx builtins\n \tawk -v FOLDERS=\"lib drivers app examples\" \\\n-\t\t-v EXPRESSIONS=\"__atomic_(add|and|nand|or|sub|xor)_fetch\\\\\\(\" \\\n+\t\t-v EXPRESSIONS=\"__atomic_.*\\\\\\(\" \\\n \t\t-v RET_ON_FAIL=1 \\\n-\t\t-v MESSAGE='Using __atomic_op_fetch, prefer __atomic_fetch_op' \\\n+\t\t-v MESSAGE='Using __atomic_xxx built-ins, prefer rte_atomic_xxx' \\\n \t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n \t\t\"$1\" || res=1\n \n", "prefixes": [ "v5", "6/6" ] }{ "id": 130481, "url": "