Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130487/?format=api
{ "id": 130487, "url": "http://patchwork.dpdk.org/api/patches/130487/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230818025249.33994-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230818025249.33994-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230818025249.33994-4-stephen@networkplumber.org", "date": "2023-08-18T02:52:38", "name": "[03/14] pipeline: remove use of term abort", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e4e11c1cc49533dc894350b36039d0842fc342ae", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230818025249.33994-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 29271, "url": "http://patchwork.dpdk.org/api/series/29271/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29271", "date": "2023-08-18T02:52:35", "name": "remove use of term abort", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29271/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130487/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A67CC41B5F;\n\tFri, 18 Aug 2023 04:53:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BDF734325D;\n\tFri, 18 Aug 2023 04:53:06 +0200 (CEST)", "from mail-pj1-f46.google.com (mail-pj1-f46.google.com\n [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 60A0C43255\n for <dev@dpdk.org>; Fri, 18 Aug 2023 04:53:04 +0200 (CEST)", "by mail-pj1-f46.google.com with SMTP id\n 98e67ed59e1d1-26813478800so348036a91.1\n for <dev@dpdk.org>; Thu, 17 Aug 2023 19:53:04 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n ep13-20020a17090ae64d00b00262e485156esm2221246pjb.57.2023.08.17.19.53.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 17 Aug 2023 19:53:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692327183;\n x=1692931983;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/U0rlONnrIXvx4fM89GhYXCDumMraqATcpJzMBFOmfo=;\n b=vpc7ID7nzREhVJVFXLpz/cLku5ol/NqlCo72vmEQevazRi8KsGLjy/IKDRP/FaaD8+\n +OwxA31AUHDfiAVCeGluNW2+Z+tIyOeTY7kXOTrfy+8RDCageXVb8bxGvvaLd/KKCZvC\n QAADoQ+JmjWYwl+BAw+Ra/47DyJ8xyOA61qt89lH5FTpf07eEUAZJLwbu4Z77WJTRWY0\n S6tt7crPAoXeGiD93shB9sP//diqhfBAKhh/4YBgurRZzTr1Y5SxOBojHFWs3ygA/4Ae\n 9GurTzlt6H3H4dS6PFlBcCh0EBQ1BhmfbEDR2yGoU+GuOIJHW9UUtvl6JHHiiYCbVRLv\n SA5Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1692327183; x=1692931983;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=/U0rlONnrIXvx4fM89GhYXCDumMraqATcpJzMBFOmfo=;\n b=grBp29ZeiSsI1L3fSb0ahLA+arFfqlkE8eeN/Apl8smkhhMhUqvjHxHvjMfGiOVXOY\n trSNI8tUYy254BXD2kCCHg+ReBZBU8WPhBS2fMEZ5qjKF3qheLG/2yyIYvbJIkpH0u4q\n vZOphg8CCehOGf14p+hsyB1ibfFYL+8x3A8XQHETT2TN4wUd92jzRm6wktDBHY4F/ZUN\n DCqobeDJSCbiSiPneaTQiDOr8Wo5TjJGdEVbuH0iuTQF3NOe6CbiArEcC9thRKD5C+QU\n bwei35V5k/cwCRiQVzwUIqIGvh4dPFPmkGK92Rql62F81sTfLadbERbhwkhM3eN7ADqb\n Mtjg==", "X-Gm-Message-State": "AOJu0YwM7HULhysYTfFViPv8089Ej3zgDn864nMwJIcaNihb/xTgpb+4\n ZaSNPPm/+t0oouBOT8RwUctVfTOHTHgSSh74UCbVFw==", "X-Google-Smtp-Source": "\n AGHT+IGt0JaVhqRdPeJ9ULES8az2NXAyuajpEQG5VVTpm4rqTyrkBCDUCp7jjD3Rw5pbzHSYnUuFVw==", "X-Received": "by 2002:a17:90b:1a8e:b0:268:c5c7:f7f1 with SMTP id\n ng14-20020a17090b1a8e00b00268c5c7f7f1mr1155429pjb.29.1692327183026;\n Thu, 17 Aug 2023 19:53:03 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH 03/14] pipeline: remove use of term abort", "Date": "Thu, 17 Aug 2023 19:52:38 -0700", "Message-Id": "<20230818025249.33994-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230818025249.33994-1-stephen@networkplumber.org>", "References": "<20230818025249.33994-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace with cancel.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/pipeline/rte_swx_ctl.c | 29 +++++++++++++++--------------\n lib/pipeline/rte_swx_ctl.h | 8 ++++----\n lib/pipeline/version.map | 2 +-\n 3 files changed, 20 insertions(+), 19 deletions(-)", "diff": "diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c\nindex 857770d297a4..41d07e9b3a19 100644\n--- a/lib/pipeline/rte_swx_ctl.c\n+++ b/lib/pipeline/rte_swx_ctl.c\n@@ -2063,7 +2063,7 @@ table_rollback(struct rte_swx_ctl_pipeline *ctl, uint32_t table_id)\n * failed commit operation to remove ALL the pending work for ALL the tables.\n */\n static void\n-table_abort(struct rte_swx_ctl_pipeline *ctl, uint32_t table_id)\n+table_cancel(struct rte_swx_ctl_pipeline *ctl, uint32_t table_id)\n {\n \tstruct table *table = &ctl->tables[table_id];\n \n@@ -2366,7 +2366,7 @@ selector_rollback(struct rte_swx_ctl_pipeline *ctl, uint32_t selector_id)\n }\n \n static void\n-selector_abort(struct rte_swx_ctl_pipeline *ctl, uint32_t selector_id)\n+selector_cancel(struct rte_swx_ctl_pipeline *ctl, uint32_t selector_id)\n {\n \tstruct selector *s = &ctl->selectors[selector_id];\n \tuint32_t group_id;\n@@ -2545,7 +2545,7 @@ learner_rollfwd_finalize(struct rte_swx_ctl_pipeline *ctl, uint32_t learner_id)\n }\n \n static void\n-learner_abort(struct rte_swx_ctl_pipeline *ctl, uint32_t learner_id)\n+learner_cancel(struct rte_swx_ctl_pipeline *ctl, uint32_t learner_id)\n {\n \tstruct learner *l = &ctl->learners[learner_id];\n \n@@ -2554,7 +2554,8 @@ learner_abort(struct rte_swx_ctl_pipeline *ctl, uint32_t learner_id)\n }\n \n int\n-rte_swx_ctl_pipeline_commit(struct rte_swx_ctl_pipeline *ctl, int abort_on_fail)\n+rte_swx_ctl_pipeline_commit(struct rte_swx_ctl_pipeline *ctl,\n+\t\t\t int cancel_on_fail)\n {\n \tstruct rte_swx_table_state *ts;\n \tint status = 0;\n@@ -2622,25 +2623,25 @@ rte_swx_ctl_pipeline_commit(struct rte_swx_ctl_pipeline *ctl, int abort_on_fail)\n rollback:\n \tfor (i = 0; i < ctl->info.n_tables; i++) {\n \t\ttable_rollback(ctl, i);\n-\t\tif (abort_on_fail)\n-\t\t\ttable_abort(ctl, i);\n+\t\tif (cancel_on_fail)\n+\t\t\ttable_cancel(ctl, i);\n \t}\n \n \tfor (i = 0; i < ctl->info.n_selectors; i++) {\n \t\tselector_rollback(ctl, i);\n-\t\tif (abort_on_fail)\n-\t\t\tselector_abort(ctl, i);\n+\t\tif (cancel_on_fail)\n+\t\t\tselector_cancel(ctl, i);\n \t}\n \n-\tif (abort_on_fail)\n+\tif (cancel_on_fail)\n \t\tfor (i = 0; i < ctl->info.n_learners; i++)\n-\t\t\tlearner_abort(ctl, i);\n+\t\t\tlearner_cancel(ctl, i);\n \n \treturn status;\n }\n \n void\n-rte_swx_ctl_pipeline_abort(struct rte_swx_ctl_pipeline *ctl)\n+rte_swx_ctl_pipeline_cancel(struct rte_swx_ctl_pipeline *ctl)\n {\n \tuint32_t i;\n \n@@ -2648,13 +2649,13 @@ rte_swx_ctl_pipeline_abort(struct rte_swx_ctl_pipeline *ctl)\n \t\treturn;\n \n \tfor (i = 0; i < ctl->info.n_tables; i++)\n-\t\ttable_abort(ctl, i);\n+\t\ttable_cancel(ctl, i);\n \n \tfor (i = 0; i < ctl->info.n_selectors; i++)\n-\t\tselector_abort(ctl, i);\n+\t\tselector_cancel(ctl, i);\n \n \tfor (i = 0; i < ctl->info.n_learners; i++)\n-\t\tlearner_abort(ctl, i);\n+\t\tlearner_cancel(ctl, i);\n }\n \n static int\ndiff --git a/lib/pipeline/rte_swx_ctl.h b/lib/pipeline/rte_swx_ctl.h\nindex 6ef2551ab534..14973b74172b 100644\n--- a/lib/pipeline/rte_swx_ctl.h\n+++ b/lib/pipeline/rte_swx_ctl.h\n@@ -1045,7 +1045,7 @@ rte_swx_ctl_pipeline_learner_default_entry_add(struct rte_swx_ctl_pipeline *ctl,\n *\n * @param[in] ctl\n * Pipeline control handle.\n- * @param[in] abort_on_fail\n+ * @param[in] revert_on_fail\n * When non-zero (false), all the scheduled work is discarded after a failed\n * commit. Otherwise, the scheduled work is still kept pending for the next\n * commit.\n@@ -1056,10 +1056,10 @@ rte_swx_ctl_pipeline_learner_default_entry_add(struct rte_swx_ctl_pipeline *ctl,\n __rte_experimental\n int\n rte_swx_ctl_pipeline_commit(struct rte_swx_ctl_pipeline *ctl,\n-\t\t\t int abort_on_fail);\n+\t\t\t int revert_on_fail);\n \n /**\n- * Pipeline abort\n+ * Pipeline cancel\n *\n * Discard all the scheduled table work.\n *\n@@ -1068,7 +1068,7 @@ rte_swx_ctl_pipeline_commit(struct rte_swx_ctl_pipeline *ctl,\n */\n __rte_experimental\n void\n-rte_swx_ctl_pipeline_abort(struct rte_swx_ctl_pipeline *ctl);\n+rte_swx_ctl_pipeline_cancel(struct rte_swx_ctl_pipeline *ctl);\n \n /**\n * Pipeline table entry read\ndiff --git a/lib/pipeline/version.map b/lib/pipeline/version.map\nindex 6997b69340ef..1ddd598fa079 100644\n--- a/lib/pipeline/version.map\n+++ b/lib/pipeline/version.map\n@@ -62,7 +62,7 @@ EXPERIMENTAL {\n \t# added in 20.11\n \trte_swx_ctl_action_arg_info_get;\n \trte_swx_ctl_action_info_get;\n-\trte_swx_ctl_pipeline_abort;\n+\trte_swx_ctl_pipeline_cancel;\n \trte_swx_ctl_pipeline_commit;\n \trte_swx_ctl_pipeline_create;\n \trte_swx_ctl_pipeline_free;\n", "prefixes": [ "03/14" ] }