Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130488/?format=api
http://patchwork.dpdk.org/api/patches/130488/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230818025249.33994-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230818025249.33994-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230818025249.33994-5-stephen@networkplumber.org", "date": "2023-08-18T02:52:39", "name": "[04/14] net/vmxnet3: replace abort() with rte_panic()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "46023fbae7608afa7ec182e8bc9e2169e936e110", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230818025249.33994-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 29271, "url": "http://patchwork.dpdk.org/api/series/29271/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29271", "date": "2023-08-18T02:52:35", "name": "remove use of term abort", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29271/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130488/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/130488/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 92DB641B5F;\n\tFri, 18 Aug 2023 04:53:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 581DE4326A;\n\tFri, 18 Aug 2023 04:53:08 +0200 (CEST)", "from mail-ot1-f48.google.com (mail-ot1-f48.google.com\n [209.85.210.48]) by mails.dpdk.org (Postfix) with ESMTP id 1695643255\n for <dev@dpdk.org>; Fri, 18 Aug 2023 04:53:05 +0200 (CEST)", "by mail-ot1-f48.google.com with SMTP id\n 46e09a7af769-6bcbb0c40b1so450000a34.3\n for <dev@dpdk.org>; Thu, 17 Aug 2023 19:53:05 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n ep13-20020a17090ae64d00b00262e485156esm2221246pjb.57.2023.08.17.19.53.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 17 Aug 2023 19:53:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692327184;\n x=1692931984;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1fhoi+hcR6PauwynPbCXhE7OxxF0DCkS+TarCv4n564=;\n b=PTnWl4D8hDitRSai6AcgpYY1lcXw5r/w12r6GskrwBGbwMbrmc6mlyCYB+xbTTQPZc\n np9OWrJSpG5Wg8E5PnFRW5wXsdLDJANgfcz1xshlbfrWOtjQB1YqSgRCg1CCEF8ck/Q6\n sIarvOfmLnEJhnZuJdOO+vVG1Nxk5o8XIZcP6pQztHLwfvveflugZTP3cEwfvbVhUFmA\n 02baalpi+Fjd0Ev9SIU0A5cf4qbGV9I+bHqWton/Vk4jXa113zupJENA1mpbCMx41kku\n 6CwPmE9hKK70s56SvvMOcthhkQJkDMb8N3JRv5Ls/LG6P7rvzo5mRfPEnjzTB3H7VAdP\n twjQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1692327184; x=1692931984;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=1fhoi+hcR6PauwynPbCXhE7OxxF0DCkS+TarCv4n564=;\n b=EsSPzitxayGc7PSn4Cq6orJwSZXGGWmVOw/O2/n0BLUj7GEAsx6WytjVk1osFrRVwG\n zzrmTRV1MrbeK/tJaUGuQG7Mn3TdisIvBJ7XCFo++veRlJcXboa1vGm0BDfpbBg0BnFH\n SBElXpGI7MIbzVkB6X3L3VrYyZwqeEza8j+PPSc4qnrUXd98Vdv6jqJmsUKlOC987Ceg\n T9lMikIVxIwOJzexpDLVacX2fpN/cdqmB7NAV0yeDfxLmjIkxswP/9I6PAIwYnlukPlo\n 3mTiqJUU+uLr91MadNY33Hx2Vi0LFjd8pTag8zaQKjouGjj1TiGv5GA+duz3LXUuQgma\n whtQ==", "X-Gm-Message-State": "AOJu0YwoZXMWThuSVv18NWX3gyBpn2tmEtgtmWZZc55+DgRVbVX+yQQu\n EDdx3X/5iAYqduP5UgE2zc1J4QzeyJe//mnfwaBhmg==", "X-Google-Smtp-Source": "\n AGHT+IEO6/YK3it/2xbx25dX/wHt+lWs9ZpkOx27uul1IGD8a9oVBuqH29TRTcxMBoEgU24X9NiWEQ==", "X-Received": "by 2002:a05:6871:707:b0:1be:ffae:29a4 with SMTP id\n f7-20020a056871070700b001beffae29a4mr1514961oap.26.1692327184039;\n Thu, 17 Aug 2023 19:53:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jochen Behrens <jbehrens@vmware.com>", "Subject": "[PATCH 04/14] net/vmxnet3: replace abort() with rte_panic()", "Date": "Thu, 17 Aug 2023 19:52:39 -0700", "Message-Id": "<20230818025249.33994-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230818025249.33994-1-stephen@networkplumber.org>", "References": "<20230818025249.33994-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Do the same thing but be better about wording.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex 380f41f98be2..98bdd6523a4e 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -565,9 +565,8 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t\t\tdgram_cksum);\n \t\t\t\tbreak;\n \t\t\tdefault:\n-\t\t\t\tPMD_TX_LOG(WARNING, \"requested cksum offload not supported %#llx\",\n-\t\t\t\t\t txm->ol_flags & RTE_MBUF_F_TX_L4_MASK);\n-\t\t\t\tabort();\n+\t\t\t\t/* should probably count as tx error and drop instead */\n+\t\t\t\trte_panic(\"unsupported cksum offload: %#llx\\n\", txm->ol_flags);\n \t\t\t}\n \t\t\tdeferred++;\n \t\t} else {\n", "prefixes": [ "04/14" ] }{ "id": 130488, "url": "