Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130629/?format=api
{ "id": 130629, "url": "http://patchwork.dpdk.org/api/patches/130629/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230822063453.97904-1-jhascoet@kalray.eu/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230822063453.97904-1-jhascoet@kalray.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/20230822063453.97904-1-jhascoet@kalray.eu", "date": "2023-08-22T06:34:53", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cb8cef8b84f75c75daf85c8bc8440cd8923f62d1", "submitter": { "id": 3147, "url": "http://patchwork.dpdk.org/api/people/3147/?format=api", "name": "jhascoet", "email": "ju.hascoet@gmail.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230822063453.97904-1-jhascoet@kalray.eu/mbox/", "series": [ { "id": 29306, "url": "http://patchwork.dpdk.org/api/series/29306/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29306", "date": "2023-08-22T06:34:53", "name": "app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29306/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130629/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130629/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD3EE430CE;\n\tTue, 22 Aug 2023 10:12:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5489B4021D;\n\tTue, 22 Aug 2023 10:12:21 +0200 (CEST)", "from mail-ed1-f42.google.com (mail-ed1-f42.google.com\n [209.85.208.42])\n by mails.dpdk.org (Postfix) with ESMTP id 7D82540041;\n Tue, 22 Aug 2023 08:35:32 +0200 (CEST)", "by mail-ed1-f42.google.com with SMTP id\n 4fb4d7f45d1cf-51e28cac164so10631916a12.1;\n Mon, 21 Aug 2023 23:35:32 -0700 (PDT)", "from coolup54.lin.mbt.kalray.eu ([217.181.231.53])\n by smtp.gmail.com with ESMTPSA id\n y6-20020a170906470600b0099364d9f0e9sm7666296ejq.102.2023.08.21.23.35.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Aug 2023 23:35:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1692686132; x=1693290932;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vNUJtctEe9Fb/DWhLDmJ4i4ahTOndz0EhBeq9LlgZk0=;\n b=XXIbNrSm4JTvw+T36wJz/PUnS44j95Pti5yTwseWstpxOqDArvPFkRgRUYAaa50fna\n pH3SWSE0LIydI1her9L5XQsmzI0RZe7smukwrxTdfxeVpx+ZIgD5wHSzrOpb4GR8OXvK\n oyeCgKTVWn+g92p49NiOj8tJLjssw2geCqJYvwWNc/tGRx6Fx8HMlVs4b3LVNJdMY7ZZ\n z8P3vIbwrZGelNMeLKdq87ncYPiqJcXwgIC7Ghg8hUmqypskxGvhQuCorrc82RdNHyfH\n 2Bx2mwebVTaKTLHcO081CPMPEdCU+80n0ijnk5s58itlVVqkqrywimrtoCnz8jxwM8DV\n PoQA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1692686132; x=1693290932;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=vNUJtctEe9Fb/DWhLDmJ4i4ahTOndz0EhBeq9LlgZk0=;\n b=CkKXgAGU7CjIBrRqURlebRQ1dA6lKOImr47JLYYm/eu3kFBz6HLaMYBvIp1/DvvsG+\n rZZTo63euxUhk2oQOvfjkFSelHLvddN+QHthrDKH42bkMTmQfc1Mpel48+GMce9wyJUV\n WOOTcDsYpQ8Dcswv6AW291NBBpzSI4v5da4E7mHhONE51IC9DN4Loj1q/VvkT4yMfIBk\n tiAvSemfRRfPCKxGreNkQuVlIJBmYCLLD4i8TW7HmvMrjHOcrYJgSquaEbeqdyzSuDlX\n QDxOTlxHawsJHsQ2Zbr90NadhclzDzmjFoOZuSZ57xVyzjBfFs8s4zqQ1eQd2mqjySvK\n ntEw==", "X-Gm-Message-State": "AOJu0YxUkNn5V7b4wXVExSmNcnX1piXK4Qc1vgK/atQAEOp8PV+0Cf3a\n bI9MeOk9KvnWIALCiv2uwRgYdEzprkredQ==", "X-Google-Smtp-Source": "\n AGHT+IFZSvsieFJfjpyYneTKtD8sgmWPPIY1wnFhRtBoxhuzVxL7QBXGw8oxN+V9wRdWuItAhRz0rQ==", "X-Received": "by 2002:a17:906:7693:b0:99b:cb59:79b3 with SMTP id\n o19-20020a170906769300b0099bcb5979b3mr9878744ejm.1.1692686131819;\n Mon, 21 Aug 2023 23:35:31 -0700 (PDT)", "From": "jhascoet <ju.hascoet@gmail.com>", "X-Google-Original-From": "jhascoet <jhascoet@kalray.eu>", "To": "olivier.matz@6wind.com", "Cc": "dev@dpdk.org, maintainers@dpdk.org, Julien Hascoet <ju.hascoet@gmail.com>", "Subject": "[PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter", "Date": "Tue, 22 Aug 2023 08:34:53 +0200", "Message-Id": "<20230822063453.97904-1-jhascoet@kalray.eu>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230810160941.3895855-1-jhascoet@kalray.eu>", "References": "<20230810160941.3895855-1-jhascoet@kalray.eu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Tue, 22 Aug 2023 10:12:20 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Julien Hascoet <ju.hascoet@gmail.com>\n\nIn case of ring full state, we retry the enqueue\noperation in order to avoid mbuf loss.\n\nFixes: af75078fece (\"first public release\")\n\nSigned-off-by: Julien Hascoet <ju.hascoet@gmail.com>\n---\n app/test/test_mbuf.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex efac01806b..ad18bf6378 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -1033,12 +1033,21 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,\n \t\ttref += ref;\n \t\tif ((ref & 1) != 0) {\n \t\t\trte_pktmbuf_refcnt_update(m, ref);\n-\t\t\twhile (ref-- != 0)\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\twhile (ref-- != 0) {\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) {\n+\t\t\t\t\t/* let others consume */\n+\t\t\t\t\trte_pause();\n+\t\t\t\t}\n+\t\t\t}\n \t\t} else {\n \t\t\twhile (ref-- != 0) {\n \t\t\t\trte_pktmbuf_refcnt_update(m, 1);\n-\t\t\t\trte_ring_enqueue(refcnt_mbuf_ring, m);\n+\t\t\t\t/* retry in case of failure */\n+\t\t\t\twhile (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) {\n+\t\t\t\t\t/* let others consume */\n+\t\t\t\t\trte_pause();\n+\t\t\t\t}\n \t\t\t}\n \t\t}\n \t\trte_pktmbuf_free(m);\n", "prefixes": [] }