get:
Show a patch.

patch:
Update a patch.

put:
Update a patch.

GET /api/patches/130715/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 130715,
    "url": "http://patchwork.dpdk.org/api/patches/130715/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230824110956.1943559-12-chaoyong.he@corigine.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230824110956.1943559-12-chaoyong.he@corigine.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230824110956.1943559-12-chaoyong.he@corigine.com",
    "date": "2023-08-24T11:09:40",
    "name": "[11/27] net/nfp: rename some parameter and variable",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "14ddc6268d02e9f0f388f00fbd323e3625c6e983",
    "submitter": {
        "id": 2554,
        "url": "http://patchwork.dpdk.org/api/people/2554/?format=api",
        "name": "Chaoyong He",
        "email": "chaoyong.he@corigine.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230824110956.1943559-12-chaoyong.he@corigine.com/mbox/",
    "series": [
        {
            "id": 29333,
            "url": "http://patchwork.dpdk.org/api/series/29333/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29333",
            "date": "2023-08-24T11:09:29",
            "name": "refact the nfpcore module",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/29333/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/130715/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/130715/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB6E7430EF;\n\tThu, 24 Aug 2023 13:12:40 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6A24A43290;\n\tThu, 24 Aug 2023 13:11:12 +0200 (CEST)",
            "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2123.outbound.protection.outlook.com [40.107.93.123])\n by mails.dpdk.org (Postfix) with ESMTP id 3F884432A1\n for <dev@dpdk.org>; Thu, 24 Aug 2023 13:11:10 +0200 (CEST)",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6116.namprd13.prod.outlook.com (2603:10b6:510:2b7::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.20; Thu, 24 Aug\n 2023 11:11:06 +0000",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::51fe:5846:af8b:bace]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::51fe:5846:af8b:bace%3]) with mapi id 15.20.6699.020; Thu, 24 Aug 2023\n 11:11:06 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lBDm7+60M0WT2/meXmO8KcEexprlgVMeG2Joap7UpfWgGFRcWf/MJgfqNFJn2LEGYBd+QyAusn7LMgmmg6qIzTPKkzbnh5Cgpm8Ev863BqJYfewAzjHtgnIPe9oOAaY6dOwJJ+uOgpYX1j8Ae2v/3mzpR290OqVojzfLK7XPMlyD52fEvieeqQcv2mfvwGpIf7wrUq6slWMaAhm/2h9tYAyZ2iTq5ckkQduv6eZXDAxxz/ERU5//n8QKq3kxXlbTp9qoX6N0lckocPwJ1H7xscFDymDXkX8JpfWNmxm4Zi2PPUagU3fUqYZ81W5yikg1aigOL18O3b5D53vLp1JhkA==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=23BgvJvYDhtQlDsGoYHCjeZMMxReVu+8jhIQkdwXURg=;\n b=glSlc1iMuYrB+qOgNg9DyzxQ1r6obKXWgSK9MsDrrJNPQ0blBymfloFJOHlnM5LyJ6dB82FvQvrxrW0jmkV3FYlbr9jUUMynWzSEl2a2i7Dt+8E/h7eZlQUO2Xws49P9fyHJx2u0DuKPi/ygHei67cF1e9P+YGxy9v35mdb8qPuwv6rgoyLK09Vxf4X6N93PryLtZWYGiPsaZ6BngykTu7u1ALW4RUFj/FbOluH8f98zTeOVQ5ZYkqN3GMAJTu8DLwXILLF9zpDtz5exxj6/S00+QZNVmmwhF8U1B+xfdhlrzEa9VIs8b4O2TSZyAbBDzMReHf2CWG97I67e1Z+e9w==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=23BgvJvYDhtQlDsGoYHCjeZMMxReVu+8jhIQkdwXURg=;\n b=Zq0BToEFbH43DmrXjDvJqBGkg8hZTNdqKcRcHegm7fCqdIAHNmDbqNX1mmilQ0513DhpT0mxwFO8GXuun22kherk4q0C1tKXqSkFnnTZHczOlmcJT46fJQPmtaFGZ6k+Q4ABN0qoNMKrrLCWQqRr+Uj/7bdXUXrytFR3CSBUUSQ=",
        "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;",
        "From": "Chaoyong He <chaoyong.he@corigine.com>",
        "To": "dev@dpdk.org",
        "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Chaoyong He <chaoyong.he@corigine.com>",
        "Subject": "[PATCH 11/27] net/nfp: rename some parameter and variable",
        "Date": "Thu, 24 Aug 2023 19:09:40 +0800",
        "Message-Id": "<20230824110956.1943559-12-chaoyong.he@corigine.com>",
        "X-Mailer": "git-send-email 2.39.1",
        "In-Reply-To": "<20230824110956.1943559-1-chaoyong.he@corigine.com>",
        "References": "<20230824110956.1943559-1-chaoyong.he@corigine.com>",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-ClientProxiedBy": "SJ0PR05CA0005.namprd05.prod.outlook.com\n (2603:10b6:a03:33b::10) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)",
        "MIME-Version": "1.0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6116:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "dea3d01c-a380-492b-a592-08dba492cf7e",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n LqjIvZgmhwvTMwGes/e8e6G3PfB8wFifhqgAlaJ3tRN9FcgUFcGddLQwgNzjHTwmRr2SNMDlpk2eAFYQbs5TiVM0yJuCs5U4akRlpsTlFqL6NA3fnV5giPq1NFLMvcVvPGH2oG9lB+UuvuVXINuWI7gHioNJCNWAQEZOTFf9717LMzOmWAmZED9/khgQ4vhLNmgDc7vri3QMEZwSUQK1dhHdzBfOYvycn5cLWC0eqyC+PU0k9mtnYEoepLnOraVxOAoYXF1lNA0BxIZmzhGD3ldrtGn3mNUJb4gUjMFOIc62TZDW/3otQwZzppyb/mjfCYY9wm7yhpEABWYzIs+AbMqLqF9+oYAuaIuDe7tnLmUu1qq25vXb6cGedhqjaf4TpZbxz2BMrSegvHtwdVmgkukk9HzKVP7VD5CIDOGJJoLOqtn4ol05FO07CI6Oj5xyzEmpVNV0+BkCw7DKTJ4B+wRefxNGCl0qpwpghWnKA12WCOIiLbe1h6bvc4+gHsOrY07W8Cp3lUJ7NPZ4X4EgCLa+VOS9T27CjtbniBxHLcNlmcSBA+IJssadhB5e137lZAhlrSkgX64aJaZNGwCV0nTuQ3ZiYtZl1I4iqijPZQmHaQw9Z2S7BzsW1f6Ak8Emj8fQaEYMcKfEPIRj7R9K+gb0Me3w+HJgPfSxIUwj1DytrXu3TI0FO16vougWRS8hD4MkrAyYOO5x6+fOLdLlWw==",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(366004)(39830400003)(346002)(396003)(136003)(376002)(1800799009)(186009)(451199024)(6506007)(26005)(1076003)(2616005)(107886003)(52116002)(12101799020)(6512007)(66574015)(6486002)(83380400001)(38100700002)(8676002)(8936002)(36756003)(316002)(4326008)(41300700001)(30864003)(2906002)(86362001)(5660300002)(44832011)(38350700002)(6666004)(6916009)(478600001)(66476007)(66946007)(66556008);\n DIR:OUT; SFP:1102;",
        "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1",
        "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?GW0IDFQLjDW4Q6jVHf7nz5W6+qdg?=\n\t=?utf-8?q?m4dDlUzgQtN5MxWOuKmud6ayGPqC7IygEiKGQbiRnQkuG7C4xny0oVQ2SDcNTgQXy?=\n\t=?utf-8?q?uO6cBMEgGRWh1AePT2Y9IvM1VVe7o77KxTqSkGTHSU/vjnxPRXsLKs954FQgfnxuk?=\n\t=?utf-8?q?15QPwQDFhNUafJlH9DxI54G7NIbiGjN+7noXeLgebpzR/wAl11JzTZYPfjHxhxY7u?=\n\t=?utf-8?q?luoQrCaQ/F7BDMTTbJcg74d/GfBB+2Xvch1zK9iMiCK4chmRpHfNou3lAuQ9W+PwO?=\n\t=?utf-8?q?TSo8fKAhbuhXx2ZUaCyhv3kf0CJ8qSzpw4t+EWTx+L5UMLv3TZt9HisZow1SFrHxx?=\n\t=?utf-8?q?GqPB3Sqnq2Rh52QcJaQTWh3w1aRDdanbYukGU1IhUeUDxi7qGS28z1VPtKRsLBlJY?=\n\t=?utf-8?q?Ehzg6etoY9H5X0lW1fb7NY0ywwQs6UZYO3XPXd/7sR+8nCPIqx/NJIxep7xX6xfAe?=\n\t=?utf-8?q?as36eSU4QLPkNRS07syRYCKpNYO6J0mJPx/86M36iduwUF41MPBr17QU1svS4983v?=\n\t=?utf-8?q?pQpbaJLSS82TCBb5AetmoBDl/oBI1P3RrSiTFLDGTWu6CGkMKh1b9Mv3Z9iVkA8si?=\n\t=?utf-8?q?ws9QxseGVrqc/Xi0VZWDncPc/OimflrJk3/X2hMoQiuqSD13Homn1OUOHZC+3+Sbk?=\n\t=?utf-8?q?kHtMBaM6aoU9Ze+U+XyvR0w3MxpNexpHzlKnG4vTtHJ/gceQmZ1UUtLqQU/p+ahWi?=\n\t=?utf-8?q?DVZZpLtBB2pa5O10RHz8JlhKgP8/88NGW3CLa8fjF444fKIG4gJe+K3/gFfyBsQ10?=\n\t=?utf-8?q?6P7VqmEPSL1/umykKo09kdPQmo5bhui/Sq95f8cZss46ZAMhh9vQfipFoZRJdLzO4?=\n\t=?utf-8?q?0ALO4cFICiiKtBCZHJSBMWxML+4TBMeGzhR19w8Ux+bLQtUsfeEXzzwxStDiLbDWT?=\n\t=?utf-8?q?1OnNckrRlk4kMNhzJZ1AdiUtF4mWGd2AoruyaNQGGhzkKW6lXaPqE8mYs41If9nld?=\n\t=?utf-8?q?z/+0KrJ6uWJXYuHJ3SD6ML0nkXOIjMwYAiDwtkiQmds31BQwEgGEX4o4qKhVxGENX?=\n\t=?utf-8?q?Zaupl7xf9DI99qcZzORs8+uXvqTW1D8fkaz70l3dElChXMwO7Uxg5BNxPpdQgCYDC?=\n\t=?utf-8?q?ni+aGVsMWdQqg+LALeIiCRETsmra+iiowaYuCWrvbGFSA+ZiecnnQXDavKIV/ZSD8?=\n\t=?utf-8?q?GZCRwjvKz44Tk9/ll+C0ntMST3SMp8BdFR8IPKjSBv2yJCaT7nwtVUka4xs6rC5op?=\n\t=?utf-8?q?qnrmoYPbY1icBlbCzkGTlZb0hFfyRw/NN3WW3niYPp4sZdTz5f9p4CP+OU4Ky2mUq?=\n\t=?utf-8?q?FvPDBJpiv3du/LUSQ9VQVWLNItoEfpdcIuIS+2ShTCmClSdnOQzZVvD5H5Z/KqdGx?=\n\t=?utf-8?q?BTBuGCJUMenxtyS4G1qJQtKqFogLl/ExOqV7bODQ+VRiCvSdtLUV1ecOGVWmaaKBI?=\n\t=?utf-8?q?RsfWdriP+jsaGWf2oZL/eZN59U6tS7Ue/mpbmNjMz7iJkWUvptUUyeElyxtfvW4k2?=\n\t=?utf-8?q?wY47LfamrvcvuF7X1eWSYZJ4GWaem7Aqa/LxmOW32dpvr9azC337VH4uD9ZwJT0sP?=\n\t=?utf-8?q?5lcTrzxmMEC+wI7mTkddazUxfvcoO7lz+w=3D=3D?=",
        "X-OriginatorOrg": "corigine.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n dea3d01c-a380-492b-a592-08dba492cf7e",
        "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "24 Aug 2023 11:11:05.9974 (UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n FdfxG/UDKRj4pnDtU3s/3SODdY4VH9bZ5Emfrt+Ky9rAlYbZrl0AbJqmYwnGBkokDv3wo6YTQYcag+ypnSTMuVD+nT0jGqnWkCBJEEheSAc=",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6116",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Rename some parameter and variable to make the logic easier to\nunderstand.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp_cpp.h          | 10 ++---\n drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 42 ++++++++---------\n drivers/net/nfp/nfpcore/nfp_cppcore.c      | 52 +++++++++++-----------\n drivers/net/nfp/nfpcore/nfp_mip.h          |  2 +-\n drivers/net/nfp/nfpcore/nfp_mutex.c        |  6 +--\n drivers/net/nfp/nfpcore/nfp_nffw.c         | 20 ++++-----\n drivers/net/nfp/nfpcore/nfp_nffw.h         |  4 +-\n drivers/net/nfp/nfpcore/nfp_nsp.h          |  8 ++--\n drivers/net/nfp/nfpcore/nfp_nsp_cmds.c     |  2 +-\n drivers/net/nfp/nfpcore/nfp_nsp_eth.c      | 20 ++++-----\n 10 files changed, 83 insertions(+), 83 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_cpp.h b/drivers/net/nfp/nfpcore/nfp_cpp.h\nindex ceb4d56a08..be7ae1d919 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cpp.h\n+++ b/drivers/net/nfp/nfpcore/nfp_cpp.h\n@@ -247,7 +247,7 @@ void *nfp_cpp_priv(struct nfp_cpp *cpp);\n \n void *nfp_cpp_area_priv(struct nfp_cpp_area *cpp_area);\n \n-uint32_t __nfp_cpp_model_autodetect(struct nfp_cpp *cpp, uint32_t *model);\n+uint32_t nfp_cpp_model_autodetect(struct nfp_cpp *cpp, uint32_t *model);\n \n /* NFP CPP core interface for CPP clients */\n struct nfp_cpp *nfp_cpp_from_device_name(struct rte_pci_device *dev,\n@@ -381,10 +381,10 @@ uint8_t *nfp_cpp_map_area(struct nfp_cpp *cpp, uint32_t cpp_id,\n \t\tuint64_t addr, uint32_t size, struct nfp_cpp_area **area);\n \n int nfp_cpp_area_read(struct nfp_cpp_area *area, uint32_t offset,\n-\t\tvoid *buffer, size_t length);\n+\t\tvoid *address, size_t length);\n \n int nfp_cpp_area_write(struct nfp_cpp_area *area, uint32_t offset,\n-\t\tconst void *buffer, size_t length);\n+\t\tconst void *address, size_t length);\n \n void *nfp_cpp_area_iomem(struct nfp_cpp_area *area);\n \n@@ -393,10 +393,10 @@ struct nfp_cpp *nfp_cpp_area_cpp(struct nfp_cpp_area *cpp_area);\n const char *nfp_cpp_area_name(struct nfp_cpp_area *cpp_area);\n \n int nfp_cpp_read(struct nfp_cpp *cpp, uint32_t cpp_id,\n-\t\tuint64_t address, void *kernel_vaddr, size_t length);\n+\t\tuint64_t address, void *buf, size_t length);\n \n int nfp_cpp_write(struct nfp_cpp *cpp, uint32_t cpp_id,\n-\t\tuint64_t address, const void *kernel_vaddr, size_t length);\n+\t\tuint64_t address, const void *buf, size_t length);\n \n int nfp_cpp_area_readl(struct nfp_cpp_area *area, uint32_t offset,\n \t\tuint32_t *value);\ndiff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\nindex 28a6278497..db15411eb2 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n@@ -118,9 +118,9 @@ static int\n nfp_compute_bar(const struct nfp_bar *bar,\n \t\tuint32_t *bar_config,\n \t\tuint64_t *bar_base,\n-\t\tint tgt,\n-\t\tint act,\n-\t\tint tok,\n+\t\tint target,\n+\t\tint action,\n+\t\tint token,\n \t\tuint64_t offset,\n \t\tsize_t size,\n \t\tint width)\n@@ -129,7 +129,7 @@ nfp_compute_bar(const struct nfp_bar *bar,\n \tuint32_t newcfg;\n \tuint32_t bitsize;\n \n-\tif (tgt >= 16)\n+\tif (target >= 16)\n \t\treturn -EINVAL;\n \n \tswitch (width) {\n@@ -149,15 +149,15 @@ nfp_compute_bar(const struct nfp_bar *bar,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (act != NFP_CPP_ACTION_RW && act != 0) {\n+\tif (action != NFP_CPP_ACTION_RW && action != 0) {\n \t\t/* Fixed CPP mapping with specific action */\n \t\tmask = ~(NFP_PCIE_P2C_FIXED_SIZE(bar) - 1);\n \n \t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_MAPTYPE\n \t\t\t\t(NFP_PCIE_BAR_PCIE2CPP_MAPTYPE_FIXED);\n-\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TARGET_BASEADDRESS(tgt);\n-\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_ACTION_BASEADDRESS(act);\n-\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TOKEN_BASEADDRESS(tok);\n+\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TARGET_BASEADDRESS(target);\n+\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_ACTION_BASEADDRESS(action);\n+\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TOKEN_BASEADDRESS(token);\n \n \t\tif ((offset & mask) != ((offset + size - 1) & mask))\n \t\t\treturn -EINVAL;\n@@ -170,8 +170,8 @@ nfp_compute_bar(const struct nfp_bar *bar,\n \t\t/* Bulk mapping */\n \t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_MAPTYPE\n \t\t\t\t(NFP_PCIE_BAR_PCIE2CPP_MAPTYPE_BULK);\n-\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TARGET_BASEADDRESS(tgt);\n-\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TOKEN_BASEADDRESS(tok);\n+\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TARGET_BASEADDRESS(target);\n+\t\tnewcfg |= NFP_PCIE_BAR_PCIE2CPP_TOKEN_BASEADDRESS(token);\n \n \t\tif ((offset & mask) != ((offset + size - 1) & mask))\n \t\t\treturn -EINVAL;\n@@ -221,9 +221,9 @@ nfp_bar_write(struct nfp_pcie_user *nfp,\n static int\n nfp_reconfigure_bar(struct nfp_pcie_user *nfp,\n \t\tstruct nfp_bar *bar,\n-\t\tint tgt,\n-\t\tint act,\n-\t\tint tok,\n+\t\tint target,\n+\t\tint action,\n+\t\tint token,\n \t\tuint64_t offset,\n \t\tsize_t size,\n \t\tint width)\n@@ -232,8 +232,8 @@ nfp_reconfigure_bar(struct nfp_pcie_user *nfp,\n \tuint32_t newcfg;\n \tuint64_t newbase;\n \n-\terr = nfp_compute_bar(bar, &newcfg, &newbase, tgt, act, tok, offset,\n-\t\t\tsize, width);\n+\terr = nfp_compute_bar(bar, &newcfg, &newbase, target, action,\n+\t\t\ttoken, offset, size, width);\n \tif (err != 0)\n \t\treturn err;\n \n@@ -457,15 +457,15 @@ nfp6000_area_iomem(struct nfp_cpp_area *area)\n \n static int\n nfp6000_area_read(struct nfp_cpp_area *area,\n-\t\tvoid *kernel_vaddr,\n+\t\tvoid *address,\n \t\tuint32_t offset,\n \t\tsize_t length)\n {\n \tsize_t n;\n \tint width;\n \tbool is_64;\n-\tuint32_t *wrptr32 = kernel_vaddr;\n-\tuint64_t *wrptr64 = kernel_vaddr;\n+\tuint32_t *wrptr32 = address;\n+\tuint64_t *wrptr64 = address;\n \tstruct nfp6000_area_priv *priv;\n \tconst volatile uint32_t *rdptr32;\n \tconst volatile uint64_t *rdptr64;\n@@ -526,7 +526,7 @@ nfp6000_area_read(struct nfp_cpp_area *area,\n \n static int\n nfp6000_area_write(struct nfp_cpp_area *area,\n-\t\tconst void *kernel_vaddr,\n+\t\tconst void *address,\n \t\tuint32_t offset,\n \t\tsize_t length)\n {\n@@ -536,8 +536,8 @@ nfp6000_area_write(struct nfp_cpp_area *area,\n \tuint32_t *wrptr32;\n \tuint64_t *wrptr64;\n \tstruct nfp6000_area_priv *priv;\n-\tconst uint32_t *rdptr32 = kernel_vaddr;\n-\tconst uint64_t *rdptr64 = kernel_vaddr;\n+\tconst uint32_t *rdptr32 = address;\n+\tconst uint64_t *rdptr64 = address;\n \n \tpriv = nfp_cpp_area_priv(area);\n \twrptr64 = (uint64_t *)(priv->iomem + offset);\ndiff --git a/drivers/net/nfp/nfpcore/nfp_cppcore.c b/drivers/net/nfp/nfpcore/nfp_cppcore.c\nindex fa199e80d3..d8e57b9075 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cppcore.c\n+++ b/drivers/net/nfp/nfpcore/nfp_cppcore.c\n@@ -90,7 +90,7 @@ nfp_cpp_model(struct nfp_cpp *cpp)\n \tif (cpp == NULL)\n \t\treturn NFP_CPP_MODEL_INVALID;\n \n-\terr = __nfp_cpp_model_autodetect(cpp, &model);\n+\terr = nfp_cpp_model_autodetect(cpp, &model);\n \n \tif (err < 0)\n \t\treturn err;\n@@ -484,7 +484,7 @@ nfp_cpp_area_iomem(struct nfp_cpp_area *area)\n  *   CPP area handle\n  * @param offset\n  *   Offset into CPP area\n- * @param kernel_vaddr\n+ * @param address\n  *   Address to put data into\n  * @param length\n  *   Number of bytes to read\n@@ -498,13 +498,13 @@ nfp_cpp_area_iomem(struct nfp_cpp_area *area)\n int\n nfp_cpp_area_read(struct nfp_cpp_area *area,\n \t\tuint32_t offset,\n-\t\tvoid *kernel_vaddr,\n+\t\tvoid *address,\n \t\tsize_t length)\n {\n \tif ((offset + length) > area->size)\n \t\treturn -EFAULT;\n \n-\treturn area->cpp->op->area_read(area, kernel_vaddr, offset, length);\n+\treturn area->cpp->op->area_read(area, address, offset, length);\n }\n \n /**\n@@ -514,7 +514,7 @@ nfp_cpp_area_read(struct nfp_cpp_area *area,\n  *   CPP area handle\n  * @param offset\n  *   Offset into CPP area\n- * @param kernel_vaddr\n+ * @param address\n  *   Address to put data into\n  * @param length\n  *   Number of bytes to read\n@@ -528,13 +528,13 @@ nfp_cpp_area_read(struct nfp_cpp_area *area,\n int\n nfp_cpp_area_write(struct nfp_cpp_area *area,\n \t\tuint32_t offset,\n-\t\tconst void *kernel_vaddr,\n+\t\tconst void *address,\n \t\tsize_t length)\n {\n \tif ((offset + length) > area->size)\n \t\treturn -EFAULT;\n \n-\treturn area->cpp->op->area_write(area, kernel_vaddr, offset, length);\n+\treturn area->cpp->op->area_write(area, address, offset, length);\n }\n \n /*\n@@ -880,14 +880,14 @@ nfp_cpp_alloc(struct rte_pci_device *dev,\n \t}\n \n \tif (NFP_CPP_MODEL_IS_6000(nfp_cpp_model(cpp))) {\n-\t\tuint32_t xpbaddr;\n-\t\tsize_t tgt;\n+\t\tuint32_t xpb_addr;\n+\t\tsize_t target;\n \n-\t\tfor (tgt = 0; tgt < RTE_DIM(cpp->imb_cat_table); tgt++) {\n+\t\tfor (target = 0; target < RTE_DIM(cpp->imb_cat_table); target++) {\n \t\t\t/* Hardcoded XPB IMB Base, island 0 */\n-\t\t\txpbaddr = 0x000a0000 + (tgt * 4);\n-\t\t\terr = nfp_xpb_readl(cpp, xpbaddr,\n-\t\t\t\t\t(uint32_t *)&cpp->imb_cat_table[tgt]);\n+\t\t\txpb_addr = 0x000a0000 + (target * 4);\n+\t\t\terr = nfp_xpb_readl(cpp, xpb_addr,\n+\t\t\t\t\t(uint32_t *)&cpp->imb_cat_table[target]);\n \t\t\tif (err < 0) {\n \t\t\t\trte_free(cpp);\n \t\t\t\treturn NULL;\n@@ -950,9 +950,9 @@ nfp_cpp_from_device_name(struct rte_pci_device *dev,\n  *   CPP handle\n  * @param destination\n  *   CPP id\n- * @param address\n+ * @param offset\n  *   Offset into CPP target\n- * @param kernel_vaddr\n+ * @param address\n  *   Buffer for result\n  * @param length\n  *   Number of bytes to read\n@@ -963,20 +963,20 @@ nfp_cpp_from_device_name(struct rte_pci_device *dev,\n int\n nfp_cpp_read(struct nfp_cpp *cpp,\n \t\tuint32_t destination,\n-\t\tuint64_t address,\n-\t\tvoid *kernel_vaddr,\n+\t\tuint64_t offset,\n+\t\tvoid *address,\n \t\tsize_t length)\n {\n \tint err;\n \tstruct nfp_cpp_area *area;\n \n-\tarea = nfp_cpp_area_alloc_acquire(cpp, destination, address, length);\n+\tarea = nfp_cpp_area_alloc_acquire(cpp, destination, offset, length);\n \tif (area == NULL) {\n \t\tPMD_DRV_LOG(ERR, \"Area allocation/acquire failed for read\");\n \t\treturn -1;\n \t}\n \n-\terr = nfp_cpp_area_read(area, 0, kernel_vaddr, length);\n+\terr = nfp_cpp_area_read(area, 0, address, length);\n \n \tnfp_cpp_area_release_free(area);\n \treturn err;\n@@ -989,9 +989,9 @@ nfp_cpp_read(struct nfp_cpp *cpp,\n  *   CPP handle\n  * @param destination\n  *   CPP id\n- * @param address\n+ * @param offset\n  *   Offset into CPP target\n- * @param kernel_vaddr\n+ * @param address\n  *   Buffer to read from\n  * @param length\n  *   Number of bytes to write\n@@ -1002,20 +1002,20 @@ nfp_cpp_read(struct nfp_cpp *cpp,\n int\n nfp_cpp_write(struct nfp_cpp *cpp,\n \t\tuint32_t destination,\n-\t\tuint64_t address,\n-\t\tconst void *kernel_vaddr,\n+\t\tuint64_t offset,\n+\t\tconst void *address,\n \t\tsize_t length)\n {\n \tint err;\n \tstruct nfp_cpp_area *area;\n \n-\tarea = nfp_cpp_area_alloc_acquire(cpp, destination, address, length);\n+\tarea = nfp_cpp_area_alloc_acquire(cpp, destination, offset, length);\n \tif (area == NULL) {\n \t\tPMD_DRV_LOG(ERR, \"Area allocation/acquire failed for write\");\n \t\treturn -1;\n \t}\n \n-\terr = nfp_cpp_area_write(area, 0, kernel_vaddr, length);\n+\terr = nfp_cpp_area_write(area, 0, address, length);\n \n \tnfp_cpp_area_release_free(area);\n \treturn err;\n@@ -1026,7 +1026,7 @@ nfp_cpp_write(struct nfp_cpp *cpp,\n  * as those are model-specific\n  */\n uint32_t\n-__nfp_cpp_model_autodetect(struct nfp_cpp *cpp,\n+nfp_cpp_model_autodetect(struct nfp_cpp *cpp,\n \t\tuint32_t *model)\n {\n \tint err;\ndiff --git a/drivers/net/nfp/nfpcore/nfp_mip.h b/drivers/net/nfp/nfpcore/nfp_mip.h\nindex 371c635b97..7fa09ee575 100644\n--- a/drivers/net/nfp/nfpcore/nfp_mip.h\n+++ b/drivers/net/nfp/nfpcore/nfp_mip.h\n@@ -17,6 +17,6 @@ const char *nfp_mip_name(const struct nfp_mip *mip);\n void nfp_mip_symtab(const struct nfp_mip *mip, uint32_t *addr, uint32_t *size);\n void nfp_mip_strtab(const struct nfp_mip *mip, uint32_t *addr, uint32_t *size);\n int nfp_nffw_info_mip_first(struct nfp_nffw_info *state, uint32_t *cpp_id,\n-\t\tuint64_t *off);\n+\t\tuint64_t *offset);\n \n #endif /* __NFP_MIP_H__ */\ndiff --git a/drivers/net/nfp/nfpcore/nfp_mutex.c b/drivers/net/nfp/nfpcore/nfp_mutex.c\nindex 61c491e07e..85c33502ca 100644\n--- a/drivers/net/nfp/nfpcore/nfp_mutex.c\n+++ b/drivers/net/nfp/nfpcore/nfp_mutex.c\n@@ -35,7 +35,7 @@ struct nfp_cpp_mutex {\n };\n \n static int\n-_nfp_cpp_mutex_validate(uint32_t model,\n+nfp_cpp_mutex_validate(uint32_t model,\n \t\tint *target,\n \t\tuint64_t address)\n {\n@@ -87,7 +87,7 @@ nfp_cpp_mutex_init(struct nfp_cpp *cpp,\n \tuint32_t model = nfp_cpp_model(cpp);\n \tuint32_t muw = NFP_CPP_ID(target, 4, 0);    /* atomic_write */\n \n-\terr = _nfp_cpp_mutex_validate(model, &target, address);\n+\terr = nfp_cpp_mutex_validate(model, &target, address);\n \tif (err < 0)\n \t\treturn err;\n \n@@ -152,7 +152,7 @@ nfp_cpp_mutex_alloc(struct nfp_cpp *cpp,\n \t\treturn NULL;\n \t}\n \n-\terr = _nfp_cpp_mutex_validate(model, &target, address);\n+\terr = nfp_cpp_mutex_validate(model, &target, address);\n \tif (err < 0)\n \t\treturn NULL;\n \ndiff --git a/drivers/net/nfp/nfpcore/nfp_nffw.c b/drivers/net/nfp/nfpcore/nfp_nffw.c\nindex b14a9bd852..b27a9fbaa7 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nffw.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nffw.c\n@@ -31,11 +31,11 @@ nffw_res_flg_init_get(const struct nfp_nffw_info_data *res)\n \treturn (res->flags[0] >> 0) & 1;\n }\n \n-/* loaded = loaded__mu_da__mip_off_hi<31:31> */\n+/* loaded = loaded_mu_da_mip_off_hi<31:31> */\n static uint32_t\n nffw_fwinfo_loaded_get(const struct nffw_fwinfo *fi)\n {\n-\treturn (fi->loaded__mu_da__mip_off_hi >> 31) & 1;\n+\treturn (fi->loaded_mu_da_mip_off_hi >> 31) & 1;\n }\n \n /* mip_cppid = mip_cppid */\n@@ -45,18 +45,18 @@ nffw_fwinfo_mip_cppid_get(const struct nffw_fwinfo *fi)\n \treturn fi->mip_cppid;\n }\n \n-/* loaded = loaded__mu_da__mip_off_hi<8:8> */\n+/* loaded = loaded_mu_da_mip_off_hi<8:8> */\n static uint32_t\n nffw_fwinfo_mip_mu_da_get(const struct nffw_fwinfo *fi)\n {\n-\treturn (fi->loaded__mu_da__mip_off_hi >> 8) & 1;\n+\treturn (fi->loaded_mu_da_mip_off_hi >> 8) & 1;\n }\n \n-/* mip_offset = (loaded__mu_da__mip_off_hi<7:0> << 32) | mip_offset_lo */\n+/* mip_offset = (loaded_mu_da_mip_off_hi<7:0> << 32) | mip_offset_lo */\n static uint64_t\n nffw_fwinfo_mip_offset_get(const struct nffw_fwinfo *fi)\n {\n-\tuint64_t mip_off_hi = fi->loaded__mu_da__mip_off_hi;\n+\tuint64_t mip_off_hi = fi->loaded_mu_da_mip_off_hi;\n \n \treturn (mip_off_hi & 0xFF) << 32 | fi->mip_offset_lo;\n }\n@@ -224,7 +224,7 @@ nfp_nffw_info_fwid_first(struct nfp_nffw_info *state)\n int\n nfp_nffw_info_mip_first(struct nfp_nffw_info *state,\n \t\tuint32_t *cpp_id,\n-\t\tuint64_t *off)\n+\t\tuint64_t *offset)\n {\n \tstruct nffw_fwinfo *fwinfo;\n \n@@ -233,7 +233,7 @@ nfp_nffw_info_mip_first(struct nfp_nffw_info *state,\n \t\treturn -EINVAL;\n \n \t*cpp_id = nffw_fwinfo_mip_cppid_get(fwinfo);\n-\t*off = nffw_fwinfo_mip_offset_get(fwinfo);\n+\t*offset = nffw_fwinfo_mip_offset_get(fwinfo);\n \n \tif (nffw_fwinfo_mip_mu_da_get(fwinfo) != 0) {\n \t\tint locality_off;\n@@ -245,8 +245,8 @@ nfp_nffw_info_mip_first(struct nfp_nffw_info *state,\n \t\tif (locality_off < 0)\n \t\t\treturn locality_off;\n \n-\t\t*off &= ~(NFP_MU_ADDR_ACCESS_TYPE_MASK << locality_off);\n-\t\t*off |= NFP_MU_ADDR_ACCESS_TYPE_DIRECT << locality_off;\n+\t\t*offset &= ~(NFP_MU_ADDR_ACCESS_TYPE_MASK << locality_off);\n+\t\t*offset |= NFP_MU_ADDR_ACCESS_TYPE_DIRECT << locality_off;\n \t}\n \n \treturn 0;\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nffw.h b/drivers/net/nfp/nfpcore/nfp_nffw.h\nindex f84be463c4..52e25c090a 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nffw.h\n+++ b/drivers/net/nfp/nfpcore/nfp_nffw.h\n@@ -38,11 +38,11 @@\n \n /* nfp.nffw meinfo */\n struct nffw_meinfo {\n-\tuint32_t ctxmask__fwid__meid;\n+\tuint32_t ctxmask_fwid_meid;\n };\n \n struct nffw_fwinfo {\n-\tuint32_t loaded__mu_da__mip_off_hi;\n+\tuint32_t loaded_mu_da_mip_off_hi;\n \tuint32_t mip_cppid; /* 0 means no MIP */\n \tuint32_t mip_offset_lo;\n };\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nsp.h b/drivers/net/nfp/nfpcore/nfp_nsp.h\nindex 7bf584dcd0..705574b900 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nsp.h\n+++ b/drivers/net/nfp/nfpcore/nfp_nsp.h\n@@ -231,9 +231,9 @@ struct nfp_nsp *nfp_eth_config_start(struct nfp_cpp *cpp, uint32_t idx);\n int nfp_eth_config_commit_end(struct nfp_nsp *nsp);\n void nfp_eth_config_cleanup_end(struct nfp_nsp *nsp);\n \n-int __nfp_eth_set_aneg(struct nfp_nsp *nsp, enum nfp_eth_aneg mode);\n-int __nfp_eth_set_speed(struct nfp_nsp *nsp, uint32_t speed);\n-int __nfp_eth_set_split(struct nfp_nsp *nsp, uint32_t lanes);\n+int nfp_eth_set_aneg(struct nfp_nsp *nsp, enum nfp_eth_aneg mode);\n+int nfp_eth_set_speed(struct nfp_nsp *nsp, uint32_t speed);\n+int nfp_eth_set_split(struct nfp_nsp *nsp, uint32_t lanes);\n \n /* NSP static information */\n struct nfp_nsp_identify {\n@@ -248,7 +248,7 @@ struct nfp_nsp_identify {\n \tuint64_t sensor_mask;  /**< Mask of present sensors available on NIC */\n };\n \n-struct nfp_nsp_identify *__nfp_nsp_identify(struct nfp_nsp *nsp);\n+struct nfp_nsp_identify *nfp_nsp_identify(struct nfp_nsp *nsp);\n \n enum nfp_nsp_sensor_id {\n \tNFP_SENSOR_CHIP_TEMPERATURE,\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nsp_cmds.c b/drivers/net/nfp/nfpcore/nfp_nsp_cmds.c\nindex 08f12f862c..429f639fa2 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nsp_cmds.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nsp_cmds.c\n@@ -24,7 +24,7 @@ struct nsp_identify {\n };\n \n struct nfp_nsp_identify *\n-__nfp_nsp_identify(struct nfp_nsp *nsp)\n+nfp_nsp_identify(struct nfp_nsp *nsp)\n {\n \tint ret;\n \tstruct nsp_identify *ni;\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nsp_eth.c b/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\nindex 837c9c6bbd..eea5cde426 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\n@@ -241,7 +241,7 @@ nfp_eth_calc_port_type(struct nfp_eth_table_port *entry)\n }\n \n static struct nfp_eth_table *\n-__nfp_eth_read_ports(struct nfp_nsp *nsp)\n+nfp_eth_read_ports_real(struct nfp_nsp *nsp)\n {\n \tint ret;\n \tuint32_t i;\n@@ -332,7 +332,7 @@ nfp_eth_read_ports(struct nfp_cpp *cpp)\n \tif (nsp == NULL)\n \t\treturn NULL;\n \n-\tret = __nfp_eth_read_ports(nsp);\n+\tret = nfp_eth_read_ports_real(nsp);\n \tnfp_nsp_close(nsp);\n \n \treturn ret;\n@@ -480,7 +480,7 @@ nfp_eth_set_mod_enable(struct nfp_cpp *cpp,\n int\n nfp_eth_set_configured(struct nfp_cpp *cpp,\n \t\tuint32_t idx,\n-\t\tint configed)\n+\t\tint configured)\n {\n \tuint64_t reg;\n \tstruct nfp_nsp *nsp;\n@@ -503,10 +503,10 @@ nfp_eth_set_configured(struct nfp_cpp *cpp,\n \n \t/* Check if we are already in requested state */\n \treg = rte_le_to_cpu_64(entries[idx].state);\n-\tif (configed != (int)FIELD_GET(NSP_ETH_STATE_CONFIGURED, reg)) {\n+\tif (configured != (int)FIELD_GET(NSP_ETH_STATE_CONFIGURED, reg)) {\n \t\treg = rte_le_to_cpu_64(entries[idx].control);\n \t\treg &= ~NSP_ETH_CTRL_CONFIGURED;\n-\t\treg |= FIELD_PREP(NSP_ETH_CTRL_CONFIGURED, configed);\n+\t\treg |= FIELD_PREP(NSP_ETH_CTRL_CONFIGURED, configured);\n \t\tentries[idx].control = rte_cpu_to_le_64(reg);\n \n \t\tnfp_nsp_config_set_modified(nsp, 1);\n@@ -572,7 +572,7 @@ nfp_eth_set_bit_config(struct nfp_nsp *nsp,\n  *   0 or -ERRNO\n  */\n int\n-__nfp_eth_set_aneg(struct nfp_nsp *nsp,\n+nfp_eth_set_aneg(struct nfp_nsp *nsp,\n \t\tenum nfp_eth_aneg mode)\n {\n \treturn NFP_ETH_SET_BIT_CONFIG(nsp, NSP_ETH_RAW_STATE,\n@@ -592,7 +592,7 @@ __nfp_eth_set_aneg(struct nfp_nsp *nsp,\n  *   0 or -ERRNO\n  */\n static int\n-__nfp_eth_set_fec(struct nfp_nsp *nsp,\n+nfp_eth_set_fec_real(struct nfp_nsp *nsp,\n \t\tenum nfp_eth_fec mode)\n {\n \treturn NFP_ETH_SET_BIT_CONFIG(nsp, NSP_ETH_RAW_STATE,\n@@ -626,7 +626,7 @@ nfp_eth_set_fec(struct nfp_cpp *cpp,\n \tif (nsp == NULL)\n \t\treturn -EIO;\n \n-\terr = __nfp_eth_set_fec(nsp, mode);\n+\terr = nfp_eth_set_fec_real(nsp, mode);\n \tif (err != 0) {\n \t\tnfp_eth_config_cleanup_end(nsp);\n \t\treturn err;\n@@ -650,7 +650,7 @@ nfp_eth_set_fec(struct nfp_cpp *cpp,\n  *   0 or -ERRNO\n  */\n int\n-__nfp_eth_set_speed(struct nfp_nsp *nsp,\n+nfp_eth_set_speed(struct nfp_nsp *nsp,\n \t\tuint32_t speed)\n {\n \tenum nfp_eth_rate rate;\n@@ -678,7 +678,7 @@ __nfp_eth_set_speed(struct nfp_nsp *nsp,\n  *   0 or -ERRNO\n  */\n int\n-__nfp_eth_set_split(struct nfp_nsp *nsp,\n+nfp_eth_set_split(struct nfp_nsp *nsp,\n \t\tuint32_t lanes)\n {\n \treturn NFP_ETH_SET_BIT_CONFIG(nsp, NSP_ETH_RAW_PORT,\n",
    "prefixes": [
        "11/27"
    ]
}