Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130913/?format=api
{ "id": 130913, "url": "http://patchwork.dpdk.org/api/patches/130913/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230830155919.592390-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230830155919.592390-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230830155919.592390-2-bruce.richardson@intel.com", "date": "2023-08-30T15:59:16", "name": "[1/4] net/i40e: fix buffer leak on Rx reconfiguration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9f5cd200c6b83264f9edeb134193e45f05909bfd", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230830155919.592390-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29377, "url": "http://patchwork.dpdk.org/api/series/29377/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29377", "date": "2023-08-30T15:59:15", "name": "Fix i40e/iavf queue reconfig and restarting", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29377/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/130913/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/130913/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6829841FD1;\n\tWed, 30 Aug 2023 18:06:27 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B9BEE427DE;\n\tWed, 30 Aug 2023 18:00:14 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id C27DB402BB;\n Wed, 30 Aug 2023 17:59:44 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Aug 2023 08:59:44 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.14])\n by orsmga002.jf.intel.com with ESMTP; 30 Aug 2023 08:59:42 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1693411185; x=1724947185;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=82J2yt48GRNjIYEQ/H5nj7iVeoV8VOdSOMgaQN8UVbs=;\n b=XqIRCA6EOc0k2fR1UqE0WhpORRlOUH/w71dBL0u0BFwEYCb6FW3aI/b8\n zuhrLlYKmWyU5KUvucmhd0+8ZmPX0p9Pz/LiBPd1Ft0FjOQ8Ng4rQbLve\n akz5VDG1/b8bwmUZExEK+L5DRwDEzbBlPfgHWRk399lwkfvA8LJXG+0QS\n 4Diru36p8UasD/7noO7HUG22F+Y+nzDV/ZSyv++ZlRSwyQU0uPKSuPCfk\n 8xeVg4swEVarVwkqDREXx7+QtjX21Q9kWIko1VUTE96eA46yegAbIQxWO\n vBAYxqztSLKNpOCNfXyobzI2M8OkcByeG/QcE1yttUT/+ClOZrhDkq86X w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10818\"; a=\"360674181\"", "E=Sophos;i=\"6.02,214,1688454000\"; d=\"scan'208\";a=\"360674181\"", "E=McAfee;i=\"6600,9927,10818\"; a=\"739142701\"", "E=Sophos;i=\"6.02,214,1688454000\"; d=\"scan'208\";a=\"739142701\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Yuying Zhang <Yuying.Zhang@intel.com>,\n Beilei Xing <beilei.xing@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>, qi.z.zhang@intel.com,\n stable@dpdk.org", "Subject": "[PATCH 1/4] net/i40e: fix buffer leak on Rx reconfiguration", "Date": "Wed, 30 Aug 2023 16:59:16 +0100", "Message-Id": "<20230830155919.592390-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230830155919.592390-1-bruce.richardson@intel.com>", "References": "<20230830155919.592390-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When reconfiguring a single queue on a device, the mbuf initializer\nvalue was not getting set, and remained at zero. This lead to mbuf leaks\nas the refcount was incorrect (0), so on free it wrapped around to\nUINT16_MAX. When setting up the mbuf initializer, also ensure that the\nqueue is explicitly marked as using a vector function by setting the\n\"rx_using_sse\" flag.\n\nFixes: a3c83a2527e1 (\"net/i40e: enable runtime queue setup\")\nCc: qi.z.zhang@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 6 ++++++\n drivers/net/i40e/i40e_rxtx_vec_common.h | 1 +\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex b4f65b58fa..d96bbbb677 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -1918,6 +1918,12 @@ i40e_dev_rx_queue_setup_runtime(struct rte_eth_dev *dev,\n \t\tif (use_def_burst_func)\n \t\t\tad->rx_bulk_alloc_allowed = false;\n \t\ti40e_set_rx_function(dev);\n+\n+\t\tif (ad->rx_vec_allowed && i40e_rxq_vec_setup(rxq)) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed vector rx setup.\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n \t\treturn 0;\n \t} else if (ad->rx_vec_allowed && !rte_is_power_of_2(rxq->nb_rx_desc)) {\n \t\tPMD_DRV_LOG(ERR, \"Vector mode is allowed, but descriptor\"\ndiff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h\nindex fe1a6ec75e..8b745630e4 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_common.h\n+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h\n@@ -201,6 +201,7 @@ i40e_rxq_vec_setup_default(struct i40e_rx_queue *rxq)\n \trte_compiler_barrier();\n \tp = (uintptr_t)&mb_def.rearm_data;\n \trxq->mbuf_initializer = *(uint64_t *)p;\n+\trxq->rx_using_sse = 1;\n \treturn 0;\n }\n \n", "prefixes": [ "1/4" ] }