Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131096/?format=api
{ "id": 131096, "url": "http://patchwork.dpdk.org/api/patches/131096/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230901142332.588856-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230901142332.588856-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230901142332.588856-1-bruce.richardson@intel.com", "date": "2023-09-01T14:23:31", "name": "[1/2] build: fail if explicitly requested lib is unbuildable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7753eae7345afaf6cbf8bcfb1b5be3daca773460", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230901142332.588856-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29406, "url": "http://patchwork.dpdk.org/api/series/29406/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29406", "date": "2023-09-01T14:23:31", "name": "[1/2] build: fail if explicitly requested lib is unbuildable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29406/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131096/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/131096/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB44A42278;\n\tFri, 1 Sep 2023 16:23:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A685D4029B;\n\tFri, 1 Sep 2023 16:23:43 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 2F1FE40285\n for <dev@dpdk.org>; Fri, 1 Sep 2023 16:23:42 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Sep 2023 07:23:40 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.152])\n by fmsmga001.fm.intel.com with ESMTP; 01 Sep 2023 07:23:42 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1693578222; x=1725114222;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=QgjfzsTMOcSiOckYs0liWgiC8HNJ7shz+FZG37/RncY=;\n b=KPHAyJz0rlaWao8x7eYYkEtsYcJKuXsbAHf7azU/20WXJFKOOPFbULFK\n wcSsnzv46krHjy17kwLayV0jBsOPrqpPEbTT5upXC3mdx+EzImtBErqNR\n RdyjbK0xG77MgOeDp9dtaeQ8qSi8jlW7grmZzOACabK5s/xwW098XJP1F\n KCFS6hnDAkr/jnyaGPaQm39RG2ptSYSXu+1jvm471hBqmloqDOW78v78m\n 43uQVXmaAHg2M0kw77yYV3hjzrqOp3UqiTGHFoLfRHakI4F1W7e/9Sbni\n oTXFadTHK9xubn6MrLPoKFWxQCtfcw6zTGBouctaap1Vodu6DkkTgvnsq g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10819\"; a=\"442624643\"", "E=Sophos;i=\"6.02,219,1688454000\"; d=\"scan'208\";a=\"442624643\"", "E=McAfee;i=\"6600,9927,10819\"; a=\"883199261\"", "E=Sophos;i=\"6.02,219,1688454000\"; d=\"scan'208\";a=\"883199261\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 1/2] build: fail if explicitly requested lib is unbuildable", "Date": "Fri, 1 Sep 2023 15:23:31 +0100", "Message-Id": "<20230901142332.588856-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the user passes a list of desired libraries to build via the\n\"enable_libs\" option, the expectation is that those libraries should be\npart of the build. However, if those libs have either external or\ninternal dependencies, they still may be silently disabled, for example:\nrunning \"meson setup -Denable_libs=security build\" will successfully\nrun, but the security lib will not be configured as \"cryptodev\" is\nmissing.\n\nWe can fix this by setting a flag to indicate when the libraries are\nspecified via an enable_libs flag. If so, then we error out when a\nlibrary is unbuildable, giving a suitable error message. For the above\nexample case, the \"meson setup\" run fails with:\n\nMessage: Disabling security [lib/security]: missing internal dependency \"cryptodev\"\n\nlib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicitly requested lib \"security\".\n\tPlease add missing dependency \"cryptodev\" to \"enable_libs\" option\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/meson.build | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/lib/meson.build b/lib/meson.build\nindex 099b0ed18a..cf4aa63630 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -131,7 +131,9 @@ endforeach\n disable_libs = run_command(list_dir_globs, get_option('disable_libs'), check: true).stdout().split()\n \n enable_libs = run_command(list_dir_globs, get_option('enable_libs'), check: true).stdout().split()\n+require_libs = true\n if enable_libs.length() == 0\n+ require_libs = false\n enable_libs += optional_libs\n endif\n enable_libs += always_enable\n@@ -189,6 +191,10 @@ foreach l:libraries\n \n if build\n subdir(l)\n+ if not build and require_libs\n+ error('Cannot build explicitly requested lib \"@0@\".\\n'.format(name)\n+ +'\\tReason: ' + reason)\n+ endif\n endif\n if name != l\n warning('Library name, \"@0@\", and directory name, \"@1@\", do not match'.format(name, l))\n@@ -208,6 +214,10 @@ foreach l:libraries\n endif\n message('Disabling @1@ [@2@]: missing internal dependency \"@0@\"'\n .format(d, name, 'lib/' + l))\n+ if require_libs\n+ error('Cannot build explicitly requested lib \"@0@\".\\n'.format(name)\n+ + '\\tPlease add missing dependency \"@0@\" to \"enable_libs\" option'.format(d))\n+ endif\n else\n shared_deps += [get_variable('shared_rte_' + d)]\n static_deps += [get_variable('static_rte_' + d)]\n", "prefixes": [ "1/2" ] }