Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131097/?format=api
{ "id": 131097, "url": "http://patchwork.dpdk.org/api/patches/131097/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230901142332.588856-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230901142332.588856-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230901142332.588856-2-bruce.richardson@intel.com", "date": "2023-09-01T14:23:32", "name": "[2/2] build: fail if explicitly requested driver is unbuildable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "015624c6e385c551b9931af25129cbb1355322e3", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230901142332.588856-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29406, "url": "http://patchwork.dpdk.org/api/series/29406/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29406", "date": "2023-09-01T14:23:31", "name": "[1/2] build: fail if explicitly requested lib is unbuildable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29406/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131097/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131097/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4DE042278;\n\tFri, 1 Sep 2023 16:23:54 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CD3E04029D;\n\tFri, 1 Sep 2023 16:23:54 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 4E7D340285\n for <dev@dpdk.org>; Fri, 1 Sep 2023 16:23:53 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Sep 2023 07:23:50 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.152])\n by fmsmga001.fm.intel.com with ESMTP; 01 Sep 2023 07:23:47 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1693578233; x=1725114233;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=AA0hbd8vdftDlLNsZIa4/Qo6yZ4ig03/7FvAjm48A1s=;\n b=CJ5AIm7wYvPCmzKmtU/Qix/vlOAndUBtXwCQpYHm4kYfaNN1l95/9VAU\n jlC7j0Mt7Prbu3NGeuZqMbNGogYrpNN1SzfJfSE13lLo7iHkXBmTpJSgA\n lCJg16DXc3rYjCX1I1wUwRXsU3eOJFC5kB0GRsyqJ16fv7Y1qLlj2xhf5\n +HuwH3oRKGiWQuyACOORkDH3fgSRD9ox3TFro4WGC0Oowd3UZktws8q6u\n 8qvbEpcNtY9N4d5srbNf3Vd5DXrtVLdr5st5F5pxmCXZoxMykfdmLw3Bo\n qysp9nPcktbv4fHk9q7FujYi/EpAUWikwcW3kS2hhIeJdDIGuWa9/+T2W w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10819\"; a=\"442624666\"", "E=Sophos;i=\"6.02,219,1688454000\"; d=\"scan'208\";a=\"442624666\"", "E=McAfee;i=\"6600,9927,10819\"; a=\"883199300\"", "E=Sophos;i=\"6.02,219,1688454000\"; d=\"scan'208\";a=\"883199300\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Subject": "[PATCH 2/2] build: fail if explicitly requested driver is unbuildable", "Date": "Fri, 1 Sep 2023 15:23:32 +0100", "Message-Id": "<20230901142332.588856-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230901142332.588856-1-bruce.richardson@intel.com>", "References": "<20230901142332.588856-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the user passes a list of desired drivers to build via the\n\"enable_drivers\" option, the expectation is that those drivers should be\npart of the build. However, if those drivers have either external or\ninternal dependencies, they still may be silently disabled, for example:\nrunning \"meson setup -Denable_drivers=net/iavf build\" will successfully\nrun, but the iavf net driver will not be configured as \"common/iavf\" is\nmissing.\n\nWe can fix this by setting a flag to indicate when the drivers are\nspecified via an enable_drivers flag. However, unlike when erroring out\non missing libs, we don't error out if a driver in unbuildable, unless\nthe driver name explicitly appears in the \"enable_drivers\" list. This is\nimplemented this way to ensure that wildcarding still works. For\nexample: we still want to allow \"meson setup -Denable_drivers=net/*\" to\nwork, configuring only the buildable network drivers. While it's true\nthat this additional restriction may cause some builds to pass when they\nshould fail, e.g. if the wildcard refers only to a single driver,\nimplementing things this way avoids massive amounts of complexity, and\nis still an improvement on the status-quo.\n\nSuggested-by: Anatoly Burakov <anatoly.burakov@intel.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex 417b64b8fc..8c775bbe62 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -41,7 +41,9 @@ disable_drivers = run_command(list_dir_globs, disable_drivers, check: true).stdo\n # add cmdline enabled drivers and meson enabled drivers together\n enable_drivers = ',' + get_option('enable_drivers')\n enable_drivers = run_command(list_dir_globs, enable_drivers, check: true).stdout().split()\n+require_drivers = true\n if enable_drivers.length() == 0\n+ require_drivers = false\n enable_drivers = run_command(list_dir_globs, '*/*', check: true).stdout().split()\n endif\n \n@@ -155,6 +157,12 @@ foreach subpath:subdirs\n build = false\n reason = 'requires IOVA in mbuf (set enable_iova_as_pa option)'\n endif\n+ # error out if we can't build a driver and that driver was explicitly requested,\n+ # i.e. not via wildcard.\n+ if not build and require_drivers and get_option('enable_drivers').contains(drv_path)\n+ error('Cannot build explicitly requested driver \"@0@\".\\n'.format(drv_path)\n+ +'\\tReason: ' + reason)\n+ endif\n \n # get dependency objs from strings\n shared_deps = ext_deps\n@@ -171,6 +179,12 @@ foreach subpath:subdirs\n endif\n message('Disabling @1@ [@2@]: missing internal dependency \"@0@\"'\n .format(d, name, 'drivers/' + drv_path))\n+ # error out if we can't build a driver and that driver was explicitly\n+ # requested, i.e. not via wildcard.\n+ if require_drivers and get_option('enable_drivers').contains(drv_path)\n+ error('Cannot build explicitly requested driver \"@0@\".\\n'.format(drv_path)\n+ +'\\tPlease enable missing dependency \"@0@\"'.format(d))\n+ endif\n else\n shared_deps += [get_variable('shared_rte_' + d)]\n static_deps += [get_variable('static_rte_' + d)]\n", "prefixes": [ "2/2" ] }