Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131195/?format=api
{ "id": 131195, "url": "http://patchwork.dpdk.org/api/patches/131195/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230905112125.5735-1-venkatx.sivaramakrishnan@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230905112125.5735-1-venkatx.sivaramakrishnan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230905112125.5735-1-venkatx.sivaramakrishnan@intel.com", "date": "2023-09-05T11:21:25", "name": "[v2] drivers/crypto: cipher buffer alignment check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f36715934f2c9ba7e5f0087a5dd2d939ef3387d0", "submitter": { "id": 3155, "url": "http://patchwork.dpdk.org/api/people/3155/?format=api", "name": "Sivaramakrishnan Venkat", "email": "venkatx.sivaramakrishnan@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230905112125.5735-1-venkatx.sivaramakrishnan@intel.com/mbox/", "series": [ { "id": 29435, "url": "http://patchwork.dpdk.org/api/series/29435/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29435", "date": "2023-09-05T11:21:25", "name": "[v2] drivers/crypto: cipher buffer alignment check", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29435/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131195/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131195/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 16A3442526;\n\tWed, 6 Sep 2023 15:00:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A9D384027C;\n\tWed, 6 Sep 2023 15:00:29 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id A7B4240289\n for <dev@dpdk.org>; Tue, 5 Sep 2023 13:21:33 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Sep 2023 04:21:31 -0700", "from silpixa00401012.ir.intel.com ([10.243.23.140])\n by fmsmga008.fm.intel.com with ESMTP; 05 Sep 2023 04:21:30 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1693912893; x=1725448893;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=aXIU8rPamGWZkZVzZzztwwxehY40STD+2MvGzPYdVko=;\n b=RckCXHGoRC8XLHQXc2C9mY8ot8XAJILus/ub/lvRmxbhSUMFbBc9eOxf\n 41APFhwXnoh8G+7YBoDuGKxF68yVfnkCgk4qoYv7pN5qE1NzJlyeJENAz\n /5yoXvSoq4gTePxNGP+KsPiRV79u4KSwFN5vMqx8ZDAcl5AOgOjOCt17C\n dE3b+mfNO6Mz5p7U/oR43gOAoTRUbd+lqIFvoo4p8gFIxzny3C+xMYVaF\n /AxZY1owNEd0gdZGFDMBfT4VTXXq6++dJiny4HsAa5DI96hEBdXkKnv0v\n iYA+o50sshOhj4exlO9MGYCPaK4de5IAvYwHn688979CP6z1moy2cLyVJ Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10823\"; a=\"374159146\"", "E=Sophos;i=\"6.02,229,1688454000\"; d=\"scan'208\";a=\"374159146\"", "E=McAfee;i=\"6600,9927,10823\"; a=\"806567442\"", "E=Sophos;i=\"6.02,229,1688454000\"; d=\"scan'208\";a=\"806567442\"" ], "X-ExtLoop1": "1", "From": "Sivaramakrishnan VenkatX <venkatx.sivaramakrishnan@intel.com>", "To": "Kai Ji <kai.ji@intel.com>", "Cc": "dev@dpdk.org,\n Sivaramakrishnan VenkatX <venkatx.sivaramakrishnan@intel.com>", "Subject": "[PATCH v2] drivers/crypto: cipher buffer alignment check", "Date": "Tue, 5 Sep 2023 11:21:25 +0000", "Message-Id": "<20230905112125.5735-1-venkatx.sivaramakrishnan@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230822104610.954234-1-venkatx.sivaramakrishnan@intel.com>", "References": "<20230822104610.954234-1-venkatx.sivaramakrishnan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 06 Sep 2023 15:00:28 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Cipher length alignment checked for 3DES-CBC and AES-CBC to avoid slice\nhang error in QAT CPM1.8\n\nSigned-off-by: Sivaramakrishnan VenkatX <venkatx.sivaramakrishnan@intel.com>\n--\nV2:\nSet auth_length = 0 for NULL CIPHER NULL AUTH operation.\n---\n drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 22 ++++++++++++++++++++\n 1 file changed, 22 insertions(+)", "diff": "diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h b/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h\nindex cab7e214c0..37647374d5 100644\n--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h\n+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gens.h\n@@ -10,6 +10,13 @@\n #include \"qat_sym_session.h\"\n #include \"qat_sym.h\"\n \n+#define AES_OR_3DES_MISALIGNED (ctx->qat_mode == ICP_QAT_HW_CIPHER_CBC_MODE && \\\n+\t\t\t((((ctx->qat_cipher_alg == ICP_QAT_HW_CIPHER_ALGO_AES128) || \\\n+\t\t\t(ctx->qat_cipher_alg == ICP_QAT_HW_CIPHER_ALGO_AES192) || \\\n+\t\t\t(ctx->qat_cipher_alg == ICP_QAT_HW_CIPHER_ALGO_AES256)) && \\\n+\t\t\t(cipher_param->cipher_length % ICP_QAT_HW_AES_BLK_SZ)) || \\\n+\t\t\t((ctx->qat_cipher_alg == ICP_QAT_HW_CIPHER_ALGO_3DES) && \\\n+\t\t\t(cipher_param->cipher_length % ICP_QAT_HW_3DES_BLK_SZ))))\n #define QAT_SYM_DP_GET_MAX_ENQ(q, c, n) \\\n \tRTE_MIN((q->max_inflights - q->enqueued + q->dequeued - c), n)\n \n@@ -704,6 +711,21 @@ enqueue_one_chain_job_gen1(struct qat_sym_session *ctx,\n \tauth_param->auth_off = ofs.ofs.auth.head;\n \tauth_param->auth_len = auth_len;\n \tauth_param->auth_res_addr = digest->iova;\n+\t/* Input cipher length alignment requirement for 3DES-CBC and AES-CBC.\n+\t * For 3DES-CBC cipher algo, ESP Payload size requires 8 Byte aligned.\n+\t * For AES-CBC cipher algo, ESP Payload size requires 16 Byte aligned.\n+\t * The alignment should be guaranteed by the ESP package padding field\n+\t * according to the RFC4303. Under this condition, QAT will pass through\n+\t * chain job as NULL cipher and NULL auth operation and report misalignment\n+\t * error detected.\n+\t */\n+\tif (AES_OR_3DES_MISALIGNED) {\n+\t\tQAT_LOG(ERR, \"Input cipher length alignment error detected.\\n\");\n+\t\tctx->qat_cipher_alg = ICP_QAT_HW_CIPHER_ALGO_NULL;\n+\t\tctx->qat_hash_alg = ICP_QAT_HW_AUTH_ALGO_NULL;\n+\t\tcipher_param->cipher_length = 0;\n+\t\tauth_param->auth_len = 0;\n+\t}\n \n \tswitch (ctx->qat_hash_alg) {\n \tcase ICP_QAT_HW_AUTH_ALGO_SNOW_3G_UIA2:\n", "prefixes": [ "v2" ] }