Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131281/?format=api
{ "id": 131281, "url": "http://patchwork.dpdk.org/api/patches/131281/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230908112901.1169869-12-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230908112901.1169869-12-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230908112901.1169869-12-haijie1@huawei.com", "date": "2023-09-08T11:28:36", "name": "[11/36] net/e1000: fix Rx and Tx queue state", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0aa1f30f7dd8a4e162dea841fadde649f54d2069", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230908112901.1169869-12-haijie1@huawei.com/mbox/", "series": [ { "id": 29461, "url": "http://patchwork.dpdk.org/api/series/29461/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29461", "date": "2023-09-08T11:28:25", "name": "fix Rx and Tx queue state", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29461/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131281/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 36E4842547;\n\tFri, 8 Sep 2023 13:34:14 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 262C440E36;\n\tFri, 8 Sep 2023 13:32:35 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 0FAA740691\n for <dev@dpdk.org>; Fri, 8 Sep 2023 13:32:22 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Rhv4h1RRHzNn8M;\n Fri, 8 Sep 2023 19:28:36 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 8 Sep 2023 19:32:17 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Simei Su <simei.su@intel.com>,\n Wenjun Wu <wenjun1.wu@intel.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Konstantin Ananyev\n <\"konstantin.v.ananyev@yandex.rukonstantin.ananyev\"@huawei.com>,\n Lijun Ou <oulijun@huawei.com>, Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>", "Subject": "[PATCH 11/36] net/e1000: fix Rx and Tx queue state", "Date": "Fri, 8 Sep 2023 19:28:36 +0800", "Message-ID": "<20230908112901.1169869-12-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20230908112901.1169869-1-haijie1@huawei.com>", "References": "<20230908112901.1169869-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The DPDK framework reports the queue state, which is stored in\ndev->data->tx_queue_state and dev->data->rx_queue_state. The\nstate is maintained by the driver. Users may determine whether\na queue participates in packet forwarding based on the state.\nTherefore, the driver needs to modify the queue state in time\naccording to the actual situation.\n\nFixes: 9ad9ff476cac (\"ethdev: add queue state in queried queue information\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/e1000/em_rxtx.c | 8 ++++++++\n drivers/net/e1000/igb_rxtx.c | 4 ++++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c\nindex cb5ce2307b3b..df5fbb782361 100644\n--- a/drivers/net/e1000/em_rxtx.c\n+++ b/drivers/net/e1000/em_rxtx.c\n@@ -1576,6 +1576,8 @@ em_dev_clear_queues(struct rte_eth_dev *dev)\n \t\t\tem_tx_queue_release_mbufs(txq);\n \t\t\tem_reset_tx_queue(txq);\n \t\t}\n+\n+\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t}\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n@@ -1584,6 +1586,8 @@ em_dev_clear_queues(struct rte_eth_dev *dev)\n \t\t\tem_rx_queue_release_mbufs(rxq);\n \t\t\tem_reset_rx_queue(rxq);\n \t\t}\n+\n+\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t}\n }\n \n@@ -1812,6 +1816,8 @@ eth_em_rx_init(struct rte_eth_dev *dev)\n \t\trxdctl |= E1000_RXDCTL_GRAN;\n \t\tE1000_WRITE_REG(hw, E1000_RXDCTL(i), rxdctl);\n \n+\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n+\n \t\t/*\n \t\t * Due to EM devices not having any sort of hardware\n \t\t * limit for packet length, jumbo frame of any size\n@@ -1946,6 +1952,8 @@ eth_em_tx_init(struct rte_eth_dev *dev)\n \t\ttxdctl |= (txq->wthresh & 0x3F) << 16;\n \t\ttxdctl |= E1000_TXDCTL_GRAN;\n \t\tE1000_WRITE_REG(hw, E1000_TXDCTL(i), txdctl);\n+\n+\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t}\n \n \t/* Program the Transmit Control Register. */\ndiff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c\nindex 61c6394310b3..448c4b7d9d0f 100644\n--- a/drivers/net/e1000/igb_rxtx.c\n+++ b/drivers/net/e1000/igb_rxtx.c\n@@ -2745,6 +2745,8 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)\n \t\telse\n \t\t\trxdctl |= ((rxq->wthresh & 0x1F) << 16);\n \t\tE1000_WRITE_REG(hw, E1000_RXDCTL(i), rxdctl);\n+\n+\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t}\n \n \tif (dev->data->dev_conf.rxmode.offloads & RTE_ETH_RX_OFFLOAD_SCATTER) {\n@@ -2816,6 +2818,8 @@ eth_igbvf_tx_init(struct rte_eth_dev *dev)\n \t\t\ttxdctl |= ((txq->wthresh & 0x1F) << 16);\n \t\ttxdctl |= E1000_TXDCTL_QUEUE_ENABLE;\n \t\tE1000_WRITE_REG(hw, E1000_TXDCTL(i), txdctl);\n+\n+\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t}\n \n }\n", "prefixes": [ "11/36" ] }