Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 131298,
    "url": "http://patchwork.dpdk.org/api/patches/131298/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230908112901.1169869-33-haijie1@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230908112901.1169869-33-haijie1@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230908112901.1169869-33-haijie1@huawei.com",
    "date": "2023-09-08T11:28:57",
    "name": "[32/36] net/txgbe: fix Rx and Tx queue state",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b647ff054c8ec763ae4d3d160ee411dd864db4c8",
    "submitter": {
        "id": 2935,
        "url": "http://patchwork.dpdk.org/api/people/2935/?format=api",
        "name": "Jie Hai",
        "email": "haijie1@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230908112901.1169869-33-haijie1@huawei.com/mbox/",
    "series": [
        {
            "id": 29461,
            "url": "http://patchwork.dpdk.org/api/series/29461/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29461",
            "date": "2023-09-08T11:28:25",
            "name": "fix Rx and Tx queue state",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/29461/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/131298/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/131298/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 45A9642547;\n\tFri,  8 Sep 2023 13:36:38 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 093E242D28;\n\tFri,  8 Sep 2023 13:32:54 +0200 (CEST)",
            "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id B688A40E0F\n for <dev@dpdk.org>; Fri,  8 Sep 2023 13:32:33 +0200 (CEST)",
            "from kwepemi500020.china.huawei.com (unknown [172.30.72.57])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Rhv5H4QY4zMl6J;\n Fri,  8 Sep 2023 19:29:07 +0800 (CST)",
            "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 8 Sep 2023 19:32:29 +0800"
        ],
        "From": "Jie Hai <haijie1@huawei.com>",
        "To": "<dev@dpdk.org>, Jiawen Wu <jiawenwu@trustnetic.com>,\n Jian Wang <jianwang@trustnetic.com>, Ferruh Yigit <ferruh.yigit@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>, Konstantin Ananyev\n <\"konstantin.v.ananyev@yandex.rukonstantin.ananyev\"@huawei.com>,\n Lijun Ou <oulijun@huawei.com>, Thomas Monjalon <thomas@monjalon.net>",
        "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>",
        "Subject": "[PATCH 32/36] net/txgbe: fix Rx and Tx queue state",
        "Date": "Fri, 8 Sep 2023 19:28:57 +0800",
        "Message-ID": "<20230908112901.1169869-33-haijie1@huawei.com>",
        "X-Mailer": "git-send-email 2.30.0",
        "In-Reply-To": "<20230908112901.1169869-1-haijie1@huawei.com>",
        "References": "<20230908112901.1169869-1-haijie1@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.67.165.2]",
        "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500020.china.huawei.com (7.221.188.8)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The DPDK framework reports the queue state, which is stored in\ndev->data->tx_queue_state and dev->data->rx_queue_state. The\nstate is maintained by the driver. Users may determine whether\na queue participates in packet forwarding based on the state.\nTherefore, the driver needs to modify the queue state in time\naccording to the actual situation.\n\nFixes: 9ad9ff476cac (\"ethdev: add queue state in queried queue information\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/txgbe/txgbe_rxtx.c | 8 ++++++++\n 1 file changed, 8 insertions(+)",
    "diff": "diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c\nindex 427f8b82ac80..f4be2bb91c78 100644\n--- a/drivers/net/txgbe/txgbe_rxtx.c\n+++ b/drivers/net/txgbe/txgbe_rxtx.c\n@@ -2805,6 +2805,8 @@ txgbe_dev_clear_queues(struct rte_eth_dev *dev)\n \t\t\ttxq->ops->release_mbufs(txq);\n \t\t\ttxq->ops->reset(txq);\n \t\t}\n+\n+\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t}\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n@@ -2814,6 +2816,8 @@ txgbe_dev_clear_queues(struct rte_eth_dev *dev)\n \t\t\ttxgbe_rx_queue_release_mbufs(rxq);\n \t\t\ttxgbe_reset_rx_queue(adapter, rxq);\n \t\t}\n+\n+\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;\n \t}\n }\n \n@@ -5004,6 +5008,8 @@ txgbevf_dev_rxtx_start(struct rte_eth_dev *dev)\n \t\t} while (--poll_ms && !(txdctl & TXGBE_TXCFG_ENA));\n \t\tif (!poll_ms)\n \t\t\tPMD_INIT_LOG(ERR, \"Could not enable Tx Queue %d\", i);\n+\t\telse\n+\t\t\tdev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t}\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\trxq = dev->data->rx_queues[i];\n@@ -5018,6 +5024,8 @@ txgbevf_dev_rxtx_start(struct rte_eth_dev *dev)\n \t\t} while (--poll_ms && !(rxdctl & TXGBE_RXCFG_ENA));\n \t\tif (!poll_ms)\n \t\t\tPMD_INIT_LOG(ERR, \"Could not enable Rx Queue %d\", i);\n+\t\telse\n+\t\t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \t\trte_wmb();\n \t\twr32(hw, TXGBE_RXWP(i), rxq->nb_rx_desc - 1);\n \t}\n",
    "prefixes": [
        "32/36"
    ]
}