Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131305/?format=api
{ "id": 131305, "url": "http://patchwork.dpdk.org/api/patches/131305/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230908131737.1714750-2-artemyko@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230908131737.1714750-2-artemyko@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230908131737.1714750-2-artemyko@nvidia.com", "date": "2023-09-08T13:17:35", "name": "[v4,1/2] eal: fix memory initialization deadlock", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6ff473c01f009b534f854c12b588d9a4ae81afea", "submitter": { "id": 3172, "url": "http://patchwork.dpdk.org/api/people/3172/?format=api", "name": "Artemy Kovalyov", "email": "artemyko@nvidia.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230908131737.1714750-2-artemyko@nvidia.com/mbox/", "series": [ { "id": 29463, "url": "http://patchwork.dpdk.org/api/series/29463/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29463", "date": "2023-09-08T13:17:34", "name": "fix memory initialization deadlock", "version": 4, "mbox": "http://patchwork.dpdk.org/series/29463/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131305/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131305/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1635042548;\n\tFri, 8 Sep 2023 15:17:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B9F0D402D3;\n\tFri, 8 Sep 2023 15:17:53 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2042.outbound.protection.outlook.com [40.107.93.42])\n by mails.dpdk.org (Postfix) with ESMTP id A6A5B402D2;\n Fri, 8 Sep 2023 15:17:52 +0200 (CEST)", "from BL0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:208:91::21)\n by SN7PR12MB6715.namprd12.prod.outlook.com (2603:10b6:806:271::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Fri, 8 Sep\n 2023 13:17:50 +0000", "from BL6PEPF0001AB76.namprd02.prod.outlook.com\n (2603:10b6:208:91:cafe::33) by BL0PR05CA0011.outlook.office365.com\n (2603:10b6:208:91::21) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.10 via Frontend\n Transport; Fri, 8 Sep 2023 13:17:50 +0000", "from mail.nvidia.com (216.228.118.232) by\n BL6PEPF0001AB76.mail.protection.outlook.com (10.167.242.169) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6792.11 via Frontend Transport; Fri, 8 Sep 2023 13:17:49 +0000", "from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com\n (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Fri, 8 Sep 2023\n 06:17:43 -0700", "from drhqmail201.nvidia.com (10.126.190.180) by\n drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.986.37; Fri, 8 Sep 2023 06:17:43 -0700", "from nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.180)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend\n Transport; Fri, 8 Sep 2023 06:17:41 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=irBeyr3s4NqVwdVlBsL0PHMI06aJQglCKOjOTcUXMV+QjnXZVznfHOk1P+b+TNfBQBoBOiR/2Tx4e2GAMRZiF71IG1ONI2dSztRmjaUkK0onT1qqfvuXPZfuxyhFrg/JhsOeG76bSRYS9xiBc2V1Inx+PL0anXT2OhSrg+lO1RGORopRyjoVqhslnT/LYVsM1448aU0HTEeiiEyDxmqF/cKe+UllNoYmCkLNpTF8fN8PSJ7dSEOA7ho5Bn/isRDUhD9FB+I6ZC5+MGf+ybP/JTCwSTzA82tPlGtV5iMW53IvD06wD9chB+p5Y1mSDa+X0RG+ZGEUEziUsI6ldwIqPA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=3EmTsUc2dnZ1aRaJuiSpVe0mz7yZFx68nVBuD7MBLXk=;\n b=nOHZRXXc89xZVz03iv7REKnyIWUjguPh1D4WIvfCdfPKnqrpQlKVNxtSnF4wzNE3ii9v9DAHLZwPmX+RdJVvN5lWY5NoLg75N0bSaj9jGEV65huBv/pvCKZG0G3sbHSAT6IIbLfoeQnQaxvr+igec2I2siyH5GXPnwz6Z/Lx1cx362H0FdL4McHRuVJlFKajtYpf3kmdOjZBlVtj7QI1p8tqiDBqEixzSFH3imUDboZ3l/pVZ9WjHJqrz5PuRtTK/geGZjUen0vWWd+c2JrDZ1KoChXOLI0lN/SY33jBJbX4OihLRO3AP9j98LL97ERRkpZ22lqtqy2hqxs5J7S/rw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.118.232) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3EmTsUc2dnZ1aRaJuiSpVe0mz7yZFx68nVBuD7MBLXk=;\n b=Hw2my+Qva5deHQ+8ZniWE6HJege8kKeb+yRYyuISgaZS1k0kwbpkQwiFgUySh0HZdmS28c8aEcAJA0Ba0f7DnQzGWU5xGlQsk/WwnnGTBjzbdyWazfqTNK4b4VggcI7gRW5gSbvcMmnjehBXV/fYL4DunwdtUFabb6xIcQX0DBh3lnQy5rbQ27GwanxYD+YtsBH1vExNXGDhLWtLPJI4LumIO3n8WPDzO0qZFSdcyQs1vmFzEIbgIdqlVXDS4C53zSYk374eEDj1dWaaS9G9dmTPThEJY99LnO4W5s2iGPy0w83FwbncTGXO95Mh5qtp52NAkiMqThyrKDrJUTN99g==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.118.232)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.118.232 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C", "From": "Artemy Kovalyov <artemyko@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Thomas Monjalon <thomas@monjalon.net>, Ophir Munk <ophirmu@nvidia.com>,\n <stable@dpdk.org>, Anatoly Burakov <anatoly.burakov@intel.com>, =?utf-8?q?M?=\n\t=?utf-8?q?orten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n \"Stephen Hemminger\" <stephen@networkplumber.org>", "Subject": "[PATCH v4 1/2] eal: fix memory initialization deadlock", "Date": "Fri, 8 Sep 2023 16:17:35 +0300", "Message-ID": "<20230908131737.1714750-2-artemyko@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230908131737.1714750-1-artemyko@nvidia.com>", "References": "<20230830103303.2428995-1-artemyko@nvidia.com>\n <20230908131737.1714750-1-artemyko@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF0001AB76:EE_|SN7PR12MB6715:EE_", "X-MS-Office365-Filtering-Correlation-Id": "c17e029d-d8b4-4675-d929-08dbb06e0043", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n I8vFvWpifBg8SoPpbJQocz4EQxLa96rZ8aphKTm+NwqJ2xp8OZfTRfj7oYyRTd2UsMuSd89O3VKMEcwhVtzlMsLVlzpw3jpfKVbAz8fI9rOzBshTGDpNzaoupZJN2dtknmuXl1fgMBqKvHZLQKiWi0IZPIOD7HxOMjnzYlB6muUG61E/bvmKjKQHp07+1tMeNiRhaRZL1ZkeLoJAVSLbTutV3g4fI4vxD997Xbgll/ufOW02/PX5d6dkljGsxpKJk6Eo6VrBBgEYHRM1Q2EHkcAoYOhCR/AUw0SMiD9nbEZMNNNeDfEGW4xa1uNbz+nn76weykpU6p9LwsDeFLtelXcPUMsJVZ12A2rBAko5WSfUeIeHtmckrBXe4J+iC9OsnzV4CzmfSwx/yf4HIY0CGL4OjPDvBXjnX2Hb9ANzsyBu5amIfyVEK95AI26m7BFkErhec87kfpvnaF/MyDTAe3c5I9iqxP6vBPDX/4NcRjdkXvd5A8vmSY7P29P1Z2ryrxaTsFckRSXvcEa6KVtRdyluc50c62yWsuCI+HgxbOIFzipy7BjrhtdASIZyTE4h92OWJbI8FdHMHgsx4RZAILmDF7eWmlyhQFu0TszWwClo8BVGykIV8j1Cg2+N29OHBgNsxdbUpo9IXTDJ0GYHJmjkhtdrWmHzhUyg20FuKKRCyJLEkZgn+JU5ZiV+6nIIulYX++WEeGjtjhyUtjD3cQW1Xn8bipSJijW34y58WajE3VVeIsyD1W/wSkRLtLI2", "X-Forefront-Antispam-Report": "CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(136003)(396003)(39860400002)(376002)(346002)(82310400011)(1800799009)(186009)(451199024)(36840700001)(40470700004)(46966006)(5660300002)(7696005)(8936002)(4326008)(8676002)(70206006)(316002)(70586007)(41300700001)(6916009)(54906003)(478600001)(2906002)(6666004)(26005)(2616005)(426003)(336012)(6286002)(1076003)(47076005)(36860700001)(83380400001)(55016003)(7636003)(356005)(82740400003)(40460700003)(86362001)(36756003)(40480700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 Sep 2023 13:17:49.8519 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c17e029d-d8b4-4675-d929-08dbb06e0043", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF0001AB76.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN7PR12MB6715", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The issue arose due to changes in the DPDK read-write lock\nimplementation. Following these changes, the RW-lock no longer supports\nrecursion, implying that a single thread shouldn't obtain a read lock if\nit already possesses one. The problem arises during initialization: the\nrte_eal_init() function acquires the memory_hotplug_lock, and later on,\nthere are sequences of calls that acquire it again without releasing it.\n* rte_eal_memory_init() -> eal_memalloc_init() -> rte_memseg_list_walk()\n* rte_eal_memory_init() -> rte_eal_hugepage_init() ->\n eal_dynmem_hugepage_init() -> rte_memseg_list_walk()\nThis scenario introduces the risk of a potential deadlock when concurrent\nwrite locks are applied to the same memory_hotplug_lock. To address this\nlocally, we resolved the issue by replacing rte_memseg_list_walk() with\nrte_memseg_list_walk_thread_unsafe().\n\nBugzilla ID: 1277\nFixes: 832cecc03d77 (\"rwlock: prevent readers from starving writers\")\nCc: stable@dpdk.org\n\nSigned-off-by: Artemy Kovalyov <artemyko@nvidia.com>\n---\n lib/eal/common/eal_common_dynmem.c | 5 ++++-\n lib/eal/include/generic/rte_rwlock.h | 4 ++++\n lib/eal/linux/eal_memalloc.c | 7 +++++--\n 3 files changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_dynmem.c b/lib/eal/common/eal_common_dynmem.c\nindex bdbbe23..95da55d 100644\n--- a/lib/eal/common/eal_common_dynmem.c\n+++ b/lib/eal/common/eal_common_dynmem.c\n@@ -251,7 +251,10 @@\n \t\t */\n \t\tmemset(&dummy, 0, sizeof(dummy));\n \t\tdummy.hugepage_sz = hpi->hugepage_sz;\n-\t\tif (rte_memseg_list_walk(hugepage_count_walk, &dummy) < 0)\n+\t\t/* memory_hotplug_lock is held during initialization, so it's\n+\t\t * safe to call thread-unsafe version.\n+\t\t */\n+\t\tif (rte_memseg_list_walk_thread_unsafe(hugepage_count_walk, &dummy) < 0)\n \t\t\treturn -1;\n \n \t\tfor (i = 0; i < RTE_DIM(dummy.num_pages); i++) {\ndiff --git a/lib/eal/include/generic/rte_rwlock.h b/lib/eal/include/generic/rte_rwlock.h\nindex 9e083bb..c98fc7d 100644\n--- a/lib/eal/include/generic/rte_rwlock.h\n+++ b/lib/eal/include/generic/rte_rwlock.h\n@@ -80,6 +80,10 @@\n /**\n * Take a read lock. Loop until the lock is held.\n *\n+ * @note The RW lock isn't recursive, so calling this function on the same\n+ * lock twice without releasing it could potentially result in a deadlock\n+ * scenario when a write lock is involved.\n+ *\n * @param rwl\n * A pointer to a rwlock structure.\n */\ndiff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c\nindex f8b1588..9853ec7 100644\n--- a/lib/eal/linux/eal_memalloc.c\n+++ b/lib/eal/linux/eal_memalloc.c\n@@ -1740,7 +1740,10 @@ struct rte_memseg *\n \t\teal_get_internal_configuration();\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n-\t\tif (rte_memseg_list_walk(secondary_msl_create_walk, NULL) < 0)\n+\t\t/* memory_hotplug_lock is held during initialization, so it's\n+\t\t * safe to call thread-unsafe version.\n+\t\t */\n+\t\tif (rte_memseg_list_walk_thread_unsafe(secondary_msl_create_walk, NULL) < 0)\n \t\t\treturn -1;\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY &&\n \t\t\tinternal_conf->in_memory) {\n@@ -1778,7 +1781,7 @@ struct rte_memseg *\n \t}\n \n \t/* initialize all of the fd lists */\n-\tif (rte_memseg_list_walk(fd_list_create_walk, NULL))\n+\tif (rte_memseg_list_walk_thread_unsafe(fd_list_create_walk, NULL))\n \t\treturn -1;\n \treturn 0;\n }\n", "prefixes": [ "v4", "1/2" ] }