Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131345/?format=api
{ "id": 131345, "url": "http://patchwork.dpdk.org/api/patches/131345/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230912063903.1266245-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230912063903.1266245-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230912063903.1266245-2-feifei.wang2@arm.com", "date": "2023-09-12T06:39:01", "name": "[v3,1/3] app/test-pipeline: relax RSS hash requirement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "51cebb2088d7c0ea28274ea4c654d64ea25c7bfd", "submitter": { "id": 1771, "url": "http://patchwork.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230912063903.1266245-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 29482, "url": "http://patchwork.dpdk.org/api/series/29482/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29482", "date": "2023-09-12T06:39:00", "name": "fix test-pipeline issues", "version": 3, "mbox": "http://patchwork.dpdk.org/series/29482/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131345/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131345/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7025942579;\n\tTue, 12 Sep 2023 08:39:20 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 57F78402D7;\n\tTue, 12 Sep 2023 08:39:17 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 64E48402CF\n for <dev@dpdk.org>; Tue, 12 Sep 2023 08:39:15 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C86E8C15;\n Mon, 11 Sep 2023 23:39:51 -0700 (PDT)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.116])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4B83F3F67D;\n Mon, 11 Sep 2023 23:39:12 -0700 (PDT)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Trevor Tao <trevor.tao@arm.com>,\n Huisong Li <lihuisong@huawei.com>", "Subject": "[PATCH v3 1/3] app/test-pipeline: relax RSS hash requirement", "Date": "Tue, 12 Sep 2023 14:39:01 +0800", "Message-Id": "<20230912063903.1266245-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230912063903.1266245-1-feifei.wang2@arm.com>", "References": "<20230626074538.3354554-1-feifei.wang2@arm.com>\n <20230912063903.1266245-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For some drivers which can not support the configured RSS hash functions,\nthe thread reports 'invalid rss_hf' when doing device configure.\n\nFor example, i40e driver can not support 'RTE_ETH_RSS_IPV4',\n'RTE_ETH_RSS_IPV6' and 'RTE_ETH_RSS_NONFRAG_IPV6_OTHER', thus it can not\nrun successfully in test-pipeline with XL710 NIC and reports the issue:\n-------------------------------------------------------------\nEthdev port_id=0 invalid rss_hf: 0xa38c, valid value: 0x7ef8\nPANIC in app_init_ports():\nCannot init NIC port 0 (-22)\n-------------------------------------------------------------\n\nTo fix this, referring to l3fwd operation, adjust the 'rss_hf' based on\ndevice capability and just report a warning.\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Trevor Tao <trevor.tao@arm.com>\nAcked-by: Huisong Li <lihuisong@huawei.com>\n---\n app/test-pipeline/init.c | 22 +++++++++++++++++++++-\n 1 file changed, 21 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c\nindex d146c44be0..84a1734519 100644\n--- a/app/test-pipeline/init.c\n+++ b/app/test-pipeline/init.c\n@@ -188,21 +188,41 @@ static void\n app_init_ports(void)\n {\n \tuint32_t i;\n+\tstruct rte_eth_dev_info dev_info;\n+\n \n \t/* Init NIC ports, then start the ports */\n \tfor (i = 0; i < app.n_ports; i++) {\n \t\tuint16_t port;\n \t\tint ret;\n+\t\tstruct rte_eth_conf local_port_conf = port_conf;\n \n \t\tport = app.ports[i];\n \t\tRTE_LOG(INFO, USER1, \"Initializing NIC port %u ...\\n\", port);\n \n+\t\tret = rte_eth_dev_info_get(port, &dev_info);\n+\t\tif (ret != 0)\n+\t\t\trte_panic(\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\t\tport, rte_strerror(-ret));\n+\n \t\t/* Init port */\n+\t\tlocal_port_conf.rx_adv_conf.rss_conf.rss_hf &=\n+\t\t\tdev_info.flow_type_rss_offloads;\n+\t\tif (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=\n+\t\t\t\tport_conf.rx_adv_conf.rss_conf.rss_hf) {\n+\t\t\tprintf(\"Warning:\"\n+\t\t\t\t\"Port %u modified RSS hash function based on hardware support,\"\n+\t\t\t\t\"requested:%#\"PRIx64\" configured:%#\"PRIx64\"\\n\",\n+\t\t\t\tport,\n+\t\t\t\tport_conf.rx_adv_conf.rss_conf.rss_hf,\n+\t\t\t\tlocal_port_conf.rx_adv_conf.rss_conf.rss_hf);\n+\t\t}\n+\n \t\tret = rte_eth_dev_configure(\n \t\t\tport,\n \t\t\t1,\n \t\t\t1,\n-\t\t\t&port_conf);\n+\t\t\t&local_port_conf);\n \t\tif (ret < 0)\n \t\t\trte_panic(\"Cannot init NIC port %u (%d)\\n\", port, ret);\n \n", "prefixes": [ "v3", "1/3" ] }