Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131366/?format=api
{ "id": 131366, "url": "http://patchwork.dpdk.org/api/patches/131366/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230912173039.1612287-9-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230912173039.1612287-9-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230912173039.1612287-9-beilei.xing@intel.com", "date": "2023-09-12T17:30:37", "name": "[v6,08/10] net/cpfl: support probe again", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1d3a661ed55380543766af858974e8a000066224", "submitter": { "id": 410, "url": "http://patchwork.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230912173039.1612287-9-beilei.xing@intel.com/mbox/", "series": [ { "id": 29486, "url": "http://patchwork.dpdk.org/api/series/29486/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29486", "date": "2023-09-12T17:30:29", "name": "net/cpfl: support port representor", "version": 6, "mbox": "http://patchwork.dpdk.org/series/29486/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131366/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131366/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E90124257B;\n\tTue, 12 Sep 2023 11:12:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 830B740A7A;\n\tTue, 12 Sep 2023 11:12:18 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 6600840A7A\n for <dev@dpdk.org>; Tue, 12 Sep 2023 11:12:16 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Sep 2023 02:12:16 -0700", "from dpdk-beileix-icelake.sh.intel.com ([10.67.116.248])\n by fmsmga008.fm.intel.com with ESMTP; 12 Sep 2023 02:12:14 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1694509936; x=1726045936;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=sVQs1DxxfaIvAeeo3x70a8oySoCQIqItfQSZrQ1Ccoo=;\n b=nclNTE0GYSpZipE4WmjaIXnzWYMCTYUL6/HmHye5UJqXXq8f7lC+FkSX\n in41bjRpGKwfar/VvHDdmK+TGwz5uBX3foLZRM6utTmzm5acbnc3W70G5\n 6gulpyhSH5CQHD6Rt9BBemXqlSLzeBCzmKqLwbPNdb7cEopH5fM1CGmOB\n VaRJTQIRWCtmIMz9w4QSg0wBjhJBox3GDF125VDu2Pz9uRCbkDx7K9VmU\n TVp2zZKJ8FSloSU4FbLYQPUUkC8EMRPcjDGoMvPOv8DiMEaR/xp8fjYmQ\n VzZ6Kcyq8+gbItz9SZU9Yuh2Bz2Py1E8fKeqpROIotamAZxQu3i5PdLIt w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10830\"; a=\"375652080\"", "E=Sophos;i=\"6.02,245,1688454000\"; d=\"scan'208\";a=\"375652080\"", "E=McAfee;i=\"6600,9927,10830\"; a=\"809164446\"", "E=Sophos;i=\"6.02,245,1688454000\"; d=\"scan'208\";a=\"809164446\"" ], "X-ExtLoop1": "1", "From": "beilei.xing@intel.com", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org, mingxia.liu@intel.com, Beilei Xing <beilei.xing@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>", "Subject": "[PATCH v6 08/10] net/cpfl: support probe again", "Date": "Tue, 12 Sep 2023 17:30:37 +0000", "Message-Id": "<20230912173039.1612287-9-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230912173039.1612287-1-beilei.xing@intel.com>", "References": "<20230912162640.1439383-1-beilei.xing@intel.com>\n <20230912173039.1612287-1-beilei.xing@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nOnly representor will be parsed for probe again.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/net/cpfl/cpfl_ethdev.c | 69 +++++++++++++++++++++++++++-------\n 1 file changed, 56 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c\nindex b6fcfe4275..428d87b960 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.c\n+++ b/drivers/net/cpfl/cpfl_ethdev.c\n@@ -26,7 +26,7 @@ rte_spinlock_t cpfl_adapter_lock;\n struct cpfl_adapter_list cpfl_adapter_list;\n bool cpfl_adapter_list_init;\n \n-static const char * const cpfl_valid_args[] = {\n+static const char * const cpfl_valid_args_first[] = {\n \tCPFL_REPRESENTOR,\n \tCPFL_TX_SINGLE_Q,\n \tCPFL_RX_SINGLE_Q,\n@@ -34,6 +34,11 @@ static const char * const cpfl_valid_args[] = {\n \tNULL\n };\n \n+static const char * const cpfl_valid_args_again[] = {\n+\tCPFL_REPRESENTOR,\n+\tNULL\n+};\n+\n uint32_t cpfl_supported_speeds[] = {\n \tRTE_ETH_SPEED_NUM_NONE,\n \tRTE_ETH_SPEED_NUM_10M,\n@@ -1533,7 +1538,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args)\n }\n \n static int\n-cpfl_parse_devargs(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapter)\n+cpfl_parse_devargs(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapter, bool first)\n {\n \tstruct rte_devargs *devargs = pci_dev->device.devargs;\n \tstruct cpfl_devargs *cpfl_args = &adapter->devargs;\n@@ -1545,7 +1550,8 @@ cpfl_parse_devargs(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adap\n \tif (devargs == NULL)\n \t\treturn 0;\n \n-\tkvlist = rte_kvargs_parse(devargs->args, cpfl_valid_args);\n+\tkvlist = rte_kvargs_parse(devargs->args,\n+\t\t\tfirst ? cpfl_valid_args_first : cpfl_valid_args_again);\n \tif (kvlist == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"invalid kvargs key\");\n \t\treturn -EINVAL;\n@@ -1562,6 +1568,9 @@ cpfl_parse_devargs(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adap\n \tif (ret != 0)\n \t\tgoto fail;\n \n+\tif (!first)\n+\t\treturn 0;\n+\n \tret = rte_kvargs_process(kvlist, CPFL_VPORT, &parse_vport,\n \t\t\t\t cpfl_args);\n \tif (ret != 0)\n@@ -2291,18 +2300,11 @@ cpfl_vport_create(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapt\n }\n \n static int\n-cpfl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n-\t struct rte_pci_device *pci_dev)\n+cpfl_pci_probe_first(struct rte_pci_device *pci_dev)\n {\n \tstruct cpfl_adapter_ext *adapter;\n \tint retval;\n \n-\tif (!cpfl_adapter_list_init) {\n-\t\trte_spinlock_init(&cpfl_adapter_lock);\n-\t\tTAILQ_INIT(&cpfl_adapter_list);\n-\t\tcpfl_adapter_list_init = true;\n-\t}\n-\n \tadapter = rte_zmalloc(\"cpfl_adapter_ext\",\n \t\t\t sizeof(struct cpfl_adapter_ext), 0);\n \tif (adapter == NULL) {\n@@ -2310,7 +2312,7 @@ cpfl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\treturn -ENOMEM;\n \t}\n \n-\tretval = cpfl_parse_devargs(pci_dev, adapter);\n+\tretval = cpfl_parse_devargs(pci_dev, adapter, true);\n \tif (retval != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to parse private devargs\");\n \t\treturn retval;\n@@ -2355,6 +2357,46 @@ cpfl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \treturn retval;\n }\n \n+static int\n+cpfl_pci_probe_again(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapter)\n+{\n+\tint ret;\n+\n+\tret = cpfl_parse_devargs(pci_dev, adapter, false);\n+\tif (ret != 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to parse private devargs\");\n+\t\treturn ret;\n+\t}\n+\n+\tret = cpfl_repr_devargs_process(adapter);\n+\tif (ret != 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to process reprenstor devargs\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+cpfl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n+\t struct rte_pci_device *pci_dev)\n+{\n+\tstruct cpfl_adapter_ext *adapter;\n+\n+\tif (!cpfl_adapter_list_init) {\n+\t\trte_spinlock_init(&cpfl_adapter_lock);\n+\t\tTAILQ_INIT(&cpfl_adapter_list);\n+\t\tcpfl_adapter_list_init = true;\n+\t}\n+\n+\tadapter = cpfl_find_adapter_ext(pci_dev);\n+\n+\tif (adapter == NULL)\n+\t\treturn cpfl_pci_probe_first(pci_dev);\n+\telse\n+\t\treturn cpfl_pci_probe_again(pci_dev, adapter);\n+}\n+\n static int\n cpfl_pci_remove(struct rte_pci_device *pci_dev)\n {\n@@ -2377,7 +2419,8 @@ cpfl_pci_remove(struct rte_pci_device *pci_dev)\n \n static struct rte_pci_driver rte_cpfl_pmd = {\n \t.id_table\t= pci_id_cpfl_map,\n-\t.drv_flags\t= RTE_PCI_DRV_NEED_MAPPING,\n+\t.drv_flags\t= RTE_PCI_DRV_NEED_MAPPING |\n+\t\t\t RTE_PCI_DRV_PROBE_AGAIN,\n \t.probe\t\t= cpfl_pci_probe,\n \t.remove\t\t= cpfl_pci_remove,\n };\n", "prefixes": [ "v6", "08/10" ] }