Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131421/?format=api
{ "id": 131421, "url": "http://patchwork.dpdk.org/api/patches/131421/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230914123615.1705654-9-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230914123615.1705654-9-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230914123615.1705654-9-david.marchand@redhat.com", "date": "2023-09-14T12:36:07", "name": "[v3,08/15] pci: define some BAR constants", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6438ba059e616510cd004d43eb22391823e19170", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230914123615.1705654-9-david.marchand@redhat.com/mbox/", "series": [ { "id": 29507, "url": "http://patchwork.dpdk.org/api/series/29507/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29507", "date": "2023-09-14T12:35:59", "name": "Cleanup PCI(e) drivers", "version": 3, "mbox": "http://patchwork.dpdk.org/series/29507/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131421/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131421/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2FDD242597;\n\tThu, 14 Sep 2023 14:37:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7E84340A8A;\n\tThu, 14 Sep 2023 14:36:58 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 22F6640395\n for <dev@dpdk.org>; Thu, 14 Sep 2023 14:36:56 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-593-rRjXFmS8MQiZJXK0Xotk_w-1; Thu, 14 Sep 2023 08:36:54 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com\n [10.11.54.6])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF99981DBE6;\n Thu, 14 Sep 2023 12:36:53 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.25])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8303721B20B1;\n Thu, 14 Sep 2023 12:36:52 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1694695015;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=wUoyAH45cHEdp6t84Dj6nJNTCDqaKZ/wg+FI17wWxYE=;\n b=WD3VF7OXYNjtToYzLmIkq2EkWVrVnj9C3Ab0Oi4+4Yfu9ipRrGLxJLvRIM9taMxzLczgtx\n f79MM12zPwPkkmNJa3kmos/wo/9ZF0L0WAq7zfBBPvI/zI1zF7kjTeoG5CQs4HuYnnRy7Z\n S++QKSJcqZwBFXt7wxyYrfEYRU4h/6o=", "X-MC-Unique": "rRjXFmS8MQiZJXK0Xotk_w-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, chenbo.xia@intel.com,\n nipun.gupta@amd.com, bruce.richardson@intel.com,\n Anatoly Burakov <anatoly.burakov@intel.com>, Gaetan Rivet <grive@u256.net>", "Subject": "[PATCH v3 08/15] pci: define some BAR constants", "Date": "Thu, 14 Sep 2023 14:36:07 +0200", "Message-ID": "<20230914123615.1705654-9-david.marchand@redhat.com>", "In-Reply-To": "<20230914123615.1705654-1-david.marchand@redhat.com>", "References": "<20230803075038.307012-1-david.marchand@redhat.com>\n <20230914123615.1705654-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.6", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Define some PCI BAR constants and use them in existing drivers.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/bus/pci/linux/pci_vfio.c | 7 +++----\n lib/pci/rte_pci.h | 4 ++++\n 2 files changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c\nindex bf91492dd9..3f3201daf2 100644\n--- a/drivers/bus/pci/linux/pci_vfio.c\n+++ b/drivers/bus/pci/linux/pci_vfio.c\n@@ -5,7 +5,6 @@\n #include <unistd.h>\n #include <string.h>\n #include <fcntl.h>\n-#include <linux/pci_regs.h>\n #include <sys/eventfd.h>\n #include <sys/socket.h>\n #include <sys/ioctl.h>\n@@ -427,14 +426,14 @@ pci_vfio_is_ioport_bar(const struct rte_pci_device *dev, int vfio_dev_fd,\n \t}\n \n \tret = pread64(vfio_dev_fd, &ioport_bar, sizeof(ioport_bar),\n-\t\t\t offset + PCI_BASE_ADDRESS_0 + bar_index * 4);\n+\t\t\t offset + RTE_PCI_BASE_ADDRESS_0 + bar_index * 4);\n \tif (ret != sizeof(ioport_bar)) {\n \t\tRTE_LOG(ERR, EAL, \"Cannot read command (%x) from config space!\\n\",\n-\t\t\tPCI_BASE_ADDRESS_0 + bar_index*4);\n+\t\t\tRTE_PCI_BASE_ADDRESS_0 + bar_index*4);\n \t\treturn -1;\n \t}\n \n-\treturn (ioport_bar & PCI_BASE_ADDRESS_SPACE_IO) != 0;\n+\treturn (ioport_bar & RTE_PCI_BASE_ADDRESS_SPACE_IO) != 0;\n }\n \n static int\ndiff --git a/lib/pci/rte_pci.h b/lib/pci/rte_pci.h\nindex 8bf60b9fb7..12866be5d5 100644\n--- a/lib/pci/rte_pci.h\n+++ b/lib/pci/rte_pci.h\n@@ -35,6 +35,7 @@ extern \"C\" {\n #define RTE_PCI_DEVICE_ID\t0x02\t/* 16 bits */\n #define RTE_PCI_COMMAND\t\t0x04\t/* 16 bits */\n #define RTE_PCI_STATUS\t\t0x06\t/* 16 bits */\n+#define RTE_PCI_BASE_ADDRESS_0\t0x10\t/* 32 bits */\n #define RTE_PCI_CAPABILITY_LIST\t0x34\t/* 32 bits */\n \n /* PCI Command Register (RTE_PCI_COMMAND) */\n@@ -45,6 +46,9 @@ extern \"C\" {\n /* PCI Status Register (RTE_PCI_STATUS) */\n #define RTE_PCI_STATUS_CAP_LIST\t\t0x10\t/* Support Capability List */\n \n+/* Base addresses (RTE_PCI_BASE_ADDRESS_*) */\n+#define RTE_PCI_BASE_ADDRESS_SPACE_IO\t0x01\n+\n /* Capability registers (RTE_PCI_CAPABILITY_LIST) */\n #define RTE_PCI_CAP_ID_PM\t\t0x01\t/* Power Management */\n #define RTE_PCI_CAP_ID_MSI\t\t0x05\t/* Message Signalled Interrupts */\n", "prefixes": [ "v3", "08/15" ] }