Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 131476,
    "url": "http://patchwork.dpdk.org/api/patches/131476/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230915091551.1459606-2-chaoyong.he@corigine.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230915091551.1459606-2-chaoyong.he@corigine.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230915091551.1459606-2-chaoyong.he@corigine.com",
    "date": "2023-09-15T09:15:25",
    "name": "[v3,01/27] net/nfp: explicitly compare to null and 0",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "4226a524620678ef57a3f61746841c84b5711340",
    "submitter": {
        "id": 2554,
        "url": "http://patchwork.dpdk.org/api/people/2554/?format=api",
        "name": "Chaoyong He",
        "email": "chaoyong.he@corigine.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230915091551.1459606-2-chaoyong.he@corigine.com/mbox/",
    "series": [
        {
            "id": 29520,
            "url": "http://patchwork.dpdk.org/api/series/29520/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29520",
            "date": "2023-09-15T09:15:24",
            "name": "refact the nfpcore module",
            "version": 3,
            "mbox": "http://patchwork.dpdk.org/series/29520/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/131476/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/131476/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2CB1425A3;\n\tFri, 15 Sep 2023 11:16:26 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 962F340A87;\n\tFri, 15 Sep 2023 11:16:22 +0200 (CEST)",
            "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2119.outbound.protection.outlook.com [40.107.93.119])\n by mails.dpdk.org (Postfix) with ESMTP id B1DF04029E\n for <dev@dpdk.org>; Fri, 15 Sep 2023 11:16:18 +0200 (CEST)",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by DM6PR13MB3625.namprd13.prod.outlook.com (2603:10b6:5:241::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep\n 2023 09:16:17 +0000",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::c05c:6915:1628:70c4]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::c05c:6915:1628:70c4%7]) with mapi id 15.20.6768.029; Fri, 15 Sep 2023\n 09:16:16 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mWM13fJjz0wltDfxqJXVsXEinQetgjo8BTRRGIPN2t2fe7C2h+1vDPyNcg9NpHsUTMOwPtueRjdvbt28JhuOJPPJGPVPiFlnmxgFHWyCyeCmn0svXpG/eZCnFo0Q38hBrv7vdxek9qgKuLAwQQ6klCUF7soVNLCeOxH5wZol5ivRdvWgzB0fzlaF0jDotmhSFQRZF6piPcPrMKJv4IQyJEm+GUZyExwSN/g9yIL6jxDRcZDlsusn46PRea+h1v/lnGQ5kbLEtlanFEHhR1iJutWwvsF6YjX0sqE8zy3YdRDp7Df7m6DJxqigxRJA4r3aoRtA9/3HFD0wFAVhe2phMQ==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=yGaBDLXLsScAe1BM2Dm8AbsKvcbb2qkcATEB9A50j4A=;\n b=L0/0pTIl6NOkDBEpBfhO9qjGQSK7Bnc1vi5U7/7Hlgg2RJkiFjy0yyDEUqa/VBU/Af4UnBSZcVrHkqSqVUcBF6QXkSupcObxAGA4kMzO34RvSEstbbaVd0bh0LP/b+95QPTQMOaQduCI3AnkZhmekhLC7vEKjPC2h+5do9F5LhcacuEy4EurFr8TQIS5muo5lDxoTo4zOOxfOQlrTVmI0GdeoL/WB+Z9k0BOY2tKnRfFtyal0RYV54/7zFqPj/7W6EFEFsT1FHLOPO5AWBZ43mhvoZJ8RTxzH9PFtpRKIQkPaeZCP6vdAemEFwUlsB0HbyNnHNFsSHDGaZzxcNr16Q==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=yGaBDLXLsScAe1BM2Dm8AbsKvcbb2qkcATEB9A50j4A=;\n b=WmKQb3c+f0KAcFu7qzxRIuaUNUUuormmYtwFg0qxd7kmh8GLxC/0fdGrk4sDDIVM8NUdfHE/qLf8vEFeX5QrmY+ANEA0vQIlLFPm2wgjYHkeOXvNLUqSJipPrRMdck3KPcOzoPuDmpJ9CbJw885sksU6AxqBQcDA0FBLO8k0AFk=",
        "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;",
        "From": "Chaoyong He <chaoyong.he@corigine.com>",
        "To": "dev@dpdk.org",
        "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n\t=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@corigine.com>",
        "Subject": "[PATCH v3 01/27] net/nfp: explicitly compare to null and 0",
        "Date": "Fri, 15 Sep 2023 17:15:25 +0800",
        "Message-Id": "<20230915091551.1459606-2-chaoyong.he@corigine.com>",
        "X-Mailer": "git-send-email 2.39.1",
        "In-Reply-To": "<20230915091551.1459606-1-chaoyong.he@corigine.com>",
        "References": "<20230830021457.2064750-1-chaoyong.he@corigine.com>\n <20230915091551.1459606-1-chaoyong.he@corigine.com>",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-ClientProxiedBy": "PH7PR10CA0017.namprd10.prod.outlook.com\n (2603:10b6:510:23d::10) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)",
        "MIME-Version": "1.0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|DM6PR13MB3625:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "be448c26-c786-4483-77e2-08dbb5cc6a6c",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n mw79O9xTVhcJn9JEQMlWWC7b5x0ui5oAPspZCy65XuFkYZUumiMWH44sPz9z3RzJv/mVQXDJITm5a/AXa0iwAx45712uvyofoEoLjP07O0Fq/QXTM0UB8DgIn7A6WLOqRtuBqOga3EUX722O9657efSg/rGujgf/bePPMgobvltqXfCBV/N1jRlaqXJ64j9rNNCNM+9Xd0/nt3/+LaTkaqAbuNolgYvvL3Q0i3sJHSYHVttj2EEKAqW0/RcaK6db6/NpERxrUdv/brjIftCfEi+MZIZrxOi+XkMIfRHsHX0SVl2x1j+kr4MBqdnG0imMvHpuNL8u6yC2qYW+TAnS/N7p/1PiX5D39ZMC3J+tMI0pOD+KjXMDMBXu1LbwVtSM7CAo28YH/oJxs7WlnxR5LQQljxUjbhgWyD6bRaqSvoSjEFrYDTvZEkE/4voSBFPKGe8UaaTcB1QH22ZlfuklBepv/LcEead7tyb9ruuKwIgxVD6fVIJSIYHOv+L4I+uSJOqGytdZEdugrRVVocXlKG4tgPXj8qZafvePbkTgqwPAK0j0VfwruCIKusdlby2a9+d1nitZ4KHA6/M/Qvk/bFLV0ZV2MBmzM3hDepJxXX0slXd5iJvewMpSUxQjcxfJFL1dg1xBVb9xaF4yx3npMJ9lV6qLTsO8AgK3ZMUpqbE=",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(39830400003)(346002)(376002)(396003)(366004)(136003)(186009)(1800799009)(451199024)(2906002)(86362001)(6512007)(52116002)(107886003)(2616005)(26005)(1076003)(478600001)(36756003)(6666004)(6506007)(6486002)(38350700002)(38100700002)(83380400001)(66574015)(5660300002)(8676002)(8936002)(4326008)(41300700001)(66946007)(66476007)(66556008)(6916009)(316002)(44832011)(54906003)(30864003);\n DIR:OUT; SFP:1102;",
        "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1",
        "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?Tl+wwpulDgR9uSUoVCq97NNMxfnA?=\n\t=?utf-8?q?yXUaogcXQqZPItAPOvo0MyqMnv8s9SkA8HW8C/1mW6IjKiAnsdrY2nTeEdBSIzD31?=\n\t=?utf-8?q?iOAHVjzXn43pBhg2Gh/ohcEOnQZQ0Rz3CCN1H+AJPMVZ6EUV1FyaIRAYj1IQupItR?=\n\t=?utf-8?q?7yMMOx93kFQsoPgKGHkncVPjYdlGpPZsiPPqh5o+VPTsSs9mDBxqV6d/7gZsgQw94?=\n\t=?utf-8?q?TE9F72uoJMjl37/2CpMkBliUbhV4ML59TYUElXFxHVXuneaa7PMCNnlJR2ZJbA4Vu?=\n\t=?utf-8?q?uGsGx3i+ZHHpmI07tKpNbTzxgtWQxa6SbZcceMRTuYrSH+/TRBVADNY61hsAY2vjM?=\n\t=?utf-8?q?KTOdJaDRbhalYOD/8KTBxshxd68EVJ8Yp8lEo2l50NFlJJ+zXi1uBXUhPWpGJnOrA?=\n\t=?utf-8?q?gHeEoFf72BSJ/hXGeAQk5Hm9pptX6c8qGCEsF+xL6NpTatQ02tDHWaYhIvt2Ywtb2?=\n\t=?utf-8?q?EJfuH8RP1WOFP9D9QSh+NCvIdiDrrN3XvyQYHj+ECpIkPATcgzmyAgcqgk4t1YyuE?=\n\t=?utf-8?q?LdA2l5I5jmPmwJaEt+AeVkv1abmKQx4qoWt4QQtcYUgmtcojtNctyTqlRoD0rrnH7?=\n\t=?utf-8?q?EGZpVcaeyqSSYT/oa63J8qOX0Sp0cuuQO+zYGEnQBAJdrFhLb8DfK2RAYVCMSDtnK?=\n\t=?utf-8?q?Vlt9NQhXRDC65nhQnqAvOr0Bz3/VzqJ0dfHYe8d6yMeDvAvxMDfxskr8Z0AIdGe5j?=\n\t=?utf-8?q?cHH011UgnEY4YtyBNjAcaSNziSnRXbXDawqGhXrbnQAUNlpa6zKVcjPxQYtqV9eJ7?=\n\t=?utf-8?q?ukyJ7fW1OjAtvQgHOVZj6GI7T5CnBmNNPh1b5FKqW9+bWkvpkJ9S2piG32zz9hmHe?=\n\t=?utf-8?q?Q1NnmupCxdswXCKueVD4uq+fWsfg1PmmE28j7I0hLgIHWQK4w80iOC8MvVOXfqd9H?=\n\t=?utf-8?q?IF65oSGUtAH1n9ZXRZ0cG0jUCPh1ezHjKG/w/Rpp55rRhuQBx8Tx7DfsFzNVzpMac?=\n\t=?utf-8?q?nGIWS6lLynJTB4GRNBkuKhlRMMm28ZpteAaj9McvBotP5uCxwWWref3r/V7ukO6pY?=\n\t=?utf-8?q?He+UtMvAcukIGv8AC9ygqnd6wUNY0Anb26ZILoMPtgM8blHJnZk6bdd0ZIYAE0zdY?=\n\t=?utf-8?q?RKtniP98q4JInAZp0vsIXKyBasYPlgs4MDi9mhhpvRlyLOTF4xn+d1fwNWX/3HQmO?=\n\t=?utf-8?q?QrrScr7+nlgYfVCkYBSLXol21QqqWqzo5AptVKBHZy94DZXtUW1EsJMePdWbhyEYi?=\n\t=?utf-8?q?Gu8SLx2UxxV6NVdLuJZA3GeNP0eVTrkvdUOLxQ2v/YFpTOFDQ9X1ue9LJCBjwzMkj?=\n\t=?utf-8?q?wnAOnxceUyM/0lZXGsVu7/eAjWc6GYKG/8vjYAtPRYKdjCoPVL1CgUHzmddJOw7z1?=\n\t=?utf-8?q?oKVLaDo+Mx1uBZLp1bbN+j/v1uqOXzC27EbTvJ5PfudIRQRTxrZH6bt4LXKW9YxKq?=\n\t=?utf-8?q?5B4FqVo0r1UmQPTOMdhhgT7pXxHncAOitU9GxQhYYi3aTV1q8fdtMBheSKuttX89Y?=\n\t=?utf-8?q?gNwzI5i/KoCVZ9ptkt3k3Zb7lkVq+WQtsp8NIRGeQtLmCsC6kqXB4aPzdDLOzuSAL?=\n\t=?utf-8?q?KVyEouOCqynpYfmbU0s26CgPqq1W4b4F5g=3D=3D?=",
        "X-OriginatorOrg": "corigine.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n be448c26-c786-4483-77e2-08dbb5cc6a6c",
        "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "15 Sep 2023 09:16:16.9430 (UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n P79+Lvh/neIhnGFd/NUxPOsVYYopkLNb1OW9/A1EnbtvjToC9gdaVwCR1SQ/fNWSITLRyU+J1Oetf4ufOQKdkZphhIpI/xaRiBNaMQXGkNw=",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR13MB3625",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "To compliance with the coding standard, make the pointer variable\nexplicitly comparing to 'NULL' and the integer variable explicitly\ncomparing to '0'.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 12 ++++++------\n drivers/net/nfp/nfpcore/nfp_cppcore.c      | 16 ++++++++--------\n drivers/net/nfp/nfpcore/nfp_hwinfo.c       |  8 ++++----\n drivers/net/nfp/nfpcore/nfp_mip.c          |  4 ++--\n drivers/net/nfp/nfpcore/nfp_mutex.c        |  2 +-\n drivers/net/nfp/nfpcore/nfp_nffw.c         |  4 ++--\n drivers/net/nfp/nfpcore/nfp_nsp.c          | 20 ++++++++++----------\n drivers/net/nfp/nfpcore/nfp_nsp_eth.c      | 10 +++++-----\n drivers/net/nfp/nfpcore/nfp_resource.c     |  6 +++---\n drivers/net/nfp/nfpcore/nfp_rtsym.c        |  4 ++--\n 10 files changed, 43 insertions(+), 43 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\nindex 658c618ee6..2ee60eefc3 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n@@ -224,10 +224,10 @@ nfp_compute_bar(const struct nfp_bar *bar, uint32_t *bar_config,\n \n \tnewcfg |= offset >> bitsize;\n \n-\tif (bar_base)\n+\tif (bar_base != NULL)\n \t\t*bar_base = offset;\n \n-\tif (bar_config)\n+\tif (bar_config != NULL)\n \t\t*bar_config = newcfg;\n \n \treturn 0;\n@@ -266,7 +266,7 @@ nfp_reconfigure_bar(struct nfp_pcie_user *nfp, struct nfp_bar *bar, int tgt,\n \n \terr = nfp_compute_bar(bar, &newcfg, &newbase, tgt, act, tok, offset,\n \t\t\t      size, width);\n-\tif (err)\n+\tif (err != 0)\n \t\treturn err;\n \n \tbar->base = newbase;\n@@ -515,7 +515,7 @@ nfp6000_area_read(struct nfp_cpp_area *area, void *kernel_vaddr,\n \t\treturn -EINVAL;\n \n \t/* Unaligned? Translate to an explicit access */\n-\tif ((priv->offset + offset) & (width - 1)) {\n+\tif (((priv->offset + offset) & (width - 1)) != 0) {\n \t\tPMD_DRV_LOG(ERR, \"aread_read unaligned!!!\");\n \t\treturn -EINVAL;\n \t}\n@@ -583,7 +583,7 @@ nfp6000_area_write(struct nfp_cpp_area *area, const void *kernel_vaddr,\n \t\treturn -EINVAL;\n \n \t/* Unaligned? Translate to an explicit access */\n-\tif ((priv->offset + offset) & (width - 1))\n+\tif (((priv->offset + offset) & (width - 1)) != 0)\n \t\treturn -EINVAL;\n \n \tis_64 = width == TARGET_WIDTH_64;\n@@ -764,7 +764,7 @@ nfp6000_init(struct nfp_cpp *cpp, struct rte_pci_device *dev)\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY &&\n \t    cpp->driver_lock_needed) {\n \t\tret = nfp_acquire_process_lock(desc);\n-\t\tif (ret)\n+\t\tif (ret != 0)\n \t\t\tgoto error;\n \t}\n \ndiff --git a/drivers/net/nfp/nfpcore/nfp_cppcore.c b/drivers/net/nfp/nfpcore/nfp_cppcore.c\nindex 6daee313ce..31338e0047 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cppcore.c\n+++ b/drivers/net/nfp/nfpcore/nfp_cppcore.c\n@@ -235,7 +235,7 @@ nfp_cpp_area_alloc_acquire(struct nfp_cpp *cpp, uint32_t destination,\n \tif (area == NULL)\n \t\treturn NULL;\n \n-\tif (nfp_cpp_area_acquire(area)) {\n+\tif (nfp_cpp_area_acquire(area) != 0) {\n \t\tnfp_cpp_area_free(area);\n \t\treturn NULL;\n \t}\n@@ -252,7 +252,7 @@ nfp_cpp_area_alloc_acquire(struct nfp_cpp *cpp, uint32_t destination,\n void\n nfp_cpp_area_free(struct nfp_cpp_area *area)\n {\n-\tif (area->cpp->op->area_cleanup)\n+\tif (area->cpp->op->area_cleanup != NULL)\n \t\tarea->cpp->op->area_cleanup(area);\n \tfree(area);\n }\n@@ -280,7 +280,7 @@ nfp_cpp_area_release_free(struct nfp_cpp_area *area)\n int\n nfp_cpp_area_acquire(struct nfp_cpp_area *area)\n {\n-\tif (area->cpp->op->area_acquire) {\n+\tif (area->cpp->op->area_acquire != NULL) {\n \t\tint err = area->cpp->op->area_acquire(area);\n \n \t\tif (err < 0)\n@@ -299,7 +299,7 @@ nfp_cpp_area_acquire(struct nfp_cpp_area *area)\n void\n nfp_cpp_area_release(struct nfp_cpp_area *area)\n {\n-\tif (area->cpp->op->area_release)\n+\tif (area->cpp->op->area_release != NULL)\n \t\tarea->cpp->op->area_release(area);\n }\n \n@@ -319,7 +319,7 @@ nfp_cpp_area_iomem(struct nfp_cpp_area *area)\n {\n \tvoid *iomem = NULL;\n \n-\tif (area->cpp->op->area_iomem)\n+\tif (area->cpp->op->area_iomem != NULL)\n \t\tiomem = area->cpp->op->area_iomem(area);\n \n \treturn iomem;\n@@ -621,10 +621,10 @@ nfp_cpp_alloc(struct rte_pci_device *dev, int driver_lock_needed)\n void\n nfp_cpp_free(struct nfp_cpp *cpp)\n {\n-\tif (cpp->op && cpp->op->free)\n+\tif (cpp->op != NULL && cpp->op->free != NULL)\n \t\tcpp->op->free(cpp);\n \n-\tif (cpp->serial_len)\n+\tif (cpp->serial_len != 0)\n \t\tfree(cpp->serial);\n \n \tfree(cpp);\n@@ -833,7 +833,7 @@ __nfp_cpp_model_autodetect(struct nfp_cpp *cpp, uint32_t *model)\n \t\treturn err;\n \n \t*model = reg & NFP_PL_DEVICE_MODEL_MASK;\n-\tif (*model & NFP_PL_DEVICE_ID_MASK)\n+\tif ((*model & NFP_PL_DEVICE_ID_MASK) != 0)\n \t\t*model -= 0x10;\n \n \treturn 0;\ndiff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c\nindex 9054bb0315..a9d166c4dc 100644\n--- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c\n+++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c\n@@ -37,7 +37,7 @@ nfp_hwinfo_db_walk(struct nfp_hwinfo *hwinfo, uint32_t size)\n {\n \tconst char *key, *val, *end = hwinfo->data + size;\n \n-\tfor (key = hwinfo->data; *key && key < end;\n+\tfor (key = hwinfo->data; *key != 0 && key < end;\n \t     key = val + strlen(val) + 1) {\n \t\tval = key + strlen(key) + 1;\n \t\tif (val >= end) {\n@@ -141,7 +141,7 @@ nfp_hwinfo_fetch(struct nfp_cpp *cpp, size_t *hwdb_size)\n \n \tfor (;;) {\n \t\tdb = nfp_hwinfo_try_fetch(cpp, hwdb_size);\n-\t\tif (db)\n+\t\tif (db != NULL)\n \t\t\treturn db;\n \n \t\tnanosleep(&wait, NULL);\n@@ -164,7 +164,7 @@ nfp_hwinfo_read(struct nfp_cpp *cpp)\n \t\treturn NULL;\n \n \terr = nfp_hwinfo_db_validate(db, hwdb_size);\n-\tif (err) {\n+\tif (err != 0) {\n \t\tfree(db);\n \t\treturn NULL;\n \t}\n@@ -188,7 +188,7 @@ nfp_hwinfo_lookup(struct nfp_hwinfo *hwinfo, const char *lookup)\n \n \tend = hwinfo->data + hwinfo->size - sizeof(uint32_t);\n \n-\tfor (key = hwinfo->data; *key && key < end;\n+\tfor (key = hwinfo->data; *key != 0 && key < end;\n \t     key = val + strlen(val) + 1) {\n \t\tval = key + strlen(key) + 1;\n \ndiff --git a/drivers/net/nfp/nfpcore/nfp_mip.c b/drivers/net/nfp/nfpcore/nfp_mip.c\nindex 6b392ad5eb..f9723dd136 100644\n--- a/drivers/net/nfp/nfpcore/nfp_mip.c\n+++ b/drivers/net/nfp/nfpcore/nfp_mip.c\n@@ -75,7 +75,7 @@ nfp_mip_read_resource(struct nfp_cpp *cpp, struct nfp_mip *mip)\n \t\treturn -ENODEV;\n \n \terr = nfp_nffw_info_mip_first(nffw_info, &cpp_id, &addr);\n-\tif (err)\n+\tif (err != 0)\n \t\tgoto exit_close_nffw;\n \n \terr = nfp_mip_try_read(cpp, cpp_id, addr, mip);\n@@ -105,7 +105,7 @@ nfp_mip_open(struct nfp_cpp *cpp)\n \t\treturn NULL;\n \n \terr = nfp_mip_read_resource(cpp, mip);\n-\tif (err) {\n+\tif (err != 0) {\n \t\tfree(mip);\n \t\treturn NULL;\n \t}\ndiff --git a/drivers/net/nfp/nfpcore/nfp_mutex.c b/drivers/net/nfp/nfpcore/nfp_mutex.c\nindex f967a29351..0410a00856 100644\n--- a/drivers/net/nfp/nfpcore/nfp_mutex.c\n+++ b/drivers/net/nfp/nfpcore/nfp_mutex.c\n@@ -38,7 +38,7 @@ static int\n _nfp_cpp_mutex_validate(uint32_t model, int *target, unsigned long long address)\n {\n \t/* Address must be 64-bit aligned */\n-\tif (address & 7)\n+\tif ((address & 7) != 0)\n \t\treturn -EINVAL;\n \n \tif (NFP_CPP_MODEL_IS_6000(model)) {\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nffw.c b/drivers/net/nfp/nfpcore/nfp_nffw.c\nindex 07d63900dc..433780a5e7 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nffw.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nffw.c\n@@ -190,7 +190,7 @@ nfp_nffw_info_fwid_first(struct nfp_nffw_info *state)\n \t\treturn NULL;\n \n \tfor (i = 0; i < cnt; i++)\n-\t\tif (nffw_fwinfo_loaded_get(&fwinfo[i]))\n+\t\tif (nffw_fwinfo_loaded_get(&fwinfo[i]) != 0)\n \t\t\treturn &fwinfo[i];\n \n \treturn NULL;\n@@ -217,7 +217,7 @@ nfp_nffw_info_mip_first(struct nfp_nffw_info *state, uint32_t *cpp_id,\n \t*cpp_id = nffw_fwinfo_mip_cppid_get(fwinfo);\n \t*off = nffw_fwinfo_mip_offset_get(fwinfo);\n \n-\tif (nffw_fwinfo_mip_mu_da_get(fwinfo)) {\n+\tif (nffw_fwinfo_mip_mu_da_get(fwinfo) != 0) {\n \t\tint locality_off;\n \n \t\tif (NFP_CPP_ID_TARGET_of(*cpp_id) != NFP_CPP_TARGET_MU)\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nsp.c b/drivers/net/nfp/nfpcore/nfp_nsp.c\nindex 1f6b7bd85c..6474abf0c2 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nsp.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nsp.c\n@@ -95,7 +95,7 @@ nfp_nsp_check(struct nfp_nsp *state)\n \t\treturn -EINVAL;\n \t}\n \n-\tif (reg & NSP_STATUS_BUSY) {\n+\tif ((reg & NSP_STATUS_BUSY) != 0) {\n \t\tPMD_DRV_LOG(ERR, \"Service processor busy!\");\n \t\treturn -EBUSY;\n \t}\n@@ -128,7 +128,7 @@ nfp_nsp_open(struct nfp_cpp *cpp)\n \tstate->res = res;\n \n \terr = nfp_nsp_check(state);\n-\tif (err) {\n+\tif (err != 0) {\n \t\tnfp_nsp_close(state);\n \t\treturn NULL;\n \t}\n@@ -219,7 +219,7 @@ nfp_nsp_command(struct nfp_nsp *state, uint16_t code, uint32_t option,\n \tnsp_buffer = nsp_base + NSP_BUFFER;\n \n \terr = nfp_nsp_check(state);\n-\tif (err)\n+\tif (err != 0)\n \t\treturn err;\n \n \tif (!FIELD_FIT(NSP_BUFFER_CPP, buff_cpp >> 8) ||\n@@ -245,7 +245,7 @@ nfp_nsp_command(struct nfp_nsp *state, uint16_t code, uint32_t option,\n \t/* Wait for NSP_COMMAND_START to go to 0 */\n \terr = nfp_nsp_wait_reg(cpp, &reg, nsp_cpp, nsp_command,\n \t\t\t       NSP_COMMAND_START, 0);\n-\tif (err) {\n+\tif (err != 0) {\n \t\tPMD_DRV_LOG(ERR, \"Error %d waiting for code 0x%04x to start\",\n \t\t\terr, code);\n \t\treturn err;\n@@ -254,7 +254,7 @@ nfp_nsp_command(struct nfp_nsp *state, uint16_t code, uint32_t option,\n \t/* Wait for NSP_STATUS_BUSY to go to 0 */\n \terr = nfp_nsp_wait_reg(cpp, &reg, nsp_cpp, nsp_status, NSP_STATUS_BUSY,\n \t\t\t       0);\n-\tif (err) {\n+\tif (err != 0) {\n \t\tPMD_DRV_LOG(ERR, \"Error %d waiting for code 0x%04x to start\",\n \t\t\terr, code);\n \t\treturn err;\n@@ -266,7 +266,7 @@ nfp_nsp_command(struct nfp_nsp *state, uint16_t code, uint32_t option,\n \tret_val = FIELD_GET(NSP_COMMAND_OPTION, ret_val);\n \n \terr = FIELD_GET(NSP_STATUS_RESULT, reg);\n-\tif (err) {\n+\tif (err != 0) {\n \t\tPMD_DRV_LOG(ERR, \"Result (error) code set: %d (%d) command: %d\",\n \t\t\t -err, (int)ret_val, code);\n \t\tnfp_nsp_print_extended_error(ret_val);\n@@ -319,13 +319,13 @@ nfp_nsp_command_buf(struct nfp_nsp *nsp, uint16_t code, uint32_t option,\n \tcpp_id = FIELD_GET(NSP_BUFFER_CPP, reg) << 8;\n \tcpp_buf = FIELD_GET(NSP_BUFFER_ADDRESS, reg);\n \n-\tif (in_buf && in_size) {\n+\tif (in_buf != NULL && in_size > 0) {\n \t\terr = nfp_cpp_write(cpp, cpp_id, cpp_buf, in_buf, in_size);\n \t\tif (err < 0)\n \t\t\treturn err;\n \t}\n \t/* Zero out remaining part of the buffer */\n-\tif (out_buf && out_size && out_size > in_size) {\n+\tif (out_buf != NULL && out_size > 0 && out_size > in_size) {\n \t\tmemset(out_buf, 0, out_size - in_size);\n \t\terr = nfp_cpp_write(cpp, cpp_id, cpp_buf + in_size, out_buf,\n \t\t\t\t    out_size - in_size);\n@@ -337,7 +337,7 @@ nfp_nsp_command_buf(struct nfp_nsp *nsp, uint16_t code, uint32_t option,\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tif (out_buf && out_size) {\n+\tif (out_buf != NULL && out_size > 0) {\n \t\terr = nfp_cpp_read(cpp, cpp_id, cpp_buf, out_buf, out_size);\n \t\tif (err < 0)\n \t\t\treturn err;\n@@ -369,7 +369,7 @@ nfp_nsp_wait(struct nfp_nsp *state)\n \t\t\tbreak;\n \t\t}\n \t}\n-\tif (err)\n+\tif (err != 0)\n \t\tPMD_DRV_LOG(ERR, \"NSP failed to respond %d\", err);\n \n \treturn err;\ndiff --git a/drivers/net/nfp/nfpcore/nfp_nsp_eth.c b/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\nindex 01b4652280..825a84a8cd 100644\n--- a/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\n+++ b/drivers/net/nfp/nfpcore/nfp_nsp_eth.c\n@@ -212,7 +212,7 @@ nfp_eth_port_translate(struct nfp_nsp *nsp, const union eth_table_entry *src,\n \tdst->fec_modes_supported |= fec << NFP_FEC_BASER_BIT;\n \tfec = FIELD_GET(NSP_ETH_PORT_FEC_SUPP_RS, port);\n \tdst->fec_modes_supported |= fec << NFP_FEC_REED_SOLOMON_BIT;\n-\tif (dst->fec_modes_supported)\n+\tif (dst->fec_modes_supported != 0)\n \t\tdst->fec_modes_supported |= NFP_FEC_AUTO | NFP_FEC_DISABLED;\n \n \tdst->fec = 1 << FIELD_GET(NSP_ETH_STATE_FEC, state);\n@@ -285,7 +285,7 @@ __nfp_eth_read_ports(struct nfp_nsp *nsp)\n \t */\n \tfor (i = 0; i < NSP_ETH_MAX_COUNT; i++) {\n \t\tmac = (const struct rte_ether_addr *)entries[i].mac_addr;\n-\t\tif ((entries[i].port & NSP_ETH_PORT_LANES_MASK) &&\n+\t\tif ((entries[i].port & NSP_ETH_PORT_LANES_MASK) != 0 &&\n \t\t\t\t!rte_is_zero_ether_addr(mac))\n \t\t\tcnt++;\n \t}\n@@ -294,7 +294,7 @@ __nfp_eth_read_ports(struct nfp_nsp *nsp)\n \t * those that give a port count, verify it against the value calculated\n \t * above.\n \t */\n-\tif (ret && ret != cnt) {\n+\tif (ret != 0 && ret != cnt) {\n \t\tPMD_DRV_LOG(ERR, \"table entry count (%d) unmatch entries present (%d)\",\n \t\t       ret, cnt);\n \t\tgoto err;\n@@ -309,7 +309,7 @@ __nfp_eth_read_ports(struct nfp_nsp *nsp)\n \ttable->count = cnt;\n \tfor (i = 0, j = 0; i < NSP_ETH_MAX_COUNT; i++) {\n \t\tmac = (const struct rte_ether_addr *)entries[i].mac_addr;\n-\t\tif ((entries[i].port & NSP_ETH_PORT_LANES_MASK) &&\n+\t\tif ((entries[i].port & NSP_ETH_PORT_LANES_MASK) != 0 &&\n \t\t\t\t!rte_is_zero_ether_addr(mac))\n \t\t\tnfp_eth_port_translate(nsp, &entries[i], i,\n \t\t\t\t\t&table->ports[j++]);\n@@ -621,7 +621,7 @@ nfp_eth_set_fec(struct nfp_cpp *cpp, unsigned int idx, enum nfp_eth_fec mode)\n \t\treturn -EIO;\n \n \terr = __nfp_eth_set_fec(nsp, mode);\n-\tif (err) {\n+\tif (err != 0) {\n \t\tnfp_eth_config_cleanup_end(nsp);\n \t\treturn err;\n \t}\ndiff --git a/drivers/net/nfp/nfpcore/nfp_resource.c b/drivers/net/nfp/nfpcore/nfp_resource.c\nindex 351bc623ed..838cd6e0ef 100644\n--- a/drivers/net/nfp/nfpcore/nfp_resource.c\n+++ b/drivers/net/nfp/nfpcore/nfp_resource.c\n@@ -115,15 +115,15 @@ nfp_resource_try_acquire(struct nfp_cpp *cpp, struct nfp_resource *res,\n {\n \tint err;\n \n-\tif (nfp_cpp_mutex_lock(dev_mutex))\n+\tif (nfp_cpp_mutex_lock(dev_mutex) != 0)\n \t\treturn -EINVAL;\n \n \terr = nfp_cpp_resource_find(cpp, res);\n-\tif (err)\n+\tif (err != 0)\n \t\tgoto err_unlock_dev;\n \n \terr = nfp_cpp_mutex_trylock(res->mutex);\n-\tif (err)\n+\tif (err != 0)\n \t\tgoto err_res_mutex_free;\n \n \tnfp_cpp_mutex_unlock(dev_mutex);\ndiff --git a/drivers/net/nfp/nfpcore/nfp_rtsym.c b/drivers/net/nfp/nfpcore/nfp_rtsym.c\nindex 343b0d0bcf..4c45aec5c1 100644\n--- a/drivers/net/nfp/nfpcore/nfp_rtsym.c\n+++ b/drivers/net/nfp/nfpcore/nfp_rtsym.c\n@@ -362,10 +362,10 @@ nfp_rtsym_read_le(struct nfp_rtsym_table *rtbl, const char *name, int *error)\n \tif (err)\n \t\terr = -EIO;\n exit:\n-\tif (error)\n+\tif (error != NULL)\n \t\t*error = err;\n \n-\tif (err)\n+\tif (err != 0)\n \t\treturn ~0ULL;\n \n \treturn val;\n",
    "prefixes": [
        "v3",
        "01/27"
    ]
}