Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131491/?format=api
{ "id": 131491, "url": "http://patchwork.dpdk.org/api/patches/131491/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230915091551.1459606-17-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230915091551.1459606-17-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230915091551.1459606-17-chaoyong.he@corigine.com", "date": "2023-09-15T09:15:40", "name": "[v3,16/27] net/nfp: refact the resource module", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "caf0472cc408896490da1b33b1d7d87f325afffb", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230915091551.1459606-17-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29520, "url": "http://patchwork.dpdk.org/api/series/29520/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29520", "date": "2023-09-15T09:15:24", "name": "refact the nfpcore module", "version": 3, "mbox": "http://patchwork.dpdk.org/series/29520/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131491/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131491/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7F7C3425A3;\n\tFri, 15 Sep 2023 11:18:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F0D9542D3F;\n\tFri, 15 Sep 2023 11:16:49 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2139.outbound.protection.outlook.com [40.107.237.139])\n by mails.dpdk.org (Postfix) with ESMTP id 2CF7742830\n for <dev@dpdk.org>; Fri, 15 Sep 2023 11:16:48 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by CO1PR13MB4773.namprd13.prod.outlook.com (2603:10b6:303:fb::6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep\n 2023 09:16:46 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::c05c:6915:1628:70c4]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::c05c:6915:1628:70c4%7]) with mapi id 15.20.6768.029; Fri, 15 Sep 2023\n 09:16:46 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WFSVNYiOKDzGUUD2+JF4ilb6G0npmyClwDvum79LN07NRdPeWmM8HSRrJnwZuR7VvjUljh5txGHSnS5PhAfurmkESAG8hy15d/DbRwkbgSngkGH17752on4UU4624uvzRo0KMwei6HghY2u/4trX3Pw6/5cRe6Cgtf3FfsFfgiuLHdFG6JoHo5wrssOB8wRi4M7RGrRTZiiVERaLJDH1se6rfoydKTOSpDsxlahZw6NsPdHFUNMym/Ca2LSk86993Vx7/7r6D0tZe8NoJWjEQEHQ0JeaMhkaaB2hJmIjohtseCmd/3KF8gFjHUnzGjKLL9BeAgGNuUy9N5LImJXN4w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ptn9ydJjsqic/wGlPp8i1tyd6DcpDIJXBUlOIsCv9ts=;\n b=KZRQG3/XGgh/3W3HFBFnLoZs+hBuYScU3Bc0TUHmQQNoVHx8w+reaGqX+ILbInoniV+IAQ3UELZBCI0jMp44uUiRCcWuo5Teih6lCbRx5UylzVZ4DpYwVo4Uv2eiMKjUo7bGb4UYzBCvSCnTpd5xJKx1kEoeD2FY2zANZkBejA+azB4bHE6g3b7QNSTdSwO+6xxc9yjkYa46K33AS2k2HQDvwSgkXd7zkmcrWZ+ybttN97bx+Tgs0hGS17Y+ld/JZpgPOZOLAFejo+zvLvI3IC3NejWDTstLpFNnvJXy70vDKn24JKyHucy4hf4X1Kciia9eA94PIxZUXn0gCkIa1A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ptn9ydJjsqic/wGlPp8i1tyd6DcpDIJXBUlOIsCv9ts=;\n b=UsjfCMkPt/3/kL17sywwgRtLrObg7FnBKgnBQNuqQLfOZsq2HH86/YQ2xX+OMv469vf+WuLLDwtwkTdPLP1q+vglU+WafYwT7SCh6f301Cybg4+YPU/rymdl5FYdNEBqr3dUHln8MT4u4yBi72Jk9ui7xtmWWPmvOCMzuvOQPLE=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n\t=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@corigine.com>", "Subject": "[PATCH v3 16/27] net/nfp: refact the resource module", "Date": "Fri, 15 Sep 2023 17:15:40 +0800", "Message-Id": "<20230915091551.1459606-17-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230915091551.1459606-1-chaoyong.he@corigine.com>", "References": "<20230830021457.2064750-1-chaoyong.he@corigine.com>\n <20230915091551.1459606-1-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "PH7PR10CA0017.namprd10.prod.outlook.com\n (2603:10b6:510:23d::10) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|CO1PR13MB4773:EE_", "X-MS-Office365-Filtering-Correlation-Id": "b3bcce25-c996-4770-9bf9-08dbb5cc7c30", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n +LVDwP4uokXNYnxjtAk2+IbbIUQdubZ8gTCvKjHZjAa7N0GSXk6ZY+/09FIDjJsumS/zKZBR/v/Cl9VaaGQijlg3BMt6B9CgurMVrPcMOuXkZRHCIZIuTVezIcptXGpmR9pkZPJH1wrDBS7ZO5gKIV9IAManUMJ4Ye0h/xtyjuzBHX3RHhtFtx9tL4I+MT28jVhEiL3bI6jucvpBfbSeH0yqGSkqRNb+PDdFxQbxPnhN6xfMFXGg88yevSzhHTcdfUBdooqscz5lyHG/iBLWVf6oQBTh3oReZfdOJ0NDofHe6VEKT9urKB7pzDPH0h1D/Xt3/UMLbdYhOUnbzFk+59qmAoF9uOtCwKWs9lIp+xOXFxFAjXghXcB0vJ3z/PTfT/fqJ6io/deP+7C3TYVlQUtcl7xeZvTiSgTUM1UCcfKtX40fd5Xu+6YpS4xMcAoGXA+9o+XVjJE6CNxo8q+b3IWgFLU8xnWbAZWOWhAFFa46jwfbutNKnah45uTtVZq91MADIAxi84Izo4TKz7f2Po3qHLHnHW776qgDgkQLMV0g+hcMmTXuPF5L0/YPfQlQV9R9iGOupTixXyUdEVCiAq6bYihUhKAMAUYFen34drwX3YVFEAASnUmAOI/XzOhEQZ4zqqfDPYxzKIuKYgC83QJbg3aw72EyLJrY9UpXTSk=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(39840400004)(346002)(136003)(376002)(396003)(366004)(451199024)(186009)(1800799009)(6512007)(107886003)(1076003)(2616005)(6666004)(52116002)(6506007)(6486002)(66946007)(26005)(316002)(41300700001)(66476007)(66556008)(6916009)(54906003)(5660300002)(4326008)(8676002)(38350700002)(8936002)(38100700002)(478600001)(83380400001)(36756003)(44832011)(86362001)(2906002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?NyvJuP7/ZiOiEnze8/DP1Iv2mPZS?=\n\t=?utf-8?q?AnCV91X+SMCqgw62AbhIco5HN4GkgFzsRel37WDpm4bcqMiwd1AK4SfdQ6vkDhRfC?=\n\t=?utf-8?q?a6IlarNzA4RHp4rUcBuDERt1pyboNNzbEZHG5r7F6DBTOsiFFtlZyd/NoOhcCidBJ?=\n\t=?utf-8?q?SlsQunw6s5HCwk/MGBDuvv8viNxa09phOOesuV71qbw+WugP+GTzwPQAlnuDg6q8T?=\n\t=?utf-8?q?bDuKHcIqkbi1uzD5sbe7SAOV5OhQu8tII3E1zeTHjzw5SViRWEsQBL809JajZDD3C?=\n\t=?utf-8?q?zk1NAYKijWeiDDkXJ0hQ1/iCtK2Znqil2yhi0wJqy/cGO9Swh/a1N+zq0YKEhSBL2?=\n\t=?utf-8?q?DrDZMyzYpc96ezgpC4TMhwm3Dr3fb/I8tqcZ/7Z3YhdfdHOaSAW0CZtsGXQq32gcd?=\n\t=?utf-8?q?1O3/IJX/fq4f/8ABaPEgdl5WG3GyvurR0P9zHzVTYcRItRcrCeUsBBQ1Uh3mV6cBX?=\n\t=?utf-8?q?qkvU073F4xgEaStJbDHxmBJYupx2hwqcPXBGNdj03+Sz6oIZKoGpFuzhdBFNf9OmJ?=\n\t=?utf-8?q?IgqghCVbltCZJcHmNrH/9/LU/YGi4HCAsyFlCV9n2QfTYEhh9NADab8zhKtXYIrw9?=\n\t=?utf-8?q?jokeOrJBLzLNCbxV88TyRnNYM9HgIcQbakvxZk4bN/zUx2nBvIJ3TDVMkpwyXFKWL?=\n\t=?utf-8?q?7fOcV/aci5gCxXjzvdqbLQCulloyGc+pRgMl1iByC6sa1bOQ8x4WY0oiHg0cu9N28?=\n\t=?utf-8?q?0bZfGO4a+3r1DxBULgzhyYjSfewnxnXqJYw2eIFoCbXX0TAkPhJ8DDMdtvKf+TiCK?=\n\t=?utf-8?q?0Y4mekQRly4O5lvbsR1rYfvpWZHoCoam5Kf1ZmF9Ln+/SYix/X2JTkB0gNVrB+gcA?=\n\t=?utf-8?q?/WPrrTYtdV5O25RUHKB2naXlnc0zxRGaqHQlsdoHjaIzFNitS98YeUbR1KRn4f6eR?=\n\t=?utf-8?q?xxjYGra24Ad4KXAtMihUml6ja8pENBAasodFPs5RbFTKgNENlussFzKf/kKWxq9Xd?=\n\t=?utf-8?q?ts2JDIkdko8HDyi5AvECa6SxZ6Ko9Obzye6nck605lLILiFt1uOkeUtn/S2XKflIM?=\n\t=?utf-8?q?g8308UdzYHdPus/yAzqDV4f4v7fejI3PRUUpsoTAFP2Djdg2qpGdxqe3jGs3nz8Lx?=\n\t=?utf-8?q?U7CM+Lc1VywZoIpTrjjm4+h0MJbDmdkUdfocfuaNFhb76UY5Y606grLNRl5RIAdFJ?=\n\t=?utf-8?q?QQpjkVwExN+kS6hoK0sQ8lNv7RnCRSSDS07ZCJ/n+h7d5SemxE38Shk3cn7ul9erb?=\n\t=?utf-8?q?nYdUSbNsR73rBMNUThXzem63c3RhN0f6GXGLvfUkRkI0Soy3dBphjCaGvYR4+Gwwb?=\n\t=?utf-8?q?mgHMPQ3DB5QHfneDJ2SWC6WOPdWUmLMlk3afRJDtmJJymchpgmsA3l9bEopNg6KBo?=\n\t=?utf-8?q?ODAghMkCpte/vzDXkqX6JOcdVDHDI2abIXIC21Ot2/az85Ml2+MBvPfermoEZYxeg?=\n\t=?utf-8?q?I7upY+Adj3pXvBZdI3iwAh9Dn/Q6MC/hUCtMBu3bbSbIwAnMCk/nw3w9or+kXke1B?=\n\t=?utf-8?q?geec9mI03jT/TIrRBxCh1bNhFVIjt3JK0+P0fYUQ8AGhc/22E7X6v/2W247kk+YXK?=\n\t=?utf-8?q?feRW2kdthqqRpbgo7GYIMtE0zm/rEl+UBA=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b3bcce25-c996-4770-9bf9-08dbb5cc7c30", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "15 Sep 2023 09:16:46.7572 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n ad0zGR9xQcs6ykQtPSnQj4HhhTbRmpNR5yty4XvzyUSuqyCB9qBn77qfiH3926CHufoxFO4GG/zRyfzlHCaQcjUFaitbdpM6LH/gAW48W9o=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CO1PR13MB4773", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Sync the logic from kernel driver and remove the unneeded header\nfile include statements.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp_resource.c | 21 ++++++++-------------\n 1 file changed, 8 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_resource.c b/drivers/net/nfp/nfpcore/nfp_resource.c\nindex e7e232eb4e..e4a3a42eea 100644\n--- a/drivers/net/nfp/nfpcore/nfp_resource.c\n+++ b/drivers/net/nfp/nfpcore/nfp_resource.c\n@@ -3,15 +3,11 @@\n * All rights reserved.\n */\n \n-#include <stdio.h>\n-#include <time.h>\n-#include <endian.h>\n+#include \"nfp_resource.h\"\n \n-#include \"nfp_cpp.h\"\n+#include \"nfp_crc.h\"\n #include \"nfp_logs.h\"\n #include \"nfp6000/nfp6000.h\"\n-#include \"nfp_resource.h\"\n-#include \"nfp_crc.h\"\n \n #define NFP_RESOURCE_TBL_TARGET NFP_CPP_TARGET_MU\n #define NFP_RESOURCE_TBL_BASE 0x8100000000ULL\n@@ -43,7 +39,7 @@ struct nfp_resource_entry {\n };\n \n #define NFP_RESOURCE_TBL_SIZE 4096\n-#define NFP_RESOURCE_TBL_ENTRIES (int)(NFP_RESOURCE_TBL_SIZE / \\\n+#define NFP_RESOURCE_TBL_ENTRIES (NFP_RESOURCE_TBL_SIZE / \\\n \t\t\t\t\tsizeof(struct nfp_resource_entry))\n \n struct nfp_resource {\n@@ -173,8 +169,7 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \t\t\tNFP_RESOURCE_TBL_BASE, NFP_RESOURCE_TBL_KEY);\n \tif (dev_mutex == NULL) {\n \t\tPMD_DRV_LOG(ERR, \"RESOURCE - CPP mutex alloc failed\");\n-\t\trte_free(res);\n-\t\treturn NULL;\n+\t\tgoto err_free;\n \t}\n \n \twait.tv_sec = 0;\n@@ -186,13 +181,12 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \t\t\tbreak;\n \t\tif (err != -EBUSY) {\n \t\t\tPMD_DRV_LOG(ERR, \"RESOURCE - try acquire failed\");\n-\t\t\tgoto err_free;\n+\t\t\tgoto mutex_free;\n \t\t}\n \n \t\tif (count++ > 1000) { /* 1ms * 1000 = 1s */\n \t\t\tPMD_DRV_LOG(ERR, \"Error: resource %s timed out\", name);\n-\t\t\terr = -EBUSY;\n-\t\t\tgoto err_free;\n+\t\t\tgoto mutex_free;\n \t\t}\n \n \t\tnanosleep(&wait, NULL);\n@@ -202,8 +196,9 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \n \treturn res;\n \n-err_free:\n+mutex_free:\n \tnfp_cpp_mutex_free(dev_mutex);\n+err_free:\n \trte_free(res);\n \treturn NULL;\n }\n", "prefixes": [ "v3", "16/27" ] }