Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131607/?format=api
{ "id": 131607, "url": "http://patchwork.dpdk.org/api/patches/131607/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230919095440.45445-21-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230919095440.45445-21-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230919095440.45445-21-chaoyong.he@corigine.com", "date": "2023-09-19T09:54:34", "name": "[v5,20/26] net/nfp: rename data field to sync with kernel driver", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e9c703efbbc941eac56ce7df76732680cd1491c9", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230919095440.45445-21-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29547, "url": "http://patchwork.dpdk.org/api/series/29547/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29547", "date": "2023-09-19T09:54:14", "name": "refact the nfpcore module", "version": 5, "mbox": "http://patchwork.dpdk.org/series/29547/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131607/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E61B942600;\n\tTue, 19 Sep 2023 11:57:07 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E7E2440EDC;\n\tTue, 19 Sep 2023 11:55:59 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2132.outbound.protection.outlook.com [40.107.243.132])\n by mails.dpdk.org (Postfix) with ESMTP id 90E5140E68\n for <dev@dpdk.org>; Tue, 19 Sep 2023 11:55:54 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MW5PR13MB5877.namprd13.prod.outlook.com (2603:10b6:303:1c7::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 19 Sep\n 2023 09:55:52 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd%6]) with mapi id 15.20.6792.026; Tue, 19 Sep 2023\n 09:55:52 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FIiS4Q4GSthZLdWtuiQT2kPRRi1AYMiwqz3HAUoFExOj2gKq3HPgJmwY1sP8qNHA8H6OLCQrH80hOxrUFHO0o1dVKqP9mlK1p4I1L5OKAm2+XFDF43rclu5FfdSsmZljJ8lFtGMRtDcWbX63QGBYnrfAfn2A+cTUNR+rGWD6qi23CoV6vO+j6p7MRlVPDPJuiXfz1ozaVmt63ZLxEpMFp2t3x9EzC7lZYn9tl7pLDmxTmLke2z0DWer9ESx57vZ2TkprtWYnVPuiVLmqdeZFHOzy0PZHCpByUg59whqmSlr3I2rN4WfLlfMPuknxuU3f5SeFNOGTqcb09SSlnqPrtA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=v/eTxtoUG0oHUmRiirfkE0AitwfrH8EautNNlmCSLGU=;\n b=igLqOKHPEPAvFrXN68K+QrW4GQaNJAH8ZTNs2pTPQ5Pzto2R/tIwxkOUMXgH2Ec69LkMIKJuvE4St4gdacaFpt1XkoO5bTw4MO4dleIINLwmXdypBS6gwUZLUFd3C9XLE1y7xkCK2koP7mgQgSSb3ZSge+6HAHmzZZ5zEcrhwdDGc+TxZfmfOU9hX/7XHkce1BvThlf+7laFLzbYxm038QseNs2mMcDICeKsEadKdtto1mItksZYkBHvCWtT7GhnGzjGZyhdrhqaQo3FJFG0bWjEE0Cwqrl2f4UtzQAJCfyMzXMbOjicA1yhW7XD61N8iFj7lN4lZ8g2aVrd9V05Xw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=v/eTxtoUG0oHUmRiirfkE0AitwfrH8EautNNlmCSLGU=;\n b=Rcb/TJOxZpHF60Az28b/acWepc6ZRW/QUl4UQ2SOm/6TkhagR2v05DObcdxmlT/6IPiRGDP1o7YNaAqKKeGfzNj6wYK5/QM6upFWs6Ke8656AQnNbWgEqHT2eJ5rgMIvjjKhrFWSLGFgTmpTNQgaPdK0IgWD1R4eSL8JKYxP4EM=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com,\n\tChaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v5 20/26] net/nfp: rename data field to sync with kernel\n driver", "Date": "Tue, 19 Sep 2023 17:54:34 +0800", "Message-Id": "<20230919095440.45445-21-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230919095440.45445-1-chaoyong.he@corigine.com>", "References": "<20230918024612.1600536-1-chaoyong.he@corigine.com>\n <20230919095440.45445-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BY5PR04CA0014.namprd04.prod.outlook.com\n (2603:10b6:a03:1d0::24) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MW5PR13MB5877:EE_", "X-MS-Office365-Filtering-Correlation-Id": "ad628aaf-0028-47da-a04c-08dbb8f69c02", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n kNLxRpb3QOpRnr40+Jqn6IdnVIkZwURVjnwQvt6zB+HfEiE1/B0Md7pNxaj4E0VX3JfmnaDVdWqE2cwqX7FueLEL1WMOAzh2n1yKWNdEpZ7D8T+Am271o99olQu2XeOOGLOmkX6yj3wkgNCJFmKLl/3w96SwptalRXq5fU3bGR+hxG3L9HxbH9Q3FjOlGyq8uLhLCSe/iMrDxedyJrd42XyrtZZcwstqp+R5zWIVS90Fk29W/wVIz7fiNAzAyIeQWprSU8Np7CpREDp0oY/omAeGl7prrE5ju4+89ZTPbZ7fakAVaAPqeo6ffv82rTCr/YAj2FyJ+u5p2CAGfPozthYsmLvW1S3H0ItZwj0Jnh6vyRmIe1SwxJCT0EPaYVsYOIrkH0kPDYW82iv7NWhYJR6aiQ/63fx65ozXKB8xfBwal1P/80VlWfTGdxzw4UUHeJAA4ueUblg0auKeJiZuINAzmTexsQCEV4j/8He3QRmBSspi4D5eMocbtT8p1shdKDFqxDGtUJjTdDmWhGgTefDViBWbjTixgJmMWBf8NdiNjxsWvndt77VrxcTCtOPaAEMaaknUEtr0K7bB0lnmPwA5ud5oSbDP+UuVVXKdh4auAL2gcHd7gATfnzYaYRw6QuFQN5kp7RwLQlO+naDxq+a04A5KUphHIpkxwMBu7KQ=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(346002)(136003)(396003)(39840400004)(366004)(376002)(186009)(451199024)(1800799009)(6506007)(6486002)(6666004)(52116002)(86362001)(36756003)(38350700002)(38100700002)(2616005)(1076003)(107886003)(26005)(2906002)(6512007)(478600001)(83380400001)(8676002)(5660300002)(4326008)(41300700001)(8936002)(44832011)(66946007)(66556008)(66476007)(6916009)(316002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n Wbjz75Ora3UkDLcvtkyRRsJN0H+HPirclLY5xlXcCwAjsaYA3sQ6Ep8wIvHrzwqXCVTATWsENhWiRCEZSkZNY2KaLNVpBMxlDzV8/9ny+KgfPccPZSopvuJDNc5QAhKxe64sD1O4pxRAWgJCjhZMmNCjyNYcpI0dbIO2T6oSEsPCFTsCQgf9z1h4RNI1MjgMUVRcFcB5xZLJnp9l478FBwgvjXF7sQ2HAfXnHqrXshZJp7EbrfDhTZPvL8WFSyTTYaRIQZ7gyDkk+iaQljwXAzyhrgIb+P2TNbQz18TteGF0SRSRJ3ZPYT5eu61nwBHhwOnsV5/IZjPclgadgoTZ6eoSBNa5C/d91lU9r81oYFTAf8OmB+akor0hsJNxUtFdEKtbj9lIB1de5xiWJn2RPEoVEGegoe4+xh0JEMWWM/IuiWeeHc3V2JHiEhUvKZypny49DVvaK15Q9yScSosxo/OEw2IjCMniEkW1NLfGnU+xrotjChZpONsw40lPfghZ/+9L07MWj0gPrpwc2rEWkI9bqs1geLKS23D7Hdn8pLXEkM3PLjBTCgodad43DlqQDzmIyWZNsttZh5jaKwOVWBKSL8AKLTwz1MftbM26ZY2wzGZxFyNWZ4cYn5hJ5TFjLoEr/yXEvzaB6Sm4yAM/DDsSW8dXQ6pzOVLBw7KDKR7rVptpMztbBFRwPe5Eyg2AXhBHhhKCiKvgn+gPjipycMGABXCRCzM1dV7XGwoMa1IojWI+pi68YOWoxrJHj7QstfEqgSWHVjlSfIY3bF5Ib4HMag+wZM3aYD91A7Qj+TZGx4mbdW5U+fqhS1AUKc20cPrmqJkWqg3myhvGazDoVTmzV/HkM83Sq5y1NM1yzvIqUuXip731AbNSXcbiSKYr4XOz/cUqY8g+M6chWcgOgj80eif6r3sBc8OnOUk94i/5P0eGM9e6wPQXnCOhqiuPy+libkkI0t4uHor8TTUAs20WYwiJZzMazvjtrOYuscFGSd5JuBAHkUeSbLI/rSRgwUtlP6CROdYlbYfCN2VdUu3/MugaG73B4+BYVdNUgMKRESoZ/dGFJ2AdKj8R7q0txFkQAL5mo0qVYqa8Vs+zhiyjV5mU/qAImijr4mvCSNKwbBkES2ro5/cwttf6ftIO4eavSFWy8zO24Ki+FDbGesLHbYcxXXuo3m+Dk4vzpoPKUVqIzUA48zLoNlpfnFOxMbFRVRgRMc/auMY79LVoGaGYUEO7NPFFYm2+KC3KGDYUabSZNS3kvycgwyFWrTCtrnuZmP+/a4+k6tNmXV36N7VqKRvGzuNpRJbJN4xWKux8No16vEZ/0tOjbs0AGSdU1pdT8sLAWG4x3/rgueedCLu6a8T1INE98naNqiW/Yf0bjiHb+c7YMYz6kbt5EXKEOluuUQ1QourZgaUHH3UXo0IvljONSgJaui+XCxtNJnKiOb0EbjgDajTsLgQKctNfvrnG3GPHD/vnrwVKjHqoCk2ty9u4S2+hMrwuouLcdbPWlMuC7I1aRykXz++99rENvEuqx4RnaBNHHD4aJpCBaAGSYw2yfZYbWDBkPP0W0J67S+oQCroCFUhndGByRWFlF6wVM4mkjXhHZZ++44d3mw==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ad628aaf-0028-47da-a04c-08dbb8f69c02", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Sep 2023 09:55:52.4694 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 3Ys46NfdnLhPreRc4ST2GqS9SmxuPsTAzhiq+/DYez+1iOoU0pqbFwVY/UNszd5rhAZyquVHe8sdPVM7DMNjunr78PJUN+fZfiO8NDxGVI0=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW5PR13MB5877", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rename the data fields to sync with the logic in kernel driver.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower.c | 6 +++---\n drivers/net/nfp/nfp_common.h | 4 ++--\n drivers/net/nfp/nfp_ethdev.c | 16 ++++++++--------\n 3 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c\nindex 77dab864f3..fead917599 100644\n--- a/drivers/net/nfp/flower/nfp_flower.c\n+++ b/drivers/net/nfp/flower/nfp_flower.c\n@@ -224,7 +224,7 @@ nfp_flower_pf_close(struct rte_eth_dev *dev)\n \t/* Now it is safe to free all PF resources */\n \tPMD_DRV_LOG(INFO, \"Freeing PF resources\");\n \tnfp_cpp_area_free(pf_dev->ctrl_area);\n-\tnfp_cpp_area_free(pf_dev->hwqueues_area);\n+\tnfp_cpp_area_free(pf_dev->qc_area);\n \tfree(pf_dev->hwinfo);\n \tfree(pf_dev->sym_tbl);\n \tnfp_cpp_free(pf_dev->cpp);\n@@ -360,8 +360,8 @@ nfp_flower_init_vnic_common(struct nfp_net_hw *hw, const char *vnic_type)\n \tstart_q = nn_cfg_readl(hw, NFP_NET_CFG_START_RXQ);\n \trx_bar_off = (uint64_t)start_q * NFP_QCP_QUEUE_ADDR_SZ;\n \n-\thw->tx_bar = pf_dev->hw_queues + tx_bar_off;\n-\thw->rx_bar = pf_dev->hw_queues + rx_bar_off;\n+\thw->tx_bar = pf_dev->qc_bar + tx_bar_off;\n+\thw->rx_bar = pf_dev->qc_bar + rx_bar_off;\n \n \t/* Set the current MTU to the maximum supported */\n \thw->mtu = hw->max_mtu;\ndiff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex 1ce51d44d4..86c4e10040 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -123,9 +123,9 @@ struct nfp_pf_dev {\n \n \tstruct nfp_cpp *cpp;\n \tstruct nfp_cpp_area *ctrl_area;\n-\tstruct nfp_cpp_area *hwqueues_area;\n+\tstruct nfp_cpp_area *qc_area;\n \n-\tuint8_t *hw_queues;\n+\tuint8_t *qc_bar;\n \n \tstruct nfp_hwinfo *hwinfo;\n \tstruct nfp_rtsym_table *sym_tbl;\ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex efb47c5d56..899d4dd253 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -311,7 +311,7 @@ nfp_net_close(struct rte_eth_dev *dev)\n \t/* Now it is safe to free all PF resources */\n \tPMD_INIT_LOG(INFO, \"Freeing PF resources\");\n \tnfp_cpp_area_free(pf_dev->ctrl_area);\n-\tnfp_cpp_area_free(pf_dev->hwqueues_area);\n+\tnfp_cpp_area_free(pf_dev->qc_area);\n \tfree(pf_dev->hwinfo);\n \tfree(pf_dev->sym_tbl);\n \tnfp_cpp_free(pf_dev->cpp);\n@@ -593,8 +593,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \tPMD_INIT_LOG(DEBUG, \"tx_bar_off: 0x%\" PRIx64 \"\", tx_bar_off);\n \tPMD_INIT_LOG(DEBUG, \"rx_bar_off: 0x%\" PRIx64 \"\", rx_bar_off);\n \n-\thw->tx_bar = pf_dev->hw_queues + tx_bar_off;\n-\thw->rx_bar = pf_dev->hw_queues + rx_bar_off;\n+\thw->tx_bar = pf_dev->qc_bar + tx_bar_off;\n+\thw->rx_bar = pf_dev->qc_bar + rx_bar_off;\n \teth_dev->data->dev_private = hw;\n \n \tPMD_INIT_LOG(DEBUG, \"ctrl_bar: %p, tx_bar: %p, rx_bar: %p\",\n@@ -995,16 +995,16 @@ nfp_pf_init(struct rte_pci_device *pci_dev)\n \t}\n \n \tcpp_id = NFP_CPP_ISLAND_ID(0, NFP_CPP_ACTION_RW, 0, 0);\n-\tpf_dev->hw_queues = nfp_cpp_map_area(pf_dev->cpp, cpp_id,\n+\tpf_dev->qc_bar = nfp_cpp_map_area(pf_dev->cpp, cpp_id,\n \t\t\taddr, NFP_QCP_QUEUE_AREA_SZ,\n-\t\t\t&pf_dev->hwqueues_area);\n-\tif (pf_dev->hw_queues == NULL) {\n+\t\t\t&pf_dev->qc_area);\n+\tif (pf_dev->qc_bar == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"nfp_rtsym_map fails for net.qc\");\n \t\tret = -EIO;\n \t\tgoto pf_cleanup;\n \t}\n \n-\tPMD_INIT_LOG(DEBUG, \"tx/rx bar address: 0x%p\", pf_dev->hw_queues);\n+\tPMD_INIT_LOG(DEBUG, \"qc_bar address: 0x%p\", pf_dev->qc_bar);\n \n \t/*\n \t * PF initialization has been done at this point. Call app specific\n@@ -1041,7 +1041,7 @@ nfp_pf_init(struct rte_pci_device *pci_dev)\n \treturn 0;\n \n hwqueues_cleanup:\n-\tnfp_cpp_area_free(pf_dev->hwqueues_area);\n+\tnfp_cpp_area_free(pf_dev->qc_area);\n pf_cleanup:\n \trte_free(pf_dev);\n sym_tbl_cleanup:\n", "prefixes": [ "v5", "20/26" ] }