Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131715/?format=api
{ "id": 131715, "url": "http://patchwork.dpdk.org/api/patches/131715/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230920113454.739356-6-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230920113454.739356-6-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230920113454.739356-6-chaoyong.he@corigine.com", "date": "2023-09-20T11:34:46", "name": "[05/13] net/nfp: improve modularazation of common module", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94acc24b3d0323bbd50f16a6df5fb5eb245a5dc2", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230920113454.739356-6-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29570, "url": "http://patchwork.dpdk.org/api/series/29570/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29570", "date": "2023-09-20T11:34:42", "name": "improve the modularization of NFP PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29570/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131715/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A61D425EF;\n\tWed, 20 Sep 2023 13:35:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A5A0842D0C;\n\tWed, 20 Sep 2023 13:35:31 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2133.outbound.protection.outlook.com [40.107.92.133])\n by mails.dpdk.org (Postfix) with ESMTP id 3860C427E1\n for <dev@dpdk.org>; Wed, 20 Sep 2023 13:35:30 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MN2PR13MB4039.namprd13.prod.outlook.com (2603:10b6:208:269::24)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Wed, 20 Sep\n 2023 11:35:28 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd%6]) with mapi id 15.20.6792.026; Wed, 20 Sep 2023\n 11:35:28 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=W8IUDuCo5Puiz31t4uGeUTHWEQGYwjY8ID/OckuHDZGNDFqtyd+5hVVamA+RN+xpy2xhd6G1VVvKG260/wdeu0l90VNumtJr4/SXP/jTd1iaSdTj24J9OEERacLfRXCrsR1qaXUn+UsjYkvBXWZzCS6WHW4rSBMfCI7GVpUqidDvVy64io6p23kUGD67grLwpDFFeTxK1hk/gV0kaf27V+MDbe6bnSpj5TbHnmqA+cpTGixmad7FZIoVGMwYRhiuSMN2bDC+m27NzpdmijvRy0+/kVxNkLtMyu2TeOV74UnuFHJN0NCqQf9A6uIbcLbF8ViakkPdEns6MzN40ERQGg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=0Ts6ThuuNoGuQf8b1bPots5ls1XZjqnFknMDteBKZ38=;\n b=m4km5rxHhAcoWJg5l7lJ5CqL6G6O5JPc719cwApUveAVMrq0begXLu4hAG7erB8WqqG8MxhycFIf+H7LlLQtEILGfA3R0C5vnw6esXup8qd2oS19XU6Fiw4hr5GSVIziFNtRfHa1IXQSNIU6YjVSHV1iIFp4C+7NT9DK1E39eEJKh7gQImT/1StLJsQRpGRBSkY4TrnlEYUbdU1lrWn4s9X8c5val/uQgCK1/M9nsw5q/7BQGxvwCBILFzQ+p8CPIcTDAoJ9xhVT/4ybtN1RTJs05NVARpxhImRPZk4PnFyQR/S9c7veA5qo+bZq9OwPW4/KZ/GcYr8+z3gmNFG2mQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=0Ts6ThuuNoGuQf8b1bPots5ls1XZjqnFknMDteBKZ38=;\n b=bEj5Rk001+1bRFHK/FrnmatEJztid379kUceVkTHvx9GZa24IOpZ7+Iuw0RCUpEJGiQI/Or5uy+g52MGJsNmo8xRR4U1ye8tYmNsQm2mVFc7w4TKJpOfTX7iVoj1bTy1E7EqR1G6DoOgWfmvL38Oq5Lc+hgxaq6LYyKeyUPBxwU=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com,\n\tChaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH 05/13] net/nfp: improve modularazation of common module", "Date": "Wed, 20 Sep 2023 19:34:46 +0800", "Message-Id": "<20230920113454.739356-6-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230920113454.739356-1-chaoyong.he@corigine.com>", "References": "<20230920113454.739356-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SL2P216CA0113.KORP216.PROD.OUTLOOK.COM (2603:1096:101::10)\n To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MN2PR13MB4039:EE_", "X-MS-Office365-Filtering-Correlation-Id": "b07d25d1-3304-4a80-ae3c-08dbb9cdb02a", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ilTAGq1oHpzu5TNJAZEDmjj4QgD3x/emaozJ+0hHDam4mhxA6ybcs4s1rdyAApCXYvASziA42YwrEu8wTJFUcMcAlSB4KWFbFuyPfwrl6ib/p0qyq88OEf2iILOUGEvxNFjVMJYlIN8mgBwhSi6TOcWMSypQU5IVH83Uhw3OIvuK9jHfmURm0eqLAakQNw6E8nYS+lO93Kw/V9QawZM2PgG9zc7GFVwVDYrFB4Emw0h0jHQwKVOu1/gZeOeva7TAGs0yaR9bkGpROU21o0H2ckpw6aRS1cild8DA3uJ3Ff31zPg8giT854R16LR5M9/7i7xAOkRA/2LfGXSXgUpmLZXwQuh/B/b+kPgvluDNWLIirq8mdjdQXhUGS7mtra7arH6e9Kp5erc+hr2NamWwaeIP/UTcCxgPHZGn76X3wakTUnZWY5fq92B0CqIYcDAuoYvJK7l7yQVZ5j+xab1BTvgIHlNNRaBnL5VK5zqV1j32wy+W+4WKX1CvnxNZ3jca0oXYSEmhUAZhYYxU/QRX4QYYjGBloIUpKysStH4HlW1PqTjKH2D8w/oZjw3JCgGjEH6g7kSP/Vy6C2JO3qN3CilRlwDg7CvshMzpMHhWyfv+UnYTIAg1p7FQYrTm9wdcEepH/0ZueDMHxSiwC9wvHxFDsLCUwBF6DH/CtyiNkeA=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(376002)(346002)(396003)(366004)(136003)(39830400003)(186009)(1800799009)(451199024)(6666004)(6512007)(52116002)(6506007)(6486002)(86362001)(41300700001)(66476007)(6916009)(66946007)(66556008)(316002)(478600001)(38100700002)(38350700002)(107886003)(8676002)(1076003)(8936002)(4326008)(36756003)(26005)(5660300002)(44832011)(83380400001)(2616005)(2906002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 42j5exZ8tmwfBUjH/EERMAMRERhTT1l3mjTOaUJQ8UzvKAar8lzq7P0qsGsxeWo21IRY18bWZGVz1JeFfrhE2lmQ3fRAAqYV8Lx3Hx4hJT+dSY204eHi7oLSNXAIjSZy3SYQ9QTuHsHVpAyBKc2EGSmDhqvQY61yJpJa+KddiHV+qe6alJC9Wzbjdw663LvANOimV2iFszClPeXpKKb9OtWHiTxdCNd9RiPOtYM5bPzAbvsJUn37U2NhBYJX94FPifaztMvdYb/5fXWAYkNqQ3x4K5simVUREJF6Iilign9fAi0Pw2+twNL5cpCpiu8n2+LTidZFJHRlDo2FiRYKBCtAaoUhbSnny1aC54JS3pJmezIrOFR5eBD4+rSs23ShxhKKdfYUpHec7T60jxb9UNqXHEJvrkTA4oVjrax1ZpB6ZQdwcrhrmAXO9B1XQGb6oir/h0LmAb7SvfMd7CkePsYyeDWm7Y59thCOC23MzSZzXiYRdOWFuSUOk+SyZy2CNOEXaZ46HRlGTp78hGoTj8RDXRPcv+Bxn3Z9prl0VdPWERdbHJjqLXaLSMbLm42AyOKPlpCAaLamQjrLHbCrfEBJVc0kbcBuoi5UtacunnUvCoOBJoDYT/W4fKZ0Kwt9A5CoeKxYokklnWIGr6tPChOK1vmve+9ie6H/W0PYmdeq/+/vJvUo8/Mj+cLfRUp5yPNGmiASJ5QejaQV+YjHRTvFCY5INiYNdCXn1dScOuVbB56ITc/Bc8bcrR7dj3p3LriwWZ4tLfHhIVf2kQ2InKhItxpe4mOnIVQk58ZBONnLII6axEza2FYxL7UVqopb2XsYifxmNQ1xfpO6VjotweU5jdRnaG1vRkVbzqLp245vHWxuzoVPosZhbEPP1oKm7zKWRlTddknA4oFIDdv2MciaYKgPksCIiUHtOCRXUmIDzwDS5Okj1rCo5ox/9+XiGi4HXtq2fTFA56xJ8QBvOZmoR8rI7alodb9ZaTc2h5zPk1Ud12thk12//we1CG0Lbc7bpGWjHqK/gBWH6vyPwaQnoM8/w2bhaPrXnc+R2WKOA9G7RB68ps7P6o29dHLc6FmCW20RiEBOd1ED+LEcJu3G6ORiqxhJ+fYMWqIQLGXCA/oqcjrmN6ycV685MHwBsWY+aGLVHllXxJxsbvIz8VlSz/0ADinCU8Zwc9AnX9XtB8wDzFlBqn2BLhzij8vgb6PdcPTs97lO4xpdfo5NqM848enbXjXGCTNTfv5leMsXCFZtgVZy69YAMVZC7tiX6+yqkeKoXYifi8baChN+dT1aqQwxTdJSkz3ClxMKCrYtAtgIHZ4yDVLvRTPoZKV3FN0aEJo4NxocsgDNHTYuUEo+wfAMYq/yGx8Kqipr0mnO2o9fSPRmm4y1Lv7hUv6tofKRbZHEhhyg5MT2x2tAIcsFb7qdQsGr3jM0dcR7AparFh1Q1GIYDZFRoUfF+UVuGgUMgKnu39h4ZvovRuA7dBal08CXuHrac5D3rJPfx35GF87sj/viAM2xqa9wQuRo0NB6JmUEpQCW8+HvPxjJnqznimQBjKYyTg3ZdQIZSKCabkaC4MYxDrjOdhuCpawVV30G3Gnvd9Vy1nSkoNL0Vw==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b07d25d1-3304-4a80-ae3c-08dbb9cdb02a", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Sep 2023 11:35:28.0668 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 8Ccl4uj2//emWpeZOwYdn1DSmvgkZS7KVJGL/WYmU50amSOE2Rl1Kokr5NmPMMlgL+tf3wFLBhj9DOdeSqAaSCR5R1LAi0ydezsjLh21kM8=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR13MB4039", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Make the header file self-containing by adding the correct include\nstatement.\nTry to keep the API small by move the logic which need not expose from\nheader file to source file verbatim and remove the unused macro.\nAlso remove the unneeded header file include statement of source file.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/nfp_common.c | 51 +++++++++++++-----------------------\n drivers/net/nfp/nfp_common.h | 34 ++++--------------------\n 2 files changed, 23 insertions(+), 62 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c\nindex 160df27c94..40027dbdfc 100644\n--- a/drivers/net/nfp/nfp_common.c\n+++ b/drivers/net/nfp/nfp_common.c\n@@ -5,47 +5,32 @@\n * Small portions derived from code Copyright(c) 2010-2015 Intel Corporation.\n */\n \n-#include <rte_byteorder.h>\n-#include <rte_common.h>\n-#include <rte_log.h>\n-#include <rte_debug.h>\n-#include <ethdev_driver.h>\n-#include <ethdev_pci.h>\n-#include <dev_driver.h>\n-#include <rte_ether.h>\n-#include <rte_malloc.h>\n-#include <rte_memzone.h>\n-#include <rte_mempool.h>\n-#include <rte_version.h>\n+#include \"nfp_common.h\"\n+\n #include <rte_alarm.h>\n-#include <rte_spinlock.h>\n-#include <rte_service_component.h>\n \n-#include \"nfpcore/nfp_cpp.h\"\n-#include \"nfpcore/nfp_nffw.h\"\n-#include \"nfpcore/nfp_hwinfo.h\"\n+#include \"flower/nfp_flower_representor.h\"\n+#include \"nfd3/nfp_nfd3.h\"\n+#include \"nfdk/nfp_nfdk.h\"\n #include \"nfpcore/nfp_mip.h\"\n-#include \"nfpcore/nfp_rtsym.h\"\n #include \"nfpcore/nfp_nsp.h\"\n+#include \"nfp_logs.h\"\n \n-#include \"flower/nfp_flower_representor.h\"\n+#define NFP_TX_MAX_SEG UINT8_MAX\n+#define NFP_TX_MAX_MTU_SEG 8\n \n-#include \"nfp_common.h\"\n-#include \"nfp_ctrl.h\"\n-#include \"nfp_rxtx.h\"\n-#include \"nfp_logs.h\"\n-#include \"nfp_cpp_bridge.h\"\n+/*\n+ * This is used by the reconfig protocol. It sets the maximum time waiting in\n+ * milliseconds before a reconfig timeout happens.\n+ */\n+#define NFP_NET_POLL_TIMEOUT 5000\n \n-#include \"nfd3/nfp_nfd3.h\"\n-#include \"nfdk/nfp_nfdk.h\"\n+#define NFP_NET_LINK_DOWN_CHECK_TIMEOUT 4000 /* ms */\n+#define NFP_NET_LINK_UP_CHECK_TIMEOUT 1000 /* ms */\n \n-#include <stdint.h>\n-#include <sys/types.h>\n-#include <sys/socket.h>\n-#include <sys/un.h>\n-#include <unistd.h>\n-#include <stdio.h>\n-#include <sys/ioctl.h>\n+/* Maximum supported NFP frame size (MTU + layer 2 headers) */\n+#define NFP_FRAME_SIZE_MAX 10048\n+#define DEFAULT_FLBUF_SIZE 9216\n \n enum nfp_xstat_group {\n \tNFP_XSTAT_GROUP_NET,\ndiff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex 36ad4e1d32..b0372c3dc6 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -6,22 +6,14 @@\n #ifndef _NFP_COMMON_H_\n #define _NFP_COMMON_H_\n \n+#include <bus_pci_driver.h>\n+#include <ethdev_driver.h>\n+#include <rte_io.h>\n+#include <rte_spinlock.h>\n+\n #include \"nfp_ctrl.h\"\n #include \"nfpcore/nfp_dev.h\"\n \n-#define NFP_NET_PMD_VERSION \"0.1\"\n-\n-/* Forward declaration */\n-struct nfp_net_adapter;\n-\n-#define NFP_TX_MAX_SEG UINT8_MAX\n-#define NFP_TX_MAX_MTU_SEG 8\n-\n-/* Bar allocation */\n-#define NFP_NET_CRTL_BAR 0\n-#define NFP_NET_TX_BAR 2\n-#define NFP_NET_RX_BAR 2\n-\n /* Macros for accessing the Queue Controller Peripheral 'CSRs' */\n #define NFP_QCP_QUEUE_OFF(_x) ((_x) * 0x800)\n #define NFP_QCP_QUEUE_ADD_RPTR 0x0000\n@@ -50,27 +42,11 @@ struct nfp_net_adapter;\n /* Alignment for dma zones */\n #define NFP_MEMZONE_ALIGN\t128\n \n-/*\n- * This is used by the reconfig protocol. It sets the maximum time waiting in\n- * milliseconds before a reconfig timeout happens.\n- */\n-#define NFP_NET_POLL_TIMEOUT 5000\n-\n #define NFP_QCP_QUEUE_ADDR_SZ (0x800)\n \n-#define NFP_NET_LINK_DOWN_CHECK_TIMEOUT 4000 /* ms */\n-#define NFP_NET_LINK_UP_CHECK_TIMEOUT 1000 /* ms */\n-\n /* Number of supported physical ports */\n #define NFP_MAX_PHYPORTS\t12\n \n-/* Maximum supported NFP frame size (MTU + layer 2 headers) */\n-#define NFP_FRAME_SIZE_MAX\t10048\n-#define DEFAULT_FLBUF_SIZE 9216\n-\n-#include <linux/types.h>\n-#include <rte_io.h>\n-\n /* Firmware application ID's */\n enum nfp_app_fw_id {\n \tNFP_APP_FW_CORE_NIC = 0x1,\n", "prefixes": [ "05/13" ] }