Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131718/?format=api
{ "id": 131718, "url": "http://patchwork.dpdk.org/api/patches/131718/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230920113454.739356-8-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230920113454.739356-8-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230920113454.739356-8-chaoyong.he@corigine.com", "date": "2023-09-20T11:34:48", "name": "[07/13] net/nfp: improve modularazation of flower representor module", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ce745b858be0970a47100804a4d622d3b75fa34e", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230920113454.739356-8-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29570, "url": "http://patchwork.dpdk.org/api/series/29570/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29570", "date": "2023-09-20T11:34:42", "name": "improve the modularization of NFP PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29570/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131718/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89AE8425EF;\n\tWed, 20 Sep 2023 13:36:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3601A42D76;\n\tWed, 20 Sep 2023 13:35:39 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2114.outbound.protection.outlook.com [40.107.92.114])\n by mails.dpdk.org (Postfix) with ESMTP id CCBD7427E8\n for <dev@dpdk.org>; Wed, 20 Sep 2023 13:35:33 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MN2PR13MB4039.namprd13.prod.outlook.com (2603:10b6:208:269::24)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Wed, 20 Sep\n 2023 11:35:32 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd%6]) with mapi id 15.20.6792.026; Wed, 20 Sep 2023\n 11:35:32 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=nLrorXmPEgt17sSaDhglVPzqUr/Jh7nfAH5v4GgK9gDQByjRP9/Y98TRaANl/JL8h03rAO6NXKy4oaRDc5Eku7vs6XXfkT/uyvylXrtLCvbhZzrpFla37spB/cewVYukCOiu214A+cwBv02JOJ/ErrXsXSmQ3hp3UKtnfSaqCVN8vtbUlNY8Joh52CY4wo6MLn9yE454lR3BjTSMA2y9bvYn13cptJJgv8f2kR7zsMZ6DEcmmbIU262FNM68ISwJD4BWMatTUlAtSzrOCmUbQVjNSWNZBsShtTVgwmarEaiM8U17Mah7++qcblAQPL+mVo63wik0DYozCgF0XCoBHw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=V8JXDK9Huul/qUrgMCPIBER2gZ6NRCn3D+LbdSUAK20=;\n b=WYePllWoFYctS8am6fNDY7A/zVe1DpkGGgaSGQKmglBEWb1laDezb4AMSc0T7Mhs/0EWXJ9QvT+eMJqRFgIMmN+f23C2C22InpmtiQd5XnLW9jyctWINedSDExRs+Fd3uIdsHZS06yXCygHydoiFFTOEPtaGynICPl0Mr9j29E+Bv4waCiQeS2lp3VX21YZehSeQ1h7/NW6Z0Hq/xLOvN6J1ObKpVq33h9rcxw12OT9JHCzYbNyX0fUHFsvqC6fVK+NLeWZtJ0y1tO8srpZAgjG8IsBRTt0QJ7ALZ48egZGxgk8MQ55waLke7KFPjuhUO+bjInvlcgFUNwHFAVZEMw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=V8JXDK9Huul/qUrgMCPIBER2gZ6NRCn3D+LbdSUAK20=;\n b=W7UIIyeLl8GpJn4k5ZAPFx4Egk7SdgA122oy+yumm74op1RmhS+y9cxeB1iYiY4oPg2oBLSqUNqSMqD5YSuGxXFksEZgLioLCZChCh6kYqeja3zkBcreCXFkABjcWz8a3+fPkoOTNhO1U5f0U+BorkgdgnANYJh8oLHcX2Zs1FA=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com,\n\tChaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH 07/13] net/nfp: improve modularazation of flower representor\n module", "Date": "Wed, 20 Sep 2023 19:34:48 +0800", "Message-Id": "<20230920113454.739356-8-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230920113454.739356-1-chaoyong.he@corigine.com>", "References": "<20230920113454.739356-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SL2P216CA0113.KORP216.PROD.OUTLOOK.COM (2603:1096:101::10)\n To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MN2PR13MB4039:EE_", "X-MS-Office365-Filtering-Correlation-Id": "043b9d35-db07-4710-5ddd-08dbb9cdb2a2", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 7qYx2aRwZz0hb53UmulVjrSsGAZXLZJdde9QLMyRQxGDVw0LvHDeKjhasrHXeWHyopOriLASBjrX95jvAwZsSJ2rXPhLHEP9IEXmK4rbKSa8VxLrK0niFuaj+CKWrLwxj3TNd3UJCplTpj/qyUkaUv7MX6VkVYOVoWLsTqBtR9Sy2deW7X2//sY1+F7WZy6tXUgXAf8nmWWQBelI7rAFc5D0WqZZzWw6P2ug4Cy/6LqIdUgyIh5VT1SVP11htdLlH/yjDiaGhyVEJdxqxw7oBOAPJbvu7vfI1WWyYstk5BEOe87tmAXgnbuitodwhAeSE3FHJA/+FksDLBb9x4el4yGS/TaXfvIfhP/SEJiel2B/1m8Bxw4WOPb2zga5EQIP0B55I4pRlEVrb9+uQNHwKrCNZNPCA+aBqkXQOPl0NoUX8GUsQnSUbA1hADe/uuxcCinT7D/qBN0RanpxrSzEHWUy2bDIQhVryAwltQK9h2MNsyO4cjR78689acY+8eG9BUpadlgOI+0XVxugpVSN1WJIzhpVILAu+M8TDAKyYC2j1DtaBkLhAEShmUEv77r23EGZBrm2tP1AuO4bngzWv0CoeQE8tJvDVvYopE8AbIkvahxGM05w2AF2vecIJosBT3fSOh1Z1MCMYTRKklorTc2cWKCfDNXo57SAiWmkpAg=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(376002)(346002)(396003)(366004)(136003)(39830400003)(186009)(1800799009)(451199024)(6666004)(6512007)(52116002)(6506007)(6486002)(86362001)(41300700001)(66476007)(6916009)(66946007)(66556008)(316002)(478600001)(38100700002)(38350700002)(107886003)(8676002)(1076003)(8936002)(4326008)(36756003)(26005)(5660300002)(44832011)(83380400001)(2616005)(2906002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n pbaEy5PAKolN2lyPCBTXdNYpBWH6GqnUl9iK4c++kQ9JPQXH4HJOVW7avST5FavWpX8fxeW+prlRgoPzbTXjjGguMymPvQ/GG8GsRKcJuao+5AwBIsvyO9JQxv5vqa+YWx276gVxu+tMvDJVEcuJjOOj9+PXKxi13mCE/4IRCrpv86uH3Vx0HWauXtu75/rl58Mz2UtuJV1IMorwWIvcbkTquKJQD48RwP5sTx4ACS7lVh+WdmVrB1EC9eGIvtRtfvwP61owWApoaEfP7i9/uP0hvsE5YoJH6TkPkvQCHQtlu10HoWCEmY4YqcpUoMSIQa9o9fWg0mQ3dmLE9DVgrbB3kkF5vB6ZTaHIYj3tcrWrVRRXsUGvx4bDdrFPKdhikrD/+XK+M0HM/e1vujKhlokTw6tkT7x243T6QFFgrcMYc+AV2L3171O7VDUNt2qcuLtWyQ/PbZlBxJr+/e8g9H/xnma0b0atFFvwk0YtPPL60DMGxaV7kgQGYQT6SUQG5W0LmpKClh3rvSqfqlyVV8DryhAQH1K7+IX7PIKYS0EEoBn9uM2zkVpqWtAgcuZ2qflj/zNE9WxXAEdbTgpTaIuoHrh6ls5DjgUHKGEC5FZIc7/JbKbrK6c/NJOcnGqDoOHSUYmJpkR0y12769YFI2vcqYQn3iL75vHxKMvyhdDRutucSqnoEtU13ssXsfeZr72+imxJbf/Var/yDlCfkV5tSOYpOrQJhLLABaj4Hdu+yEla++MtZGDWZrVbyQ6fi9iFQojEqblXjCZg923dtdSa8ESFm6+GW8iQxZGQ1EyRdOFEDFdXkRoy85Ae30XG7e5yruATv4GJaMBzbY8QfN38Q023LTPM1Ad39spwL+HBjMSZMERIIyhZ9w7B3ItxFm2jpTBkroJqVw6FBivyknQaXjFlH8Btn1SUcudvcnh0QvZTjJxxQ0Td16d9q2hSlJ/e3MOTGkS4YP33oQTvEBqKIe0P2uU+BR1t/Lz6z6Vyy1CoETzDytYZ7cCbjyTdxQAnPuAo9LP8gBIYRivmKuYDqukKiS9ntfIbw86E2/P0mL7PfnRbbc1l098OP1FJa217HOmnZY6yqb3h5duS8BcSujbSt+JuFkBtFE7SI4xIlfDJOo8Kg5HrOZkUwZkFXxciR6F2OQz7Hw/E4chydF80JcISqEK5lB2Y/yk0miQ4kvFvovi+CZxqdjRM0SfKzXhuaaoH1f51t6+DCOasHidVx75SnMK7UCPhD1gMiU1ohwYi4h6f0QqjthHVVL30LMR0EoIFI912N9MBTo9kACRy1w0Tj096e8LnRqn5IOHJxKY8KjMHbJ+KvoD2i1ny6gIy0/MZCfeXlZISGLbP0IzCUk2zRbZ7oHXMXiROHYjcdUeFAAKkt639isw+awbVTFAH468rfWzAzMuL3WlUDkwPR304Yjppcz1vm5VfilhJBNj4X00oCJ/PkhUu+hDoJPBXzB0RHORfnWKYKJlTsJexJ+5rnHEhRVq65aEIroQyYdb4sjBjJkmkz9iT8btaqFLv68m1U7c9OwvXBFA4Sl39P2w42WsraC1fbnTatF/pPmz7OMIH0XGnZHLgOI3TB4dy7+5X3DjyLyK4FjucIw==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 043b9d35-db07-4710-5ddd-08dbb9cdb2a2", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Sep 2023 11:35:32.2033 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n iadLqssA2sgLU4OYncdo9f4tSSLsp7U4064KFvZQLRVsyIdH96L/1tYlVPS3yG4+OnuT78lFp3zJMzAx+ghPtdh0ICvehANKjhwptmkMGJU=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR13MB4039", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Try to keep the API small by move the logic which need not expose from\nheader file to source file verbatim.\nAlso remove the unneeded header file include statement of source file.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n .../net/nfp/flower/nfp_flower_representor.c | 29 ++++++++++++-------\n .../net/nfp/flower/nfp_flower_representor.h | 14 ---------\n 2 files changed, 18 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c\nindex 48c3b3f844..d4df88fb73 100644\n--- a/drivers/net/nfp/flower/nfp_flower_representor.c\n+++ b/drivers/net/nfp/flower/nfp_flower_representor.c\n@@ -3,22 +3,29 @@\n * All rights reserved.\n */\n \n-#include <rte_common.h>\n-#include <ethdev_pci.h>\n+#include \"nfp_flower_representor.h\"\n \n-#include \"../nfp_common.h\"\n-#include \"../nfp_logs.h\"\n-#include \"../nfp_ctrl.h\"\n-#include \"../nfp_rxtx.h\"\n #include \"../nfd3/nfp_nfd3.h\"\n-#include \"../nfpcore/nfp_mip.h\"\n-#include \"../nfpcore/nfp_rtsym.h\"\n #include \"../nfpcore/nfp_nsp.h\"\n-#include \"nfp_flower.h\"\n-#include \"nfp_flower_representor.h\"\n-#include \"nfp_flower_ctrl.h\"\n+#include \"../nfp_flow.h\"\n+#include \"../nfp_logs.h\"\n+#include \"../nfp_mtr.h\"\n #include \"nfp_flower_cmsg.h\"\n \n+/*\n+ * enum nfp_repr_type - type of representor\n+ * @NFP_REPR_TYPE_PHYS_PORT: external NIC port\n+ * @NFP_REPR_TYPE_PF: physical function\n+ * @NFP_REPR_TYPE_VF: virtual function\n+ * @NFP_REPR_TYPE_MAX: number of representor types\n+ */\n+enum nfp_repr_type {\n+\tNFP_REPR_TYPE_PHYS_PORT,\n+\tNFP_REPR_TYPE_PF,\n+\tNFP_REPR_TYPE_VF,\n+\tNFP_REPR_TYPE_MAX,\n+};\n+\n static int\n nfp_pf_repr_rx_queue_setup(struct rte_eth_dev *dev,\n \t\tuint16_t queue_idx,\ndiff --git a/drivers/net/nfp/flower/nfp_flower_representor.h b/drivers/net/nfp/flower/nfp_flower_representor.h\nindex 685cbe46b4..5ac5e38186 100644\n--- a/drivers/net/nfp/flower/nfp_flower_representor.h\n+++ b/drivers/net/nfp/flower/nfp_flower_representor.h\n@@ -8,20 +8,6 @@\n \n #include \"nfp_flower.h\"\n \n-/*\n- * enum nfp_repr_type - type of representor\n- * @NFP_REPR_TYPE_PHYS_PORT: external NIC port\n- * @NFP_REPR_TYPE_PF: physical function\n- * @NFP_REPR_TYPE_VF: virtual function\n- * @NFP_REPR_TYPE_MAX: number of representor types\n- */\n-enum nfp_repr_type {\n-\tNFP_REPR_TYPE_PHYS_PORT = 0,\n-\tNFP_REPR_TYPE_PF,\n-\tNFP_REPR_TYPE_VF,\n-\tNFP_REPR_TYPE_MAX,\n-};\n-\n struct nfp_flower_representor {\n \tuint16_t vf_id;\n \tuint16_t switch_domain_id;\n", "prefixes": [ "07/13" ] }