Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131723/?format=api
{ "id": 131723, "url": "http://patchwork.dpdk.org/api/patches/131723/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230920113454.739356-13-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230920113454.739356-13-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230920113454.739356-13-chaoyong.he@corigine.com", "date": "2023-09-20T11:34:53", "name": "[12/13] net/nfp: improve modularazation of CPP bridge module", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3c97dbacb56861adca05b1191702c5efd19c9d9b", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230920113454.739356-13-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29570, "url": "http://patchwork.dpdk.org/api/series/29570/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29570", "date": "2023-09-20T11:34:42", "name": "improve the modularization of NFP PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29570/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131723/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131723/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 053B6425EF;\n\tWed, 20 Sep 2023 13:37:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D5B8842DCD;\n\tWed, 20 Sep 2023 13:35:46 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2100.outbound.protection.outlook.com [40.107.92.100])\n by mails.dpdk.org (Postfix) with ESMTP id EEC0F42DB4\n for <dev@dpdk.org>; Wed, 20 Sep 2023 13:35:43 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MN2PR13MB4039.namprd13.prod.outlook.com (2603:10b6:208:269::24)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Wed, 20 Sep\n 2023 11:35:42 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd%6]) with mapi id 15.20.6792.026; Wed, 20 Sep 2023\n 11:35:42 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Dajqhn06p0EoOqvJJwTU/aZK2MRXcl8w0vST2k4x3duk5CVvQEQVCPy1yps1cWBDooLs/gf9MbcxfN0kaZjSWYSbken8zADuNj7SJBZ5WXmhyW4vYMA8f786vQW4zk9+9zIWsdxw7wKrD89FhJVXjXO24zyMH2zDDB2gRbAsnk4esVEryM9uK8uY91UAa9tmrhNqVw3xLn4rCEDhdG2P+24EHoeHgKVLAJhgzGO3jlO0U+OMWyp6ts9rVqDn0I9Zmdqz3iLyLGuW+8z5Bt5XQspshsKkWHpyhhgLjvB5nE99Mdc1KtJK9ORz/schhH6EwKMlzgzaYshI23ANDjaZXg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=xfB8RhlvXxqTbZjyyo/iX9zJXmlX9lA5aBV8PPInrGo=;\n b=Jj3LIjwzooxgitbEl/sHGV+USAa9zoA9Ixz4mXu9W+s4J1b0TW7cPLjQxq1ZWaDUNfdUYqsg6NR+GvzaXfdMjjvG58y8NHdqnwy28eNKWsTAoVnc0b5e3GUIJVl1Z6MEyd26vV+HDACUfuGcaBxqV8/0Qzh2qnChGJoErE0kHE58hfvBDeLaRrwHHtNV75jnBeIPnVOY1eaEVduc+sVM50To4wPzMNhSW5CUlpbMCak8Tdm2Ul4bVcxrKYXRRJ/uXHHfWoae7MGKRKWZhTLbaE5rDp3g/6bgOFSBOFs+oiYkmPG37Yl0PgqmOPFe4F94Xq6YVI+FGI/gMMvzkQR3jA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xfB8RhlvXxqTbZjyyo/iX9zJXmlX9lA5aBV8PPInrGo=;\n b=DNpqjO4mILELBuIdsgr5leLPJkaaeeth4jvSGbfRniSEeR9i99OpmuZDtZ/gomav2LRAlpuMsBx+bcHruV7bV/l8K4xDjReBWKxSkd/cvRstVAvSt3c7kL79AOc/G0J3tL09jnmyVLDazEIU3D5vYxZVsj+mD0MHNcVzzrU8KRU=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com,\n\tChaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH 12/13] net/nfp: improve modularazation of CPP bridge module", "Date": "Wed, 20 Sep 2023 19:34:53 +0800", "Message-Id": "<20230920113454.739356-13-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230920113454.739356-1-chaoyong.he@corigine.com>", "References": "<20230920113454.739356-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SL2P216CA0113.KORP216.PROD.OUTLOOK.COM (2603:1096:101::10)\n To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MN2PR13MB4039:EE_", "X-MS-Office365-Filtering-Correlation-Id": "7cc2e688-6a67-4668-ba1b-08dbb9cdb87d", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n jg2jhPZp+WFUAsOlybi7Ay8e51nzLM+fgQx5sabjya3oGz7+Bj6IQRKKwH5BYuv1c4qi0Plpc6QQ7Q2ykfOtmeKTcmBPM7czkdRCzFarEEO+Y3nAriwA2eXchZICd9Xb3R6OsumCqw30BR4HxdwT5zDmYeJPpTaeb8762mN2C0MNnlSqcH4GYQa7ot6hc7AlQjpGFokREhL/IuGC7T/3rXF6ps1iNGxCKybi+EAnrsdntvBBtMOJyATRFeS39qL8ShQFionm2iOOcVat+rROHn7IJeJhPgPZcSxIB0HDzaU1LX69n8iRUZhVUAEt4acBK6owMkeijQKmO04m9BpYOkrkN8WQfz72QLHzwPTeERMRhll1owkL3jFl/czbZDSyKWX+0sIe2Kpc9/B8HTqU0C1GOmx/TZsYBxx4XKQ3lvNKxhtTq5XgVsXia+laeB/dKm18Nexz0L9Vejv5D8UqF58v1bw4w/HOilFyh1xp92zn9VcSspYoFJfTHJxUz42HY1FeX83gIwUWB1o3r/EJKYvZnl5xcZzzngXGqmbNs6J8HC4s4p9iA+cJ3t0213MVK/SYaH5BWiwqNCJx7jo8fTgoCzXy7lZ8ngmiL8Zl/UvoXXb943lBn4Xpp5UH0x5iWsI+WVVy1YS7E+uEXCp7B8Fm6H1WGk6BypEtWEJEgpw=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(39840400004)(376002)(346002)(396003)(366004)(136003)(186009)(1800799009)(451199024)(6666004)(6512007)(52116002)(6506007)(6486002)(86362001)(41300700001)(66476007)(6916009)(66946007)(66556008)(316002)(478600001)(38100700002)(38350700002)(107886003)(8676002)(1076003)(8936002)(4326008)(36756003)(26005)(5660300002)(44832011)(83380400001)(2616005)(2906002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n hrbFkGZhnSERt5MKFYPTS+R0lsH7R4OuKE26AXUjWzHG3Wphl9LtihDVMb6fKgfDaxBCvvEiW9R9xtwxWYJ/wnn2XHs0xTmwfKbnN2LM0W5mmm9K8Yjt8/tqMmzi6IQsrY5myM1lnParPh4eGTK+iCbCsQT+3347AqfJ7hSSuTlwcEg9Hi666kkhrzWYRuH1OCr5u6y3ETWMznJDnV3fNw8RonvH9L5BIgq0DGp/YyxipI7O38iYwbq3t8mkoXFZhs8ry0yxnDdG0BM1nKDqZjxy8P1bh/cGraJKFbCvBct9vnNog7iyn9JpnFBgLTamJqB/AJomNrXAKT7tgSZpEmV52jHGim1BL317S1KcG2tae60/IOmk+sp2u2MM0NAo/BC6YNLs/XzHu0fKLPD7XFio/twHCz2M0jRWgnsd1LE+3kOu2PpRXUbyDwEDgAv7pDmJTo0ICLRUnM66q48gsrQ+tspn/WAX/iOw/DLjVAgM1J1Etyi6fY8dCwBjkKl5caRUhr4/aaaffnGgwm3q+ZYN3DeV0mXBNRFMbpQpxwe41pTz5WVQzCVJz25BBm2iTn4PBtbF/c5l7M3wLXVEiH3R52ookIh6ts1qfU8/D/XSQVprP3d6KWpamv0l1rPfLEhUFPdMk9cL4IxRaR5uip4JPbzrYWT6Jro7VT9t/Dnx/N823iL9U98VUDFPj88XIMVJX5SQLluR5cv84Qsmu5qkyY1b1yo7qnt09F2K8jL6MelocCvnOfIU8kIfHf/OF5lQ+q40UFBwC5Af/HVIK+5UdxL4oDh46LKSP+SUah2IAiE9lfAePozzjf9AsBV1gRPqsXF/YKTaFycUQLYTwEmAEFpHdawnaAlgyzwtutGytlusbD1izm42VC5CGkJjDtECYVlWkmPJ9rLq2YdhYqfcE8NzeOrO09Pgkv1LJnrYW1RuTRKr+6A43wFjJHONPegD3SOxVoc39FZxXQQmK1lfTswHsTJkmmqUsMaFnO/pbAJPB+qOglqFaLj1U4jN4Pbe3FLzX3O1dHy4iOurZYYwK8Fz45OqqIvOLPa/0jiqsjuDYHM0hHxK0fnbsDjoB7KvWsyUBFRmcGsY81YKdzleEyhN6IxA+5Fz5gaqJh//h4mvZa4OB2ggoR2aT7ACDsLgk76PcZsFtg7QEh2nMk1X0wcswZSj8QR2v/e/IxdsxA3BwrggGisBqgm92Y7tBU2DV7sdeWf7pNBQ9JA/YABZAjtJnHbyfxmY5NU7ujmSHycZ6LVEUeIiEugU5YeF5jhQH1RPaMuku3Ult0Z9BV6uR9HA/RNBfslszZi/CncfsbLeoxtDmHjl2Hpw7/tbUG4ElyANLlQ0qcvdVEoNzOp8ZzrYEl1QN+L6Z6LFK4N5mWIR5WX29u/1qlSrOMhR0suIqzTzzZsaoVOATrQH7EsZrWQ/gm4bOBYUgYOu3My1a5zN98zkKwJxDby4K5bSKRsOWaooeInmmisIBLnIbriBsXfsCOAmZCo+yZ4ea0j82+/t2/6Yws+GRWlRqfOu9ksIKeEJ61rd7MashQccOoSU3iOmU9jUwgMRmt2oU46sqaaNwY4X4rVK7WlTzH2Hkvfp8+PLaHSLV3CascIxoA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7cc2e688-6a67-4668-ba1b-08dbb9cdb87d", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Sep 2023 11:35:41.9918 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 14WZjiSbGyx7obWLEr9Y71MDWQkTwBumLJT7e0fXzCPyltYhChrnwSv0o/BFa1wJfoFtOdLlyJo3GWctxAk7aTwFw5qzNhoC2yUcnDd4Y5k=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR13MB4039", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Try to keep the API small by move the logic which need not expose from\nheader file to source file verbatim.\nAlso remove the unneeded header file include statement of source file.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/nfp_cpp_bridge.c | 14 ++++++++++----\n drivers/net/nfp/nfp_cpp_bridge.h | 8 --------\n 2 files changed, 10 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_cpp_bridge.c b/drivers/net/nfp/nfp_cpp_bridge.c\nindex a9998f3c08..ed9a946b0c 100644\n--- a/drivers/net/nfp/nfp_cpp_bridge.c\n+++ b/drivers/net/nfp/nfp_cpp_bridge.c\n@@ -5,17 +5,23 @@\n * Small portions derived from code Copyright(c) 2010-2015 Intel Corporation.\n */\n \n+#include \"nfp_cpp_bridge.h\"\n+\n #include <unistd.h>\n #include <sys/ioctl.h>\n \n #include <rte_service_component.h>\n \n #include \"nfpcore/nfp_cpp.h\"\n-#include \"nfpcore/nfp_mip.h\"\n-#include \"nfpcore/nfp_nsp.h\"\n-\n #include \"nfp_logs.h\"\n-#include \"nfp_cpp_bridge.h\"\n+\n+#define NFP_CPP_MEMIO_BOUNDARY (1 << 20)\n+#define NFP_BRIDGE_OP_READ 20\n+#define NFP_BRIDGE_OP_WRITE 30\n+#define NFP_BRIDGE_OP_IOCTL 40\n+\n+#define NFP_IOCTL 'n'\n+#define NFP_IOCTL_CPP_IDENTIFICATION _IOW(NFP_IOCTL, 0x8f, uint32_t)\n \n /* Prototypes */\n static int nfp_cpp_bridge_serve_write(int sockfd, struct nfp_cpp *cpp);\ndiff --git a/drivers/net/nfp/nfp_cpp_bridge.h b/drivers/net/nfp/nfp_cpp_bridge.h\nindex 85289e158b..e6a957a090 100644\n--- a/drivers/net/nfp/nfp_cpp_bridge.h\n+++ b/drivers/net/nfp/nfp_cpp_bridge.h\n@@ -10,14 +10,6 @@\n \n #include \"nfp_common.h\"\n \n-#define NFP_CPP_MEMIO_BOUNDARY\t(1 << 20)\n-#define NFP_BRIDGE_OP_READ\t20\n-#define NFP_BRIDGE_OP_WRITE\t30\n-#define NFP_BRIDGE_OP_IOCTL\t40\n-\n-#define NFP_IOCTL 'n'\n-#define NFP_IOCTL_CPP_IDENTIFICATION _IOW(NFP_IOCTL, 0x8f, uint32_t)\n-\n int nfp_enable_cpp_service(struct nfp_pf_dev *pf_dev);\n int nfp_map_service(uint32_t service_id);\n \n", "prefixes": [ "12/13" ] }