Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131734/?format=api
{ "id": 131734, "url": "http://patchwork.dpdk.org/api/patches/131734/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230920133403.6420-7-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230920133403.6420-7-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230920133403.6420-7-hemant.agrawal@nxp.com", "date": "2023-09-20T13:33:56", "name": "[v2,06/13] crypto/dpaax_sec: set the authdata in non-auth case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c5f1b9c5b5a7de95999a82ab92241f3e28801e50", "submitter": { "id": 477, "url": "http://patchwork.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230920133403.6420-7-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 29574, "url": "http://patchwork.dpdk.org/api/series/29574/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29574", "date": "2023-09-20T13:33:50", "name": "crypto/dpaax_sec: misc enhancements", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29574/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131734/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131734/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 209DE425EA;\n\tWed, 20 Sep 2023 15:35:12 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E8E8142DB0;\n\tWed, 20 Sep 2023 15:34:33 +0200 (CEST)", "from EUR03-DBA-obe.outbound.protection.outlook.com\n (mail-dbaeur03on2049.outbound.protection.outlook.com [40.107.104.49])\n by mails.dpdk.org (Postfix) with ESMTP id 8513E42DA3\n for <dev@dpdk.org>; Wed, 20 Sep 2023 15:34:30 +0200 (CEST)", "from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15)\n by AS8PR04MB7606.eurprd04.prod.outlook.com (2603:10a6:20b:23e::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Wed, 20 Sep\n 2023 13:34:29 +0000", "from PAXPR04MB9328.eurprd04.prod.outlook.com\n ([fe80::450d:89ac:4f6a:6ae2]) by PAXPR04MB9328.eurprd04.prod.outlook.com\n ([fe80::450d:89ac:4f6a:6ae2%4]) with mapi id 15.20.6792.021; Wed, 20 Sep 2023\n 13:34:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=SV67yvCa6lyGQmmv6BiNMLtmuauDzHNqbYy5Jlkmig471gVCY1kjkIoL3Tnv33Jy/iOR14pAwt85nIO5CTrGhxHIwTY0qEG7FnES3ekLd6Apts3pl8yJ0xxeGQs/TSnlTkkyIpAT0becDQV9NC046PFnjqTP6It4OSWEOwbN8ZVV1VpCSCWYHLzfPMpu7b9Y3epaIUwKMDv5b9A9FFiVJ5PlXYoXwaFsFq+mWK9UmQ2BCTAtRaD5ihoxCVCV3sJKBP4T2hqVVp6ItRAJ+eB9PpmP7QmdCbDXtfG/wDf6/ZcGR/y7DsdqC1rNT29OEHodPQx3ax+lS08nzRxvS7CTQQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=B36xNyvXbkZGEYliOP7+MXeBqZ0FnAsviCM7OZ2u0Rs=;\n b=APZGaCEcs6BdGUWTeLEFjk9waDlXtGQ9K9yJh5sbTaKYVJt7uRCKhBbY/MM9rlNrIL59EIEjCgnP2lAIgMFqoonQ+LVwocC8JqhOpRbnu3WT5/3ETvvx2ZY1874axulkaVmWilcKIhPpHDTQCTKy0fQn81AZYq3fbZzXFA5CGmhezGKxbueFmhweUln2WX2aytyyvv0OvE6EN9MsBmDTRjNOMwFUglrL9VuuYgUNdqIHHtE/yaSvsimJcpOVft5RlHhraBf2JBKZUpEOuCKKxbrB2rfH7crTYRn05nCWcqlBPscAPwjM+iQ+tFZX1UaWRFgx1ovBBbwcYmBgCKg2ow==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=B36xNyvXbkZGEYliOP7+MXeBqZ0FnAsviCM7OZ2u0Rs=;\n b=H41vItDDyBd7+rmpUpJ33ieqwO9bIRLP0AF2hA7NJfGz/3BajIGoUYs9pRkYMp8IICstpqIIhBTQtRmlaOsvDtbkOx+tcizf680yzONlT/tQSU3JygT+rL1uj52eM6p1gTxF/DZ2FKTV3LJi1C7ERoU/Dy37L5QYy0U3PKAVggg=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "gakhil@marvell.com", "Cc": "dev@dpdk.org,\n\tGagandeep Singh <g.singh@nxp.com>", "Subject": "[PATCH v2 06/13] crypto/dpaax_sec: set the authdata in non-auth case", "Date": "Wed, 20 Sep 2023 19:03:56 +0530", "Message-Id": "<20230920133403.6420-7-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230920133403.6420-1-hemant.agrawal@nxp.com>", "References": "<20230823070855.27532-1-hemant.agrawal@nxp.com>\n <20230920133403.6420-1-hemant.agrawal@nxp.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI2PR01CA0015.apcprd01.prod.exchangelabs.com\n (2603:1096:4:191::15) To PAXPR04MB9328.eurprd04.prod.outlook.com\n (2603:10a6:102:2b6::15)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PAXPR04MB9328:EE_|AS8PR04MB7606:EE_", "X-MS-Office365-Filtering-Correlation-Id": "d555aa60-afcd-47a8-6f29-08dbb9de50df", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n gR1Z4PQf2HX1TyO42E3EsdeVZycBcX73lFgcBX5TZGdidlZ2IvlakAlNvCNzS4FuWL1f5R25qNWQnOoGhiQIFau/OWm9enG++sZrsaVF+8L3s5R6vm061QT2p6J94DKFDnV3qLjwf4In0N+fzlu339S78GRCxVJ5lEWilZNHrhg8iGmXI57W/X0B94LMQjVbB3KQG7PP+yf5ZMZOgUbqqsruStJirI1YV6vhI4hnu+qkww67qShd8Dzel+nKKFXLRwodJ+RS/edCQAZSuH3w1WiPqwmTiFjsDTDvPYmwX3jSvNI46kSlnJHuk9WjV1EzGtWFZtEYoz6VHKL8LU+z9M4tE6giSo3EhVv1ipkn28iD00YipFM9AyMp1DRI1wxPxlnd8Wa3yeTe8oOgNMVbhYBLqOvIvLu/9D9JgyiNnwqGyMrRsrzAk8a22a/xILIZxFv41yNj8ZgICCeCCbsgB4JGvxichepY0hqyUG4rFah0XFJcI5AxfYL5/NuLDeIWeQ7akZGwW/++b6wlqD2+i4Oezjt4uCCjGrW6v61AaQuKwciPb77MyfB0HVUnBhPZZbVW5ksjpogG5XtN1N+KMC37p17wBTe+x0VrYwHl0PvDsXtgjADLLu/u2sTG0Zt2", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199024)(186009)(1800799009)(6506007)(52116002)(6666004)(6512007)(478600001)(26005)(6486002)(4326008)(2616005)(41300700001)(5660300002)(2906002)(66946007)(66476007)(66556008)(8676002)(83380400001)(8936002)(6916009)(44832011)(316002)(1076003)(86362001)(36756003)(38100700002)(38350700002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n FLsJ5qZJyGHyhHU4LnJX5xu2mV/P59iyq36rGz/oJlUILNpXFN5pLKE89+/ig1jlnT1LE6e8jOaU8XM6qMDzi0v0Buwv0hVhoz1P4aaDpacIR3+j5lkweIFWHzT2T0ZmivqR8+Lxl+fpDjoC1BRH+ipR4RuFaejMWouBvEU0Z1ICYG4hviEwL/5VHI6igBQaHCjheFVshgJGSeVMN+gZeEw/e5+obBFbsVMWb2Pcll1Cj72+QlMUgCOeOGE9fKjaqr16lxe1OG/SV7MG/JnZDnl+JBj3S8Jub+CwhKXThc8fCbfqiQ+ROruCA9/pTPxkOOPzNlsX6/e2axroBYImRVZo7/PVxIscwRTuBepFt458vRwRKFan3grJvYRnx+fb+FGZv2C0yLGYoP6k5Os9zv2XxhlVBVDTE3PLrncdcg7WaIirx3gsfKpmgaTw8emedUHhaCcW53NjoTsPAo3pq8YsSBVtf0S4GQBmohRVmh0ZJI99viSdiazQbwH7hn21IPTJ34mH7IofmJZ+tTD7Brkt+FmtpAsr/EigugM9iSrltspkAhVL8XcgMEt05q26/+YnX2JsSoPEp4S9EwJuF33EnUnZrjAprguSFlr/GO+R8qbH1X/dFkcnogUUb59V713AtFrYpCKUutZiVeXkMLNnJu5zqV+r6xCGOcUtn6/Oi0IYALBJLoAgzUM28URsJruEkw6Nc7POcgivdJe0sdhZ7fne0nNZSKnXhCdZS5TSXRdFhx62zoQsxbv+LEqnXJdWthKsvIv/xI2mM7wbeRgLyvhqM8WTqItQMaXIchKqDscpK2Iho9EB7zg+BahNiQdJtHzAo6XjqCjZMnblWBGzvBL4VxUHGY/vqWAgZi26O8QDCrCHhBHtHTvrRx/10JpYwmXTuhNMOcpaLCDV/uoYHQDDBkrdqoxX8fVXWQnNEiF3T7V2ambbsDQnceDJPmV3Q7cTSRX3fLyMthBMO7YEtDOTyxxgpDVIys0AdHywqeBDl6k71mZ96vthacNh+0tLHq4jPpQc9BrMxkytPzd3Zjx7UFAJueTrXNc2kAOi6gLSPzMXOuDF27KivK8zmtfnm8dJGFsITP/nPUvEvhT3SwXPRPPFoz+Pa4QBmkZGFcFcJ4fhJRb4k4imC2pR4cXDesg24KTPon0VYwKyZtW1Z7KT2lmm9lbybro0ED4J92+XeeO4zZUU5+3WEDszoztqf+qjMA/E/dLj3YIcE0Wm+WY0mHtJQtsAWuNY0FbS1GdaMrCO8AyzLGL+gNkTz1jKvTtUlXrwZNMJhC1WXgVejD/xyL+hGh8ItJOpi7Bs5otOJcRs4tKvExdRVOzAUep/3mukA4oP1oTMBS5ajtoxVqmmtxnr8Lr4DwXMGe9cniPYEG8uxizr57DUHtSrp8NfGAi5EmHTSeetWB0HPDqK5l6UfqIGCBlU1Y299VAdk54I2XDocND1M2jmRjKlh7byaERPkIC78EXZHnIgprL5+xRNZwVCaRSlEjLf6lM2l+HscbcBXo23QULxbI3FcS/6WLOtY6zZj2SUjC8eNPgeqXMab0kyb9c3zR+IAMV8JYveUIV+vuXaK5+ZijmjOXtHmSbFBOabxji4FHvBfg==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d555aa60-afcd-47a8-6f29-08dbb9de50df", "X-MS-Exchange-CrossTenant-AuthSource": "PAXPR04MB9328.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Sep 2023 13:34:29.5200 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n eA+iS1g205CeY+XUAMbXW91tmhunJcdPIJqfTcSIv/TXG3ezWBm30sj+hCABvIHC+ztThRnO9cyhk10VoPav9g==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR04MB7606", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Gagandeep Singh <g.singh@nxp.com>\n\nThe descriptors refers to auth data as well, so initializing it\nproperly for the non-auth cases.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 16 ++++++++++++----\n drivers/crypto/dpaa_sec/dpaa_sec.c | 5 +++++\n 2 files changed, 17 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 3ceb886ddb..1fc0d2e7cc 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -3538,12 +3538,20 @@ dpaa2_sec_set_pdcp_session(struct rte_cryptodev *dev,\n \t\t\t\t session->auth_alg);\n \t\t\tgoto out;\n \t\t}\n-\n \t\tp_authdata = &authdata;\n-\t} else if (pdcp_xform->domain == RTE_SECURITY_PDCP_MODE_CONTROL) {\n-\t\tDPAA2_SEC_ERR(\"Crypto: Integrity must for c-plane\");\n-\t\tgoto out;\n+\t} else {\n+\t\tif (pdcp_xform->domain == RTE_SECURITY_PDCP_MODE_CONTROL) {\n+\t\t\tDPAA2_SEC_ERR(\"Crypto: Integrity must for c-plane\");\n+\t\t\tgoto out;\n+\t\t}\n+\t\tsession->auth_key.data = NULL;\n+\t\tsession->auth_key.length = 0;\n+\t\tsession->auth_alg = 0;\n \t}\n+\tauthdata.key = (size_t)session->auth_key.data;\n+\tauthdata.keylen = session->auth_key.length;\n+\tauthdata.key_enc_flags = 0;\n+\tauthdata.key_type = RTA_DATA_IMM;\n \n \tif (pdcp_xform->sdap_enabled) {\n \t\tint nb_keys_to_inline =\ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex f3f565826f..0fcba95916 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -3188,6 +3188,11 @@ dpaa_sec_set_pdcp_session(struct rte_cryptodev *dev,\n \t\t auth_xform->key.length);\n \t\tsession->auth_alg = auth_xform->algo;\n \t} else {\n+\t\tif (pdcp_xform->domain == RTE_SECURITY_PDCP_MODE_CONTROL) {\n+\t\t\tDPAA_SEC_ERR(\"Crypto: Integrity must for c-plane\");\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto out;\n+\t\t}\n \t\tsession->auth_key.data = NULL;\n \t\tsession->auth_key.length = 0;\n \t\tsession->auth_alg = 0;\n", "prefixes": [ "v2", "06/13" ] }