Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 131756,
    "url": "http://patchwork.dpdk.org/api/patches/131756/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230921042349.104150-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230921042349.104150-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230921042349.104150-3-stephen@networkplumber.org",
    "date": "2023-09-21T04:23:47",
    "name": "[2/4] dumpcap: allow multiple invocations",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fec657889a7c013424bd8f37c2aa22476e63279c",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230921042349.104150-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 29581,
            "url": "http://patchwork.dpdk.org/api/series/29581/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29581",
            "date": "2023-09-21T04:23:45",
            "name": "pcapng fixes",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/29581/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/131756/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/131756/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD4AB425DC;\n\tThu, 21 Sep 2023 06:24:15 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9019E402E8;\n\tThu, 21 Sep 2023 06:24:06 +0200 (CEST)",
            "from mail-pf1-f178.google.com (mail-pf1-f178.google.com\n [209.85.210.178])\n by mails.dpdk.org (Postfix) with ESMTP id 4D3BC402CE\n for <dev@dpdk.org>; Thu, 21 Sep 2023 06:24:03 +0200 (CEST)",
            "by mail-pf1-f178.google.com with SMTP id\n d2e1a72fcca58-6910ea9cddbso259637b3a.0\n for <dev@dpdk.org>; Wed, 20 Sep 2023 21:24:03 -0700 (PDT)",
            "from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131])\n by smtp.gmail.com with ESMTPSA id\n u5-20020aa78485000000b00690d1269691sm311946pfn.22.2023.09.20.21.24.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 20 Sep 2023 21:24:01 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1695270242;\n x=1695875042; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=omUtTH7y7VOw30b39TLXxrqp0tKrYGDXycHE1fkYinQ=;\n b=rJLMBbB1H5LQO+r0wuC8nKj7od6VtOki4ZDXRBA5j10R2PGioalxdr7osn3RAt/i1v\n 67JyHXmU73qzanpsfY2v1FogbR5ogvEwAF9UCyYIcgy6y+b7Vhjwcn419Xo87gye4FYo\n ckJlEBEZGkpMR3bjBX1SN6ZvE1F0NeukSuaE0+L8GvD3y6tUmZ2oR+z/rMq9v16ctbo8\n uOaFWtonZ0M+DY6hXNsVUcjH0RH/1eJ3cej6th7yU/mxuutko0z6KZiZ/1PG0H/HxZgc\n giYh5iwwaVD1JlqmJHCu348aFhbtEk9gd4BZj6vjGavLe9KMtP2eWsFQJH6oBGH3rQZ7\n qurQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695270242; x=1695875042;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=omUtTH7y7VOw30b39TLXxrqp0tKrYGDXycHE1fkYinQ=;\n b=InGmFVgzlcMKimQ3eyCNm/JVG/f7n8jkc/ZDapJR+WQ2lgIvOVap6JX1wgfDSEKYRp\n Q8BJvfyVBsSKyPAxHDr/5vSuUDeLRxjcwO23/0pGOVdI41V3IlYS91TYaxLq9/0AqtVW\n IdtP/or8ltx6FiUS6nMcTa0IUvCA5bqthCcdQHHxxm1L8fxc+eW3MIbJjg+sl+/Oss5y\n BUumGXq5j9Y8fGXg/w9sqBegTtegBDYWYZOG8pdSPu/gB2D04fqTYXe9tUmmWbIIOBKv\n VieBetw4IXV2WxA6RbcgLrYLAm9VNvCNYWwO+Q7MeTLsLPyMdkWWgqVfWFrkI1riw2ND\n BW5g==",
        "X-Gm-Message-State": "AOJu0YzW2wGHRRP5jWh67ZJAsJMQFtIq3XGOpwtD6F/2ELgSYbgokKvq\n 18iZpP2s6KFuW0h6ScSL1eGqqwj9XXF/a6Nle8I=",
        "X-Google-Smtp-Source": "\n AGHT+IEKsdjJJqTAIH0JcpiyktUBnbmP1vHf6lv5a+WTawQs3rr69XJUYLUYi8eMRKjz2EteMnZysg==",
        "X-Received": "by 2002:a05:6a00:3697:b0:691:2d4:23b5 with SMTP id\n dw23-20020a056a00369700b0069102d423b5mr880811pfb.31.1695270242215;\n Wed, 20 Sep 2023 21:24:02 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Isaac Boukris <iboukris@gmail.com>, Reshma Pattan <reshma.pattan@intel.com>",
        "Subject": "[PATCH 2/4] dumpcap: allow multiple invocations",
        "Date": "Wed, 20 Sep 2023 21:23:47 -0700",
        "Message-Id": "<20230921042349.104150-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20230921042349.104150-1-stephen@networkplumber.org>",
        "References": "<20230921042349.104150-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "If dumpcap is run twice with each instance pointing a different\ninterface, it would fail because of overlap in ring a pool names.\nFix by putting process id in the name.\n\nFixes: cbb44143be74 (\"app/dumpcap: add new packet capture application\")\nReported-by: Isaac Boukris <iboukris@gmail.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/dumpcap/main.c | 28 ++++++++++++++--------------\n 1 file changed, 14 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex 64294bbfb3e6..37754fd06f4f 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -44,7 +44,6 @@\n #include <pcap/pcap.h>\n #include <pcap/bpf.h>\n \n-#define RING_NAME \"capture-ring\"\n #define MONITOR_INTERVAL  (500 * 1000)\n #define MBUF_POOL_CACHE_SIZE 32\n #define BURST_SIZE 32\n@@ -647,6 +646,7 @@ static void dpdk_init(void)\n static struct rte_ring *create_ring(void)\n {\n \tstruct rte_ring *ring;\n+\tchar ring_name[RTE_RING_NAMESIZE];\n \tsize_t size, log2;\n \n \t/* Find next power of 2 >= size. */\n@@ -660,28 +660,28 @@ static struct rte_ring *create_ring(void)\n \t\tring_size = size;\n \t}\n \n-\tring = rte_ring_lookup(RING_NAME);\n-\tif (ring == NULL) {\n-\t\tring = rte_ring_create(RING_NAME, ring_size,\n-\t\t\t\t\trte_socket_id(), 0);\n-\t\tif (ring == NULL)\n-\t\t\trte_exit(EXIT_FAILURE, \"Could not create ring :%s\\n\",\n-\t\t\t\t rte_strerror(rte_errno));\n-\t}\n+\t/* Want one ring per invocation of program */\n+\tsnprintf(ring_name, sizeof(ring_name),\n+\t\t \"dumpcap-%u\", getpid());\n+\n+\tring = rte_ring_create(ring_name, ring_size,\n+\t\t\t       rte_socket_id(), 0);\n+\tif (ring == NULL)\n+\t\trte_exit(EXIT_FAILURE, \"Could not create ring :%s\\n\",\n+\t\t\t rte_strerror(rte_errno));\n+\n \treturn ring;\n }\n \n static struct rte_mempool *create_mempool(void)\n {\n \tconst struct interface *intf;\n-\tstatic const char pool_name[] = \"capture_mbufs\";\n+\tchar pool_name[RTE_MEMPOOL_NAMESIZE];\n \tsize_t num_mbufs = 2 * ring_size;\n \tstruct rte_mempool *mp;\n \tuint32_t data_size = 128;\n \n-\tmp = rte_mempool_lookup(pool_name);\n-\tif (mp)\n-\t\treturn mp;\n+\tsnprintf(pool_name, sizeof(pool_name), \"capture_%u\", getpid());\n \n \t/* Common pool so size mbuf for biggest snap length */\n \tTAILQ_FOREACH(intf, &interfaces, next) {\n@@ -826,7 +826,7 @@ static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp)\n \t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\"Packet dump enable on %u:%s failed %s\\n\",\n \t\t\t\tintf->port, intf->name,\n-\t\t\t\trte_strerror(-ret));\n+\t\t\t\trte_strerror(rte_errno));\n \t\t}\n \n \t\tif (intf->opts.promisc_mode) {\n",
    "prefixes": [
        "2/4"
    ]
}