Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131787/?format=api
{ "id": 131787, "url": "http://patchwork.dpdk.org/api/patches/131787/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230921114820.2526810-9-ktejasree@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230921114820.2526810-9-ktejasree@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230921114820.2526810-9-ktejasree@marvell.com", "date": "2023-09-21T11:48:13", "name": "[08/15] crypto/cnxk: fix control flow issues", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2565cb6afe8b8ea20c00dccc9469fc1651600877", "submitter": { "id": 1789, "url": "http://patchwork.dpdk.org/api/people/1789/?format=api", "name": "Tejasree Kondoj", "email": "ktejasree@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230921114820.2526810-9-ktejasree@marvell.com/mbox/", "series": [ { "id": 29589, "url": "http://patchwork.dpdk.org/api/series/29589/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29589", "date": "2023-09-21T11:48:05", "name": "fixes and improvements to cnxk crypto PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29589/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131787/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131787/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0FBCB425DE;\n\tThu, 21 Sep 2023 13:49:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 621DE40F35;\n\tThu, 21 Sep 2023 13:48:49 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 8B0BD40EF1\n for <dev@dpdk.org>; Thu, 21 Sep 2023 13:48:47 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 38LBSDAg018592 for <dev@dpdk.org>; Thu, 21 Sep 2023 04:48:47 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3t85ptu0e3-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 21 Sep 2023 04:48:46 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 21 Sep 2023 04:48:44 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 21 Sep 2023 04:48:44 -0700", "from hyd1554.marvell.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 707A85B693B;\n Thu, 21 Sep 2023 04:48:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=uqTabDzsjEFXvx4Ze65SEX7QLlfAzJ8hcrlEhHHOcWo=;\n b=TR6paoDxMEDng8s7aD5Fb35Z4wwJn4m0q0+xMGJfjPnRSdUuo4jVVgIvshx1Geop5wiq\n YYdlCzZFBPYnKTb2HKSiitflic1qMFFsJI/IIcmDb+soOpixgVwguBRrq+brzSILKfkl\n 4LEMhaw1Pxm/x6wZGZaRT45toQdu8Lq2tRxBUkyqG+290bmthkdA4XhnvuU1LQue6HNN\n 2/yop6CuJQp2Z71IpfK9EhzCBA7RVhH0EHChAv7dZBqshSwxHF7jgIGqt5iemGZrnqzC\n eOmcoDrZqPgNVRL0Ctmm8WaTHL9Pf6rc+v59sqsw/FkL/7A89FujBLdrBkwNFnn9pW3F pA==", "From": "Tejasree Kondoj <ktejasree@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Vidya Sagar Velumuri <vvelumuri@marvell.com>, Anoob Joseph\n <anoobj@marvell.com>, Aakash Sasidharan <asasidharan@marvell.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 08/15] crypto/cnxk: fix control flow issues", "Date": "Thu, 21 Sep 2023 17:18:13 +0530", "Message-ID": "<20230921114820.2526810-9-ktejasree@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230921114820.2526810-1-ktejasree@marvell.com>", "References": "<20230921114820.2526810-1-ktejasree@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "YJ6xdGnO_Z2sLOMAWj82uyBZvh7rGN5V", "X-Proofpoint-ORIG-GUID": "YJ6xdGnO_Z2sLOMAWj82uyBZvh7rGN5V", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-09-21_09,2023-09-21_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n\nThis patch fixes below coverity issues.\n\nCoverity issue: 393678\nFixes: 21c1c303148b (\"crypto/cnxk: support SM4\")\n\nCoverity issue: 393679\nFixes: 21c1c303148b (\"crypto/cnxk: support SM4\")\n\nSigned-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_se.h | 22 +++++-----------------\n 1 file changed, 5 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex edd929d330..bf70b0a57c 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -1070,7 +1070,6 @@ cpt_sm_prep(uint32_t flags, uint64_t d_offs, uint64_t d_lens, struct roc_se_fc_p\n \t\tiv_len = 0;\n \n \tencr_offset += iv_len;\n-\tenc_dlen = encr_data_len + encr_offset;\n \tenc_dlen = RTE_ALIGN_CEIL(encr_data_len, 8) + encr_offset;\n \n \tinputlen = enc_dlen;\n@@ -2543,11 +2542,6 @@ fill_sm_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \tchar src[SRC_IOV_SIZE];\n \tchar dst[SRC_IOV_SIZE];\n \tvoid *mdata = NULL;\n-#ifdef CPT_ALWAYS_USE_SG_MODE\n-\tuint8_t inplace = 0;\n-#else\n-\tuint8_t inplace = 1;\n-#endif\n \tuint32_t flags = 0;\n \tint ret;\n \n@@ -2577,11 +2571,9 @@ fill_sm_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \n \tfc_params.ctx = &sess->roc_se_ctx;\n \n-\tif (likely(!m_dst && inplace)) {\n+\tif (m_dst == NULL) {\n \t\tfc_params.dst_iov = fc_params.src_iov = (void *)src;\n-\n \t\tprepare_iov_from_pkt_inplace(m_src, &fc_params, &flags);\n-\n \t} else {\n \t\t/* Out of place processing */\n \t\tfc_params.src_iov = (void *)src;\n@@ -2594,14 +2586,10 @@ fill_sm_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess,\n \t\t\tgoto err_exit;\n \t\t}\n \n-\t\tif (unlikely(m_dst != NULL)) {\n-\t\t\tif (prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0)) {\n-\t\t\t\tplt_dp_err(\"Prepare dst iov failed for m_dst %p\", m_dst);\n-\t\t\t\tret = -EINVAL;\n-\t\t\t\tgoto err_exit;\n-\t\t\t}\n-\t\t} else {\n-\t\t\tfc_params.dst_iov = (void *)src;\n+\t\tif (prepare_iov_from_pkt(m_dst, fc_params.dst_iov, 0)) {\n+\t\t\tplt_dp_err(\"Prepare dst iov failed for m_dst %p\", m_dst);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto err_exit;\n \t\t}\n \t}\n \n", "prefixes": [ "08/15" ] }