Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131866/?format=api
{ "id": 131866, "url": "http://patchwork.dpdk.org/api/patches/131866/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230925103324.4137053-3-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230925103324.4137053-3-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230925103324.4137053-3-qi.z.zhang@intel.com", "date": "2023-09-25T10:33:21", "name": "[v4,2/5] net/ice: refine flow engine disabling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "42b8ef91e1e2e2406ba09c819dd58600c0244fb5", "submitter": { "id": 504, "url": "http://patchwork.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230925103324.4137053-3-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 29613, "url": "http://patchwork.dpdk.org/api/series/29613/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29613", "date": "2023-09-25T10:33:19", "name": "net/ice: refactor rte_flow", "version": 4, "mbox": "http://patchwork.dpdk.org/series/29613/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131866/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131866/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 096FA42630;\n\tMon, 25 Sep 2023 04:13:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E2502402DF;\n\tMon, 25 Sep 2023 04:13:21 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 64CDA40266\n for <dev@dpdk.org>; Mon, 25 Sep 2023 04:13:19 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Sep 2023 19:13:19 -0700", "from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.37])\n by orsmga008.jf.intel.com with ESMTP; 24 Sep 2023 19:13:17 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695607999; x=1727143999;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=75JnaB2x7bkU+f+hCmOSu4OeRcAh661XYWVzSbwMgzE=;\n b=ZlxTAaWjMB2xWDPtKGqQGFix1NVWI3a+B3ybYf1bn/4e4w1qoRZXgIl6\n YNO5UzRBgC762DZpnJorP3r2tpD4aoMPhW1y9M+oCJnLrRnu6wi7E2NT1\n vXsNTuXo284mKEGNf+QXnkgZ35v66+8v2jabxRM/txHVYdiN7xdIZqZJy\n X20ToXb9ETXfL0RzRm7suOFp7JwbhC8NAvyaRNZax8u+E4XNcy+IsY6fX\n eSC6pWpGdsO2Qx5O2Pr14behvvlHrJ/6ANzpNxdJz4UyMrlSedKON6zEi\n zgB496S34FZ2qdtYlRXRjWWG0YQbZVihVlo8/KKPgH6D7JQIysAOuij/U A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10843\"; a=\"384978673\"", "E=Sophos;i=\"6.03,174,1694761200\"; d=\"scan'208\";a=\"384978673\"", "E=McAfee;i=\"6600,9927,10843\"; a=\"777501958\"", "E=Sophos;i=\"6.03,174,1694761200\"; d=\"scan'208\";a=\"777501958\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "zhichaox.zeng@intel.com,\n\tdev@dpdk.org,\n\tQi Zhang <qi.z.zhang@intel.com>", "Subject": "[PATCH v4 2/5] net/ice: refine flow engine disabling", "Date": "Mon, 25 Sep 2023 06:33:21 -0400", "Message-Id": "<20230925103324.4137053-3-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20230925103324.4137053-1-qi.z.zhang@intel.com>", "References": "<20230814202616.3346652-1-qi.z.zhang@intel.com>\n <20230925103324.4137053-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Only \"disable_engine_mask\" for flow engine disabling\n\nIn PF mode, only ACL engine will be disabled.\nIn DCF mode, FDIR and HASH engine will be disabled.\nIn DCF mode with \"acl=off\", ACL engine will also be\ndisabled.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/ice_acl_filter.c | 3 ---\n drivers/net/ice/ice_dcf_parent.c | 3 +++\n drivers/net/ice/ice_ethdev.c | 1 +\n drivers/net/ice/ice_fdir_filter.c | 3 ---\n drivers/net/ice/ice_hash.c | 3 ---\n 5 files changed, 4 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_acl_filter.c b/drivers/net/ice/ice_acl_filter.c\nindex f2ddbd7b9b..51f4feced4 100644\n--- a/drivers/net/ice/ice_acl_filter.c\n+++ b/drivers/net/ice/ice_acl_filter.c\n@@ -995,9 +995,6 @@ ice_acl_init(struct ice_adapter *ad)\n \tstruct ice_hw *hw = ICE_PF_TO_HW(pf);\n \tstruct ice_flow_parser *parser = &ice_acl_parser;\n \n-\tif (!ad->hw.dcf_enabled)\n-\t\treturn 0;\n-\n \tret = ice_acl_prof_alloc(hw);\n \tif (ret) {\n \t\tPMD_DRV_LOG(ERR, \"Cannot allocate memory for \"\ndiff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c\nindex 173ed9f81d..6e845f458a 100644\n--- a/drivers/net/ice/ice_dcf_parent.c\n+++ b/drivers/net/ice/ice_dcf_parent.c\n@@ -474,6 +474,9 @@ ice_dcf_init_parent_adapter(struct rte_eth_dev *eth_dev)\n \tif (ice_devargs_check(eth_dev->device->devargs, ICE_DCF_DEVARG_ACL))\n \t\tparent_adapter->disabled_engine_mask |= BIT(ICE_FLOW_ENGINE_ACL);\n \n+\tparent_adapter->disabled_engine_mask |= BIT(ICE_FLOW_ENGINE_FDIR);\n+\tparent_adapter->disabled_engine_mask |= BIT(ICE_FLOW_ENGINE_HASH);\n+\n \terr = ice_flow_init(parent_adapter);\n \tif (err) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to initialize flow\");\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 036b068c22..f744bde8f4 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2442,6 +2442,7 @@ ice_dev_init(struct rte_eth_dev *dev)\n \t}\n \n \tif (!ad->is_safe_mode) {\n+\t\tad->disabled_engine_mask |= BIT(ICE_FLOW_ENGINE_ACL);\n \t\tret = ice_flow_init(ad);\n \t\tif (ret) {\n \t\t\tPMD_INIT_LOG(ERR, \"Failed to initialize flow\");\ndiff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c\nindex e9ee5a57d6..bc43883a92 100644\n--- a/drivers/net/ice/ice_fdir_filter.c\n+++ b/drivers/net/ice/ice_fdir_filter.c\n@@ -1150,9 +1150,6 @@ ice_fdir_init(struct ice_adapter *ad)\n \tstruct ice_flow_parser *parser;\n \tint ret;\n \n-\tif (ad->hw.dcf_enabled)\n-\t\treturn 0;\n-\n \tret = ice_fdir_setup(pf);\n \tif (ret)\n \t\treturn ret;\ndiff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex e36e7da2b5..37bee808c6 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -591,9 +591,6 @@ ice_hash_init(struct ice_adapter *ad)\n {\n \tstruct ice_flow_parser *parser = NULL;\n \n-\tif (ad->hw.dcf_enabled)\n-\t\treturn 0;\n-\n \tparser = &ice_hash_parser;\n \n \treturn ice_register_parser(parser, ad);\n", "prefixes": [ "v4", "2/5" ] }