Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131894/?format=api
{ "id": 131894, "url": "http://patchwork.dpdk.org/api/patches/131894/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230925163610.3307750-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230925163610.3307750-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230925163610.3307750-3-maxime.coquelin@redhat.com", "date": "2023-09-25T16:36:05", "name": "[2/7] vhost: fix missing check on virtqueue access", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3ffd3a621f42ad2ae40caa8fb4fd985360734c3c", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230925163610.3307750-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 29620, "url": "http://patchwork.dpdk.org/api/series/29620/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29620", "date": "2023-09-25T16:36:03", "name": "vhost: ensure vitqueue access status is checked", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29620/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131894/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131894/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8AF3642637;\n\tMon, 25 Sep 2023 18:36:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D1FDC40ED9;\n\tMon, 25 Sep 2023 18:36:36 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 3DFD140E7C\n for <dev@dpdk.org>; Mon, 25 Sep 2023 18:36:33 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-518-E1mjboD4NRmT6w0ZX-GT7Q-1; Mon, 25 Sep 2023 12:36:29 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C30529A9D4F;\n Mon, 25 Sep 2023 16:36:29 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.35])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D715F10EE6C9;\n Mon, 25 Sep 2023 16:36:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695659792;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=boW3UgISU7lLi+7RP/CaTK242QvWeCQi+/Q0kBQYyig=;\n b=J2t0iHCMWh4MzYCHaWfPd93poWNGTkVvnVffgqVPi3NuKZ1yW9CRHamwAIuQnP6WqzmDtu\n p6QrZ9+SJpNZd2i1GsdLSKDkqElAOV1DJOlS8bz7SbwVy6ju8nd55U1Bb7y2WTSsMmRwNC\n H58GjhsKqEbH82DT3azb0YW3Wv34xSI=", "X-MC-Unique": "E1mjboD4NRmT6w0ZX-GT7Q-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com,\n mb@smartsharesystems.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 2/7] vhost: fix missing check on virtqueue access", "Date": "Mon, 25 Sep 2023 18:36:05 +0200", "Message-ID": "<20230925163610.3307750-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230925163610.3307750-1-maxime.coquelin@redhat.com>", "References": "<20230925163610.3307750-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Acquiring the access lock is not enough to ensure\nvirtqueue's metadata such as vring pointers are valid.\n\nThe access status must also be checked.\n\nFixes: 4e0de8dac853 (\"vhost: protect vring access done by application\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost.c | 16 ++++++++++++++--\n 1 file changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex e9c775fa26..83b71ffb23 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -1416,7 +1416,10 @@ rte_vhost_avail_entries(int vid, uint16_t queue_id)\n \n \trte_rwlock_write_lock(&vq->access_lock);\n \n-\tif (unlikely(!vq->enabled || vq->avail == NULL))\n+\tif (unlikely(!vq->access_ok))\n+\t\tgoto out;\n+\n+\tif (unlikely(!vq->enabled))\n \t\tgoto out;\n \n \tret = *(volatile uint16_t *)&vq->avail->idx - vq->last_used_idx;\n@@ -1508,9 +1511,15 @@ rte_vhost_enable_guest_notification(int vid, uint16_t queue_id, int enable)\n \n \trte_rwlock_write_lock(&vq->access_lock);\n \n+\tif (unlikely(!vq->access_ok)) {\n+\t\tret = -1;\n+\t\tgoto out_unlock;\n+\t}\n+\n \tvq->notif_enable = enable;\n \tret = vhost_enable_guest_notification(dev, vq, enable);\n \n+out_unlock:\n \trte_rwlock_write_unlock(&vq->access_lock);\n \n \treturn ret;\n@@ -1601,7 +1610,10 @@ rte_vhost_rx_queue_count(int vid, uint16_t qid)\n \n \trte_rwlock_write_lock(&vq->access_lock);\n \n-\tif (unlikely(!vq->enabled || vq->avail == NULL))\n+\tif (unlikely(!vq->access_ok))\n+\t\tgoto out;\n+\n+\tif (unlikely(!vq->enabled))\n \t\tgoto out;\n \n \tret = *((volatile uint16_t *)&vq->avail->idx) - vq->last_avail_idx;\n", "prefixes": [ "2/7" ] }