Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131895/?format=api
{ "id": 131895, "url": "http://patchwork.dpdk.org/api/patches/131895/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230925163610.3307750-5-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230925163610.3307750-5-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230925163610.3307750-5-maxime.coquelin@redhat.com", "date": "2023-09-25T16:36:07", "name": "[4/7] vhost: fix check on virtqueue access in async registration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fdb3919492c0df5a554aa23d7551f7e2f7358485", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230925163610.3307750-5-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 29620, "url": "http://patchwork.dpdk.org/api/series/29620/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29620", "date": "2023-09-25T16:36:03", "name": "vhost: ensure vitqueue access status is checked", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29620/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131895/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131895/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EBDD942637;\n\tMon, 25 Sep 2023 18:37:01 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 31EC040EF1;\n\tMon, 25 Sep 2023 18:36:38 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 1CA0C40ECF\n for <dev@dpdk.org>; Mon, 25 Sep 2023 18:36:35 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-166-OCS2nbQ4N8q5JiGV2mL9kw-1; Mon, 25 Sep 2023 12:36:33 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E09A85A5BF;\n Mon, 25 Sep 2023 16:36:32 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.35])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 34AF710EE6C9;\n Mon, 25 Sep 2023 16:36:31 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695659794;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9rL6Xmtu9kRygElKC+We1OjSUvcjI5Z/BL3h8m/HzNc=;\n b=B/03jSxf5gKH0il6hlms4pvFZZoIctJtD8MVti5oRUr9TaU2IWHb0LPQwDVfd73/yvaFMw\n 9DO6gk5I9YIkmpo/Gu4nG35m5a/F0GvVZTwYHn3G2YUCPJBqNtSGrS9/xuFhOYUcmRr0Bt\n /QqgZrWV/zzh33ZgtLdJFdFLNqoNdGo=", "X-MC-Unique": "OCS2nbQ4N8q5JiGV2mL9kw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com,\n mb@smartsharesystems.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 4/7] vhost: fix check on virtqueue access in async\n registration", "Date": "Mon, 25 Sep 2023 18:36:07 +0200", "Message-ID": "<20230925163610.3307750-5-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230925163610.3307750-1-maxime.coquelin@redhat.com>", "References": "<20230925163610.3307750-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Acquiring the access lock is not enough to ensure\nvirtqueue's metadata such as vring pointers are valid.\n\nThe access status must also be checked.\n\nFixes: 78639d54563a (\"vhost: introduce async enqueue registration API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex f07674334d..7f5d25255a 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -1853,7 +1853,15 @@ rte_vhost_async_channel_register(int vid, uint16_t queue_id)\n \t\treturn -1;\n \n \trte_rwlock_write_lock(&vq->access_lock);\n+\n+\tif (unlikely(!vq->access_ok)) {\n+\t\tret = -1;\n+\t\tgoto out_unlock;\n+\t}\n+\n \tret = async_channel_register(dev, vq);\n+\n+out_unlock:\n \trte_rwlock_write_unlock(&vq->access_lock);\n \n \treturn ret;\n@@ -1905,6 +1913,11 @@ rte_vhost_async_channel_unregister(int vid, uint16_t queue_id)\n \t\treturn ret;\n \t}\n \n+\tif (unlikely(!vq->access_ok)) {\n+\t\tret = -1;\n+\t\tgoto out_unlock;\n+\t}\n+\n \tif (!vq->async) {\n \t\tret = 0;\n \t} else if (vq->async->pkts_inflight_n) {\n@@ -1916,6 +1929,7 @@ rte_vhost_async_channel_unregister(int vid, uint16_t queue_id)\n \t\tret = 0;\n \t}\n \n+out_unlock:\n \trte_rwlock_write_unlock(&vq->access_lock);\n \n \treturn ret;\n", "prefixes": [ "4/7" ] }