Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131897/?format=api
{ "id": 131897, "url": "http://patchwork.dpdk.org/api/patches/131897/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230925163610.3307750-7-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230925163610.3307750-7-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230925163610.3307750-7-maxime.coquelin@redhat.com", "date": "2023-09-25T16:36:09", "name": "[6/7] vhost: fix missing lock protection in power monitor API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "865962bf7a68c9a05180401018226925bc3dc9c3", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230925163610.3307750-7-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 29620, "url": "http://patchwork.dpdk.org/api/series/29620/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29620", "date": "2023-09-25T16:36:03", "name": "vhost: ensure vitqueue access status is checked", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29620/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/131897/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/131897/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F9A942637;\n\tMon, 25 Sep 2023 18:37:22 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4F9D64111C;\n\tMon, 25 Sep 2023 18:36:42 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id DF914410FB\n for <dev@dpdk.org>; Mon, 25 Sep 2023 18:36:39 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-408-uRauMFy_OTS8kpAIWSx3OQ-1; Mon, 25 Sep 2023 12:36:36 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6913811E88;\n Mon, 25 Sep 2023 16:36:35 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.35])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8BE361054FC1;\n Mon, 25 Sep 2023 16:36:34 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695659799;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=pBsuT9WW90WzMtf8VlqlirKuelOpaKWp8Otbi/JKlfc=;\n b=YN80Wn0mHuH5jtKAl8K/ljk2A6xRT6BWvHN7pSpmqLdWYbpp1wjzVT/fuTcTNqcZWXT/UC\n Qj0kAH+Gv4hjo/rKaY+gIfmjeS+f/ccevndK8BQjKr7pYbHaBQYBdsqgR1n13pxIDelIZI\n puwoqk5jFlPdQusu01ypGf7bJ3l3lVg=", "X-MC-Unique": "uRauMFy_OTS8kpAIWSx3OQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com,\n mb@smartsharesystems.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 6/7] vhost: fix missing lock protection in power monitor API", "Date": "Mon, 25 Sep 2023 18:36:09 +0200", "Message-ID": "<20230925163610.3307750-7-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230925163610.3307750-1-maxime.coquelin@redhat.com>", "References": "<20230925163610.3307750-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The power monitor get API is missing both access lock\nprotection and access status check.\n\nFixes: 34fd4373ce76 (\"vhost: add power monitor API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex 51383410bf..28eedf11d9 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -2117,6 +2117,7 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,\n {\n \tstruct virtio_net *dev = get_device(vid);\n \tstruct vhost_virtqueue *vq;\n+\tint ret = 0;\n \n \tif (dev == NULL)\n \t\treturn -1;\n@@ -2127,6 +2128,13 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,\n \tif (vq == NULL)\n \t\treturn -1;\n \n+\trte_rwlock_read_lock(&vq->access_lock);\n+\n+\tif (unlikely(!vq->access_ok)) {\n+\t\tret = -1;\n+\t\tgoto out_unlock;\n+\t}\n+\n \tif (vq_is_packed(dev)) {\n \t\tstruct vring_packed_desc *desc;\n \t\tdesc = vq->desc_packed;\n@@ -2146,7 +2154,10 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,\n \t\tpmc->match = 0;\n \t}\n \n-\treturn 0;\n+out_unlock:\n+\trte_rwlock_read_unlock(&vq->access_lock);\n+\n+\treturn ret;\n }\n \n \n", "prefixes": [ "6/7" ] }