Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132105/?format=api
{ "id": 132105, "url": "http://patchwork.dpdk.org/api/patches/132105/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230928094758.1076236-8-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230928094758.1076236-8-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230928094758.1076236-8-jiawenwu@trustnetic.com", "date": "2023-09-28T09:47:54", "name": "[07/11] net/txgbe: fix to keep link down after device close", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dd544afbd67a3cf61451def8b2cf3a4dfad59d77", "submitter": { "id": 1932, "url": "http://patchwork.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230928094758.1076236-8-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 29673, "url": "http://patchwork.dpdk.org/api/series/29673/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29673", "date": "2023-09-28T09:47:47", "name": "Wanguxn NICs fixes and supports", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29673/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132105/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132105/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 546C14265E;\n\tThu, 28 Sep 2023 11:38:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EEBE440FDE;\n\tThu, 28 Sep 2023 11:37:33 +0200 (CEST)", "from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n by mails.dpdk.org (Postfix) with ESMTP id CD06440EE7;\n Thu, 28 Sep 2023 11:37:30 +0200 (CEST)", "from wxdbg.localdomain.com ( [115.200.229.121])\n by bizesmtp.qq.com (ESMTP) with\n id ; Thu, 28 Sep 2023 17:37:19 +0800 (CST)" ], "X-QQ-mid": "bizesmtp74t1695893840tlyggm46", "X-QQ-SSF": "01400000000000K0Z000000A0000000", "X-QQ-FEAT": "WjKIxUDuZHQgDWXvg/HlMl6rpfpL0S1TQy7i01jaQHbDtgONa0SKdrkzpaTD9\n IVjX1YhxRD+Q1fE2AgHd6miNN66IV46Zduuu8zS++F6xi1sa4KM/csrCH3eMRb6ZVpTO9Q6\n RN8JPZOyStdo3wO/Allbn3XkNZXrLJc3Q5kRC8vfyZYFZdYRgOKaaHD+3tRgXzi6sg9qI7W\n ERq0luO46HsOIJ9Lheh1Cp8xjPBGT9sELx8Ou0772uTqkJzQu8eKDjybXJmK76jRClI0vrG\n cgSVlUTbFoxgKrVBuU2ojyhODd/5wgNPAQhT2LjgnSOyK4W5bPsHxdB01doR6JHCSxKU1Ok\n 4eO5Zamb8LmGia5p2zrTSvcmBLA8JSNJaYXdRmZVjKbb52HvpvPzfv9Eny9nNSu983UC1w0\n 1bGCM02zF+I=", "X-QQ-GoodBg": "2", "X-BIZMAIL-ID": "12081001662970362395", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 07/11] net/txgbe: fix to keep link down after device close", "Date": "Thu, 28 Sep 2023 17:47:54 +0800", "Message-Id": "<20230928094758.1076236-8-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230928094758.1076236-1-jiawenwu@trustnetic.com>", "References": "<20230928094758.1076236-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the port is closed, hardware is reset to power on. And\ntxgbe_dev_stop() is just returned 0 to avoid secondary calls,\nso that the link led remains on. Fix this bug by adding to turn\noff the copper/laser.\n\nFixes: e0d876ef6bbc (\"net/txgbe: support device stop and close\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex e789e34c01..2dad820cb5 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -1929,7 +1929,7 @@ txgbe_dev_stop(struct rte_eth_dev *dev)\n \tstruct txgbe_tm_conf *tm_conf = TXGBE_DEV_TM_CONF(dev);\n \n \tif (hw->adapter_stopped)\n-\t\treturn 0;\n+\t\tgoto out;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -1953,14 +1953,6 @@ txgbe_dev_stop(struct rte_eth_dev *dev)\n \tfor (vf = 0; vfinfo != NULL && vf < pci_dev->max_vfs; vf++)\n \t\tvfinfo[vf].clear_to_send = false;\n \n-\tif (hw->phy.media_type == txgbe_media_type_copper) {\n-\t\t/* Turn off the copper */\n-\t\thw->phy.set_phy_power(hw, false);\n-\t} else {\n-\t\t/* Turn off the laser */\n-\t\thw->mac.disable_tx_laser(hw);\n-\t}\n-\n \ttxgbe_dev_clear_queues(dev);\n \n \t/* Clear stored conf */\n@@ -1991,6 +1983,16 @@ txgbe_dev_stop(struct rte_eth_dev *dev)\n \tdev->data->dev_started = 0;\n \thw->dev_start = false;\n \n+out:\n+\t/* close phy to prevent reset in dev_close from restarting physical link */\n+\tif (hw->phy.media_type == txgbe_media_type_copper) {\n+\t\t/* Turn off the copper */\n+\t\thw->phy.set_phy_power(hw, false);\n+\t} else {\n+\t\t/* Turn off the laser */\n+\t\thw->mac.disable_tx_laser(hw);\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "07/11" ] }