Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132107/?format=api
{ "id": 132107, "url": "http://patchwork.dpdk.org/api/patches/132107/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20230928094758.1076236-12-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230928094758.1076236-12-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230928094758.1076236-12-jiawenwu@trustnetic.com", "date": "2023-09-28T09:47:58", "name": "[11/11] net/ngbe: add YT PHY fiber mode autoneg 100M support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "16c2c8eddd178f07fd9be9d57583c2525b5c3898", "submitter": { "id": 1932, "url": "http://patchwork.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20230928094758.1076236-12-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 29673, "url": "http://patchwork.dpdk.org/api/series/29673/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29673", "date": "2023-09-28T09:47:47", "name": "Wanguxn NICs fixes and supports", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29673/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132107/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132107/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE7884265E;\n\tThu, 28 Sep 2023 11:38:15 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 273FE40A80;\n\tThu, 28 Sep 2023 11:37:39 +0200 (CEST)", "from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22])\n by mails.dpdk.org (Postfix) with ESMTP id 7391240EE7\n for <dev@dpdk.org>; Thu, 28 Sep 2023 11:37:35 +0200 (CEST)", "from wxdbg.localdomain.com ( [115.200.229.121])\n by bizesmtp.qq.com (ESMTP) with\n id ; Thu, 28 Sep 2023 17:37:31 +0800 (CST)" ], "X-QQ-mid": "bizesmtp74t1695893852tn58oqvk", "X-QQ-SSF": "01400000000000K0Z000000A0000000", "X-QQ-FEAT": "mA5V8Pu2WCFWg9Ofo6iamXHMdjg//pk4QxE+SyKC4eLWaiIDh0F7ONdQZmBGb\n NYCj5N5KxmlGgh6uemVudBWD21mWzXkNPN3hlAP0G+vZ0IGGdTFhpmEHGKrIO1JxjiLecRw\n +Ok6bQBs1OhNYSukuIJ4U7OrGCdiu0bzdfmSAhCz6/3uBkMgZyIRgd7U45nSPCswcKRmpnb\n drVtm4xN3RSBGzcRBHQrjNq0RhlXIjzLouvh47l/ltOLSDKTMzXyehB4PI42eQIM98pf+39\n Ezi6EcMuKqRqN+2UYzFTMKyTjKrbZB0UrF/II3e9BrnevK/PTiFeSKvXpLsNLtENsJiWhmZ\n UPMAJqBPjIB8cm1819WCqYe/H2jYuu9UxTpyG/RVulqS1tsBKK41dUp1jdySfu6vNdbUw+I\n 5Acq8eI8b4E=", "X-QQ-GoodBg": "2", "X-BIZMAIL-ID": "17392643781201496720", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Subject": "[PATCH 11/11] net/ngbe: add YT PHY fiber mode autoneg 100M support", "Date": "Thu, 28 Sep 2023 17:47:58 +0800", "Message-Id": "<20230928094758.1076236-12-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230928094758.1076236-1-jiawenwu@trustnetic.com>", "References": "<20230928094758.1076236-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Support auto-neg 100M for YT PHY fiber mode.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/rel_notes/release_23_11.rst | 4 ++\n drivers/net/ngbe/base/ngbe_phy_yt.c | 66 +++++++++++++++++++-------\n 2 files changed, 52 insertions(+), 18 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex 9746809a66..578900f504 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -41,6 +41,10 @@ DPDK Release 23.11\n New Features\n ------------\n \n+* **Updated Wangxun ngbe driver.**\n+\n+ * Added 100M and auto-neg support in YT PHY fiber mode.\n+\n .. This section should contain new features added in this release.\n Sample format:\n \ndiff --git a/drivers/net/ngbe/base/ngbe_phy_yt.c b/drivers/net/ngbe/base/ngbe_phy_yt.c\nindex 754faadd6a..ea313cd9a5 100644\n--- a/drivers/net/ngbe/base/ngbe_phy_yt.c\n+++ b/drivers/net/ngbe/base/ngbe_phy_yt.c\n@@ -205,38 +205,68 @@ s32 ngbe_setup_phy_link_yt(struct ngbe_hw *hw, u32 speed,\n \t\thw->phy.set_phy_power(hw, true);\n \t} else if ((value & YT_CHIP_MODE_MASK) == YT_CHIP_MODE_SEL(1)) {\n \t\t/* fiber to rgmii */\n-\t\thw->phy.autoneg_advertised |= NGBE_LINK_SPEED_1GB_FULL;\n+\t\tif (!hw->mac.autoneg) {\n+\t\t\tswitch (speed) {\n+\t\t\tcase NGBE_LINK_SPEED_1GB_FULL:\n+\t\t\t\tvalue = NGBE_LINK_SPEED_1GB_FULL;\n+\t\t\t\tbreak;\n+\t\t\tcase NGBE_LINK_SPEED_100M_FULL:\n+\t\t\t\tvalue = NGBE_LINK_SPEED_100M_FULL;\n+\t\t\t\tbreak;\n+\t\t\tdefault:\n+\t\t\t\tvalue = NGBE_LINK_SPEED_1GB_FULL;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t\thw->phy.autoneg_advertised |= value;\n+\t\t\tgoto skip_an_fiber;\n+\t\t}\n \n-\t\t/* RGMII_Config1 : Config rx and tx training delay */\n-\t\tvalue = YT_RGMII_CONF1_RXDELAY |\n-\t\t\tYT_RGMII_CONF1_TXDELAY_FE |\n-\t\t\tYT_RGMII_CONF1_TXDELAY;\n+\t\tvalue = 0;\n+\t\tif (speed & NGBE_LINK_SPEED_1GB_FULL)\n+\t\t\thw->phy.autoneg_advertised |= NGBE_LINK_SPEED_1GB_FULL;\n+\t\tif (speed & NGBE_LINK_SPEED_100M_FULL)\n+\t\t\thw->phy.autoneg_advertised |= NGBE_LINK_SPEED_100M_FULL;\n+\n+skip_an_fiber:\n \t\trte_spinlock_lock(&hw->phy_lock);\n-\t\tngbe_write_phy_reg_ext_yt(hw, YT_RGMII_CONF1, 0, value);\n-\t\tvalue = YT_CHIP_MODE_SEL(1) |\n-\t\t\tYT_CHIP_SW_LDO_EN |\n-\t\t\tYT_CHIP_SW_RST;\n-\t\tngbe_write_phy_reg_ext_yt(hw, YT_CHIP, 0, value);\n+\t\tngbe_read_phy_reg_ext_yt(hw, YT_MISC, 0, &value);\n+\t\tif (hw->phy.autoneg_advertised & NGBE_LINK_SPEED_1GB_FULL)\n+\t\t\tvalue |= YT_MISC_RESV;\n+\t\telse if (hw->phy.autoneg_advertised & NGBE_LINK_SPEED_100M_FULL)\n+\t\t\tvalue &= ~YT_MISC_RESV;\n+\t\tngbe_write_phy_reg_ext_yt(hw, YT_MISC, 0, value);\n \n+\t\t/* close auto sensing */\n \t\tngbe_read_phy_reg_sds_ext_yt(hw, YT_AUTO, 0, &value);\n \t\tvalue &= ~YT_AUTO_SENSING;\n \t\tngbe_write_phy_reg_sds_ext_yt(hw, YT_AUTO, 0, value);\n \n-\t\tngbe_read_phy_reg_ext_yt(hw, YT_MISC, 0, &value);\n-\t\tvalue |= YT_MISC_RESV;\n-\t\tngbe_write_phy_reg_ext_yt(hw, YT_MISC, 0, value);\n-\n \t\tngbe_read_phy_reg_ext_yt(hw, YT_CHIP, 0, &value);\n \t\tvalue &= ~YT_CHIP_SW_RST;\n \t\tngbe_write_phy_reg_ext_yt(hw, YT_CHIP, 0, value);\n \n+\t\t/* RGMII_Config1 : Config rx and tx training delay */\n+\t\tvalue = YT_RGMII_CONF1_RXDELAY |\n+\t\t\tYT_RGMII_CONF1_TXDELAY_FE |\n+\t\t\tYT_RGMII_CONF1_TXDELAY;\n+\n+\t\tngbe_write_phy_reg_ext_yt(hw, YT_RGMII_CONF1, 0, value);\n+\t\tvalue = YT_CHIP_MODE_SEL(1) |\n+\t\t\tYT_CHIP_SW_LDO_EN |\n+\t\t\tYT_CHIP_SW_RST;\n+\t\tngbe_write_phy_reg_ext_yt(hw, YT_CHIP, 0, value);\n+\n \t\t/* software reset */\n-\t\tif (hw->mac.autoneg)\n+\t\tif (hw->mac.autoneg) {\n \t\t\tvalue = YT_BCR_RESET | YT_BCR_ANE | YT_BCR_RESTART_AN |\n \t\t\t\tYT_BCR_DUPLEX | YT_BCR_SPEED_SELECT1;\n-\t\telse\n-\t\t\tvalue = YT_BCR_RESET | YT_BCR_DUPLEX |\n-\t\t\t\tYT_BCR_SPEED_SELECT1;\n+\t\t} else {\n+\t\t\tvalue = YT_BCR_RESET | YT_BCR_DUPLEX;\n+\t\t\tif (speed & NGBE_LINK_SPEED_1GB_FULL)\n+\t\t\t\tvalue |= YT_BCR_SPEED_SELECT1;\n+\t\t\tif (speed & NGBE_LINK_SPEED_100M_FULL)\n+\t\t\t\tvalue |= YT_BCR_SPEED_SELECT0;\n+\t\t}\n \t\thw->phy.write_reg(hw, YT_BCR, 0, value);\n \t\trte_spinlock_unlock(&hw->phy_lock);\n \n", "prefixes": [ "11/11" ] }