Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 132269,
    "url": "http://patchwork.dpdk.org/api/patches/132269/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231002183730.301163-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231002183730.301163-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231002183730.301163-4-stephen@networkplumber.org",
    "date": "2023-10-02T18:37:30",
    "name": "[v2,3/3] test: add tests for rte_ether routines",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0255dc9b20d06fdb70575fa7a1555f1594ae4745",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231002183730.301163-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 29717,
            "url": "http://patchwork.dpdk.org/api/series/29717/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29717",
            "date": "2023-10-02T18:37:27",
            "name": "rte_ether_unformat_addr changes",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/29717/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/132269/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/132269/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23F08426A5;\n\tMon,  2 Oct 2023 20:38:01 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8D637402EA;\n\tMon,  2 Oct 2023 20:37:47 +0200 (CEST)",
            "from mail-pl1-f181.google.com (mail-pl1-f181.google.com\n [209.85.214.181])\n by mails.dpdk.org (Postfix) with ESMTP id 07460402D5\n for <dev@dpdk.org>; Mon,  2 Oct 2023 20:37:45 +0200 (CEST)",
            "by mail-pl1-f181.google.com with SMTP id\n d9443c01a7336-1bf55a81eeaso1081875ad.0\n for <dev@dpdk.org>; Mon, 02 Oct 2023 11:37:44 -0700 (PDT)",
            "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n iz7-20020a170902ef8700b001b9f7bc3e77sm12546595plb.189.2023.10.02.11.37.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 02 Oct 2023 11:37:43 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696271864;\n x=1696876664; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=h5MS8SMAbT7v9isRW24gI7PqH+NVxcBjHc33IbSMo/0=;\n b=CHyV/eFAb2udc+ISX8M9v7DmsL4VuvLUZgBDlo+cPT70D0PSzZqzwi209ix6M4yUQl\n 3JeSNm9nFAPEd0jJ8tHE2mkyMOp5OUJgJg2NGxDg5R1S7PrbdqA0SUPFxLzXhg/ilAMa\n mhSiKR1PeeaPRTB2ljxccrjyn1ehNfJ3hUk3jmESfNBBrLmle6UByuJKgay5DrUh0UPU\n OiyYUNIu+e3fMM1YbJiHGrN9Ny39KBY/ookR8wTj8qmp+smjUPnsn2jL6oXqPTrsi42u\n mUO3Uz705DycRmkWT5eVqL3HKEnj9zTHStDnrDCVdwD66wO7PjRiqKdviRVqVBXldEkr\n yA5Q==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1696271864; x=1696876664;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=h5MS8SMAbT7v9isRW24gI7PqH+NVxcBjHc33IbSMo/0=;\n b=TTFsiHj/izvgpDqh4JivZCfnUD3TwArx6IHD7tlimiesVJzhATT/FilOC7x79DpYza\n h7KEP96JX7zZqgnSmKYaRd6JJ7hBohMvLd7k9pUWYHMYBIbKj+xcYVflwXerkLHrcUpM\n MSB2TLjbJPldekwKyCL3uY/8hFIMlsjRO+y0rATl+IE7y3k3BhOucxAABGdr5zujAmPG\n B23nAsZdRdCkvZPeGmA4VIo8mmoFfhE0MZv/S5DJaZOB6NbyHDKgSNtwtcPtHqQUEQ1k\n 4IdDxGHn3C1rbdqi1FKzbz+M+rZlZVLu3lYMn2J+O4ZnwCuRRltdAeWz10sqlGuPvva2\n 1RRg==",
        "X-Gm-Message-State": "AOJu0YwJYgMhVnJWlodyWm6I6z/sZzxWowFCyEwfye+eSrAnfAifNQ3l\n iCnkCi9CBh6nCgLixiR6zl12v4ICp6D2vbkKgAg=",
        "X-Google-Smtp-Source": "\n AGHT+IGL1fDFGE+Gav50bXoCgUMfHWEkvE80IOmSFngRi8ujjVS73HOJB64Uk9JGtub7qNSkzF6/qw==",
        "X-Received": "by 2002:a17:902:f812:b0:1c6:1ddf:5c3b with SMTP id\n ix18-20020a170902f81200b001c61ddf5c3bmr9725036plb.28.1696271863814;\n Mon, 02 Oct 2023 11:37:43 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Subject": "[PATCH v2 3/3] test: add tests for rte_ether routines",
        "Date": "Mon,  2 Oct 2023 11:37:30 -0700",
        "Message-Id": "<20231002183730.301163-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20231002183730.301163-1-stephen@networkplumber.org>",
        "References": "<20230929163611.62691-1-stephen@networkplumber.org>\n <20231002183730.301163-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "This add some basic tests for rte_unformat_ether_addr\nand other functions in rte_ether.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/meson.build      |   1 +\n app/test/test_net_ether.c | 169 ++++++++++++++++++++++++++++++++++++++\n 2 files changed, 170 insertions(+)\n create mode 100644 app/test/test_net_ether.c",
    "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex bf9fc906128f..20a9333c726d 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -124,6 +124,7 @@ source_file_deps = {\n     'test_meter.c': ['meter'],\n     'test_metrics.c': ['metrics'],\n     'test_mp_secondary.c': ['hash', 'lpm'],\n+    'test_net_ether.c': ['net'],\n     'test_pcapng.c': ['ethdev', 'net', 'pcapng'],\n     'test_pdcp.c': ['eventdev', 'pdcp', 'net', 'timer', 'security'],\n     'test_pdump.c': ['pdump'] + sample_packet_forward_deps,\ndiff --git a/app/test/test_net_ether.c b/app/test/test_net_ether.c\nnew file mode 100644\nindex 000000000000..a6d38cc2ffa0\n--- /dev/null\n+++ b/app/test/test_net_ether.c\n@@ -0,0 +1,169 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) 2023 Stephen Hemminger\n+ */\n+\n+#include <rte_ether.h>\n+\n+#include <rte_test.h>\n+#include \"test.h\"\n+\n+#define N 1000000\n+\n+static const struct rte_ether_addr zero_ea;\n+static const struct rte_ether_addr bcast_ea = {\n+\t.addr_bytes = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff },\n+};\n+\n+static int\n+test_ether_addr(void)\n+{\n+\tstruct rte_ether_addr rand_ea = { };\n+\tunsigned int i;\n+\n+\tRTE_TEST_ASSERT(rte_is_zero_ether_addr(&zero_ea), \"Zero address is not zero\");\n+\tRTE_TEST_ASSERT(!rte_is_zero_ether_addr(&bcast_ea), \"Broadcast is zero\");\n+\n+\tfor (i = 0; i < N; i++) {\n+\t\trte_eth_random_addr(rand_ea.addr_bytes);\n+\t\tRTE_TEST_ASSERT(!rte_is_zero_ether_addr(&rand_ea),\n+\t\t\t\t\"Random address is zero\");\n+\t\tRTE_TEST_ASSERT(rte_is_unicast_ether_addr(&rand_ea),\n+\t\t\t\t\"Random addrss is not unicast\");\n+\t\tRTE_TEST_ASSERT(rte_is_local_admin_ether_addr(&rand_ea),\n+\t\t\t\t\"Random address is not local admin\");\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_format_addr(void)\n+{\n+\tstruct rte_ether_addr rand_ea = { };\n+\tchar buf[RTE_ETHER_ADDR_FMT_SIZE];\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < N; i++) {\n+\t\tstruct rte_ether_addr result = { };\n+\t\tint ret;\n+\n+\t\trte_eth_random_addr(rand_ea.addr_bytes);\n+\n+\t\trte_ether_format_addr(buf, sizeof(buf), &rand_ea);\n+\n+\t\tret = rte_ether_unformat_addr(buf, &result);\n+\t\tif (ret != 0) {\n+\t\t\tfprintf(stderr, \"rte_ether_unformat_addr(%s) failed\\n\", buf);\n+\t\t\treturn -1;\n+\t\t}\n+\t\tRTE_TEST_ASSERT(rte_is_same_ether_addr(&rand_ea, &result),\n+\t\t\t\"rte_ether_format/unformat mismatch\");\n+\t}\n+\treturn 0;\n+\n+}\n+\n+static int\n+test_unformat_addr(void)\n+{\n+\tconst struct rte_ether_addr expected = {\n+\t\t.addr_bytes = { 0x12, 0x34, 0x56, 0x78, 0x9a, 0xbc },\n+\t};\n+\tconst struct rte_ether_addr nozero_ea = {\n+\t\t.addr_bytes = { 1, 2, 3, 4, 5, 6 },\n+\t};\n+\tstruct rte_ether_addr result;\n+\tint ret;\n+\n+\t/* Test IETF format */\n+\tmemset(&result, 0, sizeof(result));\n+\tret = rte_ether_unformat_addr(\"12:34:56:78:9a:bc\", &result);\n+\tRTE_TEST_ASSERT(ret == 0, \"IETF unformat failed\");\n+\tRTE_TEST_ASSERT(rte_is_same_ether_addr(&expected, &result),\n+\t\t\"IETF unformat mismatch\");\n+\n+\t/* Test IEEE format */\n+\tmemset(&result, 0, sizeof(result));\n+\tret = rte_ether_unformat_addr(\"12-34-56-78-9A-BC\", &result);\n+\tRTE_TEST_ASSERT(ret == 0, \"IEEE unformat failed\");\n+\tRTE_TEST_ASSERT(rte_is_same_ether_addr(&expected, &result),\n+\t\t\t\"IEEE unformat mismatch\");\n+\n+\t/* Test Cisco format */\n+\tmemset(&result, 0, sizeof(result));\n+\tret = rte_ether_unformat_addr(\"1234.5678.9ABC\", &result);\n+\tRTE_TEST_ASSERT(ret == 0, \"Cisco unformat failed\");\n+\tRTE_TEST_ASSERT(rte_is_same_ether_addr(&expected, &result),\n+\t\t\t\"Cisco unformat mismatch\");\n+\n+\t/* Test no leading zeros - IETF */\n+\tmemset(&result, 0, sizeof(result));\n+\tret = rte_ether_unformat_addr(\"1:2:3:4:5:6\", &result);\n+\tRTE_TEST_ASSERT(ret == 0, \"IETF leading zero failed\");\n+\tRTE_TEST_ASSERT(rte_is_same_ether_addr(&nozero_ea, &result),\n+\t\t\t\"IETF leading zero mismatch\");\n+\n+\t/* Test no-leading zero - IEEE format */\n+\tmemset(&result, 0, sizeof(result));\n+\tret = rte_ether_unformat_addr(\"1-2-3-4-5-6\", &result);\n+\tRTE_TEST_ASSERT(ret == 0, \"IEEE leading zero failed\");\n+\tRTE_TEST_ASSERT(rte_is_same_ether_addr(&nozero_ea, &result),\n+\t\t\t\"IEEE leading zero mismatch\");\n+\n+\t/* Test no-leading zero - Cisco format */\n+\tmemset(&result, 0, sizeof(result));\n+\tret = rte_ether_unformat_addr(\"102.304.506\", &result);\n+\tRTE_TEST_ASSERT(ret == 0, \"Cisco leading zero failed\");\n+\tRTE_TEST_ASSERT(rte_is_same_ether_addr(&nozero_ea, &result),\n+\t\t\t\"Cisco leading zero mismatch\");\n+\n+\treturn 0;\n+}\n+\n+static int\n+test_invalid_addr(void)\n+{\n+\tstatic const char * const invalid[] = {\n+\t\t\"NO:ADDRESS\",\n+\t\t\"123\",\n+\t\t\"12:34:56:78:9a:gh\",\n+\t\t\"12:34:56:78:9a\",\n+\t\t\"100:34:56:78:9a:bc\",\n+\t\t\"34-56-78-9a-bc\",\n+\t\t\"12:34:56-78:9a:bc\",\n+\t\t\"12:34:56.78:9a:bc\",\n+\t\t\"123:456:789:abc\",\n+\t\t\"\",\n+\t};\n+\tstruct rte_ether_addr result;\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < RTE_DIM(invalid); ++i) {\n+\t\tif (!rte_ether_unformat_addr(invalid[i], &result)) {\n+\t\t\tfprintf(stderr, \"rte_ether_unformat_addr(%s) succeeded!\\n\",\n+\t\t\t\tinvalid[i]);\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n+test_net_ether(void)\n+{\n+\tif (test_ether_addr())\n+\t\treturn -1;\n+\n+\tif (test_format_addr())\n+\t\treturn -1;\n+\n+\tif (test_unformat_addr())\n+\t\treturn -1;\n+\n+\tif (test_invalid_addr())\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n+REGISTER_FAST_TEST(net_ether_autotest, true, true, test_net_ether);\n",
    "prefixes": [
        "v2",
        "3/3"
    ]
}