Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132290/?format=api
{ "id": 132290, "url": "http://patchwork.dpdk.org/api/patches/132290/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231003202909.391330-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231003202909.391330-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231003202909.391330-5-stephen@networkplumber.org", "date": "2023-10-03T20:29:09", "name": "[v3,4/4] net/tap: use rte_ether_unformat_address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2b994cbc742e7579b2a071b7bce728f16741b971", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231003202909.391330-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 29727, "url": "http://patchwork.dpdk.org/api/series/29727/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29727", "date": "2023-10-03T20:29:05", "name": "rte_ether_unformat_addr related changes", "version": 3, "mbox": "http://patchwork.dpdk.org/series/29727/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132290/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CF04A426B2;\n\tTue, 3 Oct 2023 22:29:46 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E11FB40A7F;\n\tTue, 3 Oct 2023 22:29:26 +0200 (CEST)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id 512B6406B4\n for <dev@dpdk.org>; Tue, 3 Oct 2023 22:29:24 +0200 (CEST)", "by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-1c60f1a2652so1970085ad.0\n for <dev@dpdk.org>; Tue, 03 Oct 2023 13:29:24 -0700 (PDT)", "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n a11-20020a1709027d8b00b001c5f62a639asm2014138plm.196.2023.10.03.13.29.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 03 Oct 2023 13:29:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696364963;\n x=1696969763; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=vwwODn05ke3sSauHLybwTs8ZNGKb1GSkj9OLdb3j6cc=;\n b=Bhrw33zmW7V4wj8/MDQl4GkCeOCn8dcOEbbq3qvEceGpw8a++40rJ0B8RVJUUv/ioY\n rvOKNswhvCM/hb5AjtH9E7+eB25+l++Jsjq3wkY6DD3JHqmQzD14oQeSCIjCGjH9X6ap\n 0RgFI7dCg3e5rl5fG9j9b/OoJ2gUr+SC2N+d/6hrXoEcdbpDAQwgu2nxCT7IZcyPHWkY\n QPFiI7hrCJnFaX7xFY9OxVZym42QQCB6zm4F5BharB0w0kSLNqcUTJbkaGufqqILiHlh\n R8a/9Ejenmy4rkUkU3ZMY2gwutSYnwSRGBlSYQo1V2PMOUoWsBHqpfRyEFAbff4qL6aO\n vRtg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1696364963; x=1696969763;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=vwwODn05ke3sSauHLybwTs8ZNGKb1GSkj9OLdb3j6cc=;\n b=aWUAGFeeVgriND86y64Y7nAy0OPh/Fm2/T81FFpa/b8h1tyIpj2trG5gi/idXuhAXX\n yA4THMUWu3uUvqPlKLrVo2mZQB9AtBcmZwIuxd8rJ2QI+Lnk/zdmCiz9a5nCtpY9FiGK\n z+Um5ezqVj93GOD0WghFdTJcNCInWTcw5uSGR3lArW2OvigqOo7hQzdKZNrIHELKsK1U\n YxKUiQ2QiWrzRvVyyXZkYIWsCpA6LZK4LvAVNZlSUEBXH56qXAnBAYvUMoO/l1TnWqkA\n IEOMR+jWN8IoRonFk+v539sWOG9eWZwH3a8fbGh6016NNgY+AwRBunKd+HF0Qu6ThxqW\n +oFg==", "X-Gm-Message-State": "AOJu0Ywg+YhoFLl4/S+OX2POdnTmXBjl9J0Is3PflEPC8BnIQMMEmLqF\n g5nOmyFzIbytoWbCSgtgrDiQ1ZduHJrBLGoRIwc=", "X-Google-Smtp-Source": "\n AGHT+IH/+w7JMdZfroA5z7pcMVfThkovmoaBNdcEQHA82PsY7Nl1GVm1xFkrywIgJnIHjT4FddDv9Q==", "X-Received": "by 2002:a17:902:f7ce:b0:1c7:47f4:7c86 with SMTP id\n h14-20020a170902f7ce00b001c747f47c86mr468696plw.15.1696364963279;\n Tue, 03 Oct 2023 13:29:23 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "David Christensen <drc@linux.vnet.ibm.com>, stable@dpdk.org,\n Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v3 4/4] net/tap: use rte_ether_unformat_address", "Date": "Tue, 3 Oct 2023 13:29:09 -0700", "Message-Id": "<20231003202909.391330-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231003202909.391330-1-stephen@networkplumber.org>", "References": "<20230929163611.62691-1-stephen@networkplumber.org>\n <20231003202909.391330-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: David Christensen <drc@linux.vnet.ibm.com>\n\nBuilding DPDK with gcc 12 on a ppc64le system generates a\nstringop-overflow warning. Replace the local MAC address\nvalidation function parse_user_mac() with a call to\nrte_ether_unformat_addr() instead.\n\nBugzilla ID: 1197\nCc: stable@dpdk.org\n\nSigned-off-by: David Christensen <drc@linux.vnet.ibm.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.c | 25 +------------------------\n 1 file changed, 1 insertion(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex bf98f7555990..b25a52655fa2 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -2267,29 +2267,6 @@ set_remote_iface(const char *key __rte_unused,\n \treturn 0;\n }\n \n-static int parse_user_mac(struct rte_ether_addr *user_mac,\n-\t\tconst char *value)\n-{\n-\tunsigned int index = 0;\n-\tchar mac_temp[strlen(ETH_TAP_USR_MAC_FMT) + 1], *mac_byte = NULL;\n-\n-\tif (user_mac == NULL || value == NULL)\n-\t\treturn 0;\n-\n-\tstrlcpy(mac_temp, value, sizeof(mac_temp));\n-\tmac_byte = strtok(mac_temp, \":\");\n-\n-\twhile ((mac_byte != NULL) &&\n-\t\t\t(strlen(mac_byte) <= 2) &&\n-\t\t\t(strlen(mac_byte) == strspn(mac_byte,\n-\t\t\t\t\tETH_TAP_CMP_MAC_FMT))) {\n-\t\tuser_mac->addr_bytes[index++] = strtoul(mac_byte, NULL, 16);\n-\t\tmac_byte = strtok(NULL, \":\");\n-\t}\n-\n-\treturn index;\n-}\n-\n static int\n set_mac_type(const char *key __rte_unused,\n \t const char *value,\n@@ -2311,7 +2288,7 @@ set_mac_type(const char *key __rte_unused,\n \t\tgoto success;\n \t}\n \n-\tif (parse_user_mac(user_mac, value) != 6)\n+\tif (rte_ether_unformat_addr(value, user_mac) < 0)\n \t\tgoto error;\n success:\n \tTAP_LOG(DEBUG, \"TAP user MAC param (%s)\", value);\n", "prefixes": [ "v3", "4/4" ] }