Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 132351,
    "url": "http://patchwork.dpdk.org/api/patches/132351/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231005230648.68244-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231005230648.68244-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231005230648.68244-3-stephen@networkplumber.org",
    "date": "2023-10-05T23:06:46",
    "name": "[v2,2/4] dumpcap: allow multiple invocations",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fec657889a7c013424bd8f37c2aa22476e63279c",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231005230648.68244-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 29747,
            "url": "http://patchwork.dpdk.org/api/series/29747/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29747",
            "date": "2023-10-05T23:06:44",
            "name": "dumpcap and pcapng fixes",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/29747/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/132351/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/132351/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E78F8426C7;\n\tFri,  6 Oct 2023 01:07:14 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0E7D402EA;\n\tFri,  6 Oct 2023 01:07:03 +0200 (CEST)",
            "from mail-oo1-f52.google.com (mail-oo1-f52.google.com\n [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id 10A80402CF\n for <dev@dpdk.org>; Fri,  6 Oct 2023 01:07:01 +0200 (CEST)",
            "by mail-oo1-f52.google.com with SMTP id\n 006d021491bc7-57e3c2adbf0so841357eaf.2\n for <dev@dpdk.org>; Thu, 05 Oct 2023 16:07:01 -0700 (PDT)",
            "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n d13-20020aa7814d000000b00690cd981652sm112665pfn.61.2023.10.05.16.06.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 Oct 2023 16:07:00 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696547221;\n x=1697152021; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=omUtTH7y7VOw30b39TLXxrqp0tKrYGDXycHE1fkYinQ=;\n b=KtzjHrk7GmTWUJlq0JnEV6VwqiS54li8D4hysIQMVZs/oF4MjLpAujXK8C/NoJ3+tR\n N0XXLm4RXmXLcCIuUzHbHeac2kbAbHRZK2kFJFm7707zZbUsSl3dAlo7+RSHMRsyrYb2\n NPTHyz457HpuwnzE27ZOMZqfec3rErR6+ZROYwHcKHL5sZxN2Ha9STLv6jl+JUuvtlta\n gMB+ZZ2DdkLItdx9ZW1HxoyxaYBx1WfO5hByZAMlurDEvD8D5QQ1grp+tpBHWPyJhi+e\n qSOisQi1p8Y21U6CjVZQZWg6qkBE42/bGta2tMqE/K6tj5QIYIdl5afBVvWkDMfg/dDV\n w6dw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1696547221; x=1697152021;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=omUtTH7y7VOw30b39TLXxrqp0tKrYGDXycHE1fkYinQ=;\n b=lTUpurjFGZYMVvf/ahTkP87mgtzEvyL6y1Ix5cLz9+01Adu7EmgWEPI/93kcksAXRw\n vWsyO/2PiCvSPfIR7rQi8fbS1QFDwvkMxW95NSqB/yUg44IYvN0MMBktmnuBODzU95F9\n SYbgsedlZPCrCNVfp6QiGCyQixVynwSK5b73OYCo+aqJT/wHeAptvoxR6DZx756Ysub6\n Yg3ctJaQUArawDUQ5jquWUJgCuWi4JIytloBuluoNONuBaFyIwHcmEozbqGh3lFYO6CH\n dhP8y8SM9+vYgCMIbRxFjqqg86lDWhWKkYZcW83w8pvKfbfyFORi/g46d6sJ8xsMQNsY\n UvYQ==",
        "X-Gm-Message-State": "AOJu0YyTY4DzxQFVVXddk+Bk0Y1EyGOnJGH119TL7GrDt08bNNkKrvQA\n /M0ikHCFvLdmq+i/LXVWcaapJ5odPEqNIfaFu80=",
        "X-Google-Smtp-Source": "\n AGHT+IGTZ5ltmKK6YJEbwNt2ovZwgA4bCCFy9TnuuYCuC1KWq76O74VZ8UM729+ogJIItp3j39lDwQ==",
        "X-Received": "by 2002:a05:6358:921:b0:143:8f7f:9150 with SMTP id\n r33-20020a056358092100b001438f7f9150mr7438403rwi.13.1696547220845;\n Thu, 05 Oct 2023 16:07:00 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Isaac Boukris <iboukris@gmail.com>, Reshma Pattan <reshma.pattan@intel.com>",
        "Subject": "[PATCH v2 2/4] dumpcap: allow multiple invocations",
        "Date": "Thu,  5 Oct 2023 16:06:46 -0700",
        "Message-Id": "<20231005230648.68244-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20231005230648.68244-1-stephen@networkplumber.org>",
        "References": "<20230921042349.104150-1-stephen@networkplumber.org>\n <20231005230648.68244-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "If dumpcap is run twice with each instance pointing a different\ninterface, it would fail because of overlap in ring a pool names.\nFix by putting process id in the name.\n\nFixes: cbb44143be74 (\"app/dumpcap: add new packet capture application\")\nReported-by: Isaac Boukris <iboukris@gmail.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/dumpcap/main.c | 28 ++++++++++++++--------------\n 1 file changed, 14 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex 64294bbfb3e6..37754fd06f4f 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -44,7 +44,6 @@\n #include <pcap/pcap.h>\n #include <pcap/bpf.h>\n \n-#define RING_NAME \"capture-ring\"\n #define MONITOR_INTERVAL  (500 * 1000)\n #define MBUF_POOL_CACHE_SIZE 32\n #define BURST_SIZE 32\n@@ -647,6 +646,7 @@ static void dpdk_init(void)\n static struct rte_ring *create_ring(void)\n {\n \tstruct rte_ring *ring;\n+\tchar ring_name[RTE_RING_NAMESIZE];\n \tsize_t size, log2;\n \n \t/* Find next power of 2 >= size. */\n@@ -660,28 +660,28 @@ static struct rte_ring *create_ring(void)\n \t\tring_size = size;\n \t}\n \n-\tring = rte_ring_lookup(RING_NAME);\n-\tif (ring == NULL) {\n-\t\tring = rte_ring_create(RING_NAME, ring_size,\n-\t\t\t\t\trte_socket_id(), 0);\n-\t\tif (ring == NULL)\n-\t\t\trte_exit(EXIT_FAILURE, \"Could not create ring :%s\\n\",\n-\t\t\t\t rte_strerror(rte_errno));\n-\t}\n+\t/* Want one ring per invocation of program */\n+\tsnprintf(ring_name, sizeof(ring_name),\n+\t\t \"dumpcap-%u\", getpid());\n+\n+\tring = rte_ring_create(ring_name, ring_size,\n+\t\t\t       rte_socket_id(), 0);\n+\tif (ring == NULL)\n+\t\trte_exit(EXIT_FAILURE, \"Could not create ring :%s\\n\",\n+\t\t\t rte_strerror(rte_errno));\n+\n \treturn ring;\n }\n \n static struct rte_mempool *create_mempool(void)\n {\n \tconst struct interface *intf;\n-\tstatic const char pool_name[] = \"capture_mbufs\";\n+\tchar pool_name[RTE_MEMPOOL_NAMESIZE];\n \tsize_t num_mbufs = 2 * ring_size;\n \tstruct rte_mempool *mp;\n \tuint32_t data_size = 128;\n \n-\tmp = rte_mempool_lookup(pool_name);\n-\tif (mp)\n-\t\treturn mp;\n+\tsnprintf(pool_name, sizeof(pool_name), \"capture_%u\", getpid());\n \n \t/* Common pool so size mbuf for biggest snap length */\n \tTAILQ_FOREACH(intf, &interfaces, next) {\n@@ -826,7 +826,7 @@ static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp)\n \t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\"Packet dump enable on %u:%s failed %s\\n\",\n \t\t\t\tintf->port, intf->name,\n-\t\t\t\trte_strerror(-ret));\n+\t\t\t\trte_strerror(rte_errno));\n \t\t}\n \n \t\tif (intf->opts.promisc_mode) {\n",
    "prefixes": [
        "v2",
        "2/4"
    ]
}