Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132473/?format=api
{ "id": 132473, "url": "http://patchwork.dpdk.org/api/patches/132473/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231010202049.771959-4-nicolas.chautru@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231010202049.771959-4-nicolas.chautru@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231010202049.771959-4-nicolas.chautru@intel.com", "date": "2023-10-10T20:20:40", "name": "[v6,03/12] baseband/acc: remove the 4G SO capability for VRB1", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "60dbabd0513becad8858ddda223464c41a118dcf", "submitter": { "id": 1314, "url": "http://patchwork.dpdk.org/api/people/1314/?format=api", "name": "Chautru, Nicolas", "email": "nicolas.chautru@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231010202049.771959-4-nicolas.chautru@intel.com/mbox/", "series": [ { "id": 29799, "url": "http://patchwork.dpdk.org/api/series/29799/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29799", "date": "2023-10-10T20:20:37", "name": "VRB2 bbdev PMD introduction", "version": 6, "mbox": "http://patchwork.dpdk.org/series/29799/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132473/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132473/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1B25142354;\n\tTue, 10 Oct 2023 22:21:14 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DBFE4406BA;\n\tTue, 10 Oct 2023 22:20:53 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 1664E4028A\n for <dev@dpdk.org>; Tue, 10 Oct 2023 22:20:49 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Oct 2023 13:20:48 -0700", "from spr-npg-bds1-eec2.sn.intel.com (HELO spr-npg-bds1-eec2..)\n ([10.233.181.123])\n by fmsmga004.fm.intel.com with ESMTP; 10 Oct 2023 13:20:48 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1696969250; x=1728505250;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ev2ReHiWVAKtpr2b3oZJ77uStM9AaCU+4xZq8q0v2vw=;\n b=VW4gHaQzcqnpHLWCuvTc1G/hrEuwf8yZucPsR3jICxYo81oyXpuXSGk+\n 4wNX/TRB8kSr3w/vC0+Q8xA5hN+WHVQq8rrHGXzc69vviCApfgGLleOCt\n F1f07LDRCVpKNbAH4pkvQWZg5P9r8pxozNLFGfb1lham1YQ+Pp6ijoC0N\n Om4BCJVu8VXO+RaV2xiqQy19r5XhJJey70Uz3AWZB/78Hf2KCx5LPVRq9\n UQefm8HEFwoIvNujlc1VSESwR6h9jiJs3rayP5b0b+uVprFOzNoMYavPv\n +ok0iSSuydB3Rc7smVj5IvbMhmP52sie2OL8KlY1cmRoOKpqYBQ10gRNn g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10859\"; a=\"364789088\"", "E=Sophos;i=\"6.03,213,1694761200\"; d=\"scan'208\";a=\"364789088\"", "E=McAfee;i=\"6600,9927,10859\"; a=\"823904076\"", "E=Sophos;i=\"6.03,213,1694761200\"; d=\"scan'208\";a=\"823904076\"" ], "X-ExtLoop1": "1", "From": "Nicolas Chautru <nicolas.chautru@intel.com>", "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com", "Cc": "hemant.agrawal@nxp.com, david.marchand@redhat.com,\n hernan.vargas@intel.com,\n Nicolas Chautru <nicolas.chautru@intel.com>", "Subject": "[PATCH v6 03/12] baseband/acc: remove the 4G SO capability for VRB1", "Date": "Tue, 10 Oct 2023 20:20:40 +0000", "Message-Id": "<20231010202049.771959-4-nicolas.chautru@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231010202049.771959-1-nicolas.chautru@intel.com>", "References": "<20231010202049.771959-1-nicolas.chautru@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This removes the specific capability and support of LTE Decoder\nSoft Output option on the VRB1 PMD.\n\nThis is triggered as a vendor decision to defeature the related optional\ncapability so that to avoid theoretical risk of race conditions\nimpacting the device reliability. That optional APP LLR output is\nnot impacting the actual decoder hard output.\n\nSigned-off-by: Nicolas Chautru <nicolas.chautru@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n doc/guides/bbdevs/vrb1.rst | 4 ----\n drivers/baseband/acc/rte_vrb_pmd.c | 10 ++++++----\n 2 files changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/bbdevs/vrb1.rst b/doc/guides/bbdevs/vrb1.rst\nindex 9c48d30964..fdefb20651 100644\n--- a/doc/guides/bbdevs/vrb1.rst\n+++ b/doc/guides/bbdevs/vrb1.rst\n@@ -71,11 +71,7 @@ The Intel vRAN Boost v1.0 PMD supports the following bbdev capabilities:\n - ``RTE_BBDEV_TURBO_EARLY_TERMINATION``: set early termination feature.\n - ``RTE_BBDEV_TURBO_DEC_SCATTER_GATHER``: supports scatter-gather for input/output data.\n - ``RTE_BBDEV_TURBO_HALF_ITERATION_EVEN``: set half iteration granularity.\n- - ``RTE_BBDEV_TURBO_SOFT_OUTPUT``: set the APP LLR soft output.\n- - ``RTE_BBDEV_TURBO_EQUALIZER``: set the turbo equalizer feature.\n- - ``RTE_BBDEV_TURBO_SOFT_OUT_SATURATE``: set the soft output saturation.\n - ``RTE_BBDEV_TURBO_CONTINUE_CRC_MATCH``: set to run an extra odd iteration after CRC match.\n- - ``RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT``: set if negative APP LLR output supported.\n - ``RTE_BBDEV_TURBO_MAP_DEC``: supports flexible parallel MAP engine decoding.\n \n * For the FFT operation:\ndiff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c\nindex b86e814f8f..1f7f82deae 100644\n--- a/drivers/baseband/acc/rte_vrb_pmd.c\n+++ b/drivers/baseband/acc/rte_vrb_pmd.c\n@@ -1024,15 +1024,11 @@ vrb_dev_info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info *dev_info)\n \t\t\t\t\tRTE_BBDEV_TURBO_SUBBLOCK_DEINTERLEAVE |\n \t\t\t\t\tRTE_BBDEV_TURBO_CRC_TYPE_24B |\n \t\t\t\t\tRTE_BBDEV_TURBO_DEC_CRC_24B_DROP |\n-\t\t\t\t\tRTE_BBDEV_TURBO_EQUALIZER |\n-\t\t\t\t\tRTE_BBDEV_TURBO_SOFT_OUT_SATURATE |\n \t\t\t\t\tRTE_BBDEV_TURBO_HALF_ITERATION_EVEN |\n \t\t\t\t\tRTE_BBDEV_TURBO_CONTINUE_CRC_MATCH |\n-\t\t\t\t\tRTE_BBDEV_TURBO_SOFT_OUTPUT |\n \t\t\t\t\tRTE_BBDEV_TURBO_EARLY_TERMINATION |\n \t\t\t\t\tRTE_BBDEV_TURBO_DEC_INTERRUPTS |\n \t\t\t\t\tRTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN |\n-\t\t\t\t\tRTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT |\n \t\t\t\t\tRTE_BBDEV_TURBO_MAP_DEC |\n \t\t\t\t\tRTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP |\n \t\t\t\t\tRTE_BBDEV_TURBO_DEC_SCATTER_GATHER,\n@@ -1982,6 +1978,12 @@ enqueue_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,\n \tstruct rte_mbuf *input, *h_output_head, *h_output,\n \t\t*s_output_head, *s_output;\n \n+\tif ((q->d->device_variant == VRB1_VARIANT) &&\n+\t\t\t(check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_SOFT_OUTPUT))) {\n+\t\t/* SO not supported for VRB1. */\n+\t\treturn -EPERM;\n+\t}\n+\n \tdesc = acc_desc(q, total_enqueued_cbs);\n \tvrb_fcw_td_fill(op, &desc->req.fcw_td);\n \n", "prefixes": [ "v6", "03/12" ] }