Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132507/?format=api
{ "id": 132507, "url": "http://patchwork.dpdk.org/api/patches/132507/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231011092805.693171-2-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231011092805.693171-2-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231011092805.693171-2-haijie1@huawei.com", "date": "2023-10-11T09:27:26", "name": "[v5,01/40] ethdev: overwrite some comment related to RSS", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9e466bffcdfa56d1e0f7f16a205164abcb8807fc", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231011092805.693171-2-haijie1@huawei.com/mbox/", "series": [ { "id": 29816, "url": "http://patchwork.dpdk.org/api/series/29816/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29816", "date": "2023-10-11T09:27:25", "name": "support setting and querying RSS algorithms", "version": 5, "mbox": "http://patchwork.dpdk.org/series/29816/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132507/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/132507/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2313B4235E;\n\tWed, 11 Oct 2023 11:31:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1808E40A79;\n\tWed, 11 Oct 2023 11:31:32 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 055AF40279\n for <dev@dpdk.org>; Wed, 11 Oct 2023 11:31:29 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4S56rG0sSpzVlYy;\n Wed, 11 Oct 2023 17:27:58 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Wed, 11 Oct 2023 17:31:27 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ori\n Kam <orika@nvidia.com>", "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liudongdong3@huawei.com>", "Subject": "[PATCH v5 01/40] ethdev: overwrite some comment related to RSS", "Date": "Wed, 11 Oct 2023 17:27:26 +0800", "Message-ID": "<20231011092805.693171-2-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231011092805.693171-1-haijie1@huawei.com>", "References": "<20230908080030.3837515-1-haijie1@huawei.com>\n <20231011092805.693171-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "1. overwrite the comments of fields of 'rte_eth_rss_conf'.\n2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.h | 29 ++++++++++++++---------------\n lib/ethdev/rte_flow.h | 3 +++\n 2 files changed, 17 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 8542257721c9..b9e4e21189d2 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -448,24 +448,23 @@ struct rte_vlan_filter_conf {\n /**\n * A structure used to configure the Receive Side Scaling (RSS) feature\n * of an Ethernet port.\n- * If not NULL, the *rss_key* pointer of the *rss_conf* structure points\n- * to an array holding the RSS key to use for hashing specific header\n- * fields of received packets. The length of this array should be indicated\n- * by *rss_key_len* below. Otherwise, a default random hash key is used by\n- * the device driver.\n- *\n- * The *rss_key_len* field of the *rss_conf* structure indicates the length\n- * in bytes of the array pointed by *rss_key*. To be compatible, this length\n- * will be checked in i40e only. Others assume 40 bytes to be used as before.\n- *\n- * The *rss_hf* field of the *rss_conf* structure indicates the different\n- * types of IPv4/IPv6 packets to which the RSS hashing must be applied.\n- * Supplying an *rss_hf* equal to zero disables the RSS feature.\n */\n struct rte_eth_rss_conf {\n-\tuint8_t *rss_key; /**< If not NULL, 40-byte hash key. */\n+\t/**\n+\t * If used to query, the'rss_key_len' indicates the size of rss key of\n+\t * the hardware. And only when rss_key_len is not zero, the 'rss_key'\n+\t * is valid.\n+\t * If used to configure, rss_key_len indicates the length of the\n+\t * 'rss_key' if 'rss_key' is not empty.\n+\t */\n+\tuint8_t *rss_key;\n \tuint8_t rss_key_len; /**< hash key length in bytes. */\n-\tuint64_t rss_hf; /**< Hash functions to apply - see below. */\n+\t/**\n+\t * Indicating which type of packets and which part of the packets\n+\t * to apply for RSS hash, (see RTE_ETH_RSS_*).\n+\t * Setting *rss_hf* to zero disables the RSS feature.\n+\t */\n+\tuint64_t rss_hf;\n };\n \n /*\ndiff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h\nindex b385741fba6d..5d9e3c68af7b 100644\n--- a/lib/ethdev/rte_flow.h\n+++ b/lib/ethdev/rte_flow.h\n@@ -3227,6 +3227,9 @@ struct rte_flow_query_count {\n * Hash function types.\n */\n enum rte_eth_hash_function {\n+\t/**\n+\t * DEFAULT means driver decides which hash algorithm to pick.\n+\t */\n \tRTE_ETH_HASH_FUNCTION_DEFAULT = 0,\n \tRTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */\n \tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */\n", "prefixes": [ "v5", "01/40" ] }