Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132521/?format=api
http://patchwork.dpdk.org/api/patches/132521/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231011092805.693171-16-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231011092805.693171-16-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231011092805.693171-16-haijie1@huawei.com", "date": "2023-10-11T09:27:40", "name": "[v5,15/40] net/fm10k: check RSS hash algorithms", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6dabfb3ba1545f2e45da1cf945b70560bef2afe9", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231011092805.693171-16-haijie1@huawei.com/mbox/", "series": [ { "id": 29816, "url": "http://patchwork.dpdk.org/api/series/29816/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29816", "date": "2023-10-11T09:27:25", "name": "support setting and querying RSS algorithms", "version": 5, "mbox": "http://patchwork.dpdk.org/series/29816/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132521/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132521/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A02CF4235E;\n\tWed, 11 Oct 2023 11:33:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4BCC0410EE;\n\tWed, 11 Oct 2023 11:31:49 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 0B6A040DCB\n for <dev@dpdk.org>; Wed, 11 Oct 2023 11:31:36 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4S56rP1H20zVlYp\n for <dev@dpdk.org>; Wed, 11 Oct 2023 17:28:05 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Wed, 11 Oct 2023 17:31:34 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang\n <xiao.w.wang@intel.com>", "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liudongdong3@huawei.com>", "Subject": "[PATCH v5 15/40] net/fm10k: check RSS hash algorithms", "Date": "Wed, 11 Oct 2023 17:27:40 +0800", "Message-ID": "<20231011092805.693171-16-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231011092805.693171-1-haijie1@huawei.com>", "References": "<20230908080030.3837515-1-haijie1@huawei.com>\n <20231011092805.693171-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "A new field 'algorithm' has been added to rss_conf, check it\nin case of ignoring unsupported values.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 4d3c4c10cfa4..d8b27e84d836 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -452,8 +452,12 @@ fm10k_dev_configure(struct rte_eth_dev *dev)\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tif (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG)\n+\tif (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) {\n \t\tdev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;\n+\t\tif (dev->data->dev_conf.rx_adv_conf.rss_conf.algorithm !=\n+\t\t RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\t\treturn -EINVAL;\n+\t}\n \n \t/* multiple queue mode checking */\n \tret = fm10k_check_mq_mode(dev);\n@@ -2195,6 +2199,9 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\t\tFM10K_RSSRK_ENTRIES_PER_REG))\n \t\treturn -EINVAL;\n \n+\tif (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn -EINVAL;\n+\n \tif (hf == 0)\n \t\treturn -EINVAL;\n \n", "prefixes": [ "v5", "15/40" ] }{ "id": 132521, "url": "