Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132525/?format=api
{ "id": 132525, "url": "http://patchwork.dpdk.org/api/patches/132525/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231011092805.693171-20-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231011092805.693171-20-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231011092805.693171-20-haijie1@huawei.com", "date": "2023-10-11T09:27:44", "name": "[v5,19/40] net/ice: check RSS hash algorithms", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "364e7dfbb6b5121e5797e39f2b17edb32ffd281b", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231011092805.693171-20-haijie1@huawei.com/mbox/", "series": [ { "id": 29816, "url": "http://patchwork.dpdk.org/api/series/29816/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29816", "date": "2023-10-11T09:27:25", "name": "support setting and querying RSS algorithms", "version": 5, "mbox": "http://patchwork.dpdk.org/series/29816/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132525/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132525/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 595994235E;\n\tWed, 11 Oct 2023 11:33:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 35CA141133;\n\tWed, 11 Oct 2023 11:31:54 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 0553040E25\n for <dev@dpdk.org>; Wed, 11 Oct 2023 11:31:38 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.54])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S56sV5Bd7zrTZ2\n for <dev@dpdk.org>; Wed, 11 Oct 2023 17:29:02 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Wed, 11 Oct 2023 17:31:36 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Qiming Yang <qiming.yang@intel.com>, Qi Zhang\n <qi.z.zhang@intel.com>", "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liudongdong3@huawei.com>", "Subject": "[PATCH v5 19/40] net/ice: check RSS hash algorithms", "Date": "Wed, 11 Oct 2023 17:27:44 +0800", "Message-ID": "<20231011092805.693171-20-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231011092805.693171-1-haijie1@huawei.com>", "References": "<20230908080030.3837515-1-haijie1@huawei.com>\n <20231011092805.693171-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "A new field 'algorithm' has been added to rss_conf, check it\nin case of ignoring unsupported values.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/ice/ice_dcf.c | 3 +++\n drivers/net/ice/ice_dcf_ethdev.c | 3 +++\n drivers/net/ice/ice_ethdev.c | 7 +++++++\n 3 files changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c\nindex 7f8f5163acef..bff39cf9d145 100644\n--- a/drivers/net/ice/ice_dcf.c\n+++ b/drivers/net/ice/ice_dcf.c\n@@ -1120,6 +1120,9 @@ ice_dcf_init_rss(struct ice_dcf_hw *hw)\n \t\treturn ice_dcf_configure_rss_lut(hw);\n \t}\n \n+\tif (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn -EINVAL;\n+\n \t/* In IAVF, RSS enablement is set by PF driver. It is not supported\n \t * to set based on rss_conf->rss_hf.\n \t */\ndiff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex 30ad18d8fc20..f0db68c5dee5 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -1405,6 +1405,9 @@ ice_dcf_dev_rss_hash_update(struct rte_eth_dev *dev,\n \tif (!(hw->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF))\n \t\treturn -ENOTSUP;\n \n+\tif (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn -EINVAL;\n+\n \t/* HENA setting, it is enabled by default, no change */\n \tif (!rss_conf->rss_key || rss_conf->rss_key_len == 0) {\n \t\tPMD_DRV_LOG(DEBUG, \"No key to be configured\");\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 4bad39c2c1c9..0cba6f7d7b6a 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3383,6 +3383,10 @@ static int ice_init_rss(struct ice_pf *pf)\n \t\t\treturn -ENOMEM;\n \t\t}\n \t}\n+\n+\tif (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn -EINVAL;\n+\n \t/* configure RSS key */\n \tif (!rss_conf->rss_key)\n \t\tice_get_default_rss_key(vsi->rss_key, vsi->rss_key_size);\n@@ -5046,6 +5050,9 @@ ice_rss_hash_update(struct rte_eth_dev *dev,\n \tstruct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tstruct ice_vsi *vsi = pf->main_vsi;\n \n+\tif (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn -EINVAL;\n+\n \t/* set hash key */\n \tstatus = ice_set_rss_key(vsi, rss_conf->rss_key, rss_conf->rss_key_len);\n \tif (status)\n", "prefixes": [ "v5", "19/40" ] }