Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132584/?format=api
{ "id": 132584, "url": "http://patchwork.dpdk.org/api/patches/132584/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231013030820.425663-2-taozj888@163.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231013030820.425663-2-taozj888@163.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231013030820.425663-2-taozj888@163.com", "date": "2023-10-13T03:08:18", "name": "[v2,1/3] examples/l3fwd: relax RSS requirement with option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d45b18e04db4bc6eeccd021822113023c0396557", "submitter": { "id": 3044, "url": "http://patchwork.dpdk.org/api/people/3044/?format=api", "name": "Trevor Tao", "email": "taozj888@163.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231013030820.425663-2-taozj888@163.com/mbox/", "series": [ { "id": 29828, "url": "http://patchwork.dpdk.org/api/series/29828/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29828", "date": "2023-10-13T03:08:19", "name": "example/l3fwd: relax l3fwd rx RSS/Offload if needed", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29828/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132584/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/132584/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E322B42338;\n\tFri, 13 Oct 2023 05:08:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 17E29402F2;\n\tFri, 13 Oct 2023 05:08:40 +0200 (CEST)", "from m12.mail.163.com (m12.mail.163.com [220.181.12.217])\n by mails.dpdk.org (Postfix) with ESMTP id EEDF8402E8\n for <dev@dpdk.org>; Fri, 13 Oct 2023 05:08:37 +0200 (CEST)", "from u2204.. (unknown [49.76.95.19])\n by zwqz-smtp-mta-g4-1 (Coremail) with SMTP id\n _____wDXr+WmtChlQbqiAQ--.22720S3;\n Fri, 13 Oct 2023 11:08:27 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=8Rdwp\n RhaqGGRpNqx7JKsPpwfI4tIvGlaPlZXdh+/6gU=; b=R71nSW9SvDHvRbJM4HNXW\n uJVu/yhFrbuZKGadHdGgFjlDQsLwvH95+Rb0XNfTbKUr29hlPqNqH+cH0JC3keYk\n WQ9DQsmq4+YYVKBEhw9xNDPoUEHOAL5q+ISJfP3e28XIoSRnuwt/9r91dznSqEBm\n DXaCn56c1j93EKhepRZz1s=", "From": "Trevor Tao <taozj888@163.com>", "To": "dev@dpdk.org", "Cc": "Trevor Tao <taozj888@163.com>", "Subject": "[PATCH v2 1/3] examples/l3fwd: relax RSS requirement with option", "Date": "Fri, 13 Oct 2023 03:08:18 +0000", "Message-Id": "<20231013030820.425663-2-taozj888@163.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231013030820.425663-1-taozj888@163.com>", "References": "<20231013030820.425663-1-taozj888@163.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "_____wDXr+WmtChlQbqiAQ--.22720S3", "X-Coremail-Antispam": "1Uf129KBjvJXoWxCrW3ZFWrury5AFWUKF4DJwb_yoW5Kw47pF\n s8Gr9rXF1vvw43t3WFyF9xWrs8JFWUAws8Ars3Z343C3WUtFZ3Wr40krn8XFn7GF18WrWU\n X3yrXryxGF4qywUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0JUTlkcUUUUU=", "X-Originating-IP": "[49.76.95.19]", "X-CM-SenderInfo": "hwdr6yqyyyqiywtou0bp/xtbBlw0Ix2I0anqvcQAAsN", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS\nby default, but some hw and/or virtual interface does not\nsupport the RSS and offload mode presupposed, e.g., some\nvirtio interfaces in the cloud don't support\nRSS and the error msg may like:\n\nvirtio_dev_configure(): RSS support requested but not supported by\nthe device\nPort0 dev_configure = -95\n\nSo to enable the l3fwd running in that environment, the Rx mode requirement\ncan be relaxed to reflect the hardware feature reality here, and the l3fwd\ncan run smoothly then.\n\nAn option named \"relax-rx-mode\" is added to enable the relax action\nhere, and it's disabled by default.\n\nSigned-off-by: Trevor Tao <taozj888@163.com>\n---\n examples/l3fwd/main.c | 19 ++++++++++++++++++-\n 1 file changed, 18 insertions(+), 1 deletion(-)", "diff": "diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex 6063eb1399..36a2a77756 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -73,6 +73,7 @@ static enum L3FWD_LOOKUP_MODE lookup_mode;\n static int numa_on = 1; /**< NUMA is enabled by default. */\n static int parse_ptype; /**< Parse packet type using rx callback, and */\n \t\t\t/**< disabled by default */\n+static int relax_rx_mode; /**< Relax RX mode is disabled by default */\n static int per_port_pool; /**< Use separate buffer pools per port; disabled */\n \t\t\t /**< by default */\n \n@@ -678,6 +679,7 @@ static const char short_options[] =\n #define CMD_LINE_OPT_MAX_PKT_LEN \"max-pkt-len\"\n #define CMD_LINE_OPT_HASH_ENTRY_NUM \"hash-entry-num\"\n #define CMD_LINE_OPT_PARSE_PTYPE \"parse-ptype\"\n+#define CMD_LINE_OPT_RELAX_RX_MODE \"relax-rx-mode\"\n #define CMD_LINE_OPT_PER_PORT_POOL \"per-port-pool\"\n #define CMD_LINE_OPT_MODE \"mode\"\n #define CMD_LINE_OPT_EVENTQ_SYNC \"eventq-sched\"\n@@ -705,6 +707,7 @@ enum {\n \tCMD_LINE_OPT_MAX_PKT_LEN_NUM,\n \tCMD_LINE_OPT_HASH_ENTRY_NUM_NUM,\n \tCMD_LINE_OPT_PARSE_PTYPE_NUM,\n+\tCMD_LINE_OPT_RELAX_RX_MODE_NUM,\n \tCMD_LINE_OPT_RULE_IPV4_NUM,\n \tCMD_LINE_OPT_RULE_IPV6_NUM,\n \tCMD_LINE_OPT_ALG_NUM,\n@@ -728,6 +731,7 @@ static const struct option lgopts[] = {\n \t{CMD_LINE_OPT_MAX_PKT_LEN, 1, 0, CMD_LINE_OPT_MAX_PKT_LEN_NUM},\n \t{CMD_LINE_OPT_HASH_ENTRY_NUM, 1, 0, CMD_LINE_OPT_HASH_ENTRY_NUM_NUM},\n \t{CMD_LINE_OPT_PARSE_PTYPE, 0, 0, CMD_LINE_OPT_PARSE_PTYPE_NUM},\n+\t{CMD_LINE_OPT_RELAX_RX_MODE, 0, 0, CMD_LINE_OPT_RELAX_RX_MODE_NUM},\n \t{CMD_LINE_OPT_PER_PORT_POOL, 0, 0, CMD_LINE_OPT_PARSE_PER_PORT_POOL},\n \t{CMD_LINE_OPT_MODE, 1, 0, CMD_LINE_OPT_MODE_NUM},\n \t{CMD_LINE_OPT_EVENTQ_SYNC, 1, 0, CMD_LINE_OPT_EVENTQ_SYNC_NUM},\n@@ -853,6 +857,11 @@ parse_args(int argc, char **argv)\n \t\t\tparse_ptype = 1;\n \t\t\tbreak;\n \n+\t\tcase CMD_LINE_OPT_RELAX_RX_MODE_NUM:\n+\t\t\tprintf(\"Relax rx mode is enabled\\n\");\n+\t\t\trelax_rx_mode = 1;\n+\t\t\tbreak;\n+\n \t\tcase CMD_LINE_OPT_PARSE_PER_PORT_POOL:\n \t\t\tprintf(\"per port buffer pool is enabled\\n\");\n \t\t\tper_port_pool = 1;\n@@ -1257,8 +1266,16 @@ l3fwd_poll_resource_setup(void)\n \t\tlocal_port_conf.rx_adv_conf.rss_conf.rss_hf &=\n \t\t\tdev_info.flow_type_rss_offloads;\n \n-\t\tif (dev_info.max_rx_queues == 1)\n+\t\tif (dev_info.max_rx_queues == 1) {\n \t\t\tlocal_port_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;\n+\t\t}\n+\n+\t\t/* relax the rx rss requirement */\n+\t\tif (relax_rx_mode && !local_port_conf.rx_adv_conf.rss_conf.rss_hf) {\n+\t\t\tprintf(\"warning: modified the rx mq_mode to RTE_ETH_MQ_RX_NONE base on\"\n+\t\t\t\t\t\" device capability\\n\");\n+\t\t\t\tlocal_port_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;\n+\t\t}\n \n \t\tif (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=\n \t\t\t\tport_conf.rx_adv_conf.rss_conf.rss_hf) {\n", "prefixes": [ "v2", "1/3" ] }