Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 132593,
    "url": "http://patchwork.dpdk.org/api/patches/132593/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231013060653.1006410-4-chaoyong.he@corigine.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231013060653.1006410-4-chaoyong.he@corigine.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231013060653.1006410-4-chaoyong.he@corigine.com",
    "date": "2023-10-13T06:06:45",
    "name": "[v3,03/11] net/nfp: unify the type of integer variable",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a57882b7fef22981d6ca558a4b6b3851f0824d87",
    "submitter": {
        "id": 2554,
        "url": "http://patchwork.dpdk.org/api/people/2554/?format=api",
        "name": "Chaoyong He",
        "email": "chaoyong.he@corigine.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231013060653.1006410-4-chaoyong.he@corigine.com/mbox/",
    "series": [
        {
            "id": 29831,
            "url": "http://patchwork.dpdk.org/api/series/29831/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29831",
            "date": "2023-10-13T06:06:42",
            "name": "Unify the PMD coding style",
            "version": 3,
            "mbox": "http://patchwork.dpdk.org/series/29831/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/132593/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/132593/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E657742354;\n\tFri, 13 Oct 2023 08:07:51 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 53A6540689;\n\tFri, 13 Oct 2023 08:07:33 +0200 (CEST)",
            "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2139.outbound.protection.outlook.com [40.107.220.139])\n by mails.dpdk.org (Postfix) with ESMTP id DCEF44067E\n for <dev@dpdk.org>; Fri, 13 Oct 2023 08:07:30 +0200 (CEST)",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6296.namprd13.prod.outlook.com (2603:10b6:510:237::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Fri, 13 Oct\n 2023 06:07:29 +0000",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Fri, 13 Oct 2023\n 06:07:29 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FhssbF7PUTgnJusMT/4Derrow4dVDMm5vIGKuw2qRdVKgoY3wGz0cmujQ00SyUdXLDcDfHTY4+3uRNY7z6qS5t0nj6kZIl/gipHRL2WsUci4EA2cEfGae8lQKhhXrHdFPXaWwtsPyq6EOB3/MZiFT36DV/Uil8YTF8nXEOmua8lrMnC3j+KPhu8G7BR1hQTKecBAANC0npRfAkgT9siICjXvwhrWxWWunZIe1+33yJZ3QEOYMAl0iCgAqm3sBtbYirjWveMEWo4DHWHOxV/3K+/F/0m+Eb5fVuxd+cOgiqJ9Spits5ETXKxGNJWg3zxNttVyH1sM3SEGSfW4VmL0SQ==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=IJuInOpW4F5Zff9n9OhSJxO9SUC918cR0qa/G1DvFYg=;\n b=jYq/RceHuN1v8kqbizxhgb3MyUSI3L44PkuVdzwL4yawVYFXlXAmZAh+CfMtPMEXrho69OJIk9uz1LSC/vtCYqXwDvVU3Es7wA9YfxGM8X54j7LXIXl1PuM0exLTAeDMfzBz8j1wFxcPAaQnd0L3PpxZaSI4+sHoDdnuu8aucCMh8y1lLXFHZQs18f/8sGKCQ1JbhsVRyy1hPG1QX46rVq/JUALVxQsO9BMxOCYUKG0oalZQIUux/bMkvPpaJN2NY02sxC+RYY+nr//GyMmE3XolpscSJDR2TgehDivhkpCBv5lcOpQTEl84PYypb/6jbcm7LNkDnKqXhcJLq/2GZw==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=IJuInOpW4F5Zff9n9OhSJxO9SUC918cR0qa/G1DvFYg=;\n b=XstbrRMrNCwe66ju1pwEBf6Kt0TuOhS/8NH4m+F6I3o5QLg5tpogpoWXCWqJeJGuXGDEeZXCo51lJWMW9DmCIoAUWEThBJEDkEld5ZjeVqql7bQFNX/6Cqdh3qqnoLxOsUOaCxza5nZZFD/Tej0zoyV3szUJ4Ja4aqeR3rHiKqc=",
        "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;",
        "From": "Chaoyong He <chaoyong.he@corigine.com>",
        "To": "dev@dpdk.org",
        "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com>",
        "Subject": "[PATCH v3 03/11] net/nfp: unify the type of integer variable",
        "Date": "Fri, 13 Oct 2023 14:06:45 +0800",
        "Message-Id": "<20231013060653.1006410-4-chaoyong.he@corigine.com>",
        "X-Mailer": "git-send-email 2.39.1",
        "In-Reply-To": "<20231013060653.1006410-1-chaoyong.he@corigine.com>",
        "References": "<20231012012704.483828-1-chaoyong.he@corigine.com>\n <20231013060653.1006410-1-chaoyong.he@corigine.com>",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-ClientProxiedBy": "SI2PR06CA0008.apcprd06.prod.outlook.com\n (2603:1096:4:186::23) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)",
        "MIME-Version": "1.0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6296:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "b1fea487-36e4-43ec-e84d-08dbcbb2ae39",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n /jRccfR6RY6VsMCPMfq5ESo2wuJ/GYkbvu7p8/OfUWTQX/KpFhTaUqBHuQWu9oCAK8Cy4jQBv8Gqnt5eIvGBseSRSl0WHmJ6n849sjLXILWW05vViMKLqfSZEKsow1qnPuZY68w1aezDGfWy0SCQa1ouKZBprlLarEN37iX23aPp097vsmKAhBLElpsUfCwYTORfIxML42SsjILtL1UA2YXxcVZdGRXkcv2IU3Gl431RSXmOzYMEj6aTNGDI9+m4Qq+XqpJCJ3hD3hh+Qh/FzG8fTM0zXgEcEwiCMNO/zPoOp2ap3JxVIc0eIeM8F3psNoi/FXwik/8rwhfMSRoV2egesfaHpUUG0H6rRRcxwQwzrb9NxEvwZxySU5X7qpeReHJ1u8B5Nx8qcIXXfRGJ+CnFoPqnd9YnsUhZKKGoJxAO5n6HfdLB9zyzQ6AwKbAHOJy+WNDTtpo6AkHT1vlob4vFyoxe8isy9LFnkX1WtYNgTx5n9ptIve9NDN9A4rk5mPf+NMkoEDEcWQAumLZZyXAH/JeBSjrIhtlqNbFHqmcM+hVSyAvI9HZ4DiEzfjq8AvSrgyuuTk9s7knjyBYhXpaaHbG+GPxelwQ+V3PvMXyz+qTWsR1tCgs12QQ0iWAUv632bAZasUNn6W+1shZFPwsDCUT588rlqLHOJMd59ag=",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(396003)(366004)(346002)(39830400003)(376002)(136003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(30864003)(86362001)(36756003)(83380400001)(2906002)(38350700002)(38100700002)(44832011)(5660300002)(8676002)(8936002)(4326008)(6666004)(316002)(66556008)(54906003)(66946007)(66476007)(52116002)(6512007)(6916009)(6506007)(41300700001)(6486002)(107886003)(1076003)(26005)(478600001)(2616005);\n DIR:OUT; SFP:1102;",
        "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1",
        "X-MS-Exchange-AntiSpam-MessageData-0": "\n QXpmDjPmOEAIHWNJ5CcUhoxwdriEWXzgBMuryfhVgBGHLnIu/F2LKjFmJhGOK2dSsOA7uzos+H9ZgnBFLinqWahmKOjlCfLsvCdMaDSQtN3DAanjnsppFxs+cKHkhcfRpAHXz/u9+Zj5VRZzXzUQ+ks/Okz/xpnTXsv0U8Abo3/r1cukVmvRJfwMtL0ekuYmyfys7GB5qi7MtTyYXXP95H9leYfu6tzv3MDEnf+eK/txVIvogmIGmjKsXyBl9blP6nX1yAgaOjWHPoz2GDdBLzTcPZvWsSZDGWqyDbpxFrH1q2lOACiInEUC+fItoJUV6dSf8iWr21fLgD188YphSKdT1yROZqr1Z42Jr3RGDw+kuer/HK1BcLOdTtJKEoEK+hgvbNO97Ec1dNdifSdzxT76u0PTSB0KNqlz05kE2gLZdHyrvxVRKfczEY8QDreoMyITHdeMctX2OXCAuakxKH9PrzUKpuLHnT7VnCGLQw4xt4CqU8jhsWNjeiszPfa/ItCujC6f6vJnHvBrUZVaZJYc3yQD+uvN4qqcR1VmA+Tk5CkT+4+CNJK+qE7ZwIBZv+NM6I8uXbl1HJ9IFv6hSJPxaKxZRKgsmoAXtOmaVuouGV27syxXo5phLQRjyvy/n26+Op6BcFw+gARjOZIaQvhEA2Wp5YqqC8GcWW4NhxmVBG+TKE7bXe7QPzXPKM1kK+oT8zyGjK2doOBXZJ19EUw73Kq53U/yo/l1ljwMeEhD19L6jij+lT3PvicKDiW6dc0nOS7dKxL5GBpTAkS7R3DhGsaSJpSNU8rl8S0/HHtkx6E4sZa5Jl/ICTEz4UQpJsSv7gc/W+cneiyW3O3MSTyfWQ6SQAnKfnXj2ou2wcoBOtTwMWs59vQfO3I6ZTI6u/fmDSLJAUX4L/k2PJCqRaR1MIblqjpehRllOKPqgkQwydVMDd+F0LOUK8wAZeLq1IN0JZ3Q/dYPtfmHLoKGzwO6j8Zf8v2RqN9XIKOCmZpJxuGg0PjA/q3glX/U656z6agdxwbmynY88z8BjwwcmYvvhAQguzG1124yyLMAAD30QTb3mzRoSidflux0af9Zh5vpr4VCS1XflWRVZbj0wyrBnP8ggblu6rlaLWEcB7Rftg543EFsn0n+ruW2vlHT05o5wfu0P4/ysa3dVNWHWIMO30rLrWhAhUDix5qj12w21NfmTW81QteIy5xWBgdOVS2r3uAfSwfl5c5VcRutSI2hRJvv7d2ZkyOMA6tHc/56Tm096A+cMJUh7fPKbpZuQDSYH7iAUDIGA3p/3drq5Sj1BOjYS+FJkxCI3/acSuFq4QRJU41IA2T/WTxCSXZdhCd2px3gfbLja1qEPxbMa4pL5fG0LAE5NlL/lWvVVJ6TrC3V2nf1k+yspVX7J/8TKo9SfIkxmLjQIvyvl85W29dPDesIDL7hukK1d1LXfwL9bLvHpwtl/86zX9FiFJoTlb9WHF1rrI/pmngPMa1EuiXSP4Q6QGZ/wpj/tCYEdNBeE4Y0D9GLU9XrLNikdyUFS2qHu+Mori0uprEVh2j+0vaMhWY54L4tkgRMgiwNGVRMZw/NwEWv+O7pGJNlm20Df/YmUBTMpNxNCBzeSkeXHg==",
        "X-OriginatorOrg": "corigine.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b1fea487-36e4-43ec-e84d-08dbcbb2ae39",
        "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Oct 2023 06:07:29.3241 (UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n kfNV/s5JX8gMF9g4NNYTLVUl+QlVCqVkBr6IrQfuo3VLdJXTD/UA9gRDzgmnL5Hb3qeLDtCY5+9zF94TtpFiiVSxy0jKl7VhHK+bB5z6RoA=",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6296",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Unify the type of integer variable to the DPDK prefer style.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower.c      |  2 +-\n drivers/net/nfp/flower/nfp_flower_cmsg.c | 16 +++++-----\n drivers/net/nfp/nfd3/nfp_nfd3_dp.c       |  6 ++--\n drivers/net/nfp/nfp_common.c             | 37 +++++++++++++-----------\n drivers/net/nfp/nfp_common.h             | 16 +++++-----\n drivers/net/nfp/nfp_ethdev.c             | 24 +++++++--------\n drivers/net/nfp/nfp_ethdev_vf.c          |  2 +-\n drivers/net/nfp/nfp_flow.c               |  8 ++---\n drivers/net/nfp/nfp_rxtx.c               | 12 ++++----\n drivers/net/nfp/nfp_rxtx.h               |  2 +-\n 10 files changed, 64 insertions(+), 61 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c\nindex 3352693d71..7dd1423aaf 100644\n--- a/drivers/net/nfp/flower/nfp_flower.c\n+++ b/drivers/net/nfp/flower/nfp_flower.c\n@@ -26,7 +26,7 @@ nfp_pf_repr_enable_queues(struct rte_eth_dev *dev)\n {\n \tstruct nfp_net_hw *hw;\n \tuint64_t enabled_queues = 0;\n-\tint i;\n+\tuint16_t i;\n \tstruct nfp_flower_representor *repr;\n \n \trepr = dev->data->dev_private;\ndiff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c b/drivers/net/nfp/flower/nfp_flower_cmsg.c\nindex 6b9532f5b6..5d6912b079 100644\n--- a/drivers/net/nfp/flower/nfp_flower_cmsg.c\n+++ b/drivers/net/nfp/flower/nfp_flower_cmsg.c\n@@ -64,10 +64,10 @@ nfp_flower_cmsg_mac_repr_init(struct rte_mbuf *mbuf,\n \n static void\n nfp_flower_cmsg_mac_repr_fill(struct rte_mbuf *m,\n-\t\tunsigned int idx,\n-\t\tunsigned int nbi,\n-\t\tunsigned int nbi_port,\n-\t\tunsigned int phys_port)\n+\t\tuint8_t idx,\n+\t\tuint32_t nbi,\n+\t\tuint32_t nbi_port,\n+\t\tuint32_t phys_port)\n {\n \tstruct nfp_flower_cmsg_mac_repr *msg;\n \n@@ -81,11 +81,11 @@ nfp_flower_cmsg_mac_repr_fill(struct rte_mbuf *m,\n int\n nfp_flower_cmsg_mac_repr(struct nfp_app_fw_flower *app_fw_flower)\n {\n-\tint i;\n+\tuint8_t i;\n \tuint16_t cnt;\n-\tunsigned int nbi;\n-\tunsigned int nbi_port;\n-\tunsigned int phys_port;\n+\tuint32_t nbi;\n+\tuint32_t nbi_port;\n+\tuint32_t phys_port;\n \tstruct rte_mbuf *mbuf;\n \tstruct nfp_eth_table *nfp_eth_table;\n \ndiff --git a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\nindex 64928254d8..5a84629ed7 100644\n--- a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n+++ b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n@@ -227,9 +227,9 @@ nfp_net_nfd3_xmit_pkts_common(void *tx_queue,\n \t\tuint16_t nb_pkts,\n \t\tbool repr_flag)\n {\n-\tint i;\n-\tint pkt_size;\n-\tint dma_size;\n+\tuint16_t i;\n+\tuint32_t pkt_size;\n+\tuint16_t dma_size;\n \tuint8_t offset;\n \tuint64_t dma_addr;\n \tuint16_t free_descs;\ndiff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c\nindex 9719a9212b..cb2c2afbd7 100644\n--- a/drivers/net/nfp/nfp_common.c\n+++ b/drivers/net/nfp/nfp_common.c\n@@ -199,7 +199,7 @@ static int\n __nfp_net_reconfig(struct nfp_net_hw *hw,\n \t\tuint32_t update)\n {\n-\tint cnt;\n+\tuint32_t cnt;\n \tuint32_t new;\n \tstruct timespec wait;\n \n@@ -229,7 +229,7 @@ __nfp_net_reconfig(struct nfp_net_hw *hw,\n \t\t}\n \t\tif (cnt >= NFP_NET_POLL_TIMEOUT) {\n \t\t\tPMD_INIT_LOG(ERR, \"Reconfig timeout for 0x%08x after\"\n-\t\t\t\t\t\" %dms\", update, cnt);\n+\t\t\t\t\t\" %ums\", update, cnt);\n \t\t\treturn -EIO;\n \t\t}\n \t\tnanosleep(&wait, 0); /* waiting for a 1ms */\n@@ -466,7 +466,7 @@ nfp_net_enable_queues(struct rte_eth_dev *dev)\n {\n \tstruct nfp_net_hw *hw;\n \tuint64_t enabled_queues = 0;\n-\tint i;\n+\tuint16_t i;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -575,7 +575,7 @@ nfp_configure_rx_interrupt(struct rte_eth_dev *dev,\n \t\tstruct rte_intr_handle *intr_handle)\n {\n \tstruct nfp_net_hw *hw;\n-\tint i;\n+\tuint16_t i;\n \n \tif (rte_intr_vec_list_alloc(intr_handle, \"intr_vec\",\n \t\t\t\tdev->data->nb_rx_queues) != 0) {\n@@ -832,7 +832,7 @@ int\n nfp_net_stats_get(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_stats *stats)\n {\n-\tint i;\n+\tuint16_t i;\n \tstruct nfp_net_hw *hw;\n \tstruct rte_eth_stats nfp_dev_stats;\n \n@@ -923,7 +923,7 @@ nfp_net_stats_get(struct rte_eth_dev *dev,\n int\n nfp_net_stats_reset(struct rte_eth_dev *dev)\n {\n-\tint i;\n+\tuint16_t i;\n \tstruct nfp_net_hw *hw;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -1398,7 +1398,7 @@ nfp_rx_queue_intr_enable(struct rte_eth_dev *dev,\n {\n \tstruct rte_pci_device *pci_dev;\n \tstruct nfp_net_hw *hw;\n-\tint base = 0;\n+\tuint16_t base = 0;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tpci_dev = RTE_ETH_DEV_TO_PCI(dev);\n@@ -1419,7 +1419,7 @@ nfp_rx_queue_intr_disable(struct rte_eth_dev *dev,\n {\n \tstruct rte_pci_device *pci_dev;\n \tstruct nfp_net_hw *hw;\n-\tint base = 0;\n+\tuint16_t base = 0;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tpci_dev = RTE_ETH_DEV_TO_PCI(dev);\n@@ -1619,9 +1619,10 @@ nfp_net_rss_reta_write(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n \t\tuint16_t reta_size)\n {\n-\tuint32_t reta, mask;\n-\tint i, j;\n-\tint idx, shift;\n+\tuint8_t mask;\n+\tuint32_t reta;\n+\tuint16_t i, j;\n+\tuint16_t idx, shift;\n \tstruct nfp_net_hw *hw =\n \t\tNFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -1695,8 +1696,9 @@ nfp_net_reta_query(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n \t\tuint16_t reta_size)\n {\n-\tuint8_t i, j, mask;\n-\tint idx, shift;\n+\tuint16_t i, j;\n+\tuint8_t mask;\n+\tuint16_t idx, shift;\n \tuint32_t reta;\n \tstruct nfp_net_hw *hw;\n \n@@ -1720,7 +1722,7 @@ nfp_net_reta_query(struct rte_eth_dev *dev,\n \t\t/* Handling 4 RSS entries per loop */\n \t\tidx = i / RTE_ETH_RETA_GROUP_SIZE;\n \t\tshift = i % RTE_ETH_RETA_GROUP_SIZE;\n-\t\tmask = (uint8_t)((reta_conf[idx].mask >> shift) & 0xF);\n+\t\tmask = (reta_conf[idx].mask >> shift) & 0xF;\n \n \t\tif (mask == 0)\n \t\t\tcontinue;\n@@ -1744,7 +1746,7 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev,\n \tuint64_t rss_hf;\n \tuint32_t cfg_rss_ctrl = 0;\n \tuint8_t key;\n-\tint i;\n+\tuint8_t i;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -1835,7 +1837,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,\n \tuint64_t rss_hf;\n \tuint32_t cfg_rss_ctrl;\n \tuint8_t key;\n-\tint i;\n+\tuint8_t i;\n \tstruct nfp_net_hw *hw;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -1893,7 +1895,8 @@ nfp_net_rss_config_default(struct rte_eth_dev *dev)\n \tstruct rte_eth_rss_reta_entry64 nfp_reta_conf[2];\n \tuint16_t rx_queues = dev->data->nb_rx_queues;\n \tuint16_t queue;\n-\tint i, j, ret;\n+\tuint8_t i, j;\n+\tint ret;\n \n \tPMD_DRV_LOG(INFO, \"setting default RSS conf for %u queues\",\n \t\t\trx_queues);\ndiff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex e4fd394868..71153ea25b 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -245,14 +245,14 @@ nn_writeq(uint64_t val,\n  */\n static inline uint8_t\n nn_cfg_readb(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn nn_readb(hw->ctrl_bar + off);\n }\n \n static inline void\n nn_cfg_writeb(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint8_t val)\n {\n \tnn_writeb(val, hw->ctrl_bar + off);\n@@ -260,14 +260,14 @@ nn_cfg_writeb(struct nfp_net_hw *hw,\n \n static inline uint16_t\n nn_cfg_readw(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn rte_le_to_cpu_16(nn_readw(hw->ctrl_bar + off));\n }\n \n static inline void\n nn_cfg_writew(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint16_t val)\n {\n \tnn_writew(rte_cpu_to_le_16(val), hw->ctrl_bar + off);\n@@ -275,14 +275,14 @@ nn_cfg_writew(struct nfp_net_hw *hw,\n \n static inline uint32_t\n nn_cfg_readl(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn rte_le_to_cpu_32(nn_readl(hw->ctrl_bar + off));\n }\n \n static inline void\n nn_cfg_writel(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint32_t val)\n {\n \tnn_writel(rte_cpu_to_le_32(val), hw->ctrl_bar + off);\n@@ -290,14 +290,14 @@ nn_cfg_writel(struct nfp_net_hw *hw,\n \n static inline uint64_t\n nn_cfg_readq(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn rte_le_to_cpu_64(nn_readq(hw->ctrl_bar + off));\n }\n \n static inline void\n nn_cfg_writeq(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint64_t val)\n {\n \tnn_writeq(rte_cpu_to_le_64(val), hw->ctrl_bar + off);\ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 65473d87e8..140d20dcf7 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -23,7 +23,7 @@\n \n static int\n nfp_net_pf_read_mac(struct nfp_app_fw_nic *app_fw_nic,\n-\t\tint port)\n+\t\tuint16_t port)\n {\n \tstruct nfp_eth_table *nfp_eth_table;\n \tstruct nfp_net_hw *hw = NULL;\n@@ -255,7 +255,7 @@ nfp_net_close(struct rte_eth_dev *dev)\n \tstruct rte_pci_device *pci_dev;\n \tstruct nfp_pf_dev *pf_dev;\n \tstruct nfp_app_fw_nic *app_fw_nic;\n-\tint i;\n+\tuint8_t i;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n@@ -487,7 +487,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \tstruct rte_ether_addr *tmp_ether_addr;\n \tuint64_t rx_base;\n \tuint64_t tx_base;\n-\tint port = 0;\n+\tuint16_t port = 0;\n \tint err;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -501,7 +501,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \tapp_fw_nic = NFP_PRIV_TO_APP_FW_NIC(pf_dev->app_fw_priv);\n \n \tport = ((struct nfp_net_hw *)eth_dev->data->dev_private)->idx;\n-\tif (port < 0 || port > 7) {\n+\tif (port > 7) {\n \t\tPMD_DRV_LOG(ERR, \"Port value is wrong\");\n \t\treturn -ENODEV;\n \t}\n@@ -761,10 +761,10 @@ static int\n nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,\n \t\tconst struct nfp_dev_info *dev_info)\n {\n-\tint i;\n+\tuint8_t i;\n \tint ret;\n \tint err = 0;\n-\tint total_vnics;\n+\tuint32_t total_vnics;\n \tstruct nfp_net_hw *hw;\n \tunsigned int numa_node;\n \tstruct rte_eth_dev *eth_dev;\n@@ -785,7 +785,7 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,\n \n \t/* Read the number of vNIC's created for the PF */\n \ttotal_vnics = nfp_rtsym_read_le(pf_dev->sym_tbl, \"nfd_cfg_pf0_num_ports\", &err);\n-\tif (err != 0 || total_vnics <= 0 || total_vnics > 8) {\n+\tif (err != 0 || total_vnics == 0 || total_vnics > 8) {\n \t\tPMD_INIT_LOG(ERR, \"nfd_cfg_pf0_num_ports symbol with wrong value\");\n \t\tret = -ENODEV;\n \t\tgoto app_cleanup;\n@@ -795,7 +795,7 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,\n \t * For coreNIC the number of vNICs exposed should be the same as the\n \t * number of physical ports\n \t */\n-\tif (total_vnics != (int)nfp_eth_table->count) {\n+\tif (total_vnics != nfp_eth_table->count) {\n \t\tPMD_INIT_LOG(ERR, \"Total physical ports do not match number of vNICs\");\n \t\tret = -ENODEV;\n \t\tgoto app_cleanup;\n@@ -1053,15 +1053,15 @@ nfp_secondary_init_app_fw_nic(struct rte_pci_device *pci_dev,\n \t\tstruct nfp_rtsym_table *sym_tbl,\n \t\tstruct nfp_cpp *cpp)\n {\n-\tint i;\n+\tuint32_t i;\n \tint err = 0;\n \tint ret = 0;\n-\tint total_vnics;\n+\tuint32_t total_vnics;\n \tstruct nfp_net_hw *hw;\n \n \t/* Read the number of vNIC's created for the PF */\n \ttotal_vnics = nfp_rtsym_read_le(sym_tbl, \"nfd_cfg_pf0_num_ports\", &err);\n-\tif (err != 0 || total_vnics <= 0 || total_vnics > 8) {\n+\tif (err != 0 || total_vnics == 0 || total_vnics > 8) {\n \t\tPMD_INIT_LOG(ERR, \"nfd_cfg_pf0_num_ports symbol with wrong value\");\n \t\treturn -ENODEV;\n \t}\n@@ -1069,7 +1069,7 @@ nfp_secondary_init_app_fw_nic(struct rte_pci_device *pci_dev,\n \tfor (i = 0; i < total_vnics; i++) {\n \t\tstruct rte_eth_dev *eth_dev;\n \t\tchar port_name[RTE_ETH_NAME_MAX_LEN];\n-\t\tsnprintf(port_name, sizeof(port_name), \"%s_port%d\",\n+\t\tsnprintf(port_name, sizeof(port_name), \"%s_port%u\",\n \t\t\t\tpci_dev->device.name, i);\n \n \t\tPMD_INIT_LOG(DEBUG, \"Secondary attaching to port %s\", port_name);\ndiff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c\nindex ac6a10685d..892300a909 100644\n--- a/drivers/net/nfp/nfp_ethdev_vf.c\n+++ b/drivers/net/nfp/nfp_ethdev_vf.c\n@@ -260,7 +260,7 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev)\n \n \tuint64_t tx_bar_off = 0, rx_bar_off = 0;\n \tuint32_t start_q;\n-\tint port = 0;\n+\tuint16_t port = 0;\n \tint err;\n \tconst struct nfp_dev_info *dev_info;\n \ndiff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c\nindex 6d9a1c249f..4c9904e36c 100644\n--- a/drivers/net/nfp/nfp_flow.c\n+++ b/drivers/net/nfp/nfp_flow.c\n@@ -121,7 +121,7 @@ struct nfp_flow_item_proc {\n \t/* Bit-mask to use when @p item->mask is not provided. */\n \tconst void *mask_default;\n \t/* Size in bytes for @p mask_support and @p mask_default. */\n-\tconst unsigned int mask_sz;\n+\tconst size_t mask_sz;\n \t/* Merge a pattern item into a flow rule handle. */\n \tint (*merge)(struct nfp_app_fw_flower *app_fw_flower,\n \t\t\tstruct rte_flow *nfp_flow,\n@@ -1941,8 +1941,8 @@ static int\n nfp_flow_item_check(const struct rte_flow_item *item,\n \t\tconst struct nfp_flow_item_proc *proc)\n {\n+\tsize_t i;\n \tint ret = 0;\n-\tunsigned int i;\n \tconst uint8_t *mask;\n \n \t/* item->last and item->mask cannot exist without item->spec. */\n@@ -2037,7 +2037,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_representor *repr,\n \t\tchar **mbuf_off_mask,\n \t\tbool is_outer_layer)\n {\n-\tint i;\n+\tuint32_t i;\n \tint ret = 0;\n \tbool continue_flag = true;\n \tconst struct rte_flow_item *item;\n@@ -2271,7 +2271,7 @@ nfp_flow_action_set_ipv6(char *act_data,\n \t\tconst struct rte_flow_action *action,\n \t\tbool ip_src_flag)\n {\n-\tint i;\n+\tuint32_t i;\n \trte_be32_t tmp;\n \tsize_t act_size;\n \tstruct nfp_fl_act_set_ipv6_addr *set_ip;\ndiff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex 7885166753..8cbb9b74a2 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -190,7 +190,7 @@ nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq)\n {\n \tstruct nfp_net_dp_buf *rxe = rxq->rxbufs;\n \tuint64_t dma_addr;\n-\tunsigned int i;\n+\tuint16_t i;\n \n \tPMD_RX_LOG(DEBUG, \"Fill Rx Freelist for %u descriptors\",\n \t\t\trxq->rx_count);\n@@ -229,7 +229,7 @@ nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq)\n int\n nfp_net_rx_freelist_setup(struct rte_eth_dev *dev)\n {\n-\tint i;\n+\tuint16_t i;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\tif (nfp_net_rx_fill_freelist(dev->data->rx_queues[i]) != 0)\n@@ -840,7 +840,7 @@ nfp_net_recv_pkts(void *rx_queue,\n static void\n nfp_net_rx_queue_release_mbufs(struct nfp_net_rxq *rxq)\n {\n-\tunsigned int i;\n+\tuint16_t i;\n \n \tif (rxq->rxbufs == NULL)\n \t\treturn;\n@@ -992,11 +992,11 @@ nfp_net_rx_queue_setup(struct rte_eth_dev *dev,\n  * @txq: TX queue to work with\n  * Returns number of descriptors freed\n  */\n-int\n+uint32_t\n nfp_net_tx_free_bufs(struct nfp_net_txq *txq)\n {\n \tuint32_t qcp_rd_p;\n-\tint todo;\n+\tuint32_t todo;\n \n \tPMD_TX_LOG(DEBUG, \"queue %hu. Check for descriptor with a complete\"\n \t\t\t\" status\", txq->qidx);\n@@ -1032,7 +1032,7 @@ nfp_net_tx_free_bufs(struct nfp_net_txq *txq)\n static void\n nfp_net_tx_queue_release_mbufs(struct nfp_net_txq *txq)\n {\n-\tunsigned int i;\n+\tuint32_t i;\n \n \tif (txq->txbufs == NULL)\n \t\treturn;\ndiff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h\nindex 9a30ebd89e..98ef6c3d93 100644\n--- a/drivers/net/nfp/nfp_rxtx.h\n+++ b/drivers/net/nfp/nfp_rxtx.h\n@@ -253,7 +253,7 @@ int nfp_net_tx_queue_setup(struct rte_eth_dev *dev,\n \t\tuint16_t nb_desc,\n \t\tunsigned int socket_id,\n \t\tconst struct rte_eth_txconf *tx_conf);\n-int nfp_net_tx_free_bufs(struct nfp_net_txq *txq);\n+uint32_t nfp_net_tx_free_bufs(struct nfp_net_txq *txq);\n void nfp_net_set_meta_vlan(struct nfp_net_meta_raw *meta_data,\n \t\tstruct rte_mbuf *pkt,\n \t\tuint8_t layer);\n",
    "prefixes": [
        "v3",
        "03/11"
    ]
}