Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132647/?format=api
{ "id": 132647, "url": "http://patchwork.dpdk.org/api/patches/132647/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231016184235.200427-11-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231016184235.200427-11-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231016184235.200427-11-getelson@nvidia.com", "date": "2023-10-16T18:42:30", "name": "[v2,11/16] net/mlx5: fix modify field expansion for raw DECAP / ENCAP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2bed78ca39dccad3bb1476b9b6cd5a261f93b169", "submitter": { "id": 1882, "url": "http://patchwork.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231016184235.200427-11-getelson@nvidia.com/mbox/", "series": [ { "id": 29662, "url": "http://patchwork.dpdk.org/api/series/29662/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29662", "date": "2023-09-27T19:10:46", "name": "net/mlx5: support indirect list actions", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29662/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132647/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D605C43181;\n\tMon, 16 Oct 2023 20:44:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EFFBE40E72;\n\tMon, 16 Oct 2023 20:43:44 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84])\n by mails.dpdk.org (Postfix) with ESMTP id E5CCD402F0\n for <dev@dpdk.org>; Mon, 16 Oct 2023 20:43:43 +0200 (CEST)", "from MW2PR16CA0021.namprd16.prod.outlook.com (2603:10b6:907::34) by\n SN7PR12MB6715.namprd12.prod.outlook.com (2603:10b6:806:271::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Mon, 16 Oct\n 2023 18:43:41 +0000", "from MWH0EPF000989E6.namprd02.prod.outlook.com\n (2603:10b6:907:0:cafe::31) by MW2PR16CA0021.outlook.office365.com\n (2603:10b6:907::34) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35 via Frontend\n Transport; Mon, 16 Oct 2023 18:43:41 +0000", "from mail.nvidia.com (216.228.117.160) by\n MWH0EPF000989E6.mail.protection.outlook.com (10.167.241.133) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6838.22 via Frontend Transport; Mon, 16 Oct 2023 18:43:41 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 16 Oct\n 2023 11:43:25 -0700", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 16 Oct\n 2023 11:43:22 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cmj2KKCDlVMTGmmnWd5Dk/KOobd05jvl++KyUFIQi6zCTHplEX/QU0L5ClrgWgWJWu2OGD1ftZwkyn13s0PHRmh7n5tbsLUJDfIwtG7rTQ7U4IwHdtY6nsJMbH/XSBAtGdeIa3obgCerT71/6/kHxpRXijTZC1E+c3jbd9bCf1554qAAUliCRe3tdzGHNMeK4cT4adfyE/mDR5hU3ZCnq7VvCQZWN160CSTGP9NNuVUCz4A1tqHJeUjQP0cHhKuxLhsCyuyX7Kvccl01qeloNYVpFDVgx/gHANdgGRIYB9WluLXF4epkbqdjWTq8Op5Qg0sP1gEF16vibbaya8yxig==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=X3pJmIui42Q8DLuF9Iwwyl50UO4+qvg4aBhuWG2awSs=;\n b=RN2tXBY1hGnaUp68IgOGOEgtihRYhQPS7TxuStIUklGzPMsE9Jpi4LkloZjhpyHmAPaXbhsLpiIfRiR0Ot5IyzSWy/RO3wzgngDJNu9OaE28OnH23pfHp5Qg4vT6toPkvbMcMsm84WGmwgY31Ci17NY/iu/mQ5wbz/xf560WiDotvg/PM5RI4KlKj60CDzn/mfa/tCUqOe2dwCGCaLnSWA+bj2fCQphJrr4Gbn2/iVWsIp0FKkQ/SfZ/wMhhHvdZ8OWLplKoZUSHmH6HbE2FjFt2H3QKc09sy4FiIwDJKjX6FRS7yfSLTiQw56GpQiAitQCyHqBeGh/SE3RHG5g2Qg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=X3pJmIui42Q8DLuF9Iwwyl50UO4+qvg4aBhuWG2awSs=;\n b=bDXuPQ8sBiURmcnjJnKoDpLp8ryzMaB9n4/u6m2IAMLu0wuLzTixiseHi1jKvDFjc8k/Pmyg6jSkRpfs6L3tAgZKRCfEOvsXLGUwdV69usWwB/GWIP/fR/B3iEQEQRLQyqKWRXk6PHffqoErI7UIM0eomHfHMXW+i7jG/D4ZS6EtGbRjImOJqRoI/O9AvxyTj74ZpoX+Z9434jPqdQLooHmV+Y1SnovuzHwGv4istCRn8yEDurktxmqj70TMAmkj9kDRYc1gjpPvpkK5G2kNAtUeCpbCikF/6mKZ3Hy1YzGohy6c29JyJ/4oSJ0rv3HWPLFVg+cb/T8bFUDh3o+w7g==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, =?utf-8?b?wqA=?= <mkashani@nvidia.com>,\n\t=?utf-8?q?=C2=A0_=2E_=2E_/patches/upstream-pmd-indirect-actions-list/v2/v2-?=\n\t=?utf-8?q?0000-cover-letter_=2E_patch?= <rasland@nvidia.com>,\n Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Suanming Mou <suanmingm@nvidia.com>", "Subject": "[PATCH v2 11/16] net/mlx5: fix modify field expansion for raw DECAP /\n ENCAP", "Date": "Mon, 16 Oct 2023 21:42:30 +0300", "Message-ID": "<20231016184235.200427-11-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231016184235.200427-1-getelson@nvidia.com>", "References": "<20230927191046.405282-1-getelson@nvidia.com>\n <20231016184235.200427-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MWH0EPF000989E6:EE_|SN7PR12MB6715:EE_", "X-MS-Office365-Filtering-Correlation-Id": "ca0cd6fa-7a3b-45bb-b5cb-08dbce77d19d", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n HHXxlRm/+nQX9SLx4WGV/FfqIc7i0b6tI86YW8EAv42jJdng8B6HVNH7EytNJa775UWBAgLAeEQRrP6ZvD4P14+XOdO9jrLFoeR1thc0jqrTUt1Sh68oeJq5B/wwLls9SDjlLqT6eBdvfrUeuA/w3wc2ri5TNPxx6XA2iEyGVB2oYQlEA5ZXYV7jnNn9WbL+XJUGe8yN0dCyXflmLKECC2vpXA7swkL7AuC4iOfFPxmslTUzu0AgK1ciFUKXCfVKbWwKOZJPyTuikEnURbjVmsjdIeAurUSPkXvVFPE7PBwSq4ykd+N3eWDPb4o1Va2KQuXn44dFY0y5DAambN8cKK3ii18hYNYddDJs55/Nn9MBkV6kmhgFJ+4sRxrZCEenCWwh+LXEzN+7F8Gb3tBVcQvMzNOPbSgRfF6hndACMifiSAJ2HNhRtLMTFT8rQblMSb03PRaie5QByNJdoI6++GxSEr6x+bzhFQCa4V5NrgINgs+8N69NDxdyp0s6tvMbwl+Lm8i9xS/ZTiep+JG2olmGGGb7Eg82PGBhxXbw3Paoru+Cn0y4w8V2w8kgDo9VynNere1Y3vVjqSPct5FjSDv5sDuVSoDnJbDBORcnBYDGeV8YjBsC4tkIZtFpdL4xZITvhaiAGM5MNKlmHWrUyxir93FJbS63esUAnPp/PjVbyXRkTStzJd8wXHknF+n1o4Xh+iinRTeWYT43eHLI2UtsnmS8riiodUiTvUeeEjaReo9+044nXcVgwiufUYeZ", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(136003)(396003)(376002)(346002)(39860400002)(230922051799003)(1800799009)(186009)(82310400011)(64100799003)(451199024)(40470700004)(46966006)(36840700001)(70586007)(70206006)(2616005)(6916009)(54906003)(316002)(478600001)(107886003)(426003)(1076003)(336012)(26005)(7696005)(2906002)(6286002)(16526019)(5660300002)(4326008)(8936002)(8676002)(41300700001)(86362001)(7636003)(36756003)(82740400003)(356005)(47076005)(83380400001)(6666004)(36860700001)(40480700001)(40460700003)(55016003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Oct 2023 18:43:41.4542 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ca0cd6fa-7a3b-45bb-b5cb-08dbce77d19d", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MWH0EPF000989E6.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN7PR12MB6715", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Flow actions in HWS actions template must be arranged according to\npre-defined order.\n\nMLX5 PMD handles RAW_DECAP / RAW_ENCAP actions sequence as a single\nRAW ENCAP or DECAP flow action.\n\nWhen the PMD scanned flow actions to locate position where\nMODIFY_FIELD action could be inserted it processed the\nRAW_DECAP / RAW_ENCAP sequence as 2 separate actions. As the result\nlocation selection was wrong.\n\nThe patch fixes RAW_DECAP / RAW_ENCAP sequence processing for\nMODIFY_FIELD expansion.\n\nFixes: cf7f458 (\"net/mlx5: add indirect QUOTA create/query/modify\")\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 36 +++++++++++++++++++++++++++++++--\n 1 file changed, 34 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex efb2d512b7..7b060442ac 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -4283,6 +4283,28 @@ flow_hw_validate_action_raw_encap(struct rte_eth_dev *dev __rte_unused,\n \treturn 0;\n }\n \n+/**\n+ * Process `... / raw_decap / raw_encap / ...` actions sequence.\n+ * The PMD handles the sequence as a single encap or decap reformat action,\n+ * depending on the raw_encap configuration.\n+ *\n+ * The function assumes that the sequence location in actions template list\n+ * complies with relative HWS actions order for the required reformat.\n+ */\n+static uint64_t\n+mlx5_decap_encap_reformat_type(const struct rte_flow_action *actions,\n+\t\t\t uint32_t encap_ind, uint64_t flags)\n+{\n+\tconst struct rte_flow_action_raw_encap *encap = actions[encap_ind].conf;\n+\n+\tif ((flags & MLX5_FLOW_ACTION_DECAP) == 0)\n+\t\treturn MLX5_FLOW_ACTION_ENCAP;\n+\tif (actions[encap_ind - 1].type != RTE_FLOW_ACTION_TYPE_RAW_DECAP)\n+\t\treturn MLX5_FLOW_ACTION_ENCAP;\n+\treturn encap->size >= MLX5_ENCAPSULATION_DECISION_SIZE ?\n+\t MLX5_FLOW_ACTION_ENCAP : MLX5_FLOW_ACTION_DECAP;\n+}\n+\n static inline uint16_t\n flow_hw_template_expand_modify_field(struct rte_flow_action actions[],\n \t\t\t\t struct rte_flow_action masks[],\n@@ -4320,13 +4342,13 @@ flow_hw_template_expand_modify_field(struct rte_flow_action actions[],\n \t */\n \tfor (i = act_num - 2; (int)i >= 0; i--) {\n \t\tenum rte_flow_action_type type = actions[i].type;\n+\t\tuint64_t reformat_type;\n \n \t\tif (type == RTE_FLOW_ACTION_TYPE_INDIRECT)\n \t\t\ttype = masks[i].type;\n \t\tswitch (type) {\n \t\tcase RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP:\n \t\tcase RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP:\n-\t\tcase RTE_FLOW_ACTION_TYPE_RAW_ENCAP:\n \t\tcase RTE_FLOW_ACTION_TYPE_DROP:\n \t\tcase RTE_FLOW_ACTION_TYPE_SEND_TO_KERNEL:\n \t\tcase RTE_FLOW_ACTION_TYPE_JUMP:\n@@ -4337,10 +4359,20 @@ flow_hw_template_expand_modify_field(struct rte_flow_action actions[],\n \t\tcase RTE_FLOW_ACTION_TYPE_VOID:\n \t\tcase RTE_FLOW_ACTION_TYPE_END:\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_RAW_ENCAP:\n+\t\t\treformat_type =\n+\t\t\t\tmlx5_decap_encap_reformat_type(actions, i,\n+\t\t\t\t\t\t\t flags);\n+\t\t\tif (reformat_type == MLX5_FLOW_ACTION_DECAP) {\n+\t\t\t\ti++;\n+\t\t\t\tgoto insert;\n+\t\t\t}\n+\t\t\tif (flags & MLX5_FLOW_ACTION_DECAP)\n+\t\t\t\ti--;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\ti++; /* new MF inserted AFTER actions[i] */\n \t\t\tgoto insert;\n-\t\t\tbreak;\n \t\t}\n \t}\n \ti = 0;\n", "prefixes": [ "v2", "11/16" ] }