Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132654/?format=api
{ "id": 132654, "url": "http://patchwork.dpdk.org/api/patches/132654/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1697482390-32106-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1697482390-32106-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1697482390-32106-2-git-send-email-roretzla@linux.microsoft.com", "date": "2023-10-16T18:53:09", "name": "[1/2] power: fix use of rte stdatomic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "550bf0d07716934b5dda3de1f1e4431bef454f03", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1697482390-32106-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29855, "url": "http://patchwork.dpdk.org/api/series/29855/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29855", "date": "2023-10-16T18:53:08", "name": "fix enable_stdatomic=true build with clang", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29855/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132654/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132654/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC43643181;\n\tMon, 16 Oct 2023 20:53:22 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C59C740DCA;\n\tMon, 16 Oct 2023 20:53:15 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4D8AF402F0\n for <dev@dpdk.org>; Mon, 16 Oct 2023 20:53:12 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id A7B6E20B74C1; Mon, 16 Oct 2023 11:53:11 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com A7B6E20B74C1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1697482391;\n bh=b93AE7/E0tAcOCCrMt8cTSSlyq51ibSTgYrQU5KH7ds=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=XdNgiwfYckSs/NH/6t4hc3cEsR8nJ3dRnQEJKbekxqffOb1soy0Ubu7atIvg0v4x3\n YubkYQIcIJxKrcTlM99xScONbneosUkCefS92yoQvIEI7hjHH+Jocl1Y2c7LfwfJDr\n NsKflBOhKMVC91x9htSXVKHd9J5KZ1xmPPqF886w=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com", "Cc": "Anatoly Burakov <anatoly.burakov@intel.com>,\n David Hunt <david.hunt@intel.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Shijith Thotton <sthotton@marvell.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 1/2] power: fix use of rte stdatomic", "Date": "Mon, 16 Oct 2023 11:53:09 -0700", "Message-Id": "<1697482390-32106-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1697482390-32106-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1697482390-32106-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "* rte stdatomic functions operate on RTE_ATOMIC(T) specified types not\n regular T add missing specifier for amd_pstate_power_info state field\n* use rte_memory_order_xxx instead of __ATOMIC_XXX\n\nFixes: 1ed04d33cf19 (\"power: support amd-pstate cpufreq driver\")\nCc: sivaprasad.tummala@amd.com\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/power/power_amd_pstate_cpufreq.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_pstate_cpufreq.c\nindex ee58395..dbd9d2b 100644\n--- a/lib/power/power_amd_pstate_cpufreq.c\n+++ b/lib/power/power_amd_pstate_cpufreq.c\n@@ -47,7 +47,7 @@ enum power_state {\n */\n struct amd_pstate_power_info {\n \tuint32_t lcore_id; /**< Logical core id */\n-\tuint32_t state; /**< Power in use state */\n+\tRTE_ATOMIC(uint32_t) state; /**< Power in use state */\n \tFILE *f; /**< FD of scaling_setspeed */\n \tchar governor_ori[28]; /**< Original governor name */\n \tuint32_t curr_idx; /**< Freq index in freqs array */\n@@ -370,7 +370,7 @@ struct amd_pstate_power_info {\n \t */\n \tif (!rte_atomic_compare_exchange_strong_explicit(&(pi->state),\n \t\t\t\t\t&exp_state, POWER_ONGOING,\n-\t\t\t\t\t__ATOMIC_ACQUIRE, __ATOMIC_RELAXED)) {\n+\t\t\t\t\trte_memory_order_acquire, rte_memory_order_relaxed)) {\n \t\tRTE_LOG(INFO, POWER, \"Power management of lcore %u is \"\n \t\t\t\t\"in use\\n\", lcore_id);\n \t\treturn -1;\n@@ -408,12 +408,12 @@ struct amd_pstate_power_info {\n \tRTE_LOG(INFO, POWER, \"Initialized successfully for lcore %u \"\n \t\t\t\"power management\\n\", lcore_id);\n \n-\trte_atomic_store_explicit(&(pi->state), POWER_USED, __ATOMIC_RELEASE);\n+\trte_atomic_store_explicit(&(pi->state), POWER_USED, rte_memory_order_release);\n \n \treturn 0;\n \n fail:\n-\trte_atomic_store_explicit(&(pi->state), POWER_UNKNOWN, __ATOMIC_RELEASE);\n+\trte_atomic_store_explicit(&(pi->state), POWER_UNKNOWN, rte_memory_order_release);\n \treturn -1;\n }\n \n@@ -448,7 +448,7 @@ struct amd_pstate_power_info {\n \t */\n \tif (!rte_atomic_compare_exchange_strong_explicit(&(pi->state),\n \t\t\t\t\t&exp_state, POWER_ONGOING,\n-\t\t\t\t\t__ATOMIC_ACQUIRE, __ATOMIC_RELAXED)) {\n+\t\t\t\t\trte_memory_order_acquire, rte_memory_order_relaxed)) {\n \t\tRTE_LOG(INFO, POWER, \"Power management of lcore %u is \"\n \t\t\t\t\"not used\\n\", lcore_id);\n \t\treturn -1;\n@@ -468,12 +468,12 @@ struct amd_pstate_power_info {\n \tRTE_LOG(INFO, POWER, \"Power management of lcore %u has exited from \"\n \t\t\t\"'userspace' mode and been set back to the \"\n \t\t\t\"original\\n\", lcore_id);\n-\trte_atomic_store_explicit(&(pi->state), POWER_IDLE, __ATOMIC_RELEASE);\n+\trte_atomic_store_explicit(&(pi->state), POWER_IDLE, rte_memory_order_release);\n \n \treturn 0;\n \n fail:\n-\trte_atomic_store_explicit(&(pi->state), POWER_UNKNOWN, __ATOMIC_RELEASE);\n+\trte_atomic_store_explicit(&(pi->state), POWER_UNKNOWN, rte_memory_order_release);\n \n \treturn -1;\n }\n", "prefixes": [ "1/2" ] }